111597 2013-03-06 10:33:43 -0800 WebKit does not build without accelerated compositing after Changeset 144823 2013-03-06 22:49:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tuxator webkit-unassigned andersca cmarcelo haraken jamesr luiz tonikitoo webkit.review.bot oldest_to_newest 849036 0 tuxator 2013-03-06 10:33:43 -0800 WebKit does not build without accelerated compositing after Changeset 144823 849040 1 191788 tuxator 2013-03-06 10:35:59 -0800 Created attachment 191788 Patch 849042 2 tuxator 2013-03-06 10:38:27 -0800 Build error Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:297:108: error: no 'WebCore::GraphicsLayer* WebCore::ScrollingCoordinator::verticalScrollbarLayerForScrollableArea(WebCore::ScrollableArea*)' member function declared in class 'WebCore::ScrollingCoordinator' make[1]: *** [Source/WebCore/page/scrolling/libWebCore_la-ScrollingCoordinator.lo] Błąd 1 make[1]: Opuszczenie katalogu `/home/pawel/src/webkit' make: *** [all] Błąd 2 Changeset http://trac.webkit.org/changeset/144823 added ifdef to ScrollingCoordinator.h and ScrollingCoordinator.cpp But turns out they dont match. Additionally it makes guards and fallback code introduced in changeset http://trac.webkit.org/changeset/144799 redundant. Attached patch should adress those. 849047 3 webkit.review.bot 2013-03-06 10:41:29 -0800 Attachment 191788 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp']" exit_code: 1 Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 849476 4 191788 ap 2013-03-06 16:57:45 -0800 Comment on attachment 191788 Patch Obviously, the tab in ChangeLog needs to be fixed before landing. 849699 5 191910 tuxator 2013-03-06 21:12:55 -0800 Created attachment 191910 Fixed style issue 849745 6 191910 haraken 2013-03-06 22:27:41 -0800 Comment on attachment 191910 Fixed style issue Thanks for the fix. 849760 7 191910 webkit.review.bot 2013-03-06 22:49:28 -0800 Comment on attachment 191910 Fixed style issue Clearing flags on attachment: 191910 Committed r145041: <http://trac.webkit.org/changeset/145041> 849761 8 webkit.review.bot 2013-03-06 22:49:32 -0800 All reviewed patches have been landed. Closing bug. 191788 2013-03-06 10:35:59 -0800 2013-03-06 21:12:48 -0800 Patch bug-111597-20130306193204.patch text/plain 2487 tuxator U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWE1ZDk2NmU0OWIwOWY2 ZmU2ZDg5ZTY4ZDU1ZTAzZDU5YjI3MDI2Yy4uYTZjZDQ0NTllY2ViOWRhOTAwOTZkYWFmMDQwOTYy YWVkMTI3YTczNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTA2ICBQYXdl xYIgRm9yeXNpdWsgIDx0dXhhdG9yQG8yLnBsPgorCisgICAgICAgIFdlYktpdCBkb2VzIG5vdCBi dWlsZCB3aXRob3V0IGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGFmdGVyIENoYW5nZXNldCAxNDQ4 MjMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTU5 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb3Bl cmx5IGd1YXJkIGZ1bmN0aW9ucyBpZmRlZmVkIGluIFNjcm9sbGluZ0Nvb3JkaW5hdG9yLmguCisJ CVJlbW92ZSByZWR1bmRhbnQgY2hlY2tzIGFuZCBmYWxsYmFjayBjb2RlIGluc2lkZSB0aG9zZSBm dW5jdGlvbnMuCisKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRv ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvcjo6c2Nyb2xsTGF5 ZXJGb3JTY3JvbGxhYmxlQXJlYSk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGlu YXRvcjo6aG9yaXpvbnRhbFNjcm9sbGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEpOgorICAgICAg ICAoV2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnZlcnRpY2FsU2Nyb2xsYmFyTGF5ZXJG b3JTY3JvbGxhYmxlQXJlYSk6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMy0wMy0wNiAgSnVs aWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUg dGhlIChkZWFkKSBjb2RlIGZvciBoYW5kbGluZyBzaG9ydGhhbmRzIGluIFN0eWxlUmVzb2x2ZXIg LyBTdHlsZUJ1aWxkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5n L1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5n L1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAppbmRleCBiNjU1NzA1MTAwNmZlMDU1MTRhODdiYzNh YTA1MDJlNTU0YmJhNzM3Li5lMTk2NTcyNTFkNDg3MDc4NzdiZjNjM2JiYjE5NzQyNmYxNjYxNTgz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29y ZGluYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5n Q29vcmRpbmF0b3IuY3BwCkBAIC0yNzUsMzQgKzI3NSwxOSBAQCB2b2lkIFNjcm9sbGluZ0Nvb3Jk aW5hdG9yOjpmcmFtZVZpZXdGaXhlZE9iamVjdHNEaWRDaGFuZ2UoRnJhbWVWaWV3KiBmcmFtZVZp ZXcpCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogR3JhcGhpY3NMYXllciogU2Ny b2xsaW5nQ29vcmRpbmF0b3I6OnNjcm9sbExheWVyRm9yU2Nyb2xsYWJsZUFyZWEoU2Nyb2xsYWJs ZUFyZWEqIHNjcm9sbGFibGVBcmVhKQogewotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElO RykKICAgICByZXR1cm4gc2Nyb2xsYWJsZUFyZWEtPmxheWVyRm9yU2Nyb2xsaW5nKCk7Ci0jZWxz ZQotICAgIFVOVVNFRF9QQVJBTShzY3JvbGxhYmxlQXJlYSk7Ci0gICAgcmV0dXJuIDA7Ci0jZW5k aWYKIH0KIAogR3JhcGhpY3NMYXllciogU2Nyb2xsaW5nQ29vcmRpbmF0b3I6Omhvcml6b250YWxT Y3JvbGxiYXJMYXllckZvclNjcm9sbGFibGVBcmVhKFNjcm9sbGFibGVBcmVhKiBzY3JvbGxhYmxl QXJlYSkKIHsKLSNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgcmV0dXJuIHNj cm9sbGFibGVBcmVhLT5sYXllckZvckhvcml6b250YWxTY3JvbGxiYXIoKTsKLSNlbHNlCi0gICAg VU5VU0VEX1BBUkFNKHNjcm9sbGFibGVBcmVhKTsKLSAgICByZXR1cm4gMDsKLSNlbmRpZgogfQot I2VuZGlmCiAKIEdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjp2ZXJ0aWNhbFNj cm9sbGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEoU2Nyb2xsYWJsZUFyZWEqIHNjcm9sbGFibGVB cmVhKQogewotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICByZXR1cm4gc2Ny b2xsYWJsZUFyZWEtPmxheWVyRm9yVmVydGljYWxTY3JvbGxiYXIoKTsKLSNlbHNlCi0gICAgVU5V U0VEX1BBUkFNKHNjcm9sbGFibGVBcmVhKTsKLSAgICByZXR1cm4gMDsKLSNlbmRpZgogfQorI2Vu ZGlmCiAKIEdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpzY3JvbGxMYXllckZv ckZyYW1lVmlldyhGcmFtZVZpZXcqIGZyYW1lVmlldykKIHsK 191910 2013-03-06 21:12:55 -0800 2013-03-06 22:49:28 -0800 Fixed style issue bug-111597-20130307060859.patch text/plain 2493 tuxator U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWE1ZDk2NmU0OWIwOWY2 ZmU2ZDg5ZTY4ZDU1ZTAzZDU5YjI3MDI2Yy4uMWQyNzNkZmI2Mzc1MGM5ZDFiNzJmMjI3NjE0MjJh ZWQwYWRkYmE4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTA2ICBQYXdl xYIgRm9yeXNpdWsgIDx0dXhhdG9yQG8yLnBsPgorCisgICAgICAgIFdlYktpdCBkb2VzIG5vdCBi dWlsZCB3aXRob3V0IGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGFmdGVyIENoYW5nZXNldCAxNDQ4 MjMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTU5 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb3Bl cmx5IGd1YXJkIGZ1bmN0aW9ucyBpZmRlZmVkIGluIFNjcm9sbGluZ0Nvb3JkaW5hdG9yLmguCisg ICAgICAgIFJlbW92ZSByZWR1bmRhbnQgY2hlY2tzIGFuZCBmYWxsYmFjayBjb2RlIGluc2lkZSB0 aG9zZSBmdW5jdGlvbnMuCisKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29y ZGluYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvcjo6c2Ny b2xsTGF5ZXJGb3JTY3JvbGxhYmxlQXJlYSk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdD b29yZGluYXRvcjo6aG9yaXpvbnRhbFNjcm9sbGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEpOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnZlcnRpY2FsU2Nyb2xsYmFy TGF5ZXJGb3JTY3JvbGxhYmxlQXJlYSk6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMy0wMy0w NiAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZW1vdmUgdGhlIChkZWFkKSBjb2RlIGZvciBoYW5kbGluZyBzaG9ydGhhbmRzIGluIFN0eWxlUmVz b2x2ZXIgLyBTdHlsZUJ1aWxkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Ny b2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Ny b2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAppbmRleCBiNjU1NzA1MTAwNmZlMDU1MTRh ODdiYzNhYTA1MDJlNTU0YmJhNzM3Li5lMTk2NTcyNTFkNDg3MDc4NzdiZjNjM2JiYjE5NzQyNmYx NjYxNTgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxp bmdDb29yZGluYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Ny b2xsaW5nQ29vcmRpbmF0b3IuY3BwCkBAIC0yNzUsMzQgKzI3NSwxOSBAQCB2b2lkIFNjcm9sbGlu Z0Nvb3JkaW5hdG9yOjpmcmFtZVZpZXdGaXhlZE9iamVjdHNEaWRDaGFuZ2UoRnJhbWVWaWV3KiBm cmFtZVZpZXcpCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogR3JhcGhpY3NMYXll ciogU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNjcm9sbExheWVyRm9yU2Nyb2xsYWJsZUFyZWEoU2Ny b2xsYWJsZUFyZWEqIHNjcm9sbGFibGVBcmVhKQogewotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01Q T1NJVElORykKICAgICByZXR1cm4gc2Nyb2xsYWJsZUFyZWEtPmxheWVyRm9yU2Nyb2xsaW5nKCk7 Ci0jZWxzZQotICAgIFVOVVNFRF9QQVJBTShzY3JvbGxhYmxlQXJlYSk7Ci0gICAgcmV0dXJuIDA7 Ci0jZW5kaWYKIH0KIAogR3JhcGhpY3NMYXllciogU2Nyb2xsaW5nQ29vcmRpbmF0b3I6Omhvcml6 b250YWxTY3JvbGxiYXJMYXllckZvclNjcm9sbGFibGVBcmVhKFNjcm9sbGFibGVBcmVhKiBzY3Jv bGxhYmxlQXJlYSkKIHsKLSNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgcmV0 dXJuIHNjcm9sbGFibGVBcmVhLT5sYXllckZvckhvcml6b250YWxTY3JvbGxiYXIoKTsKLSNlbHNl Ci0gICAgVU5VU0VEX1BBUkFNKHNjcm9sbGFibGVBcmVhKTsKLSAgICByZXR1cm4gMDsKLSNlbmRp ZgogfQotI2VuZGlmCiAKIEdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjp2ZXJ0 aWNhbFNjcm9sbGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEoU2Nyb2xsYWJsZUFyZWEqIHNjcm9s bGFibGVBcmVhKQogewotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICByZXR1 cm4gc2Nyb2xsYWJsZUFyZWEtPmxheWVyRm9yVmVydGljYWxTY3JvbGxiYXIoKTsKLSNlbHNlCi0g ICAgVU5VU0VEX1BBUkFNKHNjcm9sbGFibGVBcmVhKTsKLSAgICByZXR1cm4gMDsKLSNlbmRpZgog fQorI2VuZGlmCiAKIEdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpzY3JvbGxM YXllckZvckZyYW1lVmlldyhGcmFtZVZpZXcqIGZyYW1lVmlldykKIHsK