111586 2013-03-06 08:52:01 -0800 SVG pattern to pattern reference does not work if first pattern has a child node 2013-03-06 10:53:18 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 krit fmalita d-r fmalita pdr schenney webkit.review.bot zimmermann oldest_to_newest 848897 0 191759 krit 2013-03-06 08:52:01 -0800 Created attachment 191759 Not working pattern to pattern reference The following simple reference of another pattern does not work: <pattern xlink:href="#pattern2" id="pattern1"> </pattern> I assume this is because of the newline that creates a TextNode. With this node we do not reference the second pattern anymore. The following does work: <pattern xlink:href="#pattern2" id="pattern1"></pattern> Adobe Illustrator exports the first example, why often patterns don't work exported from Illustrator. 848940 1 191766 fmalita 2013-03-06 09:27:46 -0800 Created attachment 191766 Patch 848991 2 191766 pdr 2013-03-06 09:52:57 -0800 Comment on attachment 191766 Patch This change is very reasonable. Do you mind checking that the ~20 other instances of hasChildNodes() do not have the same problem? 849041 3 fmalita 2013-03-06 10:36:05 -0800 (In reply to comment #2) > (From update of attachment 191766 [details]) > This change is very reasonable. > > Do you mind checking that the ~20 other instances of hasChildNodes() do not have the same problem? The remaining users look good. 849065 4 191766 webkit.review.bot 2013-03-06 10:53:14 -0800 Comment on attachment 191766 Patch Clearing flags on attachment: 191766 Committed r144948: <http://trac.webkit.org/changeset/144948> 849066 5 webkit.review.bot 2013-03-06 10:53:18 -0800 All reviewed patches have been landed. Closing bug. 191759 2013-03-06 08:52:01 -0800 2013-03-06 08:52:01 -0800 Not working pattern to pattern reference pattern-reference.svg image/svg+xml 399 krit PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KPHBhdHRlcm4gaWQ9InBhdHRlcm4yIiBwYXR0ZXJu VW5pdHM9InVzZXJTcGFjZU9uVXNlIiB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCIgdmlld0JveD0i MCAwIDEwMCAxMDAiPgoJPHJlY3Qgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGZpbGw9ImdyZWVu Ii8+CjwvcGF0dGVybj4KPHBhdHRlcm4geGxpbms6aHJlZj0iI3BhdHRlcm4yIiBpZD0icGF0dGVy bjEiPgo8L3BhdHRlcm4+CjwhLS0gWW91IHNob3VsZCBzZWUgYSBncmVlbiByZWN0IC0tPgo8cmVj dCB3aWR0aD0iMjAwIiBoZWlnaHQ9IjIwMCIgZmlsbD0idXJsKCNwYXR0ZXJuMSkiLz4KPC9zdmc+ 191766 2013-03-06 09:27:46 -0800 2013-03-06 10:53:14 -0800 Patch bug-111586-20130306122351.patch text/plain 4287 fmalita U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmEyNjcyOWIyNDQ1NGM1 Y2IwOWEyZGM1NTJmNWNmZjljYmRjMzFhYS4uNjJjZGY3MDI3ZWVkYjg5YWRmNGE2YzQzMTllYTFh NzQ0MDM1OWQ0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTA2ICBGbG9y aW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU1ZHIHBhdHRlcm4g dG8gcGF0dGVybiByZWZlcmVuY2UgZG9lcyBub3Qgd29yayBpZiBmaXJzdCBwYXR0ZXJuIGhhcyBh IGNoaWxkIG5vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMTU4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFNWR1BhdHRlcm5FbGVtZW50Ojpjb2xsZWN0UGF0dGVybkF0dHJpYnV0ZXMgc2hvdWxkIHRl c3QgZm9yIGNoaWxkIGVsZW1lbnRzLCBub3QgY2hpbGQgbm9kZXMuCisKKyAgICAgICAgVGVzdHM6 IHN2Zy9jdXN0b20vcGF0dGVybi1yZWZlcmVuY2UtZXhwZWN0ZWQuc3ZnCisgICAgICAgICAgICAg ICBzdmcvY3VzdG9tL3BhdHRlcm4tcmVmZXJlbmNlLnN2ZworCisgICAgICAgICogc3ZnL1NWR1Bh dHRlcm5FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1BhdHRlcm5FbGVtZW50Ojpj b2xsZWN0UGF0dGVybkF0dHJpYnV0ZXMpOgorCiAyMDEzLTAzLTA2ICBKdWxpZW4gQ2hhZmZyYWl4 ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSB0aGUgKGRlYWQpIGNv ZGUgZm9yIGhhbmRsaW5nIHNob3J0aGFuZHMgaW4gU3R5bGVSZXNvbHZlciAvIFN0eWxlQnVpbGRl cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1BhdHRlcm5FbGVtZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQYXR0ZXJuRWxlbWVudC5jcHAKaW5kZXggMmQ5ZTRmMTM1 NzM2NGY3MzczMTZlYzhiZjM5OGI0ZjZhYzc1OWY0Yy4uMmMwNzU0OGE1M2NmZmM5NWQ2Zjc4M2Y4 ZmNlMjllNjI5ZTg3YjExMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1BhdHRl cm5FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUGF0dGVybkVsZW1lbnQu Y3BwCkBAIC0yMjIsNyArMjIyLDcgQEAgdm9pZCBTVkdQYXR0ZXJuRWxlbWVudDo6Y29sbGVjdFBh dHRlcm5BdHRyaWJ1dGVzKFBhdHRlcm5BdHRyaWJ1dGVzJiBhdHRyaWJ1dGVzKQogICAgICAgICAg ICAgYXR0cmlidXRlcy5zZXRQYXR0ZXJuVHJhbnNmb3JtKHRyYW5zZm9ybSk7CiAgICAgICAgIH0K IAotICAgICAgICBpZiAoIWF0dHJpYnV0ZXMuaGFzUGF0dGVybkNvbnRlbnRFbGVtZW50KCkgJiYg Y3VycmVudC0+aGFzQ2hpbGROb2RlcygpKQorICAgICAgICBpZiAoIWF0dHJpYnV0ZXMuaGFzUGF0 dGVybkNvbnRlbnRFbGVtZW50KCkgJiYgY3VycmVudC0+Y2hpbGRFbGVtZW50Q291bnQoKSkKICAg ICAgICAgICAgIGF0dHJpYnV0ZXMuc2V0UGF0dGVybkNvbnRlbnRFbGVtZW50KGN1cnJlbnQpOwog CiAgICAgICAgIHByb2Nlc3NlZFBhdHRlcm5zLmFkZChjdXJyZW50KTsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmZjk0NjU0 MTBkNTg1Y2U4OGUyNzA0MmM0NTQzMzU5MzU1MDVjNWVmLi5iN2E2MmMyZGU1OTQ4ZjQzY2MwOTNh NTA4Mzc1M2MyMjUxNGRhMmYxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDMtMDYgIEZs b3JpbiBNYWxpdGEgIDxmbWFsaXRhQGNocm9taXVtLm9yZz4KKworICAgICAgICBTVkcgcGF0dGVy biB0byBwYXR0ZXJuIHJlZmVyZW5jZSBkb2VzIG5vdCB3b3JrIGlmIGZpcnN0IHBhdHRlcm4gaGFz IGEgY2hpbGQgbm9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTExNTg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBzdmcvY3VzdG9tL3BhdHRlcm4tcmVmZXJlbmNlLWV4cGVjdGVkLnN2ZzogQWRkZWQu CisgICAgICAgICogc3ZnL2N1c3RvbS9wYXR0ZXJuLXJlZmVyZW5jZS5zdmc6IEFkZGVkLgorCiAy MDEzLTAzLTA2ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CiAKICAgICAgICAg RG8gbm90IGFkZCBDU1NQcm9wZXJ0eUJvcmRlckltYWdlIHNob3J0aGFuZCBwYXJ0IG9mIHRoZSBw cm9wZXJ0eSBsaXN0IHdoZW4gcGFyc2luZyBDU1MgYm9yZGVyIHByb3BlcnR5CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3BhdHRlcm4tcmVmZXJlbmNlLWV4cGVjdGVkLnN2ZyBi L0xheW91dFRlc3RzL3N2Zy9jdXN0b20vcGF0dGVybi1yZWZlcmVuY2UtZXhwZWN0ZWQuc3ZnCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLmE2OTJjZjljYTIwNWEyYjdkMDE4YmExMDUyYzc5ZDU4N2Y2NDY0YzUKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3BhdHRlcm4tcmVmZXJlbmNlLWV4 cGVjdGVkLnN2ZwpAQCAtMCwwICsxLDUgQEAKKzw/eG1sIHZlcnNpb249IjEuMCIgc3RhbmRhbG9u ZT0ibm8iPz4KKzxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4 bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayI+CisgIDxyZWN0IHdpZHRoPSIxMDAi IGhlaWdodD0iMTAwIiBmaWxsPSJncmVlbiIvPgorICA8cmVjdCB4PSIyMDAiIHdpZHRoPSIxMDAi IGhlaWdodD0iMTAwIiBmaWxsPSJncmVlbiIvPgorPC9zdmc+CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9zdmcvY3VzdG9tL3BhdHRlcm4tcmVmZXJlbmNlLnN2ZyBiL0xheW91dFRlc3RzL3N2Zy9j dXN0b20vcGF0dGVybi1yZWZlcmVuY2Uuc3ZnCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjY0MWRjODY2ZjdmNDkwODM1 YmU1OTgyMjUwMTlmZmIwNjc0NTQwOTMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9z dmcvY3VzdG9tL3BhdHRlcm4tcmVmZXJlbmNlLnN2ZwpAQCAtMCwwICsxLDIzIEBACis8P3htbCB2 ZXJzaW9uPSIxLjAiIHN0YW5kYWxvbmU9Im5vIj8+Cis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3Lncz Lm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsi PgorICA8IS0tIFRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTE1ODYgLS0+CisgIDxkZWZzPgorICAgIDxwYXR0ZXJuIGlkPSJyZWZfcGF0dGVybjEiIHBh dHRlcm5Vbml0cz0idXNlclNwYWNlT25Vc2UiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTAwIiB2aWV3 Qm94PSIwIDAgMTAwIDEwMCI+CisgICAgICA8cmVjdCB3aWR0aD0iMTAwIiBoZWlnaHQ9IjEwMCIg ZmlsbD0iZ3JlZW4iLz4KKyAgICA8L3BhdHRlcm4+CisgICAgPHBhdHRlcm4gaWQ9InJlZl9wYXR0 ZXJuMiIgcGF0dGVyblVuaXRzPSJ1c2VyU3BhY2VPblVzZSIgd2lkdGg9IjEwMCIgaGVpZ2h0PSIx MDAiIHZpZXdCb3g9IjAgMCAxMDAgMTAwIj4KKyAgICAgIDxyZWN0IHdpZHRoPSIxMDAiIGhlaWdo dD0iMTAwIiBmaWxsPSJyZWQiLz4KKyAgICA8L3BhdHRlcm4+CisKKyAgICA8cGF0dGVybiBpZD0i cGF0dGVybjEiIHhsaW5rOmhyZWY9IiNyZWZfcGF0dGVybjEiPgorICAgICAgcmFuZG9tIHRleHQg bm9kZSAtIHNob3VsZCBiZSBpZ25vcmVkCisgICAgPC9wYXR0ZXJuPgorICAgIDxwYXR0ZXJuIGlk PSJwYXR0ZXJuMiIgeGxpbms6aHJlZj0iI3JlZl9wYXR0ZXJuMiI+CisgICAgICA8cmVjdCB3aWR0 aD0iMTAwIiBoZWlnaHQ9IjEwMCIgZmlsbD0iZ3JlZW4iLz4KKyAgICA8L3BhdHRlcm4+CisgIDwv ZGVmcz4KKworICA8IS0tIFlvdSBzaG91bGQgc2VlIHR3byBncmVlbiByZWN0cyAtLT4KKyAgPHJl Y3Qgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGZpbGw9InVybCgjcGF0dGVybjEpIi8+CisgIDxy ZWN0IHg9IjIwMCIgd2lkdGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGZpbGw9InVybCgjcGF0dGVybjIp Ii8+Cis8L3N2Zz4K