111584 2013-03-06 08:20:34 -0800 [soup] session cookies are not correctly reported in getRawCookies() 2013-03-06 09:27:35 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://developer.gnome.org/libsoup/2.40/SoupCookie.html#SoupCookie-struct P2 Normal --- 1 cdumez cdumez cgarcia danw gustavo laszlo.gombos mrobinson rakuco svillar webkit.review.bot oldest_to_newest 848880 0 cdumez 2013-03-06 08:20:34 -0800 As per libsoup documentation, SoupCookie->expires is NULL for session cookies. However, the soup implementation for getRawCookies() does not check for NULL case before passing the value to soup_date_to_time_t(). This leads to the following warnings: (process:27280): libsoup-CRITICAL **: soup_date_to_time_t: assertion `date != NULL' failed We should also pass true for WebCore::Cookie's session argument if SoupCookie->expires is NULL. The current implementation reports the cookie as a session one if soup_cookie_jar_is_persistent(jar) returns true, which is inaccurate. Note that this does not currently affect Web Inspector as it ignores the session member in CookieParser.js WebInspector.Cookies.buildCookieProtocolObject(). Instead, Web Inspector currently uses the following rule: session: function() { // RFC 2965 suggests using Discard attribute to mark session cookies, but this does not seem to be widely used. // Check for absence of explicitly max-age or expiry date instead. return !("expires" in this._attributes || "max-age" in this._attributes); }, 848882 1 svillar 2013-03-06 08:25:18 -0800 Yeah I planned to fix that some time ago but I end up forgetting about it. 848883 2 191757 cdumez 2013-03-06 08:26:55 -0800 Created attachment 191757 Patch 848937 3 191757 webkit.review.bot 2013-03-06 09:27:31 -0800 Comment on attachment 191757 Patch Clearing flags on attachment: 191757 Committed r144936: <http://trac.webkit.org/changeset/144936> 848938 4 webkit.review.bot 2013-03-06 09:27:35 -0800 All reviewed patches have been landed. Closing bug. 191757 2013-03-06 08:26:55 -0800 2013-03-06 09:27:31 -0800 Patch 111584_getRawCookies.patch text/plain 2502 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNTE4ZjY1Li45NmU3NTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTMtMDMtMDYgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIFtzb3VwXSBzZXNzaW9uIGNvb2tpZXMgYXJlIG5vdCBjb3JyZWN0bHkg cmVwb3J0ZWQgaW4gZ2V0UmF3Q29va2llcygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE1ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBcyBwZXIgbGlic291cCBkb2N1bWVudGF0aW9uLCBTb3VwQ29v a2llLT5leHBpcmVzIGlzIE5VTEwgZm9yIHNlc3Npb24gY29va2llcy4KKyAgICAgICAgSG93ZXZl ciwgdGhlIHNvdXAgaW1wbGVtZW50YXRpb24gZm9yIGdldFJhd0Nvb2tpZXMoKSBkb2VzIG5vdCBj aGVjayBmb3IgTlVMTAorICAgICAgICBjYXNlIGJlZm9yZSBwYXNzaW5nIHRoZSB2YWx1ZSB0byBz b3VwX2RhdGVfdG9fdGltZV90KCksIHdoaWNoIGxlYWRzIHRvIHJ1biB0aW1lCisgICAgICAgIHdh cm5pbmdzLgorCisgICAgICAgIFdlIHNob3VsZCBhbHNvIHBhc3MgdHJ1ZSBmb3IgV2ViQ29yZTo6 Q29va2llJ3Mgc2Vzc2lvbiBhcmd1bWVudCBpZgorICAgICAgICBTb3VwQ29va2llLT5leHBpcmVz IGlzIE5VTEwuIFRoZSBjdXJyZW50IGltcGxlbWVudGF0aW9uIHJlcG9ydHMgdGhlIGNvb2tpZSBh cyBhCisgICAgICAgIHNlc3Npb24gb25lIGlmIHNvdXBfY29va2llX2phcl9pc19wZXJzaXN0ZW50 KGphcikgcmV0dXJucyB0cnVlLCB3aGljaCBpcworICAgICAgICBpbmFjY3VyYXRlLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlIGZvciBsYXlvdXQgdGVzdHMgYXMg V2ViIEluc3BlY3RvciBjdXJyZW50bHkKKyAgICAgICAgaWdub3JlcyB0aGUgInNlc3Npb24iIG1l bWJlciBhbmQgdXNlcyBleHBpcmVzL21heC1hZ2UgaW5zdGVhZCB0byBkZWR1Y2UgaXQuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpnZXRSYXdDb29raWVzKToKKwogMjAxMy0wMy0wNiAgQWxsYW4gU2FuZGZlbGQg SmVuc2VuICA8YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4KIAogICAgICAgICBSRUdHUkVTU0lPTiAo cjE0MjExMik6IEl0IG1hZGUgY29tcG9zaXRpbmcgdGVzdHMgZmFpbCBvbiBFRkwsIFF0LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL0Nvb2tpZUphclNv dXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL0Nvb2tpZUphclNv dXAuY3BwCmluZGV4IDliMzk5YWIuLjAzMjkzNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5jcHAKQEAgLTE1MCw4ICsx NTAsOCBAQCBib29sIGdldFJhd0Nvb2tpZXMoY29uc3QgTmV0d29ya1N0b3JhZ2VTZXNzaW9uJiBz ZXNzaW9uLCBjb25zdCBLVVJMJiAvKmZpcnN0UGFydAogICAgIGZvciAoR1NMaXN0KiBpdGVyID0g Y29va2llcy5nZXQoKTsgaXRlcjsgaXRlciA9IGdfc2xpc3RfbmV4dChpdGVyKSkgewogICAgICAg ICBTb3VwQ29va2llKiBjb29raWUgPSBzdGF0aWNfY2FzdDxTb3VwQ29va2llKj4oaXRlci0+ZGF0 YSk7CiAgICAgICAgIHJhd0Nvb2tpZXMuYXBwZW5kKENvb2tpZShTdHJpbmc6OmZyb21VVEY4KGNv b2tpZS0+bmFtZSksIFN0cmluZzo6ZnJvbVVURjgoY29va2llLT52YWx1ZSksIFN0cmluZzo6ZnJv bVVURjgoY29va2llLT5kb21haW4pLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg U3RyaW5nOjpmcm9tVVRGOChjb29raWUtPnBhdGgpLCBzdGF0aWNfY2FzdDxkb3VibGU+KHNvdXBf ZGF0ZV90b190aW1lX3QoY29va2llLT5leHBpcmVzKSkgKiAxMDAwLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgY29va2llLT5odHRwX29ubHksIGNvb2tpZS0+c2VjdXJlLCBzb3Vw X2Nvb2tpZV9qYXJfaXNfcGVyc2lzdGVudChqYXIpKSk7CisgICAgICAgICAgICBTdHJpbmc6OmZy b21VVEY4KGNvb2tpZS0+cGF0aCksIGNvb2tpZS0+ZXhwaXJlcyA/IHN0YXRpY19jYXN0PGRvdWJs ZT4oc291cF9kYXRlX3RvX3RpbWVfdChjb29raWUtPmV4cGlyZXMpKSAqIDEwMDAgOiAwLAorICAg ICAgICAgICAgY29va2llLT5odHRwX29ubHksIGNvb2tpZS0+c2VjdXJlLCAhY29va2llLT5leHBp cmVzKSk7CiAgICAgICAgIHNvdXBfY29va2llX2ZyZWUoY29va2llKTsKICAgICB9CiAK