111581 2013-03-06 07:50:33 -0800 Web Inspector: fix closure compiler warnings in the profiler code 2013-03-06 08:30:23 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 848862 0 yurys 2013-03-06 07:50:33 -0800 ./Source/WebCore/inspector/compile-front-end.py Source/WebCore/inspector/front-end/FlameChart.js:202: WARNING - Type annotations are not allowed here. Are you missing parentheses? var levelOffsets = /** @type {Array.<!number>} */ [0]; ^ Source/WebCore/inspector/front-end/ProfileLauncherView.js:200: WARNING - Property liveNativeMemoryChart never defined on WebInspector.experimentsSettings if (WebInspector.experimentsSettings.liveNativeMemoryChart.isEnabled()) { ^ Source/WebCore/inspector/front-end/ProfileLauncherView.js:203: WARNING - Property NativeMemoryBarChart never defined on WebInspector this._nativeMemoryLiveChart = new WebInspector.NativeMemoryBarChart(); ^ 0 error(s), 3 warning(s), 81.0% typed Compiling InjectedScriptSource.js... Source/WebCore/inspector/InjectedScriptSourceTmp.js:226: WARNING - Property objectId never defined on InjectedScriptHost var id = InjectedScriptHost.objectId(object); ^ Source/WebCore/inspector/InjectedScriptSourceTmp.js:376: WARNING - Property releaseObjectId never defined on InjectedScriptHost InjectedScriptHost.releaseObjectId(object); ^ 0 error(s), 2 warning(s), 90.3% typed Compiling InjectedScriptCanvasModuleSource.js... 0 error(s), 0 warning(s), 92.4% typed 848863 1 191750 yurys 2013-03-06 07:52:17 -0800 Created attachment 191750 Patch 848887 2 191750 webkit.review.bot 2013-03-06 08:30:20 -0800 Comment on attachment 191750 Patch Clearing flags on attachment: 191750 Committed r144932: <http://trac.webkit.org/changeset/144932> 848888 3 webkit.review.bot 2013-03-06 08:30:23 -0800 All reviewed patches have been landed. Closing bug. 191750 2013-03-06 07:52:17 -0800 2013-03-06 08:30:19 -0800 Patch bug-111581-20130306194822.patch text/plain 4606 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWVjNTQ0YzA0OGI2YzBi OGViOTQzOWMzN2NjMjAwYWJjY2RmN2Q4YS4uMDg2ZmEzY2FkNjQzYTQyOTllMzM0OGNhMDY1YzBi NmEwMzdjYWI2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTA2ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGZpeCBjbG9zdXJlIGNvbXBpbGVyIHdhcm5pbmdzIGluIHRoZSBwcm9maWxlciBjb2RlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE1ODEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBtaXNz aW5nIGFubm90YXRpb25zLiBSZXBsYWNlZCBOYXRpdmVQcm9maWxlTGF1bmNoZXJWaWV3IHdpdGgK KyAgICAgICAgUHJvZmlsZUxhdW5jaGVyVmlldy4KKworICAgICAgICAqIGluc3BlY3Rvci9Jbmpl Y3RlZFNjcmlwdEV4dGVybnMuanM6CisgICAgICAgIChJbmplY3RlZFNjcmlwdEhvc3QucHJvdG90 eXBlLm9iamVjdElkKToKKyAgICAgICAgKEluamVjdGVkU2NyaXB0SG9zdC5wcm90b3R5cGUucmVs ZWFzZU9iamVjdElkKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0ZsYW1lQ2hhcnQu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRmxhbWVDaGFydC5wcm90b3R5cGUuX2ZvckVhY2hO b2RlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVMYXVuY2hlclZpZXcu anM6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzOgorCiAy MDEzLTAzLTA2ICBWbGFkaXNsYXYgS2F6bmFjaGVldiAgPGthem5hY2hlZXZAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbWJpbmUgc3R5bGUtcmVsYXRlZCBwYW5lcyBp bnRvIGEgc2luZ2xlIHRhYiB3aGVuIEVsZW1lbnRzIHBhbmVsIGlzIHNwbGl0IGhvcml6b250YWxs eS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEV4 dGVybnMuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRFeHRlcm5z LmpzCmluZGV4IDNiNzcyNmMzM2ZlMmY0ZjdjODU4NzA3NTJhMGZhNjZlMDYyOGE4NTcuLjA2NDQ0 ZmJiMGQ4ZWE1ZTVlZGYzODgwZWRmMDA1ZWJlYTkzODJjNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEV4dGVybnMuanMKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0RXh0ZXJucy5qcwpAQCAtNjIsNiArNjIsMTUg QEAgSW5qZWN0ZWRTY3JpcHRIb3N0LnByb3RvdHlwZS5jbGVhckNvbnNvbGVNZXNzYWdlcyA9IGZ1 bmN0aW9uKCkgeyB9CiBJbmplY3RlZFNjcmlwdEhvc3QucHJvdG90eXBlLmluc3BlY3RlZE9iamVj dCA9IGZ1bmN0aW9uKGluZGV4KSB7IH0KIC8qKgogICogQHBhcmFtIHsqfSBvYmplY3QKKyAqIEBy ZXR1cm4ge251bWJlcn0KKyAqLworSW5qZWN0ZWRTY3JpcHRIb3N0LnByb3RvdHlwZS5vYmplY3RJ ZCA9IGZ1bmN0aW9uKG9iamVjdCkgeyB9CisvKioKKyAqIEBwYXJhbSB7Kn0gb2JqZWN0CisgKi8K K0luamVjdGVkU2NyaXB0SG9zdC5wcm90b3R5cGUucmVsZWFzZU9iamVjdElkID0gZnVuY3Rpb24o b2JqZWN0KSB7IH0KKy8qKgorICogQHBhcmFtIHsqfSBvYmplY3QKICAqLwogSW5qZWN0ZWRTY3Jp cHRIb3N0LnByb3RvdHlwZS5kYXRhYmFzZUlkID0gZnVuY3Rpb24ob2JqZWN0KSB7IH0KIC8qKgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9GbGFtZUNoYXJ0 LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9GbGFtZUNoYXJ0LmpzCmlu ZGV4IGFkMmUwM2VhZWI1MGM0ODdkNzQ2YjUxMWQ0ZjAwNWFkM2ZmYTVjYTEuLmE2YTU0NGVjZmEx ZTVkOTFkZGNjNjAyZDViOGVlMDU1MTZmYjhjMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRmxhbWVDaGFydC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0ZsYW1lQ2hhcnQuanMKQEAgLTE5OSw3ICsxOTksNyBAQCBXZWJJ bnNwZWN0b3IuRmxhbWVDaGFydC5wcm90b3R5cGUgPSB7CiAgICAgX2ZvckVhY2hOb2RlOiBmdW5j dGlvbihjYWxsYmFjaykKICAgICB7CiAgICAgICAgIHZhciBub2RlcyA9IHRoaXMuX3Jvb3ROb2Rl cygpOwotICAgICAgICB2YXIgbGV2ZWxPZmZzZXRzID0gLyoqIEB0eXBlIHtBcnJheS48IW51bWJl cj59ICovIFswXTsKKyAgICAgICAgdmFyIGxldmVsT2Zmc2V0cyA9IC8qKiBAdHlwZSB7QXJyYXku PCFudW1iZXI+fSAqLyAoWzBdKTsKICAgICAgICAgdmFyIGxldmVsRXhpdEluZGV4ZXMgPSBbMF07 CiAKICAgICAgICAgd2hpbGUgKG5vZGVzLmxlbmd0aCkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlTGF1bmNoZXJWaWV3LmpzIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlTGF1bmNoZXJWaWV3LmpzCmluZGV4 IGE4MzFmNGFlYjI5NDU1ZWQ5NzIyMDNiNzQzMGRjYjZjODhjNGJiOWEuLmJhYTdjYjRjYjE4ZGQw YmJjZjY4YWMyNjViZDJiN2NiMTFjMTk3NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZUxhdW5jaGVyVmlldy5qcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVMYXVuY2hlclZpZXcuanMKQEAgLTE4Nywy NCArMTg3LDMgQEAgV2ViSW5zcGVjdG9yLk11bHRpUHJvZmlsZUxhdW5jaGVyVmlldy5wcm90b3R5 cGUgPSB7CiAgICAgX19wcm90b19fOiBXZWJJbnNwZWN0b3IuUHJvZmlsZUxhdW5jaGVyVmlldy5w cm90b3R5cGUKIH0KIAotCi0vKioKLSAqIEBjb25zdHJ1Y3RvcgotICogQGV4dGVuZHMge1dlYklu c3BlY3Rvci5Qcm9maWxlTGF1bmNoZXJWaWV3fQotICogQHBhcmFtIHshV2ViSW5zcGVjdG9yLlBy b2ZpbGVzUGFuZWx9IHByb2ZpbGVzUGFuZWwKLSAqLwotV2ViSW5zcGVjdG9yLk5hdGl2ZVByb2Zp bGVMYXVuY2hlclZpZXcgPSBmdW5jdGlvbihwcm9maWxlc1BhbmVsKQotewotICAgIFdlYkluc3Bl Y3Rvci5Qcm9maWxlTGF1bmNoZXJWaWV3LmNhbGwodGhpcywgcHJvZmlsZXNQYW5lbCk7Ci0KLSAg ICBpZiAoV2ViSW5zcGVjdG9yLmV4cGVyaW1lbnRzU2V0dGluZ3MubGl2ZU5hdGl2ZU1lbW9yeUNo YXJ0LmlzRW5hYmxlZCgpKSB7Ci0gICAgICAgIHRoaXMuX25hdGl2ZU1lbW9yeUVsZW1lbnQgPSBk b2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKLSAgICAgICAgdGhpcy5fY29udGVudEVsZW1l bnQuaW5zZXJ0QmVmb3JlKHRoaXMuX25hdGl2ZU1lbW9yeUVsZW1lbnQsIHRoaXMuX2NvbnRyb2xC dXR0b24pOwotICAgICAgICB0aGlzLl9uYXRpdmVNZW1vcnlMaXZlQ2hhcnQgPSBuZXcgV2ViSW5z cGVjdG9yLk5hdGl2ZU1lbW9yeUJhckNoYXJ0KCk7Ci0gICAgICAgIHRoaXMuX25hdGl2ZU1lbW9y eUxpdmVDaGFydC5zaG93KHRoaXMuX25hdGl2ZU1lbW9yeUVsZW1lbnQpOwotICAgIH0KLX0KLQot V2ViSW5zcGVjdG9yLk5hdGl2ZVByb2ZpbGVMYXVuY2hlclZpZXcucHJvdG90eXBlID0gewotICAg IF9fcHJvdG9fXzogV2ViSW5zcGVjdG9yLlByb2ZpbGVMYXVuY2hlclZpZXcucHJvdG90eXBlCi19 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVz UGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFu ZWwuanMKaW5kZXggZjZlYjc0NjI4NDM1ODUzOGRjMzZmNzBiYTJiM2IxNDFlMjU2YzZjMy4uMWI0 MGVjNDhiN2U1ZWRlNDMyY2M5N2NmMjBlYWM2NDNlZWIxYTVhMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcwpAQCAtMTQyMiwx NSArMTQyMiw2IEBAIFdlYkluc3BlY3Rvci5NZW1vcnlDaGFydFByb2ZpbGVyUGFuZWwgPSBmdW5j dGlvbigpCiB9CiAKIFdlYkluc3BlY3Rvci5NZW1vcnlDaGFydFByb2ZpbGVyUGFuZWwucHJvdG90 eXBlID0gewotICAgIC8qKgotICAgICAqIEBvdmVycmlkZQotICAgICAqIEByZXR1cm4geyFXZWJJ bnNwZWN0b3IuUHJvZmlsZUxhdW5jaGVyVmlld30KLSAgICAgKi8KLSAgICBfY3JlYXRlTGF1bmNo ZXJWaWV3OiBmdW5jdGlvbigpCi0gICAgewotICAgICAgICByZXR1cm4gbmV3IFdlYkluc3BlY3Rv ci5OYXRpdmVQcm9maWxlTGF1bmNoZXJWaWV3KHRoaXMpOwotICAgIH0sCi0KICAgICBfX3Byb3Rv X186IFdlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVsLnByb3RvdHlwZQogfQogCg==