111568 2013-03-06 05:39:29 -0800 Token 'not' is ignored in the offlineasm 2013-03-13 02:10:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 90740 0 galpeter webkit-unassigned fpizlo mark.lam ossy webkit.review.bot zherczeg oldest_to_newest 848755 0 galpeter 2013-03-06 05:39:29 -0800 The token 'not' is ignored in the offlineasm, thus no AST is built for it. This is the relevant code part: def parsePredicateAtom if @tokens[@idx] == "not" @idx += 1 parsePredicateAtom elsif @tokens[@idx] == "(" ... 848765 1 191733 galpeter 2013-03-06 05:46:10 -0800 Created attachment 191733 Fix in the parser This is the fix, to build the Not AST node in the parser. 848769 2 galpeter 2013-03-06 05:49:14 -0800 (In reply to comment #1) > Created an attachment (id=191733) [details] > Fix in the parser > > This is the fix, to build the Not AST node in the parser. For this patch in the bug #90740 is needed, without that the generation of llint will fail. 848777 3 galpeter 2013-03-06 06:01:27 -0800 Oh.. just one thing: the 'not' is never used in the input .asm files, so that's why this wasn't spotted before. 851937 4 galpeter 2013-03-10 10:21:43 -0700 ping? 854123 5 galpeter 2013-03-13 01:40:43 -0700 Anyone up for a review? 854124 6 191733 fpizlo 2013-03-13 01:42:11 -0700 Comment on attachment 191733 Fix in the parser Sorry it took so long! Thanks for this fix. r=me. 854136 7 191733 webkit.review.bot 2013-03-13 02:09:59 -0700 Comment on attachment 191733 Fix in the parser Clearing flags on attachment: 191733 Committed r145689: <http://trac.webkit.org/changeset/145689> 854137 8 webkit.review.bot 2013-03-13 02:10:02 -0700 All reviewed patches have been landed. Closing bug. 191733 2013-03-06 05:46:10 -0800 2013-03-13 02:09:59 -0700 Fix in the parser offlineasm_parser_not_fix.patch text/plain 1245 galpeter ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDFjMmRlOTAuLjY3MTYyODMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEzLTAzLTA2ICBQZXRlciBHYWwgIDxn YWxwZXRlckBpbmYudS1zemVnZWQuaHU+CiAKKyAgICAgICAgVG9rZW4gJ25vdCcgaXMgaWdub3Jl ZCBpbiB0aGUgb2ZmbGluZWFzbS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTU2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogb2ZmbGluZWFzbS9wYXJzZXIucmI6IEJ1aWxkIHRoZSBOb3QgQVNUIG5v ZGUgaWYgdGhlICdub3QnIHRva2VuIGlzIGZvdW5kLgorCisyMDEzLTAzLTA2ICBQZXRlciBHYWwg IDxnYWxwZXRlckBpbmYudS1zemVnZWQuaHU+CisKICAgICAgICAgQ2hpbGRyZW4gbWV0aG9kIGlu IExMSU5UIEFTVCBOb3QgY2xhc3Mgc2hvdWxkIHJldHVybiBbQGNoaWxkXQogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTA3NDAKIApkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vcGFyc2VyLnJiIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL29mZmxpbmVhc20vcGFyc2VyLnJiCmluZGV4IDc2ZWVhNTIuLjRmNDVkMzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3BhcnNlci5yYgorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9wYXJzZXIucmIKQEAgLTIyMyw4ICsy MjMsOSBAQCBjbGFzcyBQYXJzZXIKICAgICAKICAgICBkZWYgcGFyc2VQcmVkaWNhdGVBdG9tCiAg ICAgICAgIGlmIEB0b2tlbnNbQGlkeF0gPT0gIm5vdCIKKyAgICAgICAgICAgIGNvZGVPcmlnaW4g PSBAdG9rZW5zW0BpZHhdLmNvZGVPcmlnaW4KICAgICAgICAgICAgIEBpZHggKz0gMQotICAgICAg ICAgICAgcGFyc2VQcmVkaWNhdGVBdG9tCisgICAgICAgICAgICBOb3QubmV3KGNvZGVPcmlnaW4s IHBhcnNlUHJlZGljYXRlQXRvbSkKICAgICAgICAgZWxzaWYgQHRva2Vuc1tAaWR4XSA9PSAiKCIK ICAgICAgICAgICAgIEBpZHggKz0gMQogICAgICAgICAgICAgc2tpcE5ld0xpbmUK