111562 2013-03-06 05:13:11 -0800 [Qt] Illegal narrowing in tst_qwebhistory 2013-03-06 06:31:27 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen jturcotte oldest_to_newest 848732 0 allan.jensen 2013-03-06 05:13:11 -0800 The bytearray in tst_QWebHistory::restoreIncompatibleVersion1 has integer values higher than 127 assigned into an array of signed chars. This works correctly but causes compiler errors in C++11 since it assigns constants (>127) that doesn't fit the destination (-128 to 127). 848734 1 191722 allan.jensen 2013-03-06 05:15:06 -0800 Created attachment 191722 Patch 848749 2 191722 jturcotte 2013-03-06 05:32:34 -0800 Comment on attachment 191722 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191722&action=review Oops > Source/WebKit/qt/tests/qwebhistory/tst_qwebhistory.cpp:517 > + QByteArray version1((const char*)version1Dump, sizeof(version1Dump)); Nit: static_cast 848802 3 allan.jensen 2013-03-06 06:31:27 -0800 Committed r144918: <http://trac.webkit.org/changeset/144918> 191722 2013-03-06 05:15:06 -0800 2013-03-06 05:32:34 -0800 Patch bug-111562-20130306141022.patch text/plain 2575 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDkzN2ZhOTE5NWVl ZDRiOGE3YTc0MDY5NmRhNjE0N2Q0MjE5NDAwMTUuLmFhNjdmNGYwNjNlOTE2YTU0OWZlYTVmYjYz NGY0ZjkwYWE1NTM0MTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMDMt MDYgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKKyAg ICAgICAgW1F0XSBJbGxlZ2FsIG5hcnJvd2luZyBpbiB0c3RfcXdlYmhpc3RvcnkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTU2MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBieXRlYXJyYXkgaW4g dHN0X1FXZWJIaXN0b3J5OjpyZXN0b3JlSW5jb21wYXRpYmxlVmVyc2lvbjEgaGFzIGludGVnZXIK KyAgICAgICAgdmFsdWVzIGhpZ2hlciB0aGFuIDEyNyBhc3NpZ25lZCBpbnRvIGFuIGFycmF5IG9m IHNpZ25lZCBjaGFycy4gVGhpcyBjYXVzZXMKKyAgICAgICAgY29tcGlsZXIgZXJyb3JzIGluIEMr KzExIHNpbmNlIGl0IGFzc2lnbnMgY29uc3RhbnRzICg+MTI3KSB0aGF0IGRvZXMgbm90CisgICAg ICAgIGZpdCB0aGUgZGVzdGluYXRpb24gKC0xMjggdG8gMTI3KQorCisgICAgICAgICogdGVzdHMv cXdlYmhpc3RvcnkvdHN0X3F3ZWJoaXN0b3J5LmNwcDoKKyAgICAgICAgKHRzdF9RV2ViSGlzdG9y eTo6cmVzdG9yZUluY29tcGF0aWJsZVZlcnNpb24xKToKKwogMjAxMy0wMy0wMyAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYXR0ZW1wdGVkIGJ1 aWxkIGZpeC4gQWRkcyBiYWNrIHNvbWUgaW5jbHVkZXMgcmVtb3ZlZCBpbgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViaGlzdG9yeS90c3RfcXdlYmhpc3RvcnkuY3BwIGIv U291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2ViaGlzdG9yeS90c3RfcXdlYmhpc3RvcnkuY3BwCmlu ZGV4IDdiNTkxYjk5YWM1OWY2MDM0MDM2ZWM2NzNhN2JhMjYwMDNhOWNlNzUuLjg4NGJmMDIwMWJj OGQ0YWU1MTI2YjA3ZGQ1NzRiNzUwYmY1NGYyYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv cXQvdGVzdHMvcXdlYmhpc3RvcnkvdHN0X3F3ZWJoaXN0b3J5LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L3F0L3Rlc3RzL3F3ZWJoaXN0b3J5L3RzdF9xd2ViaGlzdG9yeS5jcHAKQEAgLTQ0Nyw3ICs0 NDcsNyBAQCB2b2lkIHRzdF9RV2ViSGlzdG9yeTo6cmVzdG9yZUluY29tcGF0aWJsZVZlcnNpb24x KCkKIHsKICAgICAvLyBVbmNvbW1lbnQgdGhpcyBjb2RlIHRvIGdlbmVyYXRlIGEgZHVtcCBzaW1p bGFyIHRvIHRoZSBvbmUgYmVsb3cgd2l0aCB0aGUgY3VycmVudCBzdHJlYW0gdmVyc2lvbi4KICAg ICAvLyBkdW1wQ3VycmVudFZlcnNpb24oaGlzdCk7Ci0gICAgc3RhdGljIGNvbnN0IGNoYXIgdmVy c2lvbjFEdW1wW10gPSB7CisgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIGNoYXIgdmVyc2lvbjFE dW1wW10gPSB7CiAgICAgICAgIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDEsIDB4MDAsIDB4MDAsIDB4 MDAsIDB4MDUsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDQsIDB4MDAsIDB4MDAsIDB4MDAsCiAgICAg ICAgIDB4MzIsIDB4MDAsIDB4NzEsIDB4MDAsIDB4NzIsIDB4MDAsIDB4NjMsIDB4MDAsIDB4M2Es IDB4MDAsIDB4MmYsIDB4MDAsIDB4NzIsIDB4MDAsIDB4NjUsCiAgICAgICAgIDB4MDAsIDB4NzMs IDB4MDAsIDB4NmYsIDB4MDAsIDB4NzUsIDB4MDAsIDB4NzIsIDB4MDAsIDB4NjMsIDB4MDAsIDB4 NjUsIDB4MDAsIDB4NzMsIDB4MDAsCkBAIC01MTQsNyArNTE0LDcgQEAgdm9pZCB0c3RfUVdlYkhp c3Rvcnk6OnJlc3RvcmVJbmNvbXBhdGlibGVWZXJzaW9uMSgpCiAgICAgICAgIDB4MDAsIDB4MDAs IDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4 MDAsIDB4MDAsIDB4MDAsIDB4MDAsCiAgICAgICAgIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4 MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAs IDB4MDAsCiAgICAgICAgIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDAsIDB4MDB9 OwotICAgIFFCeXRlQXJyYXkgdmVyc2lvbjEodmVyc2lvbjFEdW1wLCBzaXplb2YodmVyc2lvbjFE dW1wKSk7CisgICAgUUJ5dGVBcnJheSB2ZXJzaW9uMSgoY29uc3QgY2hhciopdmVyc2lvbjFEdW1w LCBzaXplb2YodmVyc2lvbjFEdW1wKSk7CiAgICAgUURhdGFTdHJlYW0gc3RyZWFtKCZ2ZXJzaW9u MSwgUUlPRGV2aWNlOjpSZWFkT25seSk7CiAKICAgICAvLyBUaGlzIHNob3VsZCBmYWlsIHRvIGxv YWQsIHRoZSBoaXN0b3J5IHNob3VsZCBiZSBjbGVhcmVkIGFuZCB0aGUgc3RyZWFtIHNob3VsZCBi ZSBicm9rZW4uCg==