111548 2013-03-06 02:16:56 -0800 Web Inspector: test that "importScript" is used only in module heads. 2013-03-06 07:23:10 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 lushnikov lushnikov apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 848653 0 lushnikov 2013-03-06 02:16:56 -0800 Test that "importScript" function is called only in module heads to avoid bugs like https://bugs.webkit.org/show_bug.cgi?id=111535 848674 1 191701 lushnikov 2013-03-06 03:08:37 -0800 Created attachment 191701 Patch 848677 2 191701 pfeldman 2013-03-06 03:10:40 -0800 Comment on attachment 191701 Patch You want to raise exception here, not exit. 848681 3 lushnikov 2013-03-06 03:24:13 -0800 This will exit with exitcode = 1 and error message. In the nutshell it raises SystemExit exception - so what's the difference? 848688 4 191706 lushnikov 2013-03-06 03:39:32 -0800 Created attachment 191706 Patch 848844 5 191706 webkit.review.bot 2013-03-06 07:23:06 -0800 Comment on attachment 191706 Patch Clearing flags on attachment: 191706 Committed r144926: <http://trac.webkit.org/changeset/144926> 848845 6 webkit.review.bot 2013-03-06 07:23:10 -0800 All reviewed patches have been landed. Closing bug. 191701 2013-03-06 03:08:37 -0800 2013-03-06 03:39:28 -0800 Patch bug-111548-20130306150442.patch text/plain 1573 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQ4OGUwNDMwOTEzNTQ1NTA0MjIyMzYyOTJlNzZlOTFlNGJmMThiNGIuLjNhYzBmZTlkZGI5N2Q1 YTAxNGMzYTY0NWIyOWQ1YTgyMWUwMTQzYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTMtMDMtMDYgIEFuZHJleSBMdXNobmlrb3YgIDxsdXNobmlrb3ZA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHRlc3QgdGhhdCAiaW1wb3J0 U2NyaXB0IiBpcyB1c2VkIG9ubHkgaW4gbW9kdWxlIGhlYWRzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNTQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCB0aGF0IG91dHB1dCBmaWxlIGFmdGVy IGFsbCBpbmxpbmVzIGRvZXMgbm90IGhhdmUgYW55ICdpbXBvcnRTY3JpcHQocyknIHN0YXRlbWVu dHMuCisKKyAgICAgICAgKiBzY3JpcHRzL2lubGluZV9qc19pbXBvcnRzLnB5OgorICAgICAgICAo bWFpbik6CisKIDIwMTMtMDMtMDUgIEFsZXhhbmRyZSBFbGlhcyAgPGFlbGlhc0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBTY3JvbGwgZGVsdGFzIHNob3VsZCBiZSBmbG9hdHMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc2NyaXB0cy9pbmxpbmVfanNfaW1w b3J0cy5weSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc2NyaXB0cy9pbmxpbmVfanNfaW1wb3J0 cy5weQppbmRleCA3NzZhM2ZjZGU0ZDJiMjUxYzUxY2ZlZGExMmFiNjc1ZTMzNWQzZWU0Li45YWRi MDgwM2JlMzBlYThmYmQ3MzE3MzQ5Y2E0NGRiY2U0YWMwYmJhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NjcmlwdHMvaW5saW5lX2pzX2ltcG9ydHMucHkKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zY3JpcHRzL2lubGluZV9qc19pbXBvcnRzLnB5CkBAIC02OCw2ICs2 OCw4IEBAIGRlZiBtYWluKGFyZ3YpOgogICAgICAgICByZXR1cm4gaW1wb3J0X3NjcmlwdAogCiAg ICAgb3V0cHV0X3NjcmlwdCA9IHJlLnN1YihyJ2ltcG9ydFNjcmlwdHM/XChbXCciXShbXlwnIl0r KVtcJyJdXCknLCByZXBsYWNlLCBpbnB1dF9zY3JpcHQpCisgICAgaWYgcmUuc2VhcmNoKCJpbXBv cnRTY3JpcHRzP1woXCIiLCBvdXRwdXRfc2NyaXB0KToKKyAgICAgICAgc3lzLmV4aXQoIlVucmVz b2x2ZWQgXCJpbXBvcnRTY3JpcHRcIiBzdGF0ZW1lbnRzIGZvdW5kIGluIFwiIiArIG91dHB1dF9m aWxlX25hbWUgKyAiXCIuIE1ha2Ugc3VyZSB5b3UgY2FsbCBcImltcG9ydFNjcmlwdFwiIGluIG1v ZHVsZSBoZWFkcyBvbmx5LiIpCiAKICAgICBvdXRwdXRfZmlsZSA9IG9wZW4ob3V0cHV0X2ZpbGVf bmFtZSwgJ3cnKQogICAgIGlmIG5vdCBub19taW5pZnk6Cg== 191706 2013-03-06 03:39:32 -0800 2013-03-06 07:23:06 -0800 Patch bug-111548-20130306153538.patch text/plain 1627 lushnikov U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQ4OGUwNDMwOTEzNTQ1NTA0MjIyMzYyOTJlNzZlOTFlNGJmMThiNGIuLjNhYzBmZTlkZGI5N2Q1 YTAxNGMzYTY0NWIyOWQ1YTgyMWUwMTQzYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTMtMDMtMDYgIEFuZHJleSBMdXNobmlrb3YgIDxsdXNobmlrb3ZA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHRlc3QgdGhhdCAiaW1wb3J0 U2NyaXB0IiBpcyB1c2VkIG9ubHkgaW4gbW9kdWxlIGhlYWRzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNTQ4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCB0aGF0IG91dHB1dCBmaWxlIGFmdGVy IGFsbCBpbmxpbmVzIGRvZXMgbm90IGhhdmUgYW55ICdpbXBvcnRTY3JpcHQocyknIHN0YXRlbWVu dHMuCisKKyAgICAgICAgKiBzY3JpcHRzL2lubGluZV9qc19pbXBvcnRzLnB5OgorICAgICAgICAo bWFpbik6CisKIDIwMTMtMDMtMDUgIEFsZXhhbmRyZSBFbGlhcyAgPGFlbGlhc0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBTY3JvbGwgZGVsdGFzIHNob3VsZCBiZSBmbG9hdHMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc2NyaXB0cy9pbmxpbmVfanNfaW1w b3J0cy5weSBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc2NyaXB0cy9pbmxpbmVfanNfaW1wb3J0 cy5weQppbmRleCA3NzZhM2ZjZGU0ZDJiMjUxYzUxY2ZlZGExMmFiNjc1ZTMzNWQzZWU0Li40MzQz MjI2ZTgzNjhkNjlmY2UzZTIwNTA0N2Q4MjY2MGUyNGNhMjNmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NjcmlwdHMvaW5saW5lX2pzX2ltcG9ydHMucHkKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zY3JpcHRzL2lubGluZV9qc19pbXBvcnRzLnB5CkBAIC02OCw2ICs2 OCwxMCBAQCBkZWYgbWFpbihhcmd2KToKICAgICAgICAgcmV0dXJuIGltcG9ydF9zY3JpcHQKIAog ICAgIG91dHB1dF9zY3JpcHQgPSByZS5zdWIocidpbXBvcnRTY3JpcHRzP1woW1wnIl0oW15cJyJd KylbXCciXVwpJywgcmVwbGFjZSwgaW5wdXRfc2NyaXB0KQorICAgIGlmIHJlLnNlYXJjaCgiaW1w b3J0U2NyaXB0cz9cKFwiIiwgb3V0cHV0X3NjcmlwdCk6CisgICAgICAgIHJhaXNlIEV4Y2VwdGlv bignVW5yZXNvbHZlZCAiaW1wb3J0U2NyaXB0IiBzdGF0ZW1lbnRzIGZvdW5kIGluICIlcyIuICcK KyAgICAgICAgICAgICAgICAgICAgICAgICdNYWtlIHN1cmUgeW91IGNhbGwgImltcG9ydFNjcmlw dCIgaW4gbW9kdWxlIGhlYWRzIG9ubHkuJyAlCisgICAgICAgICAgICAgICAgICAgICAgICAob3V0 cHV0X2ZpbGVfbmFtZSkpCiAKICAgICBvdXRwdXRfZmlsZSA9IG9wZW4ob3V0cHV0X2ZpbGVfbmFt ZSwgJ3cnKQogICAgIGlmIG5vdCBub19taW5pZnk6Cg==