111547 2013-03-06 01:59:38 -0800 [wk2] Page Overlays: Hook up the layer border/repaint counter setting to the overlay layer 2013-03-06 12:08:02 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton simon.fraser oldest_to_newest 848645 0 thorton 2013-03-06 01:59:38 -0800 The overlay layer is invisible with tile borders on, but it should show itself! <rdar://problem/13355801> 848647 1 191691 thorton 2013-03-06 02:02:01 -0800 Created attachment 191691 patch 849168 2 thorton 2013-03-06 12:08:02 -0800 http://trac.webkit.org/changeset/144960 191691 2013-03-06 02:02:01 -0800 2013-03-06 09:46:13 -0800 patch page-overlay-border.diff text/plain 3685 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhYmUyMzU5Li40Y2JmN2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDMtMDYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgW3drMl0gUGFnZSBPdmVybGF5czogSG9vayB1cCB0aGUgbGF5ZXIgYm9yZGVyL3Jl cGFpbnQgY291bnRlciBzZXR0aW5nIHRvIHRoZSBvdmVybGF5IGxheWVyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE1NDcKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzEzMzU1ODAxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25E cmF3aW5nQXJlYS5tbToKKyAgICAgICAgKFdlYktpdDo6VGlsZWRDb3JlQW5pbWF0aW9uRHJhd2lu Z0FyZWE6OnVwZGF0ZVByZWZlcmVuY2VzKToKKyAgICAgICAgKFdlYktpdDo6VGlsZWRDb3JlQW5p bWF0aW9uRHJhd2luZ0FyZWE6OmNyZWF0ZVBhZ2VPdmVybGF5TGF5ZXIpOgorICAgICAgICBLZWVw IHRoZSBwYWdlIG92ZXJsYXkgbGF5ZXIncyBkZWJ1ZyBib3JkZXIgYW5kIHJlcGFpbnQgY291bnRl ciBzZXR0aW5ncyB1cGRhdGVkLgorCiAyMDEzLTAzLTAyICBUaW0gSG9ydG9uICA8dGltb3RoeV9o b3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFBERlBsdWdpbjogUmVuYW1lIGRlbGVnYXRlIG1l dGhvZCBmcm9tIG9wZW5XaXRoUHJldmlldyB0byBvcGVuV2l0aE5hdGl2ZUFwcGxpY2F0aW9uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1RpbGVkQ29y ZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL21hYy9UaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYS5tbQppbmRleCA5ZjljN2ExLi5l N2FkZTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFj L1RpbGVkQ29yZUFuaW1hdGlvbkRyYXdpbmdBcmVhLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9tYWMvVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWEubW0KQEAg LTIwMiwxOSArMjAyLDI1IEBAIHZvaWQgVGlsZWRDb3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnNl dFBhZ2VPdmVybGF5TmVlZHNEaXNwbGF5KGNvbnN0IEludFJlY3QmIHJlCiAKIHZvaWQgVGlsZWRD b3JlQW5pbWF0aW9uRHJhd2luZ0FyZWE6OnVwZGF0ZVByZWZlcmVuY2VzKGNvbnN0IFdlYlByZWZl cmVuY2VzU3RvcmUmKQogeworICAgIFNldHRpbmdzKiBzZXR0aW5ncyA9IG1fd2ViUGFnZS0+Y29y ZVBhZ2UoKS0+c2V0dGluZ3MoKTsKICAgICBib29sIHNjcm9sbGluZ1BlcmZvcm1hbmNlTG9nZ2lu Z0VuYWJsZWQgPSBtX3dlYlBhZ2UtPnNjcm9sbGluZ1BlcmZvcm1hbmNlTG9nZ2luZ0VuYWJsZWQo KTsKICAgICBTY3JvbGxpbmdUaHJlYWQ6OmRpc3BhdGNoKGJpbmQoJlNjcm9sbGluZ1RyZWU6OnNl dFNjcm9sbGluZ1BlcmZvcm1hbmNlTG9nZ2luZ0VuYWJsZWQsIG1fd2ViUGFnZS0+Y29yZVBhZ2Uo KS0+c2Nyb2xsaW5nQ29vcmRpbmF0b3IoKS0+c2Nyb2xsaW5nVHJlZSgpLCBzY3JvbGxpbmdQZXJm b3JtYW5jZUxvZ2dpbmdFbmFibGVkKSk7CiAKICAgICBpZiAoVGlsZWRCYWNraW5nKiB0aWxlZEJh Y2tpbmcgPSBtYWluRnJhbWVUaWxlZEJhY2tpbmcoKSkKLSAgICAgICAgdGlsZWRCYWNraW5nLT5z ZXRBZ2dyZXNzaXZlbHlSZXRhaW5zVGlsZXMobV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5n cygpLT5hZ2dyZXNzaXZlVGlsZVJldGVudGlvbkVuYWJsZWQoKSk7CisgICAgICAgIHRpbGVkQmFj a2luZy0+c2V0QWdncmVzc2l2ZWx5UmV0YWluc1RpbGVzKHNldHRpbmdzLT5hZ2dyZXNzaXZlVGls ZVJldGVudGlvbkVuYWJsZWQoKSk7CisgICAgCisgICAgaWYgKG1fcGFnZU92ZXJsYXlMYXllcikg eworICAgICAgICBtX3BhZ2VPdmVybGF5TGF5ZXItPnNldFNob3dEZWJ1Z0JvcmRlcihzZXR0aW5n cy0+c2hvd0RlYnVnQm9yZGVycygpKTsKKyAgICAgICAgbV9wYWdlT3ZlcmxheUxheWVyLT5zZXRT aG93UmVwYWludENvdW50ZXIoc2V0dGluZ3MtPnNob3dSZXBhaW50Q291bnRlcigpKTsKKyAgICB9 CiAKICAgICAvLyBTb29uIHdlIHdhbnQgcGFnZXMgd2l0aCBmaXhlZCBwb3NpdGlvbmVkIGVsZW1l bnRzIHRvIGJlIGFibGUgdG8gYmUgc2Nyb2xsZWQgYnkgdGhlIFNjcm9sbGluZ0Nvb3JkaW5hdG9y LgogICAgIC8vIEFzIGEgcGFydCBvZiB0aGF0IHdvcmssIHdlIGhhdmUgdG8gY29tcG9zaXRlIGZp eGVkIHBvc2l0aW9uIGVsZW1lbnRzLCBhbmQgd2UgaGF2ZSB0byBhbGxvdyB0aG9zZQogICAgIC8v IGVsZW1lbnRzIHRvIGNyZWF0ZSBhIHN0YWNraW5nIGNvbnRleHQuCi0gICAgbV93ZWJQYWdlLT5j b3JlUGFnZSgpLT5zZXR0aW5ncygpLT5zZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRm9yRml4ZWRQ b3NpdGlvbkVuYWJsZWQodHJ1ZSk7Ci0gICAgbV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5n cygpLT5zZXRGaXhlZFBvc2l0aW9uQ3JlYXRlc1N0YWNraW5nQ29udGV4dCh0cnVlKTsKKyAgICBz ZXR0aW5ncy0+c2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0ZvckZpeGVkUG9zaXRpb25FbmFibGVk KHRydWUpOworICAgIHNldHRpbmdzLT5zZXRGaXhlZFBvc2l0aW9uQ3JlYXRlc1N0YWNraW5nQ29u dGV4dCh0cnVlKTsKIAotICAgIGJvb2wgc2hvd1RpbGVkU2Nyb2xsaW5nSW5kaWNhdG9yID0gbV93 ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLT5zaG93VGlsZWRTY3JvbGxpbmdJbmRpY2F0 b3IoKTsKKyAgICBib29sIHNob3dUaWxlZFNjcm9sbGluZ0luZGljYXRvciA9IHNldHRpbmdzLT5z aG93VGlsZWRTY3JvbGxpbmdJbmRpY2F0b3IoKTsKICAgICBpZiAoc2hvd1RpbGVkU2Nyb2xsaW5n SW5kaWNhdG9yID09ICEhbV9kZWJ1Z0luZm9MYXllcikKICAgICAgICAgcmV0dXJuOwogCkBAIC00 OTgsNiArNTA0LDggQEAgdm9pZCBUaWxlZENvcmVBbmltYXRpb25EcmF3aW5nQXJlYTo6Y3JlYXRl UGFnZU92ZXJsYXlMYXllcigpCiAgICAgbV9wYWdlT3ZlcmxheUxheWVyLT5zZXRBY2NlbGVyYXRl c0RyYXdpbmcodHJ1ZSk7CiAgICAgbV9wYWdlT3ZlcmxheUxheWVyLT5zZXREcmF3c0NvbnRlbnQo dHJ1ZSk7CiAgICAgbV9wYWdlT3ZlcmxheUxheWVyLT5zZXRTaXplKGV4cGFuZGVkSW50U2l6ZShG bG9hdFNpemUobV9yb290TGF5ZXIuZ2V0KCkuZnJhbWUuc2l6ZSkpKTsKKyAgICBtX3BhZ2VPdmVy bGF5TGF5ZXItPnNldFNob3dEZWJ1Z0JvcmRlcihtX3dlYlBhZ2UtPmNvcmVQYWdlKCktPnNldHRp bmdzKCktPnNob3dEZWJ1Z0JvcmRlcnMoKSk7CisgICAgbV9wYWdlT3ZlcmxheUxheWVyLT5zZXRT aG93UmVwYWludENvdW50ZXIobV93ZWJQYWdlLT5jb3JlUGFnZSgpLT5zZXR0aW5ncygpLT5zaG93 UmVwYWludENvdW50ZXIoKSk7CiAKICAgICBtX3BhZ2VPdmVybGF5UGxhdGZvcm1MYXllciA9IG1f cGFnZU92ZXJsYXlMYXllci0+cGxhdGZvcm1MYXllcigpOwogCg==