111544 2013-03-06 01:29:19 -0800 [BlackBerry] Use hasTagName instead of hasLocalName in CredentialTransformData 2013-03-06 07:08:03 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 848621 0 cgarcia 2013-03-06 01:29:19 -0800 hasLocalName expects an AtomicString, but we are passing a HTMLName which is a QualifiedName. 848626 1 191686 cgarcia 2013-03-06 01:31:06 -0800 Created attachment 191686 Patch 848808 2 191686 rwlbuis 2013-03-06 06:35:22 -0800 Comment on attachment 191686 Patch LGTM. 848830 3 191686 webkit.review.bot 2013-03-06 07:07:59 -0800 Comment on attachment 191686 Patch Clearing flags on attachment: 191686 Committed r144921: <http://trac.webkit.org/changeset/144921> 848831 4 webkit.review.bot 2013-03-06 07:08:03 -0800 All reviewed patches have been landed. Closing bug. 191686 2013-03-06 01:31:06 -0800 2013-03-06 07:07:59 -0800 Patch bb-has-tag-name.diff text/plain 2231 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGJkOGZlNzAuLmNmYmI4MjcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTA2ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gVXNlIGhhc1RhZ05hbWUgaW5zdGVhZCBvZiBoYXNMb2NhbE5hbWUgaW4gQ3JlZGVu dGlhbFRyYW5zZm9ybURhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMTU0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGhhc0xvY2FsTmFtZSgpIGV4cGVjdHMgYW4gQXRvbWljU3RyaW5nLCBidXQgd2Ug YXJlIHBhc3NpbmcgYQorICAgICAgICBIVE1MTmFtZSB3aGljaCBpcyBhIFF1YWxpZmllZE5hbWUu CisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DcmVkZW50aWFsVHJhbnNmb3JtRGF0YS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpDcmVkZW50aWFsVHJhbnNmb3JtRGF0YTo6ZmluZFBhc3N3b3Jk Rm9ybUZpZWxkcyk6IFVzZQorICAgICAgICBoYXNUYWdOYW1lKCkgaW5zdGVhZCBvZiBoYXNMb2Nh bE5hbWUoKS4KKwogMjAxMy0wMy0wNSAgT3R0byBEZXJlayBDaGV1bmcgIDxvdGNoZXVuZ0ByaW0u Y29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBBdXRoZW50aWNhdGlvbiBjcmVkZW50aWFscyBs b3N0IHdoZW4gb3BlbmluZyBhIG5ldyB0YWIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DcmVkZW50aWFsVHJhbnNmb3JtRGF0YS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQ3JlZGVudGlhbFRyYW5zZm9ybURh dGEuY3BwCmluZGV4IDM2NzM0MjUuLmQ1NGE2NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DcmVkZW50aWFsVHJhbnNmb3JtRGF0YS5jcHAKKysr IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0NyZWRlbnRpYWxUcmFu c2Zvcm1EYXRhLmNwcApAQCAtMTk0LDcgKzE5NCw3IEBAIGJvb2wgQ3JlZGVudGlhbFRyYW5zZm9y bURhdGE6OmZpbmRQYXNzd29yZEZvcm1GaWVsZHMoSFRNTEZvcm1FbGVtZW50KiBmb3JtKQogICAg ICAgICBpZiAoIWZvcm1FbGVtZW50c1tpXS0+aXNGb3JtQ29udHJvbEVsZW1lbnQoKSkKICAgICAg ICAgICAgIGNvbnRpbnVlOwogICAgICAgICBIVE1MRm9ybUNvbnRyb2xFbGVtZW50KiBmb3JtRWxl bWVudCA9IHN0YXRpY19jYXN0PEhUTUxGb3JtQ29udHJvbEVsZW1lbnQqPihmb3JtRWxlbWVudHNb aV0pOwotICAgICAgICBpZiAoIWZvcm1FbGVtZW50LT5oYXNMb2NhbE5hbWUoSFRNTE5hbWVzOjpp bnB1dFRhZykpCisgICAgICAgIGlmICghZm9ybUVsZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVz OjppbnB1dFRhZykpCiAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICBIVE1MSW5wdXRF bGVtZW50KiBpbnB1dEVsZW1lbnQgPSBmb3JtRWxlbWVudC0+dG9JbnB1dEVsZW1lbnQoKTsKQEAg LTIxNiw3ICsyMTYsNyBAQCBib29sIENyZWRlbnRpYWxUcmFuc2Zvcm1EYXRhOjpmaW5kUGFzc3dv cmRGb3JtRmllbGRzKEhUTUxGb3JtRWxlbWVudCogZm9ybSkKICAgICAgICAgICAgIGlmICghZm9y bUVsZW1lbnRzW2ldLT5pc0Zvcm1Db250cm9sRWxlbWVudCgpKQogICAgICAgICAgICAgICAgIGNv bnRpbnVlOwogICAgICAgICAgICAgSFRNTEZvcm1Db250cm9sRWxlbWVudCogZm9ybUVsZW1lbnQg PSBzdGF0aWNfY2FzdDxIVE1MRm9ybUNvbnRyb2xFbGVtZW50Kj4oZm9ybUVsZW1lbnRzW2ldKTsK LSAgICAgICAgICAgIGlmICghZm9ybUVsZW1lbnQtPmhhc0xvY2FsTmFtZShIVE1MTmFtZXM6Omlu cHV0VGFnKSkKKyAgICAgICAgICAgIGlmICghZm9ybUVsZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5h bWVzOjppbnB1dFRhZykpCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgICAg IEhUTUxJbnB1dEVsZW1lbnQqIGlucHV0RWxlbWVudCA9IGZvcm1FbGVtZW50LT50b0lucHV0RWxl bWVudCgpOwo=