111542 2013-03-06 01:14:55 -0800 [BlackBerry] Use the new authenticationChallenge API in WebPage 2013-03-06 11:33:18 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 848606 0 cgarcia 2013-03-06 01:14:55 -0800 It's still using the old API. 848610 1 191682 cgarcia 2013-03-06 01:18:18 -0800 Created attachment 191682 Patch 848775 2 191682 rwlbuis 2013-03-06 06:00:51 -0800 Comment on attachment 191682 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191682&action=review > Source/WebKit/blackberry/Api/WebPage.cpp:2196 > + BlackBerry::Platform::String requestURL(url.string()); Do we need a variable for this as we only use it once? 849094 3 191682 rwlbuis 2013-03-06 11:07:04 -0800 Comment on attachment 191682 Patch Ok. 849131 4 191682 webkit.review.bot 2013-03-06 11:33:15 -0800 Comment on attachment 191682 Patch Clearing flags on attachment: 191682 Committed r144955: <http://trac.webkit.org/changeset/144955> 849132 5 webkit.review.bot 2013-03-06 11:33:18 -0800 All reviewed patches have been landed. Closing bug. 191682 2013-03-06 01:18:18 -0800 2013-03-06 11:33:15 -0800 Patch bb-auth-api.diff text/plain 3338 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGJkOGZlNzAuLjYyODRjOGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTA2ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gVXNlIHRoZSBuZXcgYXV0aGVudGljYXRpb25DaGFsbGVuZ2UgQVBJIGluIFdlYlBh Z2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTU0 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0 aGUgbmV3IEFQSSB0aGF0IGV4cGVjdHMgcmVxdWVzdFVSTCBhbmQgaXNQcm94eSBwYXJhbWV0ZXJz LgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2Vi S2l0OjpXZWJQYWdlUHJpdmF0ZTo6YXV0aGVudGljYXRpb25DaGFsbGVuZ2UpOgorICAgICAgICAq IEFwaS9XZWJQYWdlQ2xpZW50Lmg6CisKIDIwMTMtMDMtMDUgIE90dG8gRGVyZWsgQ2hldW5nICA8 b3RjaGV1bmdAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQXV0aGVudGljYXRpb24g Y3JlZGVudGlhbHMgbG9zdCB3aGVuIG9wZW5pbmcgYSBuZXcgdGFiCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRleCA0ODczNmE0Li4xNmRmZGU3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAgLTIxOTMsNiArMjE5Myw3IEBAIHZv aWQgV2ViUGFnZVByaXZhdGU6OmF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKGNvbnN0IEtVUkwmIHVy bCwgY29uc3QgUHJvdGVjdGlvblNwCiAgICAgQXV0aGVudGljYXRpb25DaGFsbGVuZ2VNYW5hZ2Vy KiBhdXRobWdyID0gQXV0aGVudGljYXRpb25DaGFsbGVuZ2VNYW5hZ2VyOjppbnN0YW5jZSgpOwog ICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcgdXNlcm5hbWU7CiAgICAgQmxhY2tCZXJy eTo6UGxhdGZvcm06OlN0cmluZyBwYXNzd29yZDsKKyAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6 U3RyaW5nIHJlcXVlc3RVUkwodXJsLnN0cmluZygpKTsKIAogI2lmICFkZWZpbmVkKFBVQkxJQ19C VUlMRCkgfHwgIVBVQkxJQ19CVUlMRAogICAgIGlmIChtX2R1bXBSZW5kZXJUcmVlKSB7CkBAIC0y MjEwLDcgKzIyMTEsNyBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjphdXRoZW50aWNhdGlvbkNoYWxs ZW5nZShjb25zdCBLVVJMJiB1cmwsIGNvbnN0IFByb3RlY3Rpb25TcAogICAgICAgICBjcmVkZW50 aWFsTWFuYWdlcigpLmF1dG9maWxsQXV0aGVudGljYXRpb25DaGFsbGVuZ2UocHJvdGVjdGlvblNw YWNlLCB1c2VybmFtZSwgcGFzc3dvcmQpOwogI2VuZGlmCiAKLSAgICBib29sIGlzQ29uZmlybWVk ID0gbV9jbGllbnQtPmF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKHByb3RlY3Rpb25TcGFjZS5yZWFs bSgpLmNoYXJhY3RlcnMoKSwgcHJvdGVjdGlvblNwYWNlLnJlYWxtKCkubGVuZ3RoKCksIHVzZXJu YW1lLCBwYXNzd29yZCk7CisgICAgYm9vbCBpc0NvbmZpcm1lZCA9IG1fY2xpZW50LT5hdXRoZW50 aWNhdGlvbkNoYWxsZW5nZShwcm90ZWN0aW9uU3BhY2UucmVhbG0oKS5jaGFyYWN0ZXJzKCksIHBy b3RlY3Rpb25TcGFjZS5yZWFsbSgpLmxlbmd0aCgpLCB1c2VybmFtZSwgcGFzc3dvcmQsIHJlcXVl c3RVUkwsIHByb3RlY3Rpb25TcGFjZS5pc1Byb3h5KCkpOwogCiAjaWYgRU5BQkxFKEJMQUNLQkVS UllfQ1JFREVOVElBTF9QRVJTSVNUKQogICAgIENyZWRlbnRpYWwgY3JlZGVudGlhbCh1c2VybmFt ZSwgcGFzc3dvcmQsIENyZWRlbnRpYWxQZXJzaXN0ZW5jZVBlcm1hbmVudCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDbGllbnQuaCBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oCmluZGV4IDk4ZTc1YzguLmY1NTNh NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVu dC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNsaWVudC5oCkBA IC0yMDYsNyArMjA2LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBhbmltYXRlVG9TY2Fs ZUFuZERvY3VtZW50U2Nyb2xsUG9zaXRpb24oZG91YmxlIGZpbmFsU2NhbGUsIGNvbnN0IFBsYXRm b3JtOjpGbG9hdFBvaW50JiBmaW5hbERvY3VtZW50U2Nyb2xsUG9zaXRpb24sIGJvb2wgc2hvdWxk Q29uc3RyYWluU2Nyb2xsaW5nVG9Db250ZW50RWRnZSkgPSAwOwogCiAgICAgdmlydHVhbCB2b2lk IHNldFByZXZlbnRzU2NyZWVuSWRsZURpbW1pbmcoYm9vbCBub0RpbW1pbmcpID0gMDsKLSAgICB2 aXJ0dWFsIGJvb2wgYXV0aGVudGljYXRpb25DaGFsbGVuZ2UoY29uc3QgdW5zaWduZWQgc2hvcnQq IHJlYWxtLCB1bnNpZ25lZCByZWFsbUxlbmd0aCwgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0cmlu ZyYgdXNlcm5hbWUsIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcmIHBhc3N3b3JkKSA9IDA7 CisgICAgdmlydHVhbCBib29sIGF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKGNvbnN0IHVuc2lnbmVk IHNob3J0KiByZWFsbSwgdW5zaWduZWQgcmVhbG1MZW5ndGgsIEJsYWNrQmVycnk6OlBsYXRmb3Jt OjpTdHJpbmcmIHVzZXJuYW1lLCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nJiBwYXNzd29y ZCwgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0cmluZyYgcmVxdWVzdFVSTCwgYm9vbCBpc1Byb3h5 KSA9IDA7CiAgICAgdmlydHVhbCBTYXZlQ3JlZGVudGlhbFR5cGUgbm90aWZ5U2hvdWxkU2F2ZUNy ZWRlbnRpYWwoYm9vbCBpc05ldykgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzeW5jUHJveHlDcmVk ZW50aWFsKGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTdHJpbmcmIHVzZXJuYW1lLCBjb25z dCBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U3RyaW5nJiBwYXNzd29yZCkgPSAwOwogICAgIHZpcnR1 YWwgdm9pZCBub3RpZnlQb3B1cEF1dG9maWxsRGlhbG9nKGNvbnN0IHN0ZDo6dmVjdG9yPEJsYWNr QmVycnk6OlBsYXRmb3JtOjpTdHJpbmc+JikgPSAwOwo=