111530 2013-03-05 23:55:46 -0800 [EFL][WK2] Use Vector::reserveInitialCapacity() in WebEventFactory::createWebTouchEvent() 2013-03-06 01:29:54 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez benjamin enmi.lee gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 848521 0 cdumez 2013-03-05 23:55:46 -0800 In WebEventFactory::createWebTouchEvent(), when constructor the vector of touch points, we already know in advance the total number of touch points. Therefore, we should leverage WTF::Vector::reserveCapacity() and WTF::Vector::uncheckedAppend() to save some capacity checks. 848525 1 191662 cdumez 2013-03-05 23:59:48 -0800 Created attachment 191662 Patch 848586 2 191662 benjamin 2013-03-06 00:53:51 -0800 Comment on attachment 191662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191662&action=review Why not... > Source/WebKit2/Shared/efl/WebEventFactory.cpp:225 > + touchPoints.reserveCapacity(eina_list_count(points)); This should be reserveInitialCapacity. 848591 3 191676 cdumez 2013-03-06 00:58:32 -0800 Created attachment 191676 Patch for landing 848622 4 191676 webkit.review.bot 2013-03-06 01:29:50 -0800 Comment on attachment 191676 Patch for landing Clearing flags on attachment: 191676 Committed r144898: <http://trac.webkit.org/changeset/144898> 848623 5 webkit.review.bot 2013-03-06 01:29:54 -0800 All reviewed patches have been landed. Closing bug. 191662 2013-03-05 23:59:48 -0800 2013-03-06 00:58:32 -0800 Patch 111530_createWebTouchEvent.patch text/plain 2572 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNGRkYmExLi43NzczYjRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDMtMDUgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIFtFRkxdW1dLMl0gVXNlIFZlY3Rvcjo6cmVzZXJ2ZUNhcGFjaXR5KCkg aW4gV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJUb3VjaEV2ZW50KCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTUzMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIFdlYkV2ZW50RmFjdG9yeTo6Y3Jl YXRlV2ViVG91Y2hFdmVudCgpLCB3aGVuIGNvbnN0cnVjdGluZyB0aGUgdmVjdG9yIG9mIHRvdWNo IHBvaW50cywKKyAgICAgICAgd2UgYWxyZWFkeSBrbm93IGluIGFkdmFuY2UgdGhlIHRvdGFsIG51 bWJlciBvZiB0b3VjaCBwb2ludHMuIFRoZXJlZm9yZSwgd2Ugc2hvdWxkCisgICAgICAgIGxldmVy YWdlIFdURjo6VmVjdG9yOjpyZXNlcnZlQ2FwYWNpdHkoKSBhbmQgV1RGOjpWZWN0b3I6OnVuY2hl Y2tlZEFwcGVuZCgpIHRvIHNhdmUgc29tZQorICAgICAgICBjYXBhY2l0eSBjaGVja3MuCisKKyAg ICAgICAgKiBTaGFyZWQvZWZsL1dlYkV2ZW50RmFjdG9yeS5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViVG91Y2hFdmVudCk6CisKIDIwMTMtMDMtMDUgIEdl b2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBFYWNoIHdlYiBwcm9j ZXNzIHRydW5jYXRlcyB0aGUgZGlzayBjYWNoZSB0byB6ZXJvIG9uIGxhdW5jaApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL2VmbC9XZWJFdmVudEZhY3RvcnkuY3BwIGIvU291cmNl L1dlYktpdDIvU2hhcmVkL2VmbC9XZWJFdmVudEZhY3RvcnkuY3BwCmluZGV4IGI5OTkyNTAuLjNm ZTVhYzNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvZWZsL1dlYkV2ZW50RmFj dG9yeS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2VmbC9XZWJFdmVudEZhY3Rvcnku Y3BwCkBAIC0yMjIsMTIgKzIyMiwxNCBAQCBzdGF0aWMgaW5saW5lIFdlYkV2ZW50OjpUeXBlIHR5 cGVGb3JUb3VjaEV2ZW50KEV3a19Ub3VjaF9FdmVudF9UeXBlIHR5cGUpCiBXZWJUb3VjaEV2ZW50 IFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViVG91Y2hFdmVudChFd2tfVG91Y2hfRXZlbnRfVHlw ZSB0eXBlLCBjb25zdCBFaW5hX0xpc3QqIHBvaW50cywgY29uc3QgRXZhc19Nb2RpZmllciogbW9k aWZpZXJzLCBjb25zdCBBZmZpbmVUcmFuc2Zvcm0mIHRvV2ViQ29udGVudCwgY29uc3QgQWZmaW5l VHJhbnNmb3JtJiB0b0RldmljZVNjcmVlbiwgZG91YmxlIHRpbWVzdGFtcCkKIHsKICAgICBWZWN0 b3I8V2ViUGxhdGZvcm1Ub3VjaFBvaW50PiB0b3VjaFBvaW50czsKLSAgICBXZWJQbGF0Zm9ybVRv dWNoUG9pbnQ6OlRvdWNoUG9pbnRTdGF0ZSBzdGF0ZTsKKyAgICB0b3VjaFBvaW50cy5yZXNlcnZl Q2FwYWNpdHkoZWluYV9saXN0X2NvdW50KHBvaW50cykpOworCiAgICAgY29uc3QgRWluYV9MaXN0 KiBsaXN0OwogICAgIHZvaWQqIGl0ZW07CiAgICAgRUlOQV9MSVNUX0ZPUkVBQ0gocG9pbnRzLCBs aXN0LCBpdGVtKSB7CiAgICAgICAgIEV3a19Ub3VjaF9Qb2ludCogcG9pbnQgPSBzdGF0aWNfY2Fz dDxFd2tfVG91Y2hfUG9pbnQqPihpdGVtKTsKIAorICAgICAgICBXZWJQbGF0Zm9ybVRvdWNoUG9p bnQ6OlRvdWNoUG9pbnRTdGF0ZSBzdGF0ZTsKICAgICAgICAgc3dpdGNoIChwb2ludC0+c3RhdGUp IHsKICAgICAgICAgY2FzZSBFVkFTX1RPVUNIX1BPSU5UX1VQOgogICAgICAgICAgICAgc3RhdGUg PSBXZWJQbGF0Zm9ybVRvdWNoUG9pbnQ6OlRvdWNoUmVsZWFzZWQ7CkBAIC0yNTAsNyArMjUyLDcg QEAgV2ViVG91Y2hFdmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYlRvdWNoRXZlbnQoRXdr X1RvdWNoX0V2ZW50X1R5cGUgdHlwZSwgY28KICAgICAgICAgfQogCiAgICAgICAgIEludFBvaW50 IHBvcyhwb2ludC0+eCwgcG9pbnQtPnkpOwotICAgICAgICB0b3VjaFBvaW50cy5hcHBlbmQoV2Vi UGxhdGZvcm1Ub3VjaFBvaW50KHBvaW50LT5pZCwgc3RhdGUsIHRvRGV2aWNlU2NyZWVuLm1hcFBv aW50KHBvcyksIHRvV2ViQ29udGVudC5tYXBQb2ludChwb3MpKSk7CisgICAgICAgIHRvdWNoUG9p bnRzLnVuY2hlY2tlZEFwcGVuZChXZWJQbGF0Zm9ybVRvdWNoUG9pbnQocG9pbnQtPmlkLCBzdGF0 ZSwgdG9EZXZpY2VTY3JlZW4ubWFwUG9pbnQocG9zKSwgdG9XZWJDb250ZW50Lm1hcFBvaW50KHBv cykpKTsKICAgICB9CiAKICAgICByZXR1cm4gV2ViVG91Y2hFdmVudCh0eXBlRm9yVG91Y2hFdmVu dCh0eXBlKSwgdG91Y2hQb2ludHMsIG1vZGlmaWVyc0ZvckV2ZW50KG1vZGlmaWVycyksIHRpbWVz dGFtcCk7Cg== 191676 2013-03-06 00:58:32 -0800 2013-03-06 01:29:50 -0800 Patch for landing 111530_createWebTouchEvent.patch text/plain 2594 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNGRkYmExLi44ZWUzZjg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDMtMDUgIENocmlzdG9waGUgRHVtZXogIDxjaC5kdW1lekBzaXNhLnNhbXN1bmcu Y29tPgorCisgICAgICAgIFtFRkxdW1dLMl0gVXNlIFZlY3Rvcjo6cmVzZXJ2ZUluaXRpYWxDYXBh Y2l0eSgpIGluIFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViVG91Y2hFdmVudCgpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE1MzAKKworICAgICAg ICBSZXZpZXdlZCBieSBCZW5qYW1pbiBQb3VsYWluLgorCisgICAgICAgIEluIFdlYkV2ZW50RmFj dG9yeTo6Y3JlYXRlV2ViVG91Y2hFdmVudCgpLCB3aGVuIGNvbnN0cnVjdGluZyB0aGUgdmVjdG9y IG9mIHRvdWNoIHBvaW50cywKKyAgICAgICAgd2UgYWxyZWFkeSBrbm93IGluIGFkdmFuY2UgdGhl IHRvdGFsIG51bWJlciBvZiB0b3VjaCBwb2ludHMuIFRoZXJlZm9yZSwgd2Ugc2hvdWxkCisgICAg ICAgIGxldmVyYWdlIFdURjo6VmVjdG9yOjpyZXNlcnZlSW5pdGlhbENhcGFjaXR5KCkgYW5kIFdU Rjo6VmVjdG9yOjp1bmNoZWNrZWRBcHBlbmQoKSB0byBzYXZlCisgICAgICAgIHNvbWUgY2FwYWNp dHkgY2hlY2tzLgorCisgICAgICAgICogU2hhcmVkL2VmbC9XZWJFdmVudEZhY3RvcnkuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYlRvdWNoRXZlbnQpOgor CiAyMDEzLTAzLTA1ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAg ICAgRWFjaCB3ZWIgcHJvY2VzcyB0cnVuY2F0ZXMgdGhlIGRpc2sgY2FjaGUgdG8gemVybyBvbiBs YXVuY2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvV2ViRXZlbnRGYWN0 b3J5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9lZmwvV2ViRXZlbnRGYWN0b3J5LmNwcApp bmRleCBiOTk5MjUwLi40ZTIxYWU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv ZWZsL1dlYkV2ZW50RmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2VmbC9X ZWJFdmVudEZhY3RvcnkuY3BwCkBAIC0yMjIsMTIgKzIyMiwxNCBAQCBzdGF0aWMgaW5saW5lIFdl YkV2ZW50OjpUeXBlIHR5cGVGb3JUb3VjaEV2ZW50KEV3a19Ub3VjaF9FdmVudF9UeXBlIHR5cGUp CiBXZWJUb3VjaEV2ZW50IFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViVG91Y2hFdmVudChFd2tf VG91Y2hfRXZlbnRfVHlwZSB0eXBlLCBjb25zdCBFaW5hX0xpc3QqIHBvaW50cywgY29uc3QgRXZh c19Nb2RpZmllciogbW9kaWZpZXJzLCBjb25zdCBBZmZpbmVUcmFuc2Zvcm0mIHRvV2ViQ29udGVu dCwgY29uc3QgQWZmaW5lVHJhbnNmb3JtJiB0b0RldmljZVNjcmVlbiwgZG91YmxlIHRpbWVzdGFt cCkKIHsKICAgICBWZWN0b3I8V2ViUGxhdGZvcm1Ub3VjaFBvaW50PiB0b3VjaFBvaW50czsKLSAg ICBXZWJQbGF0Zm9ybVRvdWNoUG9pbnQ6OlRvdWNoUG9pbnRTdGF0ZSBzdGF0ZTsKKyAgICB0b3Vj aFBvaW50cy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KGVpbmFfbGlzdF9jb3VudChwb2ludHMpKTsK KwogICAgIGNvbnN0IEVpbmFfTGlzdCogbGlzdDsKICAgICB2b2lkKiBpdGVtOwogICAgIEVJTkFf TElTVF9GT1JFQUNIKHBvaW50cywgbGlzdCwgaXRlbSkgewogICAgICAgICBFd2tfVG91Y2hfUG9p bnQqIHBvaW50ID0gc3RhdGljX2Nhc3Q8RXdrX1RvdWNoX1BvaW50Kj4oaXRlbSk7CiAKKyAgICAg ICAgV2ViUGxhdGZvcm1Ub3VjaFBvaW50OjpUb3VjaFBvaW50U3RhdGUgc3RhdGU7CiAgICAgICAg IHN3aXRjaCAocG9pbnQtPnN0YXRlKSB7CiAgICAgICAgIGNhc2UgRVZBU19UT1VDSF9QT0lOVF9V UDoKICAgICAgICAgICAgIHN0YXRlID0gV2ViUGxhdGZvcm1Ub3VjaFBvaW50OjpUb3VjaFJlbGVh c2VkOwpAQCAtMjUwLDcgKzI1Miw3IEBAIFdlYlRvdWNoRXZlbnQgV2ViRXZlbnRGYWN0b3J5Ojpj cmVhdGVXZWJUb3VjaEV2ZW50KEV3a19Ub3VjaF9FdmVudF9UeXBlIHR5cGUsIGNvCiAgICAgICAg IH0KIAogICAgICAgICBJbnRQb2ludCBwb3MocG9pbnQtPngsIHBvaW50LT55KTsKLSAgICAgICAg dG91Y2hQb2ludHMuYXBwZW5kKFdlYlBsYXRmb3JtVG91Y2hQb2ludChwb2ludC0+aWQsIHN0YXRl LCB0b0RldmljZVNjcmVlbi5tYXBQb2ludChwb3MpLCB0b1dlYkNvbnRlbnQubWFwUG9pbnQocG9z KSkpOworICAgICAgICB0b3VjaFBvaW50cy51bmNoZWNrZWRBcHBlbmQoV2ViUGxhdGZvcm1Ub3Vj aFBvaW50KHBvaW50LT5pZCwgc3RhdGUsIHRvRGV2aWNlU2NyZWVuLm1hcFBvaW50KHBvcyksIHRv V2ViQ29udGVudC5tYXBQb2ludChwb3MpKSk7CiAgICAgfQogCiAgICAgcmV0dXJuIFdlYlRvdWNo RXZlbnQodHlwZUZvclRvdWNoRXZlbnQodHlwZSksIHRvdWNoUG9pbnRzLCBtb2RpZmllcnNGb3JF dmVudChtb2RpZmllcnMpLCB0aW1lc3RhbXApOwo=