111522 2013-03-05 22:08:38 -0800 Autoreleased cached pages slow down the PLT by 2% 2013-03-15 21:30:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren darin fpizlo simon.fraser oldest_to_newest 848459 0 ggaren 2013-03-05 22:08:38 -0800 Autoreleased cached pages slow down the PLT by 2% 848460 1 191652 ggaren 2013-03-05 22:10:28 -0800 Created attachment 191652 Patch 848490 2 ggaren 2013-03-05 22:55:54 -0800 Committed r144884: <http://trac.webkit.org/changeset/144884> 850159 3 darin 2013-03-07 09:23:30 -0800 What were we getting by autoreleasing? I would trust this patch more if the change log stated what changed between the time we added it and now when we are removing it. 850337 4 ggaren 2013-03-07 11:48:38 -0800 > What were we getting by autoreleasing? Originally, it was a hack to avoid doing any document tear-down while running PLT1. > I would trust this patch more if the change log stated what changed between the time we added it and now when we are removing it. I can't say for sure what changed, but if I had to speculate, I'd say this: (1) Web pages are large enough these days that eagerly reclaiming memory can be a cache locality win. (2) Garbage collection is a more robust way to gain whatever advantage is attributable to lazy tear-down, especially since most pages don't make it into the page cache. (3) PLT3 is a more representative benchmark than PLT1. 856502 5 simon.fraser 2013-03-15 21:30:44 -0700 This caused bug 112205. 191652 2013-03-05 22:10:28 -0800 2013-03-05 22:12:55 -0800 Patch bug-111522-20130305220634.patch text/plain 1139 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDg4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTA1ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgQXV0b3JlbGVhc2VkIGNhY2hl ZCBwYWdlcyBzbG93IGRvd24gdGhlIFBMVCBieSAyJQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTGV0J3Mgc3RvcCBkb2luZyB0aGF0LgorCisgICAgICAg IDIlIFBMVCBzcGVlZHVwLgorCisgICAgICAgICogaGlzdG9yeS9QYWdlQ2FjaGUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UGFnZUNhY2hlOjpyZW1vdmUpOgorCiAyMDEzLTAzLTA1ICBIYXlhdG8g SXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbU2hhZG93XSBJbXBsZW1lbnRz IGV2ZW50IHJlLXRhcmdldGluZyBmb3IgVG91Y2ggRXZlbnRzLgpJbmRleDogU291cmNlL1dlYkNv cmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2hp c3RvcnkvUGFnZUNhY2hlLmNwcAkocmV2aXNpb24gMTQ0ODU5KQorKysgU291cmNlL1dlYkNvcmUv aGlzdG9yeS9QYWdlQ2FjaGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00ODUsNyArNDg1LDcgQEAg dm9pZCBQYWdlQ2FjaGU6OnJlbW92ZShIaXN0b3J5SXRlbSogaXRlbQogICAgIGlmICghaXRlbSB8 fCAhaXRlbS0+bV9jYWNoZWRQYWdlKQogICAgICAgICByZXR1cm47CiAKLSAgICBhdXRvcmVsZWFz ZShpdGVtLT5tX2NhY2hlZFBhZ2UucmVsZWFzZSgpKTsKKyAgICBpdGVtLT5tX2NhY2hlZFBhZ2Uu Y2xlYXIoKTsKICAgICByZW1vdmVGcm9tTFJVTGlzdChpdGVtKTsKICAgICAtLW1fc2l6ZTsKIAo=