111514 2013-03-05 19:51:11 -0800 Layout Test plugins/plugin-clip-subframe.html is failing 2013-03-14 17:41:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 109879 1 hayato jbauman andersca eric jamesr jbauman lforschler rniwa simon.fraser webkit.review.bot oldest_to_newest 848400 0 hayato 2013-03-05 19:51:11 -0800 The following layout test is failing on WebKit Mac and Win. plugins/plugin-clip-subframe.html Dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fplugin-clip-subframe.html Probable cause: I cannot tell a exact revision from the dashboard. The test was introduced 6 days ago in: http://trac.webkit.org/changeset/144236 Plugin in iframe may not display 848408 1 hayato 2013-03-05 20:01:18 -0800 Updated a chromium TestExpectations: http://trac.webkit.org/changeset/144869 webkit.org/b/111514 [ Mac ] plugins/plugin-clip-subframe.html [ Failure ] 850965 2 192170 jbauman 2013-03-08 00:53:28 -0800 Created attachment 192170 Patch 852864 3 eric 2013-03-11 16:41:27 -0700 We should not need to force layouts from JavaScript. If that does de-flake this, then we're missing a layout somewhere! 852875 4 jbauman 2013-03-11 16:48:20 -0700 Ok, I'm not certain this deflakes it on Win7 (dbg)(2) (as I can't reproduce the flakiness myself), but it seemed likely that this would fix the issue. I figured that it's probably doing layout at paint time, and since I'm using setTimeout in the test that means it's not doing a second paint/layout by the time the test finishes. I don't know if there's a better explanation. 855033 5 rniwa 2013-03-14 01:06:48 -0700 *** Bug 112324 has been marked as a duplicate of this bug. *** 855035 6 rniwa 2013-03-14 01:08:10 -0700 I've confirmed that this test change fixes the bug 112324. If this signifies a real bug in WebCore, please file a separate bug and fix it there. It's not acceptable to have a flaky test like this one. 855036 7 rniwa 2013-03-14 01:10:16 -0700 In fact, the bug 112324 might have been the culprit of Mac WK2 EWS being so behind. 855041 8 jbauman 2013-03-14 01:17:36 -0700 Actually, I'm not certain that this patch fixes the type of flakiness found in bug 1123234. Are you sure you weren't just lucky when testing it? I'll make a patch that's certain to fix that flakiness, just in case this one doesn't help. 855046 9 rniwa 2013-03-14 01:21:49 -0700 (In reply to comment #8) > Actually, I'm not certain that this patch fixes the type of flakiness found in bug 1123234. Are you sure you weren't just lucky when testing it? I'll make a patch that's certain to fix that flakiness, just in case this one doesn't help. Yeah. I was seeing the 100% sample failure rate on my MBP with Mac WK2. With this change, its sample failure rate is 0%. 855051 10 192170 webkit.review.bot 2013-03-14 01:41:10 -0700 Comment on attachment 192170 Patch Clearing flags on attachment: 192170 Committed r145794: <http://trac.webkit.org/changeset/145794> 855052 11 webkit.review.bot 2013-03-14 01:41:14 -0700 All reviewed patches have been landed. Closing bug. 855603 12 rniwa 2013-03-14 17:41:03 -0700 You're right. plugins/plugin-clip-subframe.html is still flaky on some bot :( 192170 2013-03-08 00:53:28 -0800 2013-03-14 01:41:10 -0700 Patch bug-111514-20130308004931.patch text/plain 3368 jbauman U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ1MTQ4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjVkZmJkYWJkMjA4NDAxMmUzMTVj NDRjYTI0NjY3OThjOWYzZjhiYi4uYmQxYjVhM2YwMGRmYTEzNzVlZjI1NzZmNzZkNDdiMTc1NzA3 MDhjMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTA4ICBKb2huIEJhdW1hbiAgPGpi YXVtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIExheW91dCBUZXN0IHBsdWdpbnMvcGx1Z2lu LWNsaXAtc3ViZnJhbWUuaHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE1MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZWJhc2VsaW5lIHRlc3QgcmVzdWx0IGR1ZSB0byBjaHJv bWl1bSByMTg1NzI5LiBBbHNvIHRyeSB0byBmb3JjZQorICAgICAgICBsYXlvdXQgaW4gdGVzdCB0 byBwcmV2ZW50IGZsYWtpbmVzcyBvbiB3aW4tZGJnLgorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0tbWFjL3BsdWdpbnMvcGx1Z2luLWNsaXAtc3ViZnJhbWUtZXhwZWN0ZWQudHh0OgorICAg ICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICogcGx1 Z2lucy9wbHVnaW4tY2xpcC1zdWJmcmFtZS5odG1sOgorCiAyMDEzLTAzLTA3ICBGaWxpcCBQaXps byAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgREZHIHNob3VsZCBub3QgZ2V0IGNvcnJ1 cHRlZCBJUiBpbiB0aGUgY2FzZSBvZiBjb2RlIHRoYXQgaXMgZGVhZCwgdW5yZWFjaGFibGUsIGFu ZCBjb250YWlucyBhIGNoYWluIG9mIG5vZGVzIHRoYXQgdXNlIGVhY2ggb3RoZXIgaW4gYW4gdW50 eXBlZCB3YXkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLW1hYy9w bHVnaW5zL3BsdWdpbi1jbGlwLXN1YmZyYW1lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtLW1hYy9wbHVnaW5zL3BsdWdpbi1jbGlwLXN1YmZyYW1lLWV4cGVjdGVk LnR4dAppbmRleCBhYTUyODNiNWM3YWQ1NWFlOGY0YjdkZTRjZTM1YmFjZmEwMTRlMzY4Li4wNjM1 YjgyNmU3ZDIzMjFhN2Q4YTU0YjZhMjViZTg2NTBiYmQyNGM4IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1tYWMvcGx1Z2lucy9wbHVnaW4tY2xpcC1zdWJmcmFtZS1l eHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbWFjL3BsdWdp bnMvcGx1Z2luLWNsaXAtc3ViZnJhbWUtZXhwZWN0ZWQudHh0CkBAIC0xLDIgKzEsMyBAQAotQ09O U09MRSBNRVNTQUdFOiBsaW5lIDM6IE5QUF9TZXRXaW5kb3c6IE5VTEwgd2luZG93LCBSZWN0IHsw LCAwLCAzMDAsIDE1MH0sIENsaXAgUmVjdCB7MCwgMCwgMCwgMH0sIFR5cGUgMgorQ09OU09MRSBN RVNTQUdFOiBsaW5lIDM6IE5QUF9TZXRXaW5kb3c6IE5VTEwgd2luZG93LCBSZWN0IHswLCAwLCAz MDAsIDE1MH0sIENsaXAgUmVjdCB7NjU1MTgsIDY1MzE4LCA2NTUxOCwgNjUzMTh9LCBUeXBlIDIK K0NPTlNPTEUgTUVTU0FHRTogbGluZSAzOiBOUFBfU2V0V2luZG93OiBOVUxMIHdpbmRvdywgUmVj dCB7MCwgMCwgMzAwLCAxNTB9LCBDbGlwIFJlY3QgezAsIDAsIDkwLCAxNTB9LCBUeXBlIDIKIApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9u cyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXgg NmMzNWFmYmVkYjkwYWRiYTRhOWFjMWI4ZjhjNzZmYWM2MmQxOTc1My4uN2I1ZTg5ZWQyODhjNTlh NTQxNGQ4OTljZGQ3N2ExYmViNDRhOWQ4NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCkBAIC00NDU4LDggKzQ0NTgsNiBAQCB3ZWJraXQub3Jn L2IvMTExNDYyIFsgTWFjIF0gZmFzdC9ldmVudHMvdG91Y2gvZ2VzdHVyZS90b3VjaC1nZXN0dXJl LW5vc2Nyb2xsLWJvZAogIyBGYWlsaW5nIHNpbmNlIHIxNDQ2MzMKIHdlYmtpdC5vcmcvYi8xMTE1 MTAgWyBNb3VudGFpbkxpb24gXSBmYXN0L3JlZ2lvbnMvcmVnaW9uLXN0eWxlLWluLWNvbHVtbnMu aHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTExNTE0IFsgTWFjIF0g cGx1Z2lucy9wbHVnaW4tY2xpcC1zdWJmcmFtZS5odG1sIFsgRmFpbHVyZSBdCi0KIHdlYmtpdC5v cmcvYi8xMTE1MjQgWyBEZWJ1ZyBXaW4gTWFjIF0gZmFzdC9kb20vSFRNTERvY3VtZW50L2RvY3Vt ZW50LXNwZWNpYWwtcHJvcGVydGllcy5odG1sIFsgUGFzcyBUaW1lb3V0IF0KIAogd2Via2l0Lm9y Zy9iLzExMTY0MCBbIE1hYyBXaW4gXSBmYXN0L2RvbS9XaW5kb3cvd2luZG93LXNwZWNpYWwtcHJv cGVydGllcy5odG1sIFsgU2xvdyBdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbHVnaW5zL3Bs dWdpbi1jbGlwLXN1YmZyYW1lLmh0bWwgYi9MYXlvdXRUZXN0cy9wbHVnaW5zL3BsdWdpbi1jbGlw LXN1YmZyYW1lLmh0bWwKaW5kZXggNjVhZDQ5YmI2OTBkZDA4NTg1M2Y1Nzk2NzhjMjc1ZTliOGYz MGJkNS4uZjkwMDQ5YmQ1YWQ1Njg4ZjY5YjJkYTZmMzA5MWNlYTczZTA1NjljMiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGx1Z2lucy9wbHVnaW4tY2xpcC1zdWJmcmFtZS5odG1sCisrKyBiL0xh eW91dFRlc3RzL3BsdWdpbnMvcGx1Z2luLWNsaXAtc3ViZnJhbWUuaHRtbApAQCAtNCw2ICs0LDcg QEAKIGZ1bmN0aW9uIHRlc3QoKSB7CiAgICAgLy8gSW5jcmVhc2UgdGhlIHNpemUgb2YgdGhlIGNv bnRhaW5lciBzbyB0aGUgaWZyYW1lIGJlY29tZXMgdmlzaWJsZS4KICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiY29udGFpbmVyIikuc3R5bGUuaGVpZ2h0ID0gIjQwMHB4IjsKKyAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiY29udGFpbmVyIikub2Zmc2V0V2lkdGg7CiAgICAgc2V0VGlt ZW91dChkb25lLCAxMCk7CiB9CiAKQEAgLTE3LDYgKzE4LDcgQEAgZnVuY3Rpb24gZG9uZSgpIHsK IGZ1bmN0aW9uIHJ1blRlc3QoKSB7CiAgICAgaWYgKHRlc3RSdW5uZXIpCiAgICAgICAgIHRlc3RS dW5uZXIud2FpdFVudGlsRG9uZSgpOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb250 YWluZXIiKS5vZmZzZXRXaWR0aDsKICAgICBzZXRUaW1lb3V0KHRlc3QsIDEwKTsKIH0KIDwvc2Ny aXB0Pgo=