111509 2013-03-05 19:07:29 -0800 [chromium] making DumpRenderTree_resources a separate bundle breaks xcode 2013-03-06 12:47:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111508 1 dpranke dpranke jamesr thakis tony webkit.review.bot oldest_to_newest 848370 0 dpranke 2013-03-05 19:07:29 -0800 [chromium] making DumpRenderTree_resources a separate bundle breaks xcode 848371 1 191637 dpranke 2013-03-05 19:08:23 -0800 Created attachment 191637 Patch 848372 2 dpranke 2013-03-05 19:09:14 -0800 Committed r144866: <http://trac.webkit.org/changeset/144866> 848376 3 dpranke 2013-03-05 19:11:45 -0800 See the preceding patch in bug 111504 / r144863 . Nico, what's the right thing to do here? 848383 4 dpranke 2013-03-05 19:27:55 -0800 argh ... I didn't actually comment out the line. Fixing. 848384 5 dpranke 2013-03-05 19:29:24 -0800 Reopening to attach new patch. 848385 6 191639 dpranke 2013-03-05 19:29:25 -0800 Created attachment 191639 Patch 848387 7 dpranke 2013-03-05 19:29:46 -0800 Committed r144867: <http://trac.webkit.org/changeset/144867> 848388 8 dpranke 2013-03-05 19:30:25 -0800 leaving open until nico can weigh in or I revert it (and nico can still weigh in). 848467 9 191639 thakis 2013-03-05 22:14:21 -0800 Comment on attachment 191639 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191639&action=review > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:396 > + # 'process_outputs_as_mac_bundle_resources': 1, If it's not enabled, the repacked resources probably aren't copied into the DumpRenderTree.app bundle, right? On my system: $ find out/Release/DumpRenderTree.app -name '*.pak' out/Release/DumpRenderTree.app/Contents/Resources/DumpRenderTree.pak If you do `rm -rf out/Release/DumpRenderTree.app; ninja -C out/Release DumpRenderTree` and run the above find again, I'm guessing the pak file won't be found any more (which probably means resources won't load). You might not see this immediately if you use ninja because it doesn't remove resource files from produced bundles, but if you blow away the .app before rebuilding it should be just as visible with ninja as it is with xcode. 848994 10 tony 2013-03-06 09:55:00 -0800 I think there are a couple options here. We could either add: ['OS=="mac"', { 'all_dependent_settings': { 'mac_bundle_resources': [ '<(PRODUCT_DIR)/DumpRenderTree.pak' ] } ] Like we have in TestRunner_resources or we could inline DumpRenderTree_resources into the DumpRenderTree target and uncomment the 'process_outputs_as_mac_bundle_resources':1 line. The former might be better so we can fix bug 111508, but I haven't tested it. 849133 11 191802 tony 2013-03-06 11:33:32 -0800 Created attachment 191802 Patch 849138 12 tony 2013-03-06 11:39:48 -0800 Here's my try job: http://build.chromium.org/p/tryserver.chromium/builders/mac_layout_rel/builds/1167 If you click on compile and search for DumpRenderTree.pak, you can see it being copied into DumpRenderTree.app: CpResource ../../../../../xcodebuild/Release/DumpRenderTree.pak ../../../../../xcodebuild/Release/DumpRenderTree.app/Contents/Resources/DumpRenderTree.pak cd /Volumes/data/b/build/slave/mac_layout/build/src/third_party/WebKit/Tools/DumpRenderTree/DumpRenderTree.gyp builtin-copy -exclude .DS_Store -exclude CVS -exclude .svn -exclude .git -exclude .hg -strip-debug-symbols -resolve-src-symlinks /Volumes/data/b/build/slave/mac_layout/build/src/third_party/WebKit/Tools/DumpRenderTree/DumpRenderTree.gyp/../../../../../xcodebuild/Release/DumpRenderTree.pak /Volumes/data/b/build/slave/mac_layout/build/src/third_party/WebKit/Tools/DumpRenderTree/DumpRenderTree.gyp/../../../../../xcodebuild/Release/DumpRenderTree.app/Contents/Resources 849197 13 191802 dpranke 2013-03-06 12:41:05 -0800 Comment on attachment 191802 Patch This seems like the right way to do things. Nice! 849205 14 191802 webkit.review.bot 2013-03-06 12:47:39 -0800 Comment on attachment 191802 Patch Clearing flags on attachment: 191802 Committed r144966: <http://trac.webkit.org/changeset/144966> 849206 15 webkit.review.bot 2013-03-06 12:47:43 -0800 All reviewed patches have been landed. Closing bug. 191637 2013-03-05 19:08:23 -0800 2013-03-05 19:29:23 -0800 Patch bug-111509-20130305190429.patch text/plain 1689 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0ODY1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWIzOWYxOTc4ZGRiN2IyOWFlNGYzNGU5NTBhOTRiNThj NTJmZDI4Ny4uYTQ0ZmI0MGJmMmU4MGY5ZGNjZjAyZmJiODZmMWU5YTc2OTM4ZWU5MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDEzLTAzLTA1ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIFtjaHJvbWl1bV0gbWFraW5nIER1bXBSZW5kZXJUcmVlX3Jlc291cmNlcyBhIHNlcGFy YXRlIGJ1bmRsZSBicmVha3MgeGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMTUwOQorCisgICAgICAgIFVucmV2aWV3ZWQsIGJ1aWxkIGZpeC4K KworICAgICAgICByMTQ0ODYzIGFwcGVhcnMgdG8gaGF2ZSBicm9rZW4gdGhlIHhjb2RlIGJ1aWxk OyBJJ20gdGVtcG9yYXJpbHkKKyAgICAgICAgdHJ5aW5nIHRoaXMgaW5zdGVhZCwgYW5kIGlmIHRo aXMgZG9lc24ndCB3b3JrLCBJJ2xsIHJldmVydCB0aGUKKyAgICAgICAgb3RoZXIgY2hhbmdlcy4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVy VHJlZS5neXA6CisKKzIwMTMtMDMtMDUgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5v cmc+CisKICAgICAgICAgW2Nocm9taXVtXSBidWlsZCBhIER1bXBSZW5kZXJUcmVlLnBhayBldmVu IG9uIHdpbmRvd3MKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMTUwNAogCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVy VHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJl bmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cAppbmRleCBiOWZiZTJhOGJlZDM3NmMyOGM5 NzYyNTRmYTUwMWYxMjVlOTA4ZDI0Li4wNDBmMDhmMmYzZGI4OGUxOWU4Yjg4MTk5NTQ3MGQ5ZDE4 ZTYzNDg1IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5n eXAvRHVtcFJlbmRlclRyZWUuZ3lwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5k ZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAKQEAgLTM5MCw2ICszOTAsOSBAQAogICAgICAg ICAgICAgICAgICAgICAnPChQUk9EVUNUX0RJUikvRHVtcFJlbmRlclRyZWUucGFrJywKICAgICAg ICAgICAgICAgICBdLAogICAgICAgICAgICAgICAgICdhY3Rpb24nOiBbJ3B5dGhvbicsICc8KHJl cGFja19wYXRoKScsICc8QChfb3V0cHV0cyknLCAnPEAocGFrX2lucHV0cyknXSwKKyAgICAgICAg ICAgICAgICAjIEZJWE1FOiBkb2VzIHRoaXMgbmVlZCB0byBiZSBlbmFibGVkPyBJZiBpdCBpcywg eGNvZGUKKyAgICAgICAgICAgICAgICAjIHNlZW1zIHRvIGJyZWFrIHNpbmNlIER1bXBSZW5kZXJU cmVlX3Jlc291cmNlcyBpc24ndCBhY3R1YWxseQorICAgICAgICAgICAgICAgICMgYSBidW5kbGUu CiAgICAgICAgICAgICAgICAgJ3Byb2Nlc3Nfb3V0cHV0c19hc19tYWNfYnVuZGxlX3Jlc291cmNl cyc6IDEsCiAgICAgICAgICAgICB9XSwKICAgICAgICAgfSwK 191639 2013-03-05 19:29:25 -0800 2013-03-06 11:33:31 -0800 Patch bug-111509-20130305192532.patch text/plain 1503 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0ODY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTQ0ZmI0MGJmMmU4MGY5ZGNjZjAyZmJiODZmMWU5YTc2 OTM4ZWU5MS4uZDRkMzBmZTU2Yzc5N2ZiYzA3NjRjNDk2YzI2M2U0YWUyM2FhNTVmMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtNSw2ICs1LDE3 IEBACiAKICAgICAgICAgVW5yZXZpZXdlZCwgYnVpbGQgZml4LgogCisgICAgICAgIEFjdHVhbGx5 IGNvbW1lbnQgb3V0IHRoZSBmbGFnIDooLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVt cFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cDoKKworMjAxMy0wMy0wNSAgRGlyayBQ cmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIG1ha2lu ZyBEdW1wUmVuZGVyVHJlZV9yZXNvdXJjZXMgYSBzZXBhcmF0ZSBidW5kbGUgYnJlYWtzIHhjb2Rl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE1MDkK KworICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCisKICAgICAgICAgcjE0NDg2MyBhcHBl YXJzIHRvIGhhdmUgYnJva2VuIHRoZSB4Y29kZSBidWlsZDsgSSdtIHRlbXBvcmFyaWx5CiAgICAg ICAgIHRyeWluZyB0aGlzIGluc3RlYWQsIGFuZCBpZiB0aGlzIGRvZXNuJ3Qgd29yaywgSSdsbCBy ZXZlcnQgdGhlCiAgICAgICAgIG90aGVyIGNoYW5nZXMuCmRpZmYgLS1naXQgYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cAppbmRl eCAwNDBmMDhmMmYzZGI4OGUxOWU4Yjg4MTk5NTQ3MGQ5ZDE4ZTYzNDg1Li4yNzk2NTExNGE1Zjk4 NGJmMTQ5MmZkN2UwODhjMzE2NzYzMGY5NDU1IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwCisrKyBiL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5neXAKQEAgLTM5 Myw3ICszOTMsNyBAQAogICAgICAgICAgICAgICAgICMgRklYTUU6IGRvZXMgdGhpcyBuZWVkIHRv IGJlIGVuYWJsZWQ/IElmIGl0IGlzLCB4Y29kZQogICAgICAgICAgICAgICAgICMgc2VlbXMgdG8g YnJlYWsgc2luY2UgRHVtcFJlbmRlclRyZWVfcmVzb3VyY2VzIGlzbid0IGFjdHVhbGx5CiAgICAg ICAgICAgICAgICAgIyBhIGJ1bmRsZS4KLSAgICAgICAgICAgICAgICAncHJvY2Vzc19vdXRwdXRz X2FzX21hY19idW5kbGVfcmVzb3VyY2VzJzogMSwKKyAgICAgICAgICAgICAgICAjICdwcm9jZXNz X291dHB1dHNfYXNfbWFjX2J1bmRsZV9yZXNvdXJjZXMnOiAxLAogICAgICAgICAgICAgfV0sCiAg ICAgICAgIH0sCiAgICAgICAgIHsK 191802 2013-03-06 11:33:32 -0800 2013-03-06 12:47:39 -0800 Patch bug-111509-20130306112937.patch text/plain 1938 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTQ0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTBkMDljNjMyNDkwMmIxZmZhOGU0YzgxZjg5NTllYjNi NmVkN2I2YS4uMzY1MTNhNTc0M2YzOTJkNTFkNjdkOTAwYjhlODdhNTA1Y2FjNjVjYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTAzLTA2ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgW2Nocm9taXVtXSBtYWtpbmcgRHVtcFJlbmRlclRyZWVfcmVzb3VyY2VzIGEgc2VwYXJhdGUg YnVuZGxlIGJyZWFrcyB4Y29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTExNTA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIER1bXBSZW5kZXJUcmVlLnBhayB0byBEdW1wUmVuZGVyVHJlZS5hcHAg YWdhaW4uCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVt cFJlbmRlclRyZWUuZ3lwOgorCiAyMDEzLTAzLTA2ICBBbGFuIEN1dHRlciAgPGFsYW5jdXR0ZXJA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIHNoZXJpZmZib3Qgcm9sbC1jaHJvbWl1bS1kZXBzIHNo b3VsZG4ndCBjcmVhdGUgYSBidWcgd2l0aCBOb25lIGFzIHRoZSBuZXcgcmV2aXNpb24uCmRpZmYg LS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRl clRyZWUuZ3lwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBS ZW5kZXJUcmVlLmd5cAppbmRleCA2YTM3MTIyMWYzZDA4YTU4YzkwMTkxMTY1MWYyYzM2NGVmMTU5 MzM0Li42NzVmYThkYTM0OTU0YWU1NGVjODAxNTMzNjBlNzNmNmJlMTA3OTIwIDEwMDY0NAotLS0g YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUu Z3lwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVu ZGVyVHJlZS5neXAKQEAgLTM5MCwxMSArMzkwLDE2IEBACiAgICAgICAgICAgICAgICAgICAgICc8 KFBST0RVQ1RfRElSKS9EdW1wUmVuZGVyVHJlZS5wYWsnLAogICAgICAgICAgICAgICAgIF0sCiAg ICAgICAgICAgICAgICAgJ2FjdGlvbic6IFsncHl0aG9uJywgJzwocmVwYWNrX3BhdGgpJywgJzxA KF9vdXRwdXRzKScsICc8QChwYWtfaW5wdXRzKSddLAotICAgICAgICAgICAgICAgICMgRklYTUU6 IGRvZXMgdGhpcyBuZWVkIHRvIGJlIGVuYWJsZWQ/IElmIGl0IGlzLCB4Y29kZQotICAgICAgICAg ICAgICAgICMgc2VlbXMgdG8gYnJlYWsgc2luY2UgRHVtcFJlbmRlclRyZWVfcmVzb3VyY2VzIGlz bid0IGFjdHVhbGx5Ci0gICAgICAgICAgICAgICAgIyBhIGJ1bmRsZS4KLSAgICAgICAgICAgICAg ICAjICdwcm9jZXNzX291dHB1dHNfYXNfbWFjX2J1bmRsZV9yZXNvdXJjZXMnOiAxLAogICAgICAg ICAgICAgfV0sCisgICAgICAgICAgICAnY29uZGl0aW9ucyc6IFsKKyAgICAgICAgICAgICAgICBb J09TPT0ibWFjIicsIHsKKyAgICAgICAgICAgICAgICAgICAgJ2FsbF9kZXBlbmRlbnRfc2V0dGlu Z3MnOiB7CisgICAgICAgICAgICAgICAgICAgICAgICAnbWFjX2J1bmRsZV9yZXNvdXJjZXMnOiBb CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgJzwoUFJPRFVDVF9ESVIpL0R1bXBSZW5kZXJU cmVlLnBhaycsCisgICAgICAgICAgICAgICAgICAgICAgICBdLAorICAgICAgICAgICAgICAgICAg ICB9LAorICAgICAgICAgICAgICAgIH1dLAorICAgICAgICAgICAgXQogICAgICAgICB9LAogICAg ICAgICB7CiAgICAgICAgICAgICAndGFyZ2V0X25hbWUnOiAnVGVzdE5ldHNjYXBlUGx1Z0luJywK