111508 2013-03-05 18:49:42 -0800 [chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp 2013-03-06 13:14:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111504 111509 1 jamesr jamesr dpranke thakis tony webkit.review.bot oldest_to_newest 848357 0 jamesr 2013-03-05 18:49:42 -0800 [chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp 848362 1 191635 jamesr 2013-03-05 18:55:06 -0800 Created attachment 191635 Patch 848365 2 191635 jamesr 2013-03-05 19:02:25 -0800 Comment on attachment 191635 Patch cq- for now, looks like the patch this depends on (to create DumpRenderTree_resources) is having some trouble with the xcode generator. 848378 3 dpranke 2013-03-05 19:15:46 -0800 (In reply to comment #2) > (From update of attachment 191635 [details]) > cq- for now, looks like the patch this depends on (to create DumpRenderTree_resources) is having some trouble with the xcode generator. Yeah, it looks like putting the resources in a separate target may or may not work correctly w/ xcode. Let's wait and see what nico says about this. 849213 4 191635 dpranke 2013-03-06 12:55:35 -0800 Comment on attachment 191635 Patch I think this should be fine w/ Tony's approach in bug 11509. 849232 5 191635 webkit.review.bot 2013-03-06 13:14:08 -0800 Comment on attachment 191635 Patch Clearing flags on attachment: 191635 Committed r144970: <http://trac.webkit.org/changeset/144970> 849233 6 webkit.review.bot 2013-03-06 13:14:11 -0800 All reviewed patches have been landed. Closing bug. 191635 2013-03-05 18:55:06 -0800 2013-03-06 13:14:08 -0800 Patch bug-111508-20130305185112.patch text/plain 2897 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0ODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQ4OGUwNDMwOTEzNTQ1NTA0MjIyMzYyOTJlNzZlOTFlNGJmMThiNGIuLjIwYTFmZjg5M2MxOTI3 MzY4MTAxMGExNmYwOWYyYTE3YWRhYjQ1NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTMtMDMtMDUgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEV4cHJlc3Mgd2Via2l0X3VuaXRfdGVzdHMn IGRlcGVuZGVuY3kgb24gRHVtcFJlbmRlclRyZWUucGFrIGluIGd5cAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNTA4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU29tZSB0ZXN0cyBpbiB3ZWJraXRfdW5p dF90ZXN0cywgZm9yIGV4YW1wbGUgV2ViUGFnZVNlcmlhbGl6ZXJUZXN0LkhUTUxOb2RlcywgZGVw ZW5kIG9uIGxvY2FsaXphYmxlIHJlc291cmNlcworICAgICAgICBmcm9tIGEgcGFrIGZpbGUuIFNp bmNlIHVuaXQgdGVzdHMgaW5pdGlhbGl6ZSBmb3IgdGVzdGluZyB3aXRoIHRoZSBzYW1lIHdlYmtp dF9zdXBwb3J0IGZ1bmN0aW9ucyBhcyBsYXlvdXQgdGVzdHMKKyAgICAgICAgdGhleSBlbmQgdXAg dXNpbmcgRHVtcFJlbmRlclRyZWUucGFrLCBidXQgdGhpcyBkZXBlbmRlbmN5IGlzbid0IGxpc3Rl ZCBleHBsaWNpdGx5IGluIHRoZSBneXAgc28gaWYgeW91IG1hbmFnZSB0bworICAgICAgICBydW4g d2Via2l0X3VuaXRfdGVzdHMgd2l0aG91dCBidWlsZGluZyBEdW1wUmVuZGVyVHJlZSBmaXJzdCB0 aGVzZSB0ZXN0cyBqdXN0IGNyYXNoLgorCisgICAgICAgIFRoaXMgYWRkcyBhIGRlcGVuZGVuY3kg ZnJvbSB3ZWJraXRfdW5pdF90ZXN0cyB0byBEdW1wUmVuZGVyVHJlZV9yZXNvdXJjZXMgc28gdGhl IHBhayBpcyBhbHdheXMgYnVpbHQuIEl0J3MgYSBiaXQKKyAgICAgICAgd2VpcmQgZm9yIGEgZ3lw IGZpbGUgaW4gU291cmNlL1dlYktpdC9jaHJvbWl1bS8gdG8gcmVhY2ggaW50byBUb29scy9EdW1w UmVuZGVyVHJlZSwgYnV0IEkgY2FuJ3QgdGhpbmsgb2YKKyAgICAgICAgYW55dGhpbmcgYmV0dGVy LgorCisgICAgICAgICogV2ViS2l0VW5pdFRlc3RzLmd5cDoKKwogMjAxMy0wMy0wNSAgQWxleGFu ZHJlIEVsaWFzICA8YWVsaWFzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFNj cm9sbCBkZWx0YXMgc2hvdWxkIGJlIGZsb2F0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJL aXRVbml0VGVzdHMuZ3lwCmluZGV4IDMxZWE3NTQ1YmNlNWM3NmU0NTY4OGFiMDA0NjQxZmM5MzA4 MWEyODIuLjg0ZjVkNDE2MGZkMGY1ODE0YWRmODNmMGI1YTNhMWJlOTE1NWFjN2MgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0VW5pdFRlc3RzLmd5cAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVuaXRUZXN0cy5neXAKQEAgLTU1LDE0ICs1NSwxNSBA QAogICAgICAgICAgICAgJ21zdnNfZ3VpZCc6ICc3Q0VGRTgwMC04NDAzLTQxOEEtQUQ2QS0yRDUy QzZGQzNFQUQnLAogICAgICAgICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKICAgICAgICAgICAgICAg ICAnV2ViS2l0Lmd5cDp3ZWJraXQnLAotICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19k aXIpL2J1aWxkL3RlbXBfZ3lwL2dvb2dsZXVybC5neXA6Z29vZ2xldXJsJywKLSAgICAgICAgICAg ICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS92OC90b29scy9neXAvdjguZ3lwOnY4JywKLSAgICAg ICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90ZXN0aW5nL2d0ZXN0Lmd5cDpndGVzdCcs Ci0gICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGVzdGluZy9nbW9jay5neXA6 Z21vY2snLAorICAgICAgICAgICAgICAgICcuLi8uLi8uLi9Ub29scy9EdW1wUmVuZGVyVHJlZS9E dW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lwOkR1bXBSZW5kZXJUcmVlX3Jlc291 cmNlcycsCiAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvYmFzZS9iYXNlLmd5 cDpiYXNlJywKICAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9iYXNlL2Jhc2Uu Z3lwOmJhc2VfaTE4bicsCiAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvYmFz ZS9iYXNlLmd5cDp0ZXN0X3N1cHBvcnRfYmFzZScsCisgICAgICAgICAgICAgICAgJzwoY2hyb21p dW1fc3JjX2RpcikvYnVpbGQvdGVtcF9neXAvZ29vZ2xldXJsLmd5cDpnb29nbGV1cmwnLAorICAg ICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3Rlc3RpbmcvZ21vY2suZ3lwOmdtb2Nr JywKKyAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90ZXN0aW5nL2d0ZXN0Lmd5 cDpndGVzdCcsCiAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFy dHkvemxpYi96bGliLmd5cDp6bGliJywKKyAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNf ZGlyKS92OC90b29scy9neXAvdjguZ3lwOnY4JywKICAgICAgICAgICAgICAgICAnPChjaHJvbWl1 bV9zcmNfZGlyKS93ZWJraXQvc3VwcG9ydC93ZWJraXRfc3VwcG9ydC5neXA6d2Via2l0X3N1cHBv cnQnLAogICAgICAgICAgICAgXSwKICAgICAgICAgICAgICdzb3VyY2VzJzogWwo=