111504 2013-03-05 17:44:43 -0800 build a DumpRenderTree.pak even on windows 2013-03-05 22:19:21 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111508 1 dpranke dpranke jamesr jochen thakis tony oldest_to_newest 848313 0 dpranke 2013-03-05 17:44:43 -0800 build a DumpRenderTree.pak even on windows 848315 1 191620 dpranke 2013-03-05 17:48:35 -0800 Created attachment 191620 Patch 848317 2 191620 dpranke 2013-03-05 17:49:52 -0800 Comment on attachment 191620 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191620&action=review > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:-345 > - }], I don't know why we were previously building the .pak file in <(INTERMEDIATE_DIR) and then copying it into <(PRODUCT_DIR). Is there a reason not to just build it into <(PRODUCT_DIR) by default? 848333 3 191620 tony 2013-03-05 18:12:53 -0800 Comment on attachment 191620 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191620&action=review >> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:-345 >> - }], > > I don't know why we were previously building the .pak file in <(INTERMEDIATE_DIR) and then copying it into <(PRODUCT_DIR). Is there a reason not to just build it into <(PRODUCT_DIR) by default? Not sure, but it seems fine to write the final result to <(PRODUCT_DIR). 848350 4 191620 dpranke 2013-03-05 18:39:14 -0800 Comment on attachment 191620 Patch Clearing flags on attachment: 191620 Committed r144863: <http://trac.webkit.org/changeset/144863> 848351 5 dpranke 2013-03-05 18:39:16 -0800 All reviewed patches have been landed. Closing bug. 848367 6 dpranke 2013-03-05 19:05:19 -0800 hm, this appears to break xcode ... making DumpRenderTree_resources be a separate target and still having process_outputs_as_mac_bundle_resources set to true doesn't look like it works right (since DumpRenderTree_resources isn't actually a bundle). Temporarily, I'm going to set that flag off, and we'll see what else breaks. 848374 7 dpranke 2013-03-05 19:10:18 -0800 Okay, I've attempted to patch this in bug 111506 / r144866 . It looks like that might work, but I have to wait for the xcode builders to cycle to be sure, and even then I'm not sure if this is the right fix. 848375 8 dpranke 2013-03-05 19:10:55 -0800 Er, that's bug 111509, not bug 111506. 848468 9 thakis 2013-03-05 22:15:35 -0800 (In reply to comment #7) > Okay, I've attempted to patch this in bug 111506 / r144866 . It looks like that might work, but I have to wait for the xcode builders to cycle to be sure, and even then I'm not sure if this is the right fix. It fairly likely isn't. I commented on bug 111509. 848472 10 191620 thakis 2013-03-05 22:19:21 -0800 Comment on attachment 191620 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191620&action=review > Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:235 > + 'DumpRenderTree_resources', What you can do to fix the problem I described in the other bug: Add `'mac_bundle_resources': [ '<(PRODUCT_DIR)/DumpRenderTree.pak' ]` to this target, and remove process_outputs_as_mac_bundle_resources from your drt_resources target. (If this target here already has a mac_bundle_resources section, add the pak file to that.) With that, everything should work. >>> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:-345 >>> - }], >> >> I don't know why we were previously building the .pak file in <(INTERMEDIATE_DIR) and then copying it into <(PRODUCT_DIR). Is there a reason not to just build it into <(PRODUCT_DIR) by default? > > Not sure, but it seems fine to write the final result to <(PRODUCT_DIR). Maybe repack.py doesn't write the output file atomically? 191620 2013-03-05 17:48:35 -0800 2013-03-05 22:19:21 -0800 Patch bug-111504-20130305174441.patch text/plain 6714 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0ODEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTZhNWQ2ZjY5NzUwNjU2MTRlMjU4MDUzYWVjNWNiOWE1 M2FhMzAzNy4uZTY3NDkxYjgwNDBlNGY3NjJhOTUzZTYyNjE2OTk1OWM3Y2EwOTM2OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0 IEBACiAyMDEzLTAzLTA1ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIFtjaHJvbWl1bV0gYnVpbGQgYSBEdW1wUmVuZGVyVHJlZS5wYWsgZXZlbiBvbiB3aW5k b3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE1 MDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg Q2hyb21pdW0gQXVyYSBidWlsZCB1c2VzIHRoZSBkZWZhdWx0IHRoZW1lIHRvIGRyYXcKKyAgICAg ICAgY29udHJvbHMsIGFuZCB0aGF0IHRoZW1lIHJlcXVpcmVzIHRoZSB1aSBSZXNvdXJjZUJ1bmRs ZQorICAgICAgICB0byBiZSBpbml0aWFsaXplZC4gT24gZXZlcnkgb3RoZXIgcGxhdGZvcm0sIHdl IGJ1aWxkCisgICAgICAgIGEgRHVtcFJlbmRlclRyZWUucGFrIHRoYXQgd29ya3MgZm9yIHRoaXMs IGJ1dCBvbiBXaW5kb3dzIHdlCisgICAgICAgIHN0aWxsIGNvbXBpbGUgdGhlIHJlc291cmNlcyBk aXJlY3RseSBpbnRvIERSVC4gQXMgYSBmaXJzdCBzdGVwLAorICAgICAgICBsZXQncyBidWlsZCB0 aGUgcGFrIGZpbGUuIEkgd2lsbCB0aGVuIG5lZWQgdG8gbGFuZCBhIHBhdGNoCisgICAgICAgIGlu IENocm9taXVtIHRvIGFjdHVhbGx5IGxvYWQgaXQuIFRoZW4gSSBjYW4gZ28gYmFjayBhbmQgbW92 ZQorICAgICAgICB0aGUgcmVzb3VyY2VzIG92ZXIgdG8ganVzdCB1c2UgdGhlIC5wYWsgZmlsZSBh bmQgbm8gbG9uZ2VyIG5lZWQKKyAgICAgICAgdGhlIC5yYydzLgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cDoKKworMjAxMy0w My0wNSAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBbY2hy b21pdW1dIERSVCBjcmFzaGVzIGluIGFuIEF1cmEvV2luIGJ1aWxkCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTEzOTQKIApkaWZmIC0tZ2l0IGEvVG9v bHMvRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cCBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZS5n eXAKaW5kZXggODkxNDE3ZTM1ZDg3MDQ2YmJhMTNjY2ZjMTMyYTIzZmExNjdkOTY4Zi4uYjlmYmUy YThiZWQzNzZjMjhjOTc2MjU0ZmE1MDFmMTI1ZTkwOGQyNCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVt cFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cAorKysgYi9U b29scy9EdW1wUmVuZGVyVHJlZS9EdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuZ3lw CkBAIC0yMzIsNiArMjMyLDcgQEAKICAgICAgICAgICAgICdtYWNfYnVuZGxlJzogMSwKICAgICAg ICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCiAgICAgICAgICAgICAgICAgJ1Rlc3RSdW5uZXInLAor ICAgICAgICAgICAgICAgICdEdW1wUmVuZGVyVHJlZV9yZXNvdXJjZXMnLAogICAgICAgICAgICAg ICAgICc8KHNvdXJjZV9kaXIpL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwOmluc3BlY3Rvcl9y ZXNvdXJjZXMnLAogICAgICAgICAgICAgICAgICc8KHNvdXJjZV9kaXIpL1dlYktpdC9jaHJvbWl1 bS9XZWJLaXQuZ3lwOndlYmtpdCcsCiAgICAgICAgICAgICAgICAgJzwoc291cmNlX2RpcikvV2Vi S2l0L2Nocm9taXVtL1dlYktpdC5neXA6d2Via2l0X3d0Zl9zdXBwb3J0JywKQEAgLTI3Miw2ICsy NzMsNyBAQAogICAgICAgICAgICAgICAgICAgICBdLAogICAgICAgICAgICAgICAgICAgICAncmVz b3VyY2VfaW5jbHVkZV9kaXJzJzogWyc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQn XSwKICAgICAgICAgICAgICAgICAgICAgJ3NvdXJjZXMnOiBbCisgICAgICAgICAgICAgICAgICAg ICAgICAjIEZJWE1FOiBXZSBzaG91bGQganVzdCB1c2UgdGhlIHJlc291cmNlcyBpbiB0aGUgLnBh ayBmaWxlLgogICAgICAgICAgICAgICAgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9E SVIpL25ldC9uZXRfcmVzb3VyY2VzLnJjJywKICAgICAgICAgICAgICAgICAgICAgICAgICc8KFNI QVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvd2Via2l0X2Nocm9taXVtX3Jlc291cmNlcy5y YycsCiAgICAgICAgICAgICAgICAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikv d2Via2l0L3dlYmtpdF9yZXNvdXJjZXMucmMnLApAQCAtMjk0LDI5ICsyOTYsNiBAQAogICAgICAg ICAgICAgICAgICAgICAnc291cmNlcy8nOiBbCiAgICAgICAgICAgICAgICAgICAgICAgICBbJ2V4 Y2x1ZGUnLCAnV2luXFwuY3BwJCddLAogICAgICAgICAgICAgICAgICAgICBdLAotICAgICAgICAg ICAgICAgICAgICAnYWN0aW9ucyc6IFsKLSAgICAgICAgICAgICAgICAgICAgICAgIHsKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnYWN0aW9uX25hbWUnOiAncmVwYWNrX2xvY2FsZScsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3ZhcmlhYmxlcyc6IHsKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJ3JlcGFja19wYXRoJzogJzwoY2hyb21pdW1fc3JjX2RpcikvdG9v bHMvZ3JpdC9ncml0L2Zvcm1hdC9yZXBhY2sucHknLAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAncGFrX2lucHV0cyc6IFsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS9uZXQvbmV0X3Jlc291cmNlcy5wYWsnLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFU RV9ESVIpL3VpL2dmeC9nZnhfcmVzb3VyY2VzLnBhaycsCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L3dlYmtpdF9j aHJvbWl1bV9yZXNvdXJjZXMucGFrJywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvd2Via2l0X3N0cmluZ3NfZW4t VVMucGFrJywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICc8KFNIQVJFRF9J TlRFUk1FRElBVEVfRElSKS93ZWJraXQvd2Via2l0X3Jlc291cmNlc18xMDBfcGVyY2VudC5wYWsn LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIF19LAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICdpbnB1dHMnOiBbCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICc8KHJl cGFja19wYXRoKScsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICc8QChwYWtfaW5w dXRzKScsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgXSwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAnb3V0cHV0cyc6IFsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg JzwoSU5URVJNRURJQVRFX0RJUikvcmVwYWNrL0R1bXBSZW5kZXJUcmVlLnBhaycsCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgXSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAnYWN0 aW9uJzogWydweXRob24nLCAnPChyZXBhY2tfcGF0aCknLCAnPEAoX291dHB1dHMpJywgJzxAKHBh a19pbnB1dHMpJ10sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3Byb2Nlc3Nfb3V0cHV0 c19hc19tYWNfYnVuZGxlX3Jlc291cmNlcyc6IDEsCi0gICAgICAgICAgICAgICAgICAgICAgICB9 LAotICAgICAgICAgICAgICAgICAgICBdLCAjIGFjdGlvbnMKICAgICAgICAgICAgICAgICB9XSwK ICAgICAgICAgICAgICAgICBbJ09TPT0ibWFjIicsIHsKICAgICAgICAgICAgICAgICAgICAgJ2Rl cGVuZGVuY2llcyc6IFsKQEAgLTMzNywxMiArMzE2LDYgQEAKICAgICAgICAgICAgICAgICAgICAg J2RlcGVuZGVuY2llcyc6IFsKICAgICAgICAgICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3Ny Y19kaXIpL2J1aWxkL2xpbnV4L3N5c3RlbS5neXA6Zm9udGNvbmZpZycsCiAgICAgICAgICAgICAg ICAgICAgIF0sCi0gICAgICAgICAgICAgICAgICAgICdjb3BpZXMnOiBbewotICAgICAgICAgICAg ICAgICAgICAgICAgJ2Rlc3RpbmF0aW9uJzogJzwoUFJPRFVDVF9ESVIpJywKLSAgICAgICAgICAg ICAgICAgICAgICAgICdmaWxlcyc6IFsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAnPChJ TlRFUk1FRElBVEVfRElSKS9yZXBhY2svRHVtcFJlbmRlclRyZWUucGFrJywKLSAgICAgICAgICAg ICAgICAgICAgICAgIF0KLSAgICAgICAgICAgICAgICAgICAgfV0sCiAgICAgICAgICAgICAgICAg ICAgICd2YXJpYWJsZXMnOiB7CiAgICAgICAgICAgICAgICAgICAgICAgICAjIEZJWE1FOiBFbmFi bGUgd2FybmluZ3Mgb24gb3RoZXIgcGxhdGZvcm1zLgogICAgICAgICAgICAgICAgICAgICAgICAg J2Nocm9taXVtX2NvZGUnOiAxLApAQCAtMzc4LDEyICszNTEsNiBAQAogICAgICAgICAgICAgICAg ICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvdG9vbHMvYW5kcm9pZC9mb3J3YXJkZXIvZm9y d2FyZGVyLmd5cDpmb3J3YXJkZXInLAogICAgICAgICAgICAgICAgICAgICAgICAgJzwoY2hyb21p dW1fc3JjX2RpcikvdG9vbHMvYW5kcm9pZC9tZDVzdW0vbWQ1c3VtLmd5cDptZDVzdW0nLAogICAg ICAgICAgICAgICAgICAgICBdLAotICAgICAgICAgICAgICAgICAgICAnY29waWVzJzogW3sKLSAg ICAgICAgICAgICAgICAgICAgICAgICdkZXN0aW5hdGlvbic6ICc8KFBST0RVQ1RfRElSKScsCi0g ICAgICAgICAgICAgICAgICAgICAgICAnZmlsZXMnOiBbCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgJzwoSU5URVJNRURJQVRFX0RJUikvcmVwYWNrL0R1bXBSZW5kZXJUcmVlLnBhaycsCi0g ICAgICAgICAgICAgICAgICAgICAgICBdCi0gICAgICAgICAgICAgICAgICAgIH1dLAogICAgICAg ICAgICAgICAgIH0sIHsgIyBPUyE9ImFuZHJvaWQiCiAgICAgICAgICAgICAgICAgICAgICdzb3Vy Y2VzLyc6IFsKICAgICAgICAgICAgICAgICAgICAgICAgIFsnZXhjbHVkZScsICdBbmRyb2lkXFwu Y3BwJCddLApAQCAtNDAyLDYgKzM2OSwzMSBAQAogICAgICAgICAgICAgXSwKICAgICAgICAgfSwK ICAgICAgICAgeworICAgICAgICAgICAgJ3RhcmdldF9uYW1lJzogJ0R1bXBSZW5kZXJUcmVlX3Jl c291cmNlcycsCisgICAgICAgICAgICAndHlwZSc6ICdub25lJywKKyAgICAgICAgICAgICdhY3Rp b25zJzogW3sKKyAgICAgICAgICAgICAgICAnYWN0aW9uX25hbWUnOiAncmVwYWNrX2xvY2FsJywK KyAgICAgICAgICAgICAgICAndmFyaWFibGVzJzogeworICAgICAgICAgICAgICAgICAgICAncmVw YWNrX3BhdGgnOiAnPChjaHJvbWl1bV9zcmNfZGlyKS90b29scy9ncml0L2dyaXQvZm9ybWF0L3Jl cGFjay5weScsCisgICAgICAgICAgICAgICAgICAgICdwYWtfaW5wdXRzJzogWworICAgICAgICAg ICAgICAgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL25ldC9uZXRfcmVzb3Vy Y2VzLnBhaycsCisgICAgICAgICAgICAgICAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRF X0RJUikvdWkvZ2Z4L2dmeF9yZXNvdXJjZXMucGFrJywKKyAgICAgICAgICAgICAgICAgICAgICAg ICc8KFNIQVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvd2Via2l0X2Nocm9taXVtX3Jlc291 cmNlcy5wYWsnLAorICAgICAgICAgICAgICAgICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFU RV9ESVIpL3dlYmtpdC93ZWJraXRfc3RyaW5nc19lbi1VUy5wYWsnLAorICAgICAgICAgICAgICAg ICAgICAgICAgJzwoU0hBUkVEX0lOVEVSTUVESUFURV9ESVIpL3dlYmtpdC93ZWJraXRfcmVzb3Vy Y2VzXzEwMF9wZXJjZW50LnBhaycsCisgICAgICAgICAgICAgICAgXX0sCisgICAgICAgICAgICAg ICAgJ2lucHV0cyc6IFsKKyAgICAgICAgICAgICAgICAgICAgJzwocmVwYWNrX3BhdGgpJywKKyAg ICAgICAgICAgICAgICAgICAgJzxAKHBha19pbnB1dHMpJywKKyAgICAgICAgICAgICAgICBdLAor ICAgICAgICAgICAgICAgICdvdXRwdXRzJzogWworICAgICAgICAgICAgICAgICAgICAnPChQUk9E VUNUX0RJUikvRHVtcFJlbmRlclRyZWUucGFrJywKKyAgICAgICAgICAgICAgICBdLAorICAgICAg ICAgICAgICAgICdhY3Rpb24nOiBbJ3B5dGhvbicsICc8KHJlcGFja19wYXRoKScsICc8QChfb3V0 cHV0cyknLCAnPEAocGFrX2lucHV0cyknXSwKKyAgICAgICAgICAgICAgICAncHJvY2Vzc19vdXRw dXRzX2FzX21hY19idW5kbGVfcmVzb3VyY2VzJzogMSwKKyAgICAgICAgICAgIH1dLAorICAgICAg ICB9LAorICAgICAgICB7CiAgICAgICAgICAgICAndGFyZ2V0X25hbWUnOiAnVGVzdE5ldHNjYXBl UGx1Z0luJywKICAgICAgICAgICAgICd0eXBlJzogJ2xvYWRhYmxlX21vZHVsZScsCiAgICAgICAg ICAgICAnc291cmNlcyc6IFsgJzxAKHRlc3RfcGx1Z2luX2ZpbGVzKScgXSwK