111499 2013-03-05 17:00:55 -0800 [chromium] Remove WebView's sharedGraphicsContext3D method. 2013-03-07 10:00:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj abarth backer dglazkov fishd jamesr piman tkent+wkapi webkit.review.bot oldest_to_newest 848264 0 danakj 2013-03-05 17:00:55 -0800 [chromium] Remove WebView's sharedGraphicsContext3D method. 848265 1 191605 danakj 2013-03-05 17:01:11 -0800 Created attachment 191605 Patch 848266 2 danakj 2013-03-05 17:01:47 -0800 This depends on https://codereview.chromium.org/12506003/ on the chromium side which needs to land still. But once it does, we can remove this method. 848269 3 webkit.review.bot 2013-03-05 17:04:02 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 848271 4 191605 jamesr 2013-03-05 17:04:28 -0800 Comment on attachment 191605 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191605&action=review > Source/WebKit/chromium/public/WebView.h:-469 > // GPU acceleration support -------------------------------------------- > > - // Context that's in the compositor's share group, but is not the compositor context itself. > - // Can be used for allocating resources that the compositor will later access. > - virtual WebGraphicsContext3D* sharedGraphicsContext3D() = 0; > - You can delete the "GPU acceleration support" comment too since nothing below here has to do with GPU stuff, really 848273 5 191607 danakj 2013-03-05 17:07:05 -0800 Created attachment 191607 Patch Thanks! Done. 850196 6 191607 webkit.review.bot 2013-03-07 10:00:44 -0800 Comment on attachment 191607 Patch Clearing flags on attachment: 191607 Committed r145091: <http://trac.webkit.org/changeset/145091> 850197 7 webkit.review.bot 2013-03-07 10:00:51 -0800 All reviewed patches have been landed. Closing bug. 191605 2013-03-05 17:01:11 -0800 2013-03-05 17:07:01 -0800 Patch bug-111499-20130305195717.patch text/plain 3206 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBhYjY5ODFkY2E1NjhiYWJkNjhmYjQxNjVhNGI3OTViZjgxODQ3YzEuLjFkMWNjZWZiYmVmOGRj MjM1NDU4OTBiYTQ0NjY5YmMwZGU1MmQ5MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTMtMDMtMDUgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBSZW1vdmUgV2ViVmlldydzIHNoYXJlZEdyYXBo aWNzQ29udGV4dDNEIG1ldGhvZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcHVibGljL1dlYlZpZXcuaDoKKyAgICAgICAgKFdlYlZpZXcpOgorICAg ICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmg6 CisgICAgICAgIChXZWJWaWV3SW1wbCk6CisKIDIwMTMtMDMtMDUgIEphbWVzIFJvYmluc29uICA8 amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIENsZWFuIHVwIFdlYldp ZGdldCAvIFdlYkxheWVyVHJlZVZpZXcgaW50ZXJhY3Rpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJWaWV3LmgKaW5kZXggNjRkZmExYjE0ZWMxMTFmNzEwYWMzMDRiODVjNWNkYzY0 NmI4YzZmOC4uYjJjNDc4ZDg0NmZiMjM5ODdjMmJiYWU0NjMwMWRkN2UxYTY1ZGZkYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaApAQCAtNDYzLDEwICs0NjMsNiBAQCBw dWJsaWM6CiAKICAgICAvLyBHUFUgYWNjZWxlcmF0aW9uIHN1cHBvcnQgLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAotICAgIC8vIENvbnRleHQgdGhhdCdzIGlu IHRoZSBjb21wb3NpdG9yJ3Mgc2hhcmUgZ3JvdXAsIGJ1dCBpcyBub3QgdGhlIGNvbXBvc2l0b3Ig Y29udGV4dCBpdHNlbGYuCi0gICAgLy8gQ2FuIGJlIHVzZWQgZm9yIGFsbG9jYXRpbmcgcmVzb3Vy Y2VzIHRoYXQgdGhlIGNvbXBvc2l0b3Igd2lsbCBsYXRlciBhY2Nlc3MuCi0gICAgdmlydHVhbCBX ZWJHcmFwaGljc0NvbnRleHQzRCogc2hhcmVkR3JhcGhpY3NDb250ZXh0M0QoKSA9IDA7Ci0KICAg ICAvLyBDYWxsZWQgdG8gaW5mb3JtIHRoZSBXZWJWaWV3IHRoYXQgYSB3aGVlbCBmbGluZyBhbmlt YXRpb24gd2FzIHN0YXJ0ZWQgZXh0ZXJuYWxseSAoZm9yIGluc3RhbmNlCiAgICAgLy8gYnkgdGhl IGNvbXBvc2l0b3IpIGJ1dCBtdXN0IGJlIGNvbXBsZXRlZCBieSB0aGUgV2ViVmlldy4KICAgICB2 aXJ0dWFsIHZvaWQgdHJhbnNmZXJBY3RpdmVXaGVlbEZsaW5nQW5pbWF0aW9uKGNvbnN0IFdlYkFj dGl2ZVdoZWVsRmxpbmdQYXJhbWV0ZXJzJikgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IGFjYjA2MjZjZWNjYzVhYzg1NjBmNmQ2MDUwNjNkMjFl ZGEzM2U4ZmUuLmI4NTZlOGFhZTE2YmRmOTIwYzI0Y2ZjMDNhYmU0NDk2NmU3MmRmZjMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTQyNDUsMTQgKzQy NDUsNiBAQCB2b2lkIFdlYlZpZXdJbXBsOjp1cGRhdGVMYXllclRyZWVWaWV3cG9ydCgpCiAgICAg bV9sYXllclRyZWVWaWV3LT5zZXRQYWdlU2NhbGVGYWN0b3JBbmRMaW1pdHMocGFnZVNjYWxlRmFj dG9yKCksIG1fbWluaW11bVBhZ2VTY2FsZUZhY3RvciwgbV9tYXhpbXVtUGFnZVNjYWxlRmFjdG9y KTsKIH0KIAotV2ViR3JhcGhpY3NDb250ZXh0M0QqIFdlYlZpZXdJbXBsOjpzaGFyZWRHcmFwaGlj c0NvbnRleHQzRCgpCi17Ci0gICAgaWYgKCFtX3BhZ2UtPnNldHRpbmdzKCktPmFjY2VsZXJhdGVk Q29tcG9zaXRpbmdFbmFibGVkKCkgfHwgIWFsbG93c0FjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSkK LSAgICAgICAgcmV0dXJuIDA7Ci0KLSAgICByZXR1cm4gR3JhcGhpY3NDb250ZXh0M0RQcml2YXRl OjpleHRyYWN0V2ViR3JhcGhpY3NDb250ZXh0M0QoU2hhcmVkR3JhcGhpY3NDb250ZXh0M0Q6Omdl dCgpLmdldCgpKTsKLX0KLQogdm9pZCBXZWJWaWV3SW1wbDo6c2VsZWN0QXV0b2ZpbGxTdWdnZXN0 aW9uQXRJbmRleCh1bnNpZ25lZCBsaXN0SW5kZXgpCiB7CiAgICAgaWYgKG1fYXV0b2ZpbGxQb3B1 cENsaWVudCAmJiBsaXN0SW5kZXggPCBtX2F1dG9maWxsUG9wdXBDbGllbnQtPmdldFN1Z2dlc3Rp b25zQ291bnQoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp ZXdJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCmluZGV4 IDY0ZjczNmY4MjlkYjQ2ZGVmZGRmMWM4NTlhMjZjZDIzNTNmOTIxZGYuLjA0Y2YyZGNhOTE1NDVk YWM3NzZhYTkwNjMyMWZjNjVhZTE0MGQ0NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuaApAQCAtNTQ0LDggKzU0NCw2IEBAIHB1YmxpYzoKICAgICB2b2lkIHNjaGVk dWxlQW5pbWF0aW9uKCk7CiAjZW5kaWYKIAotICAgIHZpcnR1YWwgV2ViR3JhcGhpY3NDb250ZXh0 M0QqIHNoYXJlZEdyYXBoaWNzQ29udGV4dDNEKCk7Ci0KICAgICB2aXJ0dWFsIHZvaWQgc2V0Vmlz aWJpbGl0eVN0YXRlKFdlYlBhZ2VWaXNpYmlsaXR5U3RhdGUsIGJvb2wpOwogCiAgICAgV2ViQ29y ZTo6UG9wdXBDb250YWluZXIqIHNlbGVjdFBvcHVwKCkgY29uc3QgeyByZXR1cm4gbV9zZWxlY3RQ b3B1cC5nZXQoKTsgfQo= 191607 2013-03-05 17:07:05 -0800 2013-03-07 10:00:44 -0800 Patch bug-111499-20130305200311.patch text/plain 3310 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0Nzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBhYjY5ODFkY2E1NjhiYWJkNjhmYjQxNjVhNGI3OTViZjgxODQ3YzEuLmM4YTc0OTFlYTQxYmI4 N2ZiNTc4MTIwMmNhNjA4Y2M1NDAyYzYxYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTMtMDMtMDUgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBSZW1vdmUgV2ViVmlldydzIHNoYXJlZEdyYXBo aWNzQ29udGV4dDNEIG1ldGhvZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmluc29u LgorCisgICAgICAgICogcHVibGljL1dlYlZpZXcuaDoKKyAgICAgICAgKFdlYlZpZXcpOgorICAg ICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmg6 CisgICAgICAgIChXZWJWaWV3SW1wbCk6CisKIDIwMTMtMDMtMDUgIEphbWVzIFJvYmluc29uICA8 amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIENsZWFuIHVwIFdlYldp ZGdldCAvIFdlYkxheWVyVHJlZVZpZXcgaW50ZXJhY3Rpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJWaWV3LmgKaW5kZXggNjRkZmExYjE0ZWMxMTFmNzEwYWMzMDRiODVjNWNkYzY0 NmI4YzZmOC4uN2RmNjBlNDQ5MmY5YzU0NTU2YzE1NWQ4YTAyNTJkNTliZjcwZTc3MCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVmlldy5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXcuaApAQCAtNDYxLDEyICs0NjEsNiBAQCBw dWJsaWM6CiAgICAgV0VCS0lUX0VYUE9SVCBzdGF0aWMgdm9pZCB3aWxsRW50ZXJNb2RhbExvb3Ao KTsKICAgICBXRUJLSVRfRVhQT1JUIHN0YXRpYyB2b2lkIGRpZEV4aXRNb2RhbExvb3AoKTsKIAot ICAgIC8vIEdQVSBhY2NlbGVyYXRpb24gc3VwcG9ydCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQotCi0gICAgLy8gQ29udGV4dCB0aGF0J3MgaW4gdGhlIGNvbXBv c2l0b3IncyBzaGFyZSBncm91cCwgYnV0IGlzIG5vdCB0aGUgY29tcG9zaXRvciBjb250ZXh0IGl0 c2VsZi4KLSAgICAvLyBDYW4gYmUgdXNlZCBmb3IgYWxsb2NhdGluZyByZXNvdXJjZXMgdGhhdCB0 aGUgY29tcG9zaXRvciB3aWxsIGxhdGVyIGFjY2Vzcy4KLSAgICB2aXJ0dWFsIFdlYkdyYXBoaWNz Q29udGV4dDNEKiBzaGFyZWRHcmFwaGljc0NvbnRleHQzRCgpID0gMDsKLQogICAgIC8vIENhbGxl ZCB0byBpbmZvcm0gdGhlIFdlYlZpZXcgdGhhdCBhIHdoZWVsIGZsaW5nIGFuaW1hdGlvbiB3YXMg c3RhcnRlZCBleHRlcm5hbGx5IChmb3IgaW5zdGFuY2UKICAgICAvLyBieSB0aGUgY29tcG9zaXRv cikgYnV0IG11c3QgYmUgY29tcGxldGVkIGJ5IHRoZSBXZWJWaWV3LgogICAgIHZpcnR1YWwgdm9p ZCB0cmFuc2ZlckFjdGl2ZVdoZWVsRmxpbmdBbmltYXRpb24oY29uc3QgV2ViQWN0aXZlV2hlZWxG bGluZ1BhcmFtZXRlcnMmKSA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAKaW5kZXggYWNiMDYyNmNlY2NjNWFjODU2MGY2ZDYwNTA2M2QyMWVkYTMzZThmZS4u Yjg1NmU4YWFlMTZiZGY5MjBjMjRjZmMwM2FiZTQ0OTY2ZTcyZGZmMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcApAQCAtNDI0NSwxNCArNDI0NSw2IEBAIHZv aWQgV2ViVmlld0ltcGw6OnVwZGF0ZUxheWVyVHJlZVZpZXdwb3J0KCkKICAgICBtX2xheWVyVHJl ZVZpZXctPnNldFBhZ2VTY2FsZUZhY3RvckFuZExpbWl0cyhwYWdlU2NhbGVGYWN0b3IoKSwgbV9t aW5pbXVtUGFnZVNjYWxlRmFjdG9yLCBtX21heGltdW1QYWdlU2NhbGVGYWN0b3IpOwogfQogCi1X ZWJHcmFwaGljc0NvbnRleHQzRCogV2ViVmlld0ltcGw6OnNoYXJlZEdyYXBoaWNzQ29udGV4dDNE KCkKLXsKLSAgICBpZiAoIW1fcGFnZS0+c2V0dGluZ3MoKS0+YWNjZWxlcmF0ZWRDb21wb3NpdGlu Z0VuYWJsZWQoKSB8fCAhYWxsb3dzQWNjZWxlcmF0ZWRDb21wb3NpdGluZygpKQotICAgICAgICBy ZXR1cm4gMDsKLQotICAgIHJldHVybiBHcmFwaGljc0NvbnRleHQzRFByaXZhdGU6OmV4dHJhY3RX ZWJHcmFwaGljc0NvbnRleHQzRChTaGFyZWRHcmFwaGljc0NvbnRleHQzRDo6Z2V0KCkuZ2V0KCkp OwotfQotCiB2b2lkIFdlYlZpZXdJbXBsOjpzZWxlY3RBdXRvZmlsbFN1Z2dlc3Rpb25BdEluZGV4 KHVuc2lnbmVkIGxpc3RJbmRleCkKIHsKICAgICBpZiAobV9hdXRvZmlsbFBvcHVwQ2xpZW50ICYm IGxpc3RJbmRleCA8IG1fYXV0b2ZpbGxQb3B1cENsaWVudC0+Z2V0U3VnZ2VzdGlvbnNDb3VudCgp KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaCBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKaW5kZXggNjRmNzM2Zjgy OWRiNDZkZWZkZGYxYzg1OWEyNmNkMjM1M2Y5MjFkZi4uMDRjZjJkY2E5MTU0NWRhYzc3NmFhOTA2 MzIxZmM2NWFlMTQwZDQ2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5oCkBAIC01NDQsOCArNTQ0LDYgQEAgcHVibGljOgogICAgIHZvaWQgc2NoZWR1bGVBbmltYXRp b24oKTsKICNlbmRpZgogCi0gICAgdmlydHVhbCBXZWJHcmFwaGljc0NvbnRleHQzRCogc2hhcmVk R3JhcGhpY3NDb250ZXh0M0QoKTsKLQogICAgIHZpcnR1YWwgdm9pZCBzZXRWaXNpYmlsaXR5U3Rh dGUoV2ViUGFnZVZpc2liaWxpdHlTdGF0ZSwgYm9vbCk7CiAKICAgICBXZWJDb3JlOjpQb3B1cENv bnRhaW5lciogc2VsZWN0UG9wdXAoKSBjb25zdCB7IHJldHVybiBtX3NlbGVjdFBvcHVwLmdldCgp OyB9Cg==