111486 2013-03-05 14:45:04 -0800 Add V8Document.h include when the V8 code generator creates a toV8(Document*) call. 2013-03-05 16:21:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 acolwell acolwell abarth haraken japhet webkit.review.bot oldest_to_newest 848096 0 acolwell 2013-03-05 14:45:04 -0800 Add V8Document.h include when the V8 code generator creates a toV8(Document*) call. 848097 1 191570 acolwell 2013-03-05 14:46:00 -0800 Created attachment 191570 Patch 848116 2 acolwell 2013-03-05 14:54:43 -0800 It's not obvious from the patch context, but the line below the "Document* document = currentDocument(BindingState::instance());" line uses the Document* version of toV8() declared in V8Document.h. While tracking down a crash that led me to move the ActiveDOMObject annotation from HTMLAudioElement.idl to HTMLMediaElement.idl, I discovered a build breaker caused by this missing include. 848142 3 abarth 2013-03-05 15:19:37 -0800 Please run-bindings-tests before landing. 848163 4 191585 acolwell 2013-03-05 15:33:03 -0800 Created attachment 191585 Fix run-bindings-tests expectations 848220 5 191585 webkit.review.bot 2013-03-05 16:21:46 -0800 Comment on attachment 191585 Fix run-bindings-tests expectations Clearing flags on attachment: 191585 Committed r144846: <http://trac.webkit.org/changeset/144846> 848221 6 webkit.review.bot 2013-03-05 16:21:49 -0800 All reviewed patches have been landed. Closing bug. 191570 2013-03-05 14:46:00 -0800 2013-03-05 15:33:01 -0800 Patch bug-111486-20130305144206.patch text/plain 1447 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0ODIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjdiNDA5N2JkYjg0ZGZk NThmZmJhMmU2NjE5YTE4ZDU0MDI4NzExYS4uNmYwYzg1MjVjMTAyODFjYzA3NzhmMzJkMDk4MjBh ZGI1MGZkZGNlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTA1ICBBYXJv biBDb2x3ZWxsICA8YWNvbHdlbGxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBWOERvY3Vt ZW50LmggaW5jbHVkZSB3aGVuIHRoZSBWOCBjb2RlIGdlbmVyYXRvciBjcmVhdGVzIGEgdG9WOChE b2N1bWVudCopIGNhbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTE0ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBObyBuZXcgdGVzdHMuIERvZXNuJ3QgY2hhbmdlIHVzZXIgdmlzaWJsZSBiZWhhdmlv ci4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorICAg ICAgICAoR2VuZXJhdGVOYW1lZENvbnN0cnVjdG9yKToKKwogMjAxMy0wMy0wNSAgQWxlYyBGbGV0 dCAgPGFsZWNmbGV0dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBQcm9wZXJs eSByZWZhY3RvciBmcm9udGVuZC9iYWNrZW5kIGNvZGUgYnkgI2luY2x1ZGVzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4IDE5 ZmI5NjYzNDNlMDY1NGE2NDE4ODA4OTgyZGY5YTAzMmU1MTMyZDkuLmM0MmYyYjQ2ZGIwM2I4ZTM2 Y2NlMDQ1Y2ZjNmU3Yzk4ZjZkMThlMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0yMTc5LDYgKzIxNzksNyBAQCBzdGF0 aWMgdjg6OkhhbmRsZTx2ODo6VmFsdWU+ICR7djhJbnRlcmZhY2VOYW1lfUNvbnN0cnVjdG9yQ2Fs bGJhY2soY29uc3Qgdjg6OkFyZwogICAgICR7bWF5YmVPYnNlcnZlRmVhdHVyZX0KIEVORAogICAg IHB1c2goQGltcGxDb250ZW50LCBHZW5lcmF0ZUNvbnN0cnVjdG9ySGVhZGVyKCkpOworICAgIEFk ZFRvSW1wbEluY2x1ZGVzKCJWOERvY3VtZW50LmgiKTsKICAgICBwdXNoKEBpbXBsQ29udGVudCwg PDxFTkQpOwogICAgIERvY3VtZW50KiBkb2N1bWVudCA9IGN1cnJlbnREb2N1bWVudChCaW5kaW5n U3RhdGU6Omluc3RhbmNlKCkpOwogCg== 191585 2013-03-05 15:33:03 -0800 2013-03-05 16:21:46 -0800 Fix run-bindings-tests expectations bug-111486-20130305152909.patch text/plain 2097 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0ODIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjdiNDA5N2JkYjg0ZGZk NThmZmJhMmU2NjE5YTE4ZDU0MDI4NzExYS4uODU2NGY1YTA1NTVmNDZiZjlmYmM3ODc2YTliNWQ0 YzY5MTk3ZmIyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTA1ICBBYXJv biBDb2x3ZWxsICA8YWNvbHdlbGxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBWOERvY3Vt ZW50LmggaW5jbHVkZSB3aGVuIHRoZSBWOCBjb2RlIGdlbmVyYXRvciBjcmVhdGVzIGEgdG9WOChE b2N1bWVudCopIGNhbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTE0ODYKKworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBkb2Vzbid0IGNoYW5nZSB1c2VyIHZpc2libGUgYmVoYXZp b3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAg ICAgICAgKEdlbmVyYXRlTmFtZWRDb25zdHJ1Y3Rvcik6CisgICAgICAgICogYmluZGluZ3Mvc2Ny aXB0cy90ZXN0L1Y4L1Y4VGVzdE5hbWVkQ29uc3RydWN0b3IuY3BwOgorCiAyMDEzLTAzLTA1ICBB bGVjIEZsZXR0ICA8YWxlY2ZsZXR0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6 IFByb3Blcmx5IHJlZmFjdG9yIGZyb250ZW5kL2JhY2tlbmQgY29kZSBieSAjaW5jbHVkZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0K aW5kZXggMTlmYjk2NjM0M2UwNjU0YTY0MTg4MDg5ODJkZjlhMDMyZTUxMzJkOS4uYzQyZjJiNDZk YjAzYjhlMzZjY2UwNDVjZmM2ZTdjOThmNmQxOGUzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTIxNzksNiArMjE3OSw3 IEBAIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gJHt2OEludGVyZmFjZU5hbWV9Q29uc3Ry dWN0b3JDYWxsYmFjayhjb25zdCB2ODo6QXJnCiAgICAgJHttYXliZU9ic2VydmVGZWF0dXJlfQog RU5ECiAgICAgcHVzaChAaW1wbENvbnRlbnQsIEdlbmVyYXRlQ29uc3RydWN0b3JIZWFkZXIoKSk7 CisgICAgQWRkVG9JbXBsSW5jbHVkZXMoIlY4RG9jdW1lbnQuaCIpOwogICAgIHB1c2goQGltcGxD b250ZW50LCA8PEVORCk7CiAgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gY3VycmVudERvY3VtZW50 KEJpbmRpbmdTdGF0ZTo6aW5zdGFuY2UoKSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3ROYW1lZENvbnN0cnVjdG9yLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3ROYW1lZENvbnN0cnVj dG9yLmNwcAppbmRleCAyMDYxNzg1ZDBjYTdlNzE1MWQwZjAyYTU0ZDRjZDllMTdjZDQ5MWFhLi5k Njg5NGVlODVkZDljZjA3ZTMyZWFlZDYwMzhhNTgzOTNkMzdjMzYxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0TmFtZWRDb25zdHJ1Y3Rv ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVz dE5hbWVkQ29uc3RydWN0b3IuY3BwCkBAIC0yOCw2ICsyOCw3IEBACiAjaW5jbHVkZSAiUnVudGlt ZUVuYWJsZWRGZWF0dXJlcy5oIgogI2luY2x1ZGUgIlY4QmluZGluZy5oIgogI2luY2x1ZGUgIlY4 RE9NV3JhcHBlci5oIgorI2luY2x1ZGUgIlY4RG9jdW1lbnQuaCIKICNpbmNsdWRlIDx3dGYvVW51 c2VkUGFyYW0uaD4KIAogI2lmIEVOQUJMRShCSU5ESU5HX0lOVEVHUklUWSkK