111483 2013-03-05 14:39:03 -0800 Modify log method in DOMActivityLogger 2013-03-06 14:58:43 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Enhancement --- 0 ataly webkit-unassigned abarth dglazkov fishd haraken jamesr japhet tkent+wkapi webkit.review.bot oldest_to_newest 848086 0 ataly 2013-03-05 14:39:03 -0800 This patch modifies the "log" method in WebDOMActivityLogger (and V8DOMActivityLogger) so that it takes const WebString& (const String&) arguments instead of const char*, and also takes an additional context handle. 848150 1 191581 ataly 2013-03-05 15:24:08 -0800 Created attachment 191581 Patch 848156 2 webkit.review.bot 2013-03-05 15:27:54 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 848160 3 191581 abarth 2013-03-05 15:31:00 -0800 Comment on attachment 191581 Patch This patch does not explain why you think we should make this change. It only explains what change you're making. I'm skeptical about needing to include the context in the log message. The current context is available in a static from V8 via v8::Context::GetCurrent(). 848260 4 ataly 2013-03-05 16:52:03 -0800 The WebDOMActivityLogger class is overridden on the Chromium side with a log method that marshalls all its arguments and then sends them over to the browser process. This marshaling requires a handle to the current context. The chromium reviewers suggested avoiding using the static v8::context::GetCurent() and instead have the context explicitly passed to the log method. FYI, the link to the chromium patch is: https://codereview.chromium.org/12390076/ 848326 5 191625 ataly 2013-03-05 18:06:31 -0800 Created attachment 191625 Patch 848328 6 ataly 2013-03-05 18:07:35 -0800 I checked again with Matt Perry (OWNER on chrome/renderer/extensions) and it turns out that it is fine to invoke the static getCurrent() in order access the context. I have updated the patch so that it only makes the following change: move const char* arguments of the log methods in WebDOMActivityLogger and V8DOMActvityLogger to const WebString& and const String& respectively. 848488 7 191625 abarth 2013-03-05 22:53:18 -0800 Comment on attachment 191625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191625&action=review > Source/WebCore/ChangeLog:9 > + https://bugs.webkit.org/show_bug.cgi?id=111483 > + > + Reviewed by NOBODY (OOPS!). > + Please explain why you're making this change in the ChangeLog. > Source/WebCore/ChangeLog:10 > + No new tests (OOPS!). This line will prevent your patch from being landed. You should explain that there are no tests because there is no behavior change. 848489 8 abarth 2013-03-05 22:53:33 -0800 (The patch looks fine otherwise.) 849081 9 191795 ataly 2013-03-06 10:59:56 -0800 Created attachment 191795 Patch 849306 10 191795 abarth 2013-03-06 14:34:21 -0800 Comment on attachment 191795 Patch Thanks. 849334 11 191795 webkit.review.bot 2013-03-06 14:58:39 -0800 Comment on attachment 191795 Patch Clearing flags on attachment: 191795 Committed r144988: <http://trac.webkit.org/changeset/144988> 849335 12 webkit.review.bot 2013-03-06 14:58:43 -0800 All reviewed patches have been landed. Closing bug. 191581 2013-03-05 15:24:08 -0800 2013-03-05 18:06:27 -0800 Patch bug-111483-20130305152014.patch text/plain 4768 ataly SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDgyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTA1ICBBbmt1ciBU YWx5ICA8YXRhbHlAZ29vZ2xlLmNvbT4KKworICAgICAgICBNb2RpZnkgbG9nIG1ldGhvZCBpbiBW OERPTUFjdGl2aXR5TG9nZ2VyIHRvIHRocmVhZCB0aHJvdWdoIGEgY29udGV4dAorICAgICAgICBo YW5kbGUgYW5kIGFsc28gaGF2ZSBjb25zdCBTdHJpbmcmIGFyZ3VtZW50cyBpbnN0ZWFkIG9mIGNv bnN0IGNoYXIqLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMTE0ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9N QWN0aXZpdHlMb2dnZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NQWN0aXZpdHlMb2dnZXI6 OmxvZyk6CisKIDIwMTMtMDMtMDQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBbY2hyb21pdW1dIE1vdmUgY2hlY2sgZm9yIHRocmVhZGVkIGNvbXBvc2l0 aW5nIGZyb20gV2ViQ29tcG9zaXRvclN1cHBvcnQgdG8gUGxhdGZvcm0KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NQWN0aXZpdHlMb2dnZXIuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTUFjdGl2aXR5TG9nZ2VyLmgJKHJldmlzaW9u IDE0NDgyNikKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NQWN0aXZpdHlMb2dn ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzEsNyArMzEsOCBAQAogI2lmbmRlZiBWOERPTUFjdGl2 aXR5TG9nZ2VyX2gKICNkZWZpbmUgVjhET01BY3Rpdml0eUxvZ2dlcl9oCiAKLSNpbmNsdWRlICJ2 OC5oIgorI2luY2x1ZGUgPHY4Lmg+CisjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtMzksNyArNDAsNyBAQCBjbGFzcyBWOERPTUFjdGl2 aXR5TG9nZ2VyIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5WOERPTUFjdGl2aXR5TG9nZ2VyKCkg eyB9CiAKLSAgICB2aXJ0dWFsIHZvaWQgbG9nKGNvbnN0IGNoYXIqIGFwaU5hbWUsIGludCBhcmdj LCBjb25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4qIGFyZ3YsIGNvbnN0IGNoYXIqIGV4dHJhSW5m bykgeyB9CisgICAgdmlydHVhbCB2b2lkIGxvZyhjb25zdCBTdHJpbmcmIGFwaU5hbWUsIGludCBh cmdjLCBjb25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4qIGFyZ3YsIGNvbnN0IFN0cmluZyYgZXh0 cmFJbmZvLCB2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiBjb250ZXh0KSB7IH0KIH07CiAKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lv biAxNDQ4MjcpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTA1ICBBbmt1ciBUYWx5ICA8YXRhbHlAZ29v Z2xlLmNvbT4KKworICAgICAgICBNb2RpZnkgbG9nIG1ldGhvZCBpbiBXZWJET01BY3Rpdml0eUxv Z2dlciB0byB0aHJlYWQgdGhyb3VnaCBhIGNvbnRleHQKKyAgICAgICAgaGFuZGxlIGFuZCBhbHNv IGhhdmUgY29uc3QgV2ViU3RyaW5nJiBhcmd1bWVudHMgaW5zdGVhZCBvZiBjb25zdCBjaGFyKi4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTQ4Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcHVibGlj L1dlYkRPTUFjdGl2aXR5TG9nZ2VyLmg6IEFkZGVkIHByb3BlcnR5IHN2bjplb2wtc3R5bGUuCisg ICAgICAgIChXZWJLaXQ6OldlYkRPTUFjdGl2aXR5TG9nZ2VyOjpsb2cpOgorICAgICAgICAqIHNy Yy9XZWJET01BY3Rpdml0eUxvZ2dlci5jcHA6IEFkZGVkIHByb3BlcnR5IHN2bjplb2wtc3R5bGUu CisgICAgICAgIChXZWJLaXQ6OkRPTUFjdGl2aXR5TG9nZ2VyQ29udGFpbmVyOjpsb2cpOgorCiAy MDEzLTAzLTA0ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW2Nocm9taXVtXSBNb3ZlIGNoZWNrIGZvciB0aHJlYWRlZCBjb21wb3NpdGluZyBmcm9tIFdl YkNvbXBvc2l0b3JTdXBwb3J0IHRvIFBsYXRmb3JtCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJET01BY3Rpdml0eUxvZ2dlci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRPTUFjdGl2aXR5TG9nZ2VyLmgJKHJldmlzaW9uIDE0 NDgyNikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRPTUFjdGl2aXR5TG9n Z2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAKICNkZWZpbmUgV2ViRE9NQWN0 aXZpdHlMb2dnZXJfaAogCiAjaW5jbHVkZSAiLi4vLi4vLi4vUGxhdGZvcm0vY2hyb21pdW0vcHVi bGljL1dlYkNvbW1vbi5oIgorI2luY2x1ZGUgIi4uLy4uLy4uL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJTdHJpbmcuaCIKICNpbmNsdWRlIDx2OC5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsK QEAgLTM5LDcgKzQwLDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiBjbGFzcyBXZWJET01BY3Rpdml0 eUxvZ2dlciB7CiBwdWJsaWM6CiAgICAgdmlydHVhbCB+V2ViRE9NQWN0aXZpdHlMb2dnZXIoKSB7 IH0KLSAgICB2aXJ0dWFsIHZvaWQgbG9nKGNvbnN0IGNoYXIqIGFwaU5hbWUsIGludCBhcmdjLCBj b25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4qIGFyZ3YsIGNvbnN0IGNoYXIqIGV4dHJhSW5mbykg eyB9CisgICAgdmlydHVhbCB2b2lkIGxvZyhjb25zdCBXZWJTdHJpbmcmIGFwaU5hbWUsIGludCBh cmdjLCBjb25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4qIGFyZ3YsIGNvbnN0IFdlYlN0cmluZyYg ZXh0cmFJbmZvLCB2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiBjb250ZXh0KSB7IH0KIH07CiAKIC8v IENoZWNrcyBpZiBhIGxvZ2dlciBhbHJlYWR5IGV4aXN0cyBmb3IgdGhlIHdvcmxkIGlkZW50aWZp ZWQKClByb3BlcnR5IGNoYW5nZXMgb246IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkRPTUFjdGl2aXR5TG9nZ2VyLmgKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBZGRlZDogc3ZuOmVvbC1zdHlsZQogICAr IExGCgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRE9NQWN0aXZpdHlMb2dn ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRPTUFj dGl2aXR5TG9nZ2VyLmNwcAkocmV2aXNpb24gMTQ0ODI2KQorKysgU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRE9NQWN0aXZpdHlMb2dnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2 ICszNCw3IEBACiAjaW5jbHVkZSAiRE9NV3JhcHBlcldvcmxkLmgiCiAjaW5jbHVkZSAiVjhET01B Y3Rpdml0eUxvZ2dlci5oIgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CisjaW5jbHVkZSA8 d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC00 Niw5ICs0Nyw5IEBAIHB1YmxpYzoKICAgICB7CiAgICAgfQogCi0gICAgdmlydHVhbCB2b2lkIGxv Zyhjb25zdCBjaGFyKiBhcGlOYW1lLCBpbnQgYXJnYywgY29uc3Qgdjg6OkhhbmRsZTx2ODo6VmFs dWU+KiBhcmd2LCBjb25zdCBjaGFyKiBleHRyYUluZm8pCisgICAgdmlydHVhbCB2b2lkIGxvZyhj b25zdCBTdHJpbmcmIGFwaU5hbWUsIGludCBhcmdjLCBjb25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1 ZT4qIGFyZ3YsIGNvbnN0IFN0cmluZyYgZXh0cmFJbmZvLCB2ODo6SGFuZGxlPHY4OjpDb250ZXh0 PiBjb250ZXh0KQogICAgIHsgICAKLSAgICAgICAgbV9kb21BY3Rpdml0eUxvZ2dlci0+bG9nKGFw aU5hbWUsIGFyZ2MsIGFyZ3YsIGV4dHJhSW5mbyk7IAorICAgICAgICBtX2RvbUFjdGl2aXR5TG9n Z2VyLT5sb2coV2ViU3RyaW5nKGFwaU5hbWUpLCBhcmdjLCBhcmd2LCBXZWJTdHJpbmcoZXh0cmFJ bmZvKSwgY29udGV4dCk7IAogICAgIH0KIAogcHJpdmF0ZToKClByb3BlcnR5IGNoYW5nZXMgb246 IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRPTUFjdGl2aXR5TG9nZ2VyLmNwcApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkFkZGVkOiBzdm46ZW9sLXN0eWxlCiAgICsgTEYKCg== 191625 2013-03-05 18:06:31 -0800 2013-03-06 10:59:52 -0800 Patch bug-111483-20130305180237.patch text/plain 4654 ataly SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDgyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTA1ICBBbmt1ciBU YWx5ICA8YXRhbHlAZ29vZ2xlLmNvbT4KKworICAgICAgICBNb2RpZnkgbG9nIG1ldGhvZCBpbiBW OERPTUFjdGl2aXR5TG9nZ2VyIHNvIHRoYXQgdGhlIGFwaU5hbWUgYW5kCisgICAgICAgIGV4dHJh SW5mbyBhcmd1bWVudHMgYXJlIG9mIHR5cGUgY29uc3QgU3RyaW5nJiBpbnN0ZWFkIG9mIGNvbnN0 IGNoYXIqLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTE0ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NQWN0 aXZpdHlMb2dnZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NQWN0aXZpdHlMb2dnZXI6Omxv Zyk6CisKIDIwMTMtMDMtMDQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbY2hyb21pdW1dIE1vdmUgY2hlY2sgZm9yIHRocmVhZGVkIGNvbXBvc2l0aW5n IGZyb20gV2ViQ29tcG9zaXRvclN1cHBvcnQgdG8gUGxhdGZvcm0KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4RE9NQWN0aXZpdHlMb2dnZXIuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTUFjdGl2aXR5TG9nZ2VyLmgJKHJldmlzaW9uIDE0 NDgyNikKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NQWN0aXZpdHlMb2dnZXIu aAkod29ya2luZyBjb3B5KQpAQCAtMzEsNyArMzEsOCBAQAogI2lmbmRlZiBWOERPTUFjdGl2aXR5 TG9nZ2VyX2gKICNkZWZpbmUgVjhET01BY3Rpdml0eUxvZ2dlcl9oCiAKLSNpbmNsdWRlICJ2OC5o IgorI2luY2x1ZGUgPHY4Lmg+CisjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtMzksNyArNDAsNyBAQCBjbGFzcyBWOERPTUFjdGl2aXR5 TG9nZ2VyIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5WOERPTUFjdGl2aXR5TG9nZ2VyKCkgeyB9 CiAKLSAgICB2aXJ0dWFsIHZvaWQgbG9nKGNvbnN0IGNoYXIqIGFwaU5hbWUsIGludCBhcmdjLCBj b25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4qIGFyZ3YsIGNvbnN0IGNoYXIqIGV4dHJhSW5mbykg eyB9CisgICAgdmlydHVhbCB2b2lkIGxvZyhjb25zdCBTdHJpbmcmIGFwaU5hbWUsIGludCBhcmdj LCBjb25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4qIGFyZ3YsIGNvbnN0IFN0cmluZyYgZXh0cmFJ bmZvKSB7IH0KIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDQ4MjcpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTA1ICBB bmt1ciBUYWx5ICA8YXRhbHlAZ29vZ2xlLmNvbT4KKworICAgICAgICBNb2RpZnkgbG9nIG1ldGhv ZCBpbiBXZWJET01BY3Rpdml0eUxvZ2dlciBzbyB0aGF0IHRoZSBhcGlOYW1lIGFuZAorICAgICAg ICBleHRyYUluZm8gYXJndW1lbnRzIGFyZSBvZiB0eXBlIGNvbnN0IFdlYlN0cmluZyYgaW5zdGVh ZCBvZiBjb25zdCBjaGFyKi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMTQ4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcHVibGljL1dlYkRPTUFjdGl2aXR5TG9nZ2VyLmg6IEFkZGVkIHByb3BlcnR5 IHN2bjplb2wtc3R5bGUuCisgICAgICAgIChXZWJLaXQ6OldlYkRPTUFjdGl2aXR5TG9nZ2VyOjps b2cpOgorICAgICAgICAqIHNyYy9XZWJET01BY3Rpdml0eUxvZ2dlci5jcHA6IEFkZGVkIHByb3Bl cnR5IHN2bjplb2wtc3R5bGUuCisgICAgICAgIChXZWJLaXQ6OkRPTUFjdGl2aXR5TG9nZ2VyQ29u dGFpbmVyOjpsb2cpOgorCiAyMDEzLTAzLTA0ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBNb3ZlIGNoZWNrIGZvciB0aHJlYWRlZCBj b21wb3NpdGluZyBmcm9tIFdlYkNvbXBvc2l0b3JTdXBwb3J0IHRvIFBsYXRmb3JtCkluZGV4OiBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJET01BY3Rpdml0eUxvZ2dlci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRPTUFjdGl2aXR5TG9n Z2VyLmgJKHJldmlzaW9uIDE0NDgyNikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkRPTUFjdGl2aXR5TG9nZ2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDYgKzMyLDcgQEAK ICNkZWZpbmUgV2ViRE9NQWN0aXZpdHlMb2dnZXJfaAogCiAjaW5jbHVkZSAiLi4vLi4vLi4vUGxh dGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkNvbW1vbi5oIgorI2luY2x1ZGUgIi4uLy4uLy4uL1Bs YXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJTdHJpbmcuaCIKICNpbmNsdWRlIDx2OC5oPgogCiBu YW1lc3BhY2UgV2ViS2l0IHsKQEAgLTM5LDcgKzQwLDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiBj bGFzcyBXZWJET01BY3Rpdml0eUxvZ2dlciB7CiBwdWJsaWM6CiAgICAgdmlydHVhbCB+V2ViRE9N QWN0aXZpdHlMb2dnZXIoKSB7IH0KLSAgICB2aXJ0dWFsIHZvaWQgbG9nKGNvbnN0IGNoYXIqIGFw aU5hbWUsIGludCBhcmdjLCBjb25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4qIGFyZ3YsIGNvbnN0 IGNoYXIqIGV4dHJhSW5mbykgeyB9CisgICAgdmlydHVhbCB2b2lkIGxvZyhjb25zdCBXZWJTdHJp bmcmIGFwaU5hbWUsIGludCBhcmdjLCBjb25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4qIGFyZ3Ys IGNvbnN0IFdlYlN0cmluZyYgZXh0cmFJbmZvKSB7IH0KIH07CiAKIC8vIENoZWNrcyBpZiBhIGxv Z2dlciBhbHJlYWR5IGV4aXN0cyBmb3IgdGhlIHdvcmxkIGlkZW50aWZpZWQKClByb3BlcnR5IGNo YW5nZXMgb246IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRPTUFjdGl2aXR5TG9n Z2VyLmgKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpBZGRlZDogc3ZuOmVvbC1zdHlsZQogICArIExGCgpJbmRleDogU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRE9NQWN0aXZpdHlMb2dnZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRPTUFjdGl2aXR5TG9nZ2VyLmNw cAkocmV2aXNpb24gMTQ0ODI2KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRE9N QWN0aXZpdHlMb2dnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw3IEBACiAjaW5j bHVkZSAiRE9NV3JhcHBlcldvcmxkLmgiCiAjaW5jbHVkZSAiVjhET01BY3Rpdml0eUxvZ2dlci5o IgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CisjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3Ry aW5nLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCkBAIC00Niw5ICs0Nyw5IEBAIHB1 YmxpYzoKICAgICB7CiAgICAgfQogCi0gICAgdmlydHVhbCB2b2lkIGxvZyhjb25zdCBjaGFyKiBh cGlOYW1lLCBpbnQgYXJnYywgY29uc3Qgdjg6OkhhbmRsZTx2ODo6VmFsdWU+KiBhcmd2LCBjb25z dCBjaGFyKiBleHRyYUluZm8pCisgICAgdmlydHVhbCB2b2lkIGxvZyhjb25zdCBTdHJpbmcmIGFw aU5hbWUsIGludCBhcmdjLCBjb25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4qIGFyZ3YsIGNvbnN0 IFN0cmluZyYgZXh0cmFJbmZvKQogICAgIHsgICAKLSAgICAgICAgbV9kb21BY3Rpdml0eUxvZ2dl ci0+bG9nKGFwaU5hbWUsIGFyZ2MsIGFyZ3YsIGV4dHJhSW5mbyk7IAorICAgICAgICBtX2RvbUFj dGl2aXR5TG9nZ2VyLT5sb2coV2ViU3RyaW5nKGFwaU5hbWUpLCBhcmdjLCBhcmd2LCBXZWJTdHJp bmcoZXh0cmFJbmZvKSk7IAogICAgIH0KIAogcHJpdmF0ZToKClByb3BlcnR5IGNoYW5nZXMgb246 IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRPTUFjdGl2aXR5TG9nZ2VyLmNwcApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkFkZGVkOiBzdm46ZW9sLXN0eWxlCiAgICsgTEYKCg== 191795 2013-03-06 10:59:56 -0800 2013-03-06 14:58:39 -0800 Patch bug-111483-20130306105601.patch text/plain 4977 ataly SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDgyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAzLTA1ICBBbmt1ciBU YWx5ICA8YXRhbHlAZ29vZ2xlLmNvbT4KKworICAgICAgICBNb2RpZnkgbG9nIG1ldGhvZCBpbiBW OERPTUFjdGl2aXR5TG9nZ2VyIHNvIHRoYXQgdGhlIGFwaU5hbWUgYW5kCisgICAgICAgIGV4dHJh SW5mbyBhcmd1bWVudHMgYXJlIG9mIHR5cGUgY29uc3QgU3RyaW5nJiBpbnN0ZWFkIG9mIGNvbnN0 IGNoYXIqLgorICAgICAgICBUaGlzIGNoYW5nZSBnZXRzIHJpZCBvZiBzb21lIG9mIHRoZSBtZW1v cnkgb3duZXJzaGlwIGlzc3VlcyB0aGF0IGFyaXNlCisgICAgICAgIHdpdGggY2hhciogcG9pbnRl cnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE0 ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVy ZSBhcmUgbm8gbmV3IHRlc3RzIGFzIHRoZXJlIGlzIG5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKwor ICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NQWN0aXZpdHlMb2dnZXIuaDoKKyAgICAgICAgKFdl YkNvcmU6OlY4RE9NQWN0aXZpdHlMb2dnZXI6OmxvZyk6CisKIDIwMTMtMDMtMDQgIEphbWVzIFJv Ymluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIE1vdmUg Y2hlY2sgZm9yIHRocmVhZGVkIGNvbXBvc2l0aW5nIGZyb20gV2ViQ29tcG9zaXRvclN1cHBvcnQg dG8gUGxhdGZvcm0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NQWN0aXZp dHlMb2dnZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERP TUFjdGl2aXR5TG9nZ2VyLmgJKHJldmlzaW9uIDE0NDgyNikKKysrIFNvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4RE9NQWN0aXZpdHlMb2dnZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzEsNyAr MzEsOCBAQAogI2lmbmRlZiBWOERPTUFjdGl2aXR5TG9nZ2VyX2gKICNkZWZpbmUgVjhET01BY3Rp dml0eUxvZ2dlcl9oCiAKLSNpbmNsdWRlICJ2OC5oIgorI2luY2x1ZGUgPHY4Lmg+CisjaW5jbHVk ZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtMzks NyArNDAsNyBAQCBjbGFzcyBWOERPTUFjdGl2aXR5TG9nZ2VyIHsKIHB1YmxpYzoKICAgICB2aXJ0 dWFsIH5WOERPTUFjdGl2aXR5TG9nZ2VyKCkgeyB9CiAKLSAgICB2aXJ0dWFsIHZvaWQgbG9nKGNv bnN0IGNoYXIqIGFwaU5hbWUsIGludCBhcmdjLCBjb25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4q IGFyZ3YsIGNvbnN0IGNoYXIqIGV4dHJhSW5mbykgeyB9CisgICAgdmlydHVhbCB2b2lkIGxvZyhj b25zdCBTdHJpbmcmIGFwaU5hbWUsIGludCBhcmdjLCBjb25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1 ZT4qIGFyZ3YsIGNvbnN0IFN0cmluZyYgZXh0cmFJbmZvKSB7IH0KIH07CiAKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDQ4 MjcpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTA1ICBBbmt1ciBUYWx5ICA8YXRhbHlAZ29vZ2xlLmNv bT4KKworICAgICAgICBNb2RpZnkgbG9nIG1ldGhvZCBpbiBXZWJET01BY3Rpdml0eUxvZ2dlciBz byB0aGF0IHRoZSBhcGlOYW1lIGFuZAorICAgICAgICBleHRyYUluZm8gYXJndW1lbnRzIGFyZSBv ZiB0eXBlIGNvbnN0IFdlYlN0cmluZyYgaW5zdGVhZCBvZiBjb25zdCBjaGFyKi4KKyAgICAgICAg VGhpcyBjaGFuZ2UgZ2V0cyByaWQgb2Ygc29tZSBvZiB0aGUgbWVtb3J5IG93bmVyc2hpcCBpc3N1 ZXMgdGhhdCBhcmlzZQorICAgICAgICB3aXRoIGNoYXIqIHBvaW50ZXJzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNDgzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlIG5vIG5ldyB0ZXN0 cyBhcyB0aGVyZSBpcyBubyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBwdWJsaWMv V2ViRE9NQWN0aXZpdHlMb2dnZXIuaDogQWRkZWQgcHJvcGVydHkgc3ZuOmVvbC1zdHlsZS4KKyAg ICAgICAgKFdlYktpdDo6V2ViRE9NQWN0aXZpdHlMb2dnZXI6OmxvZyk6CisgICAgICAgICogc3Jj L1dlYkRPTUFjdGl2aXR5TG9nZ2VyLmNwcDogQWRkZWQgcHJvcGVydHkgc3ZuOmVvbC1zdHlsZS4K KyAgICAgICAgKFdlYktpdDo6RE9NQWN0aXZpdHlMb2dnZXJDb250YWluZXI6OmxvZyk6CisKIDIw MTMtMDMtMDQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbY2hyb21pdW1dIE1vdmUgY2hlY2sgZm9yIHRocmVhZGVkIGNvbXBvc2l0aW5nIGZyb20gV2Vi Q29tcG9zaXRvclN1cHBvcnQgdG8gUGxhdGZvcm0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYkRPTUFjdGl2aXR5TG9nZ2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRE9NQWN0aXZpdHlMb2dnZXIuaAkocmV2aXNpb24gMTQ0 ODI2KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRE9NQWN0aXZpdHlMb2dn ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzIsNiArMzIsNyBAQAogI2RlZmluZSBXZWJET01BY3Rp dml0eUxvZ2dlcl9oCiAKICNpbmNsdWRlICIuLi8uLi8uLi9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJs aWMvV2ViQ29tbW9uLmgiCisjaW5jbHVkZSAiLi4vLi4vLi4vUGxhdGZvcm0vY2hyb21pdW0vcHVi bGljL1dlYlN0cmluZy5oIgogI2luY2x1ZGUgPHY4Lmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewpA QCAtMzksNyArNDAsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIGNsYXNzIFdlYkRPTUFjdGl2aXR5 TG9nZ2VyIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5XZWJET01BY3Rpdml0eUxvZ2dlcigpIHsg fQotICAgIHZpcnR1YWwgdm9pZCBsb2coY29uc3QgY2hhciogYXBpTmFtZSwgaW50IGFyZ2MsIGNv bnN0IHY4OjpIYW5kbGU8djg6OlZhbHVlPiogYXJndiwgY29uc3QgY2hhciogZXh0cmFJbmZvKSB7 IH0KKyAgICB2aXJ0dWFsIHZvaWQgbG9nKGNvbnN0IFdlYlN0cmluZyYgYXBpTmFtZSwgaW50IGFy Z2MsIGNvbnN0IHY4OjpIYW5kbGU8djg6OlZhbHVlPiogYXJndiwgY29uc3QgV2ViU3RyaW5nJiBl eHRyYUluZm8pIHsgfQogfTsKIAogLy8gQ2hlY2tzIGlmIGEgbG9nZ2VyIGFscmVhZHkgZXhpc3Rz IGZvciB0aGUgd29ybGQgaWRlbnRpZmllZAoKUHJvcGVydHkgY2hhbmdlcyBvbjogU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRE9NQWN0aXZpdHlMb2dnZXIuaApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFk ZGVkOiBzdm46ZW9sLXN0eWxlCiAgICsgTEYKCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJET01BY3Rpdml0eUxvZ2dlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRE9NQWN0aXZpdHlMb2dnZXIuY3BwCShyZXZpc2lvbiAxNDQ4MjYp CisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJET01BY3Rpdml0eUxvZ2dlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTM0LDYgKzM0LDcgQEAKICNpbmNsdWRlICJET01XcmFwcGVyV29y bGQuaCIKICNpbmNsdWRlICJWOERPTUFjdGl2aXR5TG9nZ2VyLmgiCiAjaW5jbHVkZSA8d3RmL1Bh c3NSZWZQdHIuaD4KKyNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAogdXNpbmcgbmFt ZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTQ2LDkgKzQ3LDkgQEAgcHVibGljOgogICAgIHsKICAgICB9 CiAKLSAgICB2aXJ0dWFsIHZvaWQgbG9nKGNvbnN0IGNoYXIqIGFwaU5hbWUsIGludCBhcmdjLCBj b25zdCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4qIGFyZ3YsIGNvbnN0IGNoYXIqIGV4dHJhSW5mbykK KyAgICB2aXJ0dWFsIHZvaWQgbG9nKGNvbnN0IFN0cmluZyYgYXBpTmFtZSwgaW50IGFyZ2MsIGNv bnN0IHY4OjpIYW5kbGU8djg6OlZhbHVlPiogYXJndiwgY29uc3QgU3RyaW5nJiBleHRyYUluZm8p CiAgICAgeyAgIAotICAgICAgICBtX2RvbUFjdGl2aXR5TG9nZ2VyLT5sb2coYXBpTmFtZSwgYXJn YywgYXJndiwgZXh0cmFJbmZvKTsgCisgICAgICAgIG1fZG9tQWN0aXZpdHlMb2dnZXItPmxvZyhX ZWJTdHJpbmcoYXBpTmFtZSksIGFyZ2MsIGFyZ3YsIFdlYlN0cmluZyhleHRyYUluZm8pKTsgCiAg ICAgfQogCiBwcml2YXRlOgoKUHJvcGVydHkgY2hhbmdlcyBvbjogU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRE9NQWN0aXZpdHlMb2dnZXIuY3BwCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjpl b2wtc3R5bGUKICAgKyBMRgoK