111467 2013-03-05 12:40:45 -0800 Each web process truncates the disk cache to zero on launch 2013-03-06 11:50:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren darin oldest_to_newest 847928 0 ggaren 2013-03-05 12:40:45 -0800 Each web process truncates the disk cache to zero on launch 847930 1 191537 ggaren 2013-03-05 12:42:57 -0800 Created attachment 191537 Patch 848045 2 191537 darin 2013-03-05 14:04:19 -0800 Comment on attachment 191537 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191537&action=review > Source/WebKit2/WebProcess/mac/WebProcessMac.mm:165 > + NSUInteger cacheMemoryCapacity = parameters.nsURLCacheMemoryCapacity; > + NSUInteger cacheDiskCapacity = parameters.nsURLCacheDiskCapacity; Strange to put two arguments into local variables here, but not the third. All three or none? > Source/WebKit2/WebProcess/mac/WebProcessMac.mm:168 > + RetainPtr<NSURLCache> parentProcessURLCache(AdoptNS, [[NSURLCache alloc] initWithMemoryCapacity:cacheMemoryCapacity diskCapacity:cacheDiskCapacity diskPath:parameters.diskCacheDirectory]); > + [NSURLCache setSharedURLCache:parentProcessURLCache.get()]; Wrong indentation here. 848337 3 ggaren 2013-03-05 18:15:35 -0800 Committed r144860: <http://trac.webkit.org/changeset/144860> 849115 4 darin 2013-03-06 11:23:14 -0800 More style comments for Geoff: 1) The adoptNS function is so much better than RetainPtr<xxx> yyy(AdoptNS, zzz). 2) No local variable needed. So next time I have a chance I’d just change this to: [NSURLCache setSharedURLCache:adoptNS([[NSURLCache alloc] initWithMemoryCapacity:parameters.nsURLCacheMemoryCapacity diskCapacity:parameters.nsURLCacheDiskCapacity diskPath:parameters.diskCacheDirectory]).get()]; Just wanted to get you into the adoptNS/adoptCF/adoptRef club! 849152 5 ggaren 2013-03-06 11:50:26 -0800 Committed r144958: <http://trac.webkit.org/changeset/144958> 191537 2013-03-05 12:42:57 -0800 2013-03-05 14:04:19 -0800 Patch bug-111467-20130305123903.patch text/plain 2774 ggaren SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDgwMCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTA1ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgRWFjaCB3ZWIgcHJvY2VzcyB0 cnVuY2F0ZXMgdGhlIGRpc2sgY2FjaGUgdG8gemVybyBvbiBsYXVuY2gKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTQ2NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExldCdzIG5vdCBkbyB0aGF0LgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9tYWMvV2ViUHJvY2Vzc01hYy5tbToKKyAgICAgICAgKFdlYktp dDo6V2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMTMtMDMt MDUgIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CiAK ICAgICAgICAgW1dLMl1bRUZMXSBXZWJQYWdlUHJveHk6OnNldFRoZW1lUGF0aCgpIHNob3VsZCBj aGVjayB0aGF0IHRoZSBwYWdlIGlzIHZhbGlkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL21hYy9XZWJQcm9jZXNzTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvbWFjL1dlYlByb2Nlc3NNYWMubW0JKHJldmlzaW9uIDE0NDY1OCkKKysrIFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvbWFjL1dlYlByb2Nlc3NNYWMubW0JKHdvcmtpbmcgY29weSkK QEAgLTE1NSwxNCArMTU1LDIxIEBAIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXpl V2ViUHIKICAgICBTYW5kYm94RXh0ZW5zaW9uOjpjb25zdW1lUGVybWFuZW50bHkocGFyYW1ldGVy cy5hcHBsaWNhdGlvbkNhY2hlRGlyZWN0b3J5RXh0ZW5zaW9uSGFuZGxlKTsKICAgICBTYW5kYm94 RXh0ZW5zaW9uOjpjb25zdW1lUGVybWFuZW50bHkocGFyYW1ldGVycy5kaXNrQ2FjaGVEaXJlY3Rv cnlFeHRlbnNpb25IYW5kbGUpOwogCi0gICAgLy8gRklYTUUgKE5ldHdvcmtQcm9jZXNzKTogVGhp cyBzaG91bGQgbm90IGJlIG5lY2Vzc2FyeSBvbmNlIGFsbCBsb2FkaW5nIGlzIGluIE5ldHdvcmtQ cm9jZXNzLgotICAgIGlmICghcGFyYW1ldGVycy5kaXNrQ2FjaGVEaXJlY3RvcnkuaXNOdWxsKCkp IHsKLSAgICAgICAgTlNVSW50ZWdlciBjYWNoZU1lbW9yeUNhcGFjaXR5ID0gcGFyYW1ldGVycy5u c1VSTENhY2hlTWVtb3J5Q2FwYWNpdHk7Ci0gICAgICAgIE5TVUludGVnZXIgY2FjaGVEaXNrQ2Fw YWNpdHkgPSBwYXJhbWV0ZXJzLm5zVVJMQ2FjaGVEaXNrQ2FwYWNpdHk7Ci0KLSAgICAgICAgUmV0 YWluUHRyPE5TVVJMQ2FjaGU+IHBhcmVudFByb2Nlc3NVUkxDYWNoZShBZG9wdE5TLCBbW05TVVJM Q2FjaGUgYWxsb2NdIGluaXRXaXRoTWVtb3J5Q2FwYWNpdHk6Y2FjaGVNZW1vcnlDYXBhY2l0eSBk aXNrQ2FwYWNpdHk6Y2FjaGVEaXNrQ2FwYWNpdHkgZGlza1BhdGg6cGFyYW1ldGVycy5kaXNrQ2Fj aGVEaXJlY3RvcnldKTsKLSAgICAgICAgW05TVVJMQ2FjaGUgc2V0U2hhcmVkVVJMQ2FjaGU6cGFy ZW50UHJvY2Vzc1VSTENhY2hlLmdldCgpXTsKKyAgICAvLyBXaGVuIHRoZSBuZXR3b3JrIHByb2Nl c3MgaXMgZW5hYmxlZCwgZWFjaCB3ZWIgcHJvY2VzcyB3YW50cyBhIHN0YW5kLWFsb25lCisgICAg Ly8gTlNVUkxDYWNoZSwgd2hpY2ggaXQgY2FuIGRpc2FibGUgdG8gc2F2ZSBtZW1vcnkuCisjaWYg RU5BQkxFKE5FVFdPUktfUFJPQ0VTUykKKyAgICBpZiAoIW1fdXNlc05ldHdvcmtQcm9jZXNzKSB7 CisjZW5kaWYKKyAgICAgICAgaWYgKCFwYXJhbWV0ZXJzLmRpc2tDYWNoZURpcmVjdG9yeS5pc051 bGwoKSkgeworICAgICAgICAgICAgTlNVSW50ZWdlciBjYWNoZU1lbW9yeUNhcGFjaXR5ID0gcGFy YW1ldGVycy5uc1VSTENhY2hlTWVtb3J5Q2FwYWNpdHk7CisgICAgICAgICAgICBOU1VJbnRlZ2Vy IGNhY2hlRGlza0NhcGFjaXR5ID0gcGFyYW1ldGVycy5uc1VSTENhY2hlRGlza0NhcGFjaXR5Owor CisgICAgICAgICAgICAgICAgUmV0YWluUHRyPE5TVVJMQ2FjaGU+IHBhcmVudFByb2Nlc3NVUkxD YWNoZShBZG9wdE5TLCBbW05TVVJMQ2FjaGUgYWxsb2NdIGluaXRXaXRoTWVtb3J5Q2FwYWNpdHk6 Y2FjaGVNZW1vcnlDYXBhY2l0eSBkaXNrQ2FwYWNpdHk6Y2FjaGVEaXNrQ2FwYWNpdHkgZGlza1Bh dGg6cGFyYW1ldGVycy5kaXNrQ2FjaGVEaXJlY3RvcnldKTsKKyAgICAgICAgICAgICAgICBbTlNV UkxDYWNoZSBzZXRTaGFyZWRVUkxDYWNoZTpwYXJlbnRQcm9jZXNzVVJMQ2FjaGUuZ2V0KCldOwor ICAgICAgICB9CisjaWYgRU5BQkxFKE5FVFdPUktfUFJPQ0VTUykKICAgICB9CisjZW5kaWYKIAog ICAgIG1fc2hvdWxkRm9yY2VTY3JlZW5Gb250U3Vic3RpdHV0aW9uID0gcGFyYW1ldGVycy5zaG91 bGRGb3JjZVNjcmVlbkZvbnRTdWJzdGl0dXRpb247CiAgICAgRm9udDo6c2V0RGVmYXVsdFR5cGVz ZXR0aW5nRmVhdHVyZXMocGFyYW1ldGVycy5zaG91bGRFbmFibGVLZXJuaW5nQW5kTGlnYXR1cmVz QnlEZWZhdWx0ID8gS2VybmluZyB8IExpZ2F0dXJlcyA6IDApOwo=