111456 2013-03-05 11:02:48 -0800 [WK2] Crashes creating WebKit processes in WKSandboxExtensionConsume 2013-03-05 11:26:05 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap oldest_to_newest 847823 0 ap 2013-03-05 11:02:48 -0800 When extension creation fails, we are likely to crash in SandboxExtension::consumePermanently(). That's too late to diagnose, and also, other SandboxExtension functions handle this situation more gracefully. 847837 1 191514 ap 2013-03-05 11:10:33 -0800 Created attachment 191514 proposed fix 847852 2 ap 2013-03-05 11:19:39 -0800 Committed <http://trac.webkit.org/changeset/144788>. 847857 3 ap 2013-03-05 11:26:05 -0800 <rdar://problem/13269245> 191514 2013-03-05 11:10:33 -0800 2013-03-05 11:11:29 -0800 proposed fix ConsumePermanently.txt text/plain 2883 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDc4MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAzLTA1ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x MzI2OTI0NT4gQ3Jhc2hlcyBjcmVhdGluZyBXZWJLaXQgcHJvY2Vzc2VzIGluIFdLU2FuZGJveEV4 dGVuc2lvbkNvbnN1bWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTExMTQ1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEl0J3MgdG9vIGxhdGUgdG8gYmUgZHJhY29uaWFuIGFib3V0IHRoaXMgY29uZGl0aW9u IGhlcmUsIGNyYXNoaW5nIGRvZXNuJ3QgaGVscAorICAgICAgICBkaWFnbm9zZSB3aGF0IHdlbnQg d3Jvbmcgd2hlbiBjcmVhdGluZyBhIHNhbmRib3ggZXh0ZW5zaW9uLgorCisgICAgICAgIE90aGVy IFNhbmRib3hFeHRlbnNpb24gZnVuY3Rpb25zIGFscmVhZHkgaGF2ZSBudWxsIGNoZWNrcyBmb3Ig V0tTYW5kYm94RXh0ZW5zaW9uUmVmLAorICAgICAgICBhbmQgc28gc2hvdWxkIGNvbnN1bWVQZXJt YW5lbnRseSgpLgorCisgICAgICAgICogU2hhcmVkL21hYy9TYW5kYm94RXh0ZW5zaW9uTWFjLm1t OgorICAgICAgICAoV2ViS2l0OjpTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGUpOiBGb3Ig bm93LCBhZGRlZCBsb2dnaW5nIHdoZW4gZXh0ZW5zaW9uCisgICAgICAgIGNyZWF0aW9uIGZhaWxz LiBJZiB0aGF0IHByb3ZlcyBpbnN1ZmZpY2llbnRseSBoZWxwZnVsIGluIHByYWN0aWNlLCB3ZSBj YW4gY2hhbmdlCisgICAgICAgIHRvIGEgQ1JBU0goKSBsYXRlci4KKyAgICAgICAgKFdlYktpdDo6 U2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlRm9yVGVtcG9yYXJ5RmlsZSk6IERpdHRvLgor ICAgICAgICAoV2ViS2l0OjpTYW5kYm94RXh0ZW5zaW9uOjpjb25zdW1lUGVybWFuZW50bHkpOiBH cmFjZWZ1bGx5IGZhaWwgaWYgdGhlcmUgaXMgbm8gZXh0ZW5zaW9uCisgICAgICAgIHRvIGNvbnN1 bWUuCisKIDIwMTMtMDMtMDUgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAg ICBGb2xsb3cgdXAgdG8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MTQ1MywgZm9yZ290IHRvIG1hcmsgdGhlIGZpbGVzIGFzIFByaXZhdGUuCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvbWFjL1NhbmRib3hFeHRlbnNpb25NYWMubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9TYW5kYm94RXh0ZW5zaW9uTWFjLm1tCShyZXZpc2lv biAxNDQ3NzApCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1NhbmRib3hFeHRlbnNpb25N YWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTIxNiw2ICsyMTYsOCBAQCB2b2lkIFNhbmRib3hFeHRl bnNpb246OmNyZWF0ZUhhbmRsZShjb25zCiAKICAgICBDU3RyaW5nIHN0YW5kYXJkaXplZFBhdGgg PSByZXNvbHZlU3ltbGlua3NJblBhdGgoW1soTlNTdHJpbmcgKilwYXRoIHN0cmluZ0J5U3RhbmRh cmRpemluZ1BhdGhdIGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbl0pOwogICAgIGhhbmRsZS5tX3Nh bmRib3hFeHRlbnNpb24gPSBXS1NhbmRib3hFeHRlbnNpb25DcmVhdGUoc3RhbmRhcmRpemVkUGF0 aC5kYXRhKCksIHdrU2FuZGJveEV4dGVuc2lvblR5cGUodHlwZSkpOworICAgIGlmICghaGFuZGxl Lm1fc2FuZGJveEV4dGVuc2lvbikKKyAgICAgICAgV1RGTG9nQWx3YXlzKCJDb3VsZCBub3QgY3Jl YXRlIGEgc2FuZGJveCBleHRlbnNpb24gZm9yICclcyciLCBwYXRoLnV0ZjgoKS5kYXRhKCkpOwog fQogCiB2b2lkIFNhbmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZUZvclJlYWRXcml0ZURpcmVj dG9yeShjb25zdCBTdHJpbmcmIHBhdGgsIFNhbmRib3hFeHRlbnNpb246OkhhbmRsZSYgaGFuZGxl KQpAQCAtMjUwLDYgKzI1Miw3IEBAIFN0cmluZyBTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5k bGVGb3IKICAgICBoYW5kbGUubV9zYW5kYm94RXh0ZW5zaW9uID0gV0tTYW5kYm94RXh0ZW5zaW9u Q3JlYXRlKGZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihwYXRoLmRhdGEoKSkuZGF0YSgpLCB3a1Nh bmRib3hFeHRlbnNpb25UeXBlKHR5cGUpKTsKIAogICAgIGlmICghaGFuZGxlLm1fc2FuZGJveEV4 dGVuc2lvbikgeworICAgICAgICBXVEZMb2dBbHdheXMoIkNvdWxkIG5vdCBjcmVhdGUgYSBzYW5k Ym94IGV4dGVuc2lvbiBmb3IgdGVtcG9yYXJ5IGZpbGUgJyVzJyIsIHBhdGguZGF0YSgpKTsKICAg ICAgICAgcmV0dXJuIFN0cmluZygpOwogICAgIH0KICAgICByZXR1cm4gU3RyaW5nKHBhdGguZGF0 YSgpKTsKQEAgLTMwMyw3ICszMDYsOCBAQCBib29sIFNhbmRib3hFeHRlbnNpb246OmNvbnN1bWVQ ZXJtYW5lbnRsCiAKIGJvb2wgU2FuZGJveEV4dGVuc2lvbjo6Y29uc3VtZVBlcm1hbmVudGx5KGNv bnN0IEhhbmRsZSYgaGFuZGxlKQogewotICAgIEFTU0VSVChoYW5kbGUubV9zYW5kYm94RXh0ZW5z aW9uKTsKKyAgICBpZiAoIWhhbmRsZS5tX3NhbmRib3hFeHRlbnNpb24pCisgICAgICAgIHJldHVy biBmYWxzZTsKIAogICAgIGJvb2wgcmVzdWx0ID0gV0tTYW5kYm94RXh0ZW5zaW9uQ29uc3VtZSho YW5kbGUubV9zYW5kYm94RXh0ZW5zaW9uKTsKICAgICAK