111450 2013-03-05 09:39:55 -0800 GetnUniform*vEXT (Robustness extension) passed incorrect parameter in WebGLRenderingContext 2013-03-11 12:52:15 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rsarvaria webkit-unassigned dino esprehn+autocc ojan.autocc rwlbuis webkit.review.bot oldest_to_newest 847752 0 rsarvaria 2013-03-05 09:39:55 -0800 According to the robustness spec, GetnUniform*vEXT expects a parameter "sizei bufSize" which sets the number of bytes to be written. In the current implementation they pass the maximum number of entries that can be written instead of the amount of bytes. 847845 1 191517 rsarvaria 2013-03-05 11:16:33 -0800 Created attachment 191517 Patch 848865 2 191751 rsarvaria 2013-03-06 07:55:11 -0800 Created attachment 191751 Patch 848993 3 191779 rsarvaria 2013-03-06 09:54:38 -0800 Created attachment 191779 Patch 849101 4 191779 rwlbuis 2013-03-06 11:10:42 -0800 Comment on attachment 191779 Patch Is there some scenario where the problem is shown? Ideal would be if there was a test showing the problem. 849173 5 rsarvaria 2013-03-06 12:13:29 -0800 It showed up in the DRT test fast/canvas/webgl/gl-object-get-calls.html 850323 6 rwlbuis 2013-03-07 11:28:20 -0800 (In reply to comment #5) > It showed up in the DRT test fast/canvas/webgl/gl-object-get-calls.html What effect does your change have on this test? Is it an improvement? If the test result is different you may need to add the new test result to your patch. 852455 7 rsarvaria 2013-03-11 10:40:35 -0700 There is no change to the actual test. 852512 8 rwlbuis 2013-03-11 11:32:16 -0700 (In reply to comment #7) > There is no change to the actual test. Ok, then we need to go back to your earlier remark: > It showed up in the DRT test fast/canvas/webgl/gl-object-get-calls.html How did it show up, as a warning? 852592 9 191779 rwlbuis 2013-03-11 12:42:12 -0700 Comment on attachment 191779 Patch Ok. 852606 10 191779 webkit.review.bot 2013-03-11 12:52:11 -0700 Comment on attachment 191779 Patch Clearing flags on attachment: 191779 Committed r145387: <http://trac.webkit.org/changeset/145387> 852607 11 webkit.review.bot 2013-03-11 12:52:15 -0700 All reviewed patches have been landed. Closing bug. 191517 2013-03-05 11:16:33 -0800 2013-03-06 07:55:08 -0800 Patch bug-111450-20130305091400.patch text/plain 3083 rsarvaria U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTVjNzFjMDZmN2VmZDI4 YzBmNDExZTczZmQ4ZWMyYzk4MzFkMGEwZC4uYjdiMmRiZWRjMWUwNDc4ODUxNTlkMThhZDhlYjY4 MDk5ZTkwZTE3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTA1ICBSYWpl ZXYgU2FydmFyaWEgIDxyc2FydmFyaWFAYmxhY2tiZXJyeS5jb20+CisKKyAgICAgICAgR2V0blVu aWZvcm0qdkVYVCAoUm9idXN0bmVzcyBleHRlbnNpb24pIHBhc3NlZCBpbmNvcnJlY3QgcGFyYW1l dGVyIGluIFdlYkdMUmVuZGVyaW5nQ29udGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNDUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQnVmc2l6ZSBhcmd1bWVudCBjb3JyZWN0ZWQgdG8gc2l6ZSBp biBieXRlcyBpbnN0ZWFkIG9mIG51bWJlciBvZiBpbnRlZ2VycyBvciBmbG9hdHMuCisKKyAgICAg ICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2Vi Q29yZSk6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZv cm0pOgorCiAyMDEzLTAyLTI4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmVydCBhbiBlcnJvbmVvdXMgY2hhbmdlIGluIHIxNDQzMzYuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRl eCBkZWI2NGIxMDI0MWExNGU4N2Y3ZWUyYjQzYTEzMGE2ZjYwYTExZDU1Li5mYmNkNGNlYTE1YmRh Yjk4MzhjZDYwYjZmMDY3OWM5YWNkOGNjMWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKQEAgLTMxMTYsNyArMzExNiw3 IEBAIFdlYkdMR2V0SW5mbyBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZvcm0oV2ViR0xQ cm9ncmFtKiBwcm9ncmFtLCBjb25zdCBXZWJHCiAgICAgICAgICAgICAgICAgY2FzZSBHcmFwaGlj c0NvbnRleHQzRDo6RkxPQVQ6IHsKICAgICAgICAgICAgICAgICAgICAgR0MzRGZsb2F0IHZhbHVl WzE2XSA9IHswfTsKICAgICAgICAgICAgICAgICAgICAgaWYgKG1faXNSb2J1c3RuZXNzRVhUU3Vw cG9ydGVkKQotICAgICAgICAgICAgICAgICAgICAgICAgbV9jb250ZXh0LT5nZXRFeHRlbnNpb25z KCktPmdldG5Vbmlmb3JtZnZFWFQob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBsb2NhdGlvbiwgMTYs IHZhbHVlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9u cygpLT5nZXRuVW5pZm9ybWZ2RVhUKG9iamVjdE9yWmVybyhwcm9ncmFtKSwgbG9jYXRpb24sIDY0 LCB2YWx1ZSk7CiAgICAgICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAg ICAgIG1fY29udGV4dC0+Z2V0VW5pZm9ybWZ2KG9iamVjdE9yWmVybyhwcm9ncmFtKSwgbG9jYXRp b24sIHZhbHVlKTsKICAgICAgICAgICAgICAgICAgICAgaWYgKGxlbmd0aCA9PSAxKQpAQCAtMzEy Niw3ICszMTI2LDcgQEAgV2ViR0xHZXRJbmZvIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0VW5p Zm9ybShXZWJHTFByb2dyYW0qIHByb2dyYW0sIGNvbnN0IFdlYkcKICAgICAgICAgICAgICAgICBj YXNlIEdyYXBoaWNzQ29udGV4dDNEOjpJTlQ6IHsKICAgICAgICAgICAgICAgICAgICAgR0MzRGlu dCB2YWx1ZVs0XSA9IHswfTsKICAgICAgICAgICAgICAgICAgICAgaWYgKG1faXNSb2J1c3RuZXNz RVhUU3VwcG9ydGVkKQotICAgICAgICAgICAgICAgICAgICAgICAgbV9jb250ZXh0LT5nZXRFeHRl bnNpb25zKCktPmdldG5Vbmlmb3JtaXZFWFQob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBsb2NhdGlv biwgNCwgdmFsdWUpOworICAgICAgICAgICAgICAgICAgICAgICAgbV9jb250ZXh0LT5nZXRFeHRl bnNpb25zKCktPmdldG5Vbmlmb3JtaXZFWFQob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBsb2NhdGlv biwgMTYsIHZhbHVlKTsKICAgICAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAg ICAgICAgICAgbV9jb250ZXh0LT5nZXRVbmlmb3JtaXYob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBs b2NhdGlvbiwgdmFsdWUpOwogICAgICAgICAgICAgICAgICAgICBpZiAobGVuZ3RoID09IDEpCkBA IC0zMTM2LDcgKzMxMzYsNyBAQCBXZWJHTEdldEluZm8gV2ViR0xSZW5kZXJpbmdDb250ZXh0Ojpn ZXRVbmlmb3JtKFdlYkdMUHJvZ3JhbSogcHJvZ3JhbSwgY29uc3QgV2ViRwogICAgICAgICAgICAg ICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OkJPT0w6IHsKICAgICAgICAgICAgICAgICAgICAg R0MzRGludCB2YWx1ZVs0XSA9IHswfTsKICAgICAgICAgICAgICAgICAgICAgaWYgKG1faXNSb2J1 c3RuZXNzRVhUU3VwcG9ydGVkKQotICAgICAgICAgICAgICAgICAgICAgICAgbV9jb250ZXh0LT5n ZXRFeHRlbnNpb25zKCktPmdldG5Vbmlmb3JtaXZFWFQob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBs b2NhdGlvbiwgNCwgdmFsdWUpOworICAgICAgICAgICAgICAgICAgICAgICAgbV9jb250ZXh0LT5n ZXRFeHRlbnNpb25zKCktPmdldG5Vbmlmb3JtaXZFWFQob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBs b2NhdGlvbiwgMTYsIHZhbHVlKTsKICAgICAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAg ICAgICAgICAgICAgICAgbV9jb250ZXh0LT5nZXRVbmlmb3JtaXYob2JqZWN0T3JaZXJvKHByb2dy YW0pLCBsb2NhdGlvbiwgdmFsdWUpOwogICAgICAgICAgICAgICAgICAgICBpZiAobGVuZ3RoID4g MSkgewo= 191751 2013-03-06 07:55:11 -0800 2013-03-06 09:54:34 -0800 Patch bug-111450-20130306055239.patch text/plain 3125 rsarvaria U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTVjNzFjMDZmN2VmZDI4 YzBmNDExZTczZmQ4ZWMyYzk4MzFkMGEwZC4uYjdiMmRiZWRjMWUwNDc4ODUxNTlkMThhZDhlYjY4 MDk5ZTkwZTE3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTA1ICBSYWpl ZXYgU2FydmFyaWEgIDxyc2FydmFyaWFAYmxhY2tiZXJyeS5jb20+CisKKyAgICAgICAgR2V0blVu aWZvcm0qdkVYVCAoUm9idXN0bmVzcyBleHRlbnNpb24pIHBhc3NlZCBpbmNvcnJlY3QgcGFyYW1l dGVyIGluIFdlYkdMUmVuZGVyaW5nQ29udGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNDUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQnVmc2l6ZSBhcmd1bWVudCBjb3JyZWN0ZWQgdG8gc2l6ZSBp biBieXRlcyBpbnN0ZWFkIG9mIG51bWJlciBvZiBpbnRlZ2VycyBvciBmbG9hdHMuCisKKyAgICAg ICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2Vi Q29yZSk6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZv cm0pOgorCiAyMDEzLTAyLTI4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmVydCBhbiBlcnJvbmVvdXMgY2hhbmdlIGluIHIxNDQzMzYuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRl eCBkZWI2NGIxMDI0MWExNGU4N2Y3ZWUyYjQzYTEzMGE2ZjYwYTExZDU1Li5jOTQ0ZDA4OWZhMDY5 YmNhNjM4NDVmZjQyMWMwYmZiYTdkNGFmNmJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKQEAgLTMxMTYsNyArMzExNiw3 IEBAIFdlYkdMR2V0SW5mbyBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZvcm0oV2ViR0xQ cm9ncmFtKiBwcm9ncmFtLCBjb25zdCBXZWJHCiAgICAgICAgICAgICAgICAgY2FzZSBHcmFwaGlj c0NvbnRleHQzRDo6RkxPQVQ6IHsKICAgICAgICAgICAgICAgICAgICAgR0MzRGZsb2F0IHZhbHVl WzE2XSA9IHswfTsKICAgICAgICAgICAgICAgICAgICAgaWYgKG1faXNSb2J1c3RuZXNzRVhUU3Vw cG9ydGVkKQotICAgICAgICAgICAgICAgICAgICAgICAgbV9jb250ZXh0LT5nZXRFeHRlbnNpb25z KCktPmdldG5Vbmlmb3JtZnZFWFQob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBsb2NhdGlvbiwgMTYs IHZhbHVlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9u cygpLT5nZXRuVW5pZm9ybWZ2RVhUKG9iamVjdE9yWmVybyhwcm9ncmFtKSwgbG9jYXRpb24sIDE2 ICogc2l6ZW9mKGZsb2F0KSwgdmFsdWUpOwogICAgICAgICAgICAgICAgICAgICBlbHNlCiAgICAg ICAgICAgICAgICAgICAgICAgICBtX2NvbnRleHQtPmdldFVuaWZvcm1mdihvYmplY3RPclplcm8o cHJvZ3JhbSksIGxvY2F0aW9uLCB2YWx1ZSk7CiAgICAgICAgICAgICAgICAgICAgIGlmIChsZW5n dGggPT0gMSkKQEAgLTMxMjYsNyArMzEyNiw3IEBAIFdlYkdMR2V0SW5mbyBXZWJHTFJlbmRlcmlu Z0NvbnRleHQ6OmdldFVuaWZvcm0oV2ViR0xQcm9ncmFtKiBwcm9ncmFtLCBjb25zdCBXZWJHCiAg ICAgICAgICAgICAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6SU5UOiB7CiAgICAgICAgICAg ICAgICAgICAgIEdDM0RpbnQgdmFsdWVbNF0gPSB7MH07CiAgICAgICAgICAgICAgICAgICAgIGlm IChtX2lzUm9idXN0bmVzc0VYVFN1cHBvcnRlZCkKLSAgICAgICAgICAgICAgICAgICAgICAgIG1f Y29udGV4dC0+Z2V0RXh0ZW5zaW9ucygpLT5nZXRuVW5pZm9ybWl2RVhUKG9iamVjdE9yWmVybyhw cm9ncmFtKSwgbG9jYXRpb24sIDQsIHZhbHVlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIG1f Y29udGV4dC0+Z2V0RXh0ZW5zaW9ucygpLT5nZXRuVW5pZm9ybWl2RVhUKG9iamVjdE9yWmVybyhw cm9ncmFtKSwgbG9jYXRpb24sIDQgKiBzaXplb2YoaW50KSwgdmFsdWUpOwogICAgICAgICAgICAg ICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgICAgICAgICBtX2NvbnRleHQtPmdldFVuaWZv cm1pdihvYmplY3RPclplcm8ocHJvZ3JhbSksIGxvY2F0aW9uLCB2YWx1ZSk7CiAgICAgICAgICAg ICAgICAgICAgIGlmIChsZW5ndGggPT0gMSkKQEAgLTMxMzYsNyArMzEzNiw3IEBAIFdlYkdMR2V0 SW5mbyBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZvcm0oV2ViR0xQcm9ncmFtKiBwcm9n cmFtLCBjb25zdCBXZWJHCiAgICAgICAgICAgICAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6 Qk9PTDogewogICAgICAgICAgICAgICAgICAgICBHQzNEaW50IHZhbHVlWzRdID0gezB9OwogICAg ICAgICAgICAgICAgICAgICBpZiAobV9pc1JvYnVzdG5lc3NFWFRTdXBwb3J0ZWQpCi0gICAgICAg ICAgICAgICAgICAgICAgICBtX2NvbnRleHQtPmdldEV4dGVuc2lvbnMoKS0+Z2V0blVuaWZvcm1p dkVYVChvYmplY3RPclplcm8ocHJvZ3JhbSksIGxvY2F0aW9uLCA0LCB2YWx1ZSk7CisgICAgICAg ICAgICAgICAgICAgICAgICBtX2NvbnRleHQtPmdldEV4dGVuc2lvbnMoKS0+Z2V0blVuaWZvcm1p dkVYVChvYmplY3RPclplcm8ocHJvZ3JhbSksIGxvY2F0aW9uLCA0ICogc2l6ZW9mKGludCksIHZh bHVlKTsKICAgICAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICAgICAg bV9jb250ZXh0LT5nZXRVbmlmb3JtaXYob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBsb2NhdGlvbiwg dmFsdWUpOwogICAgICAgICAgICAgICAgICAgICBpZiAobGVuZ3RoID4gMSkgewo= 191779 2013-03-06 09:54:38 -0800 2013-03-11 12:52:11 -0700 Patch bug-111450-20130306075205.patch text/plain 3137 rsarvaria U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0MzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTVjNzFjMDZmN2VmZDI4 YzBmNDExZTczZmQ4ZWMyYzk4MzFkMGEwZC4uYjdiMmRiZWRjMWUwNDc4ODUxNTlkMThhZDhlYjY4 MDk5ZTkwZTE3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTA1ICBSYWpl ZXYgU2FydmFyaWEgIDxyc2FydmFyaWFAYmxhY2tiZXJyeS5jb20+CisKKyAgICAgICAgR2V0blVu aWZvcm0qdkVYVCAoUm9idXN0bmVzcyBleHRlbnNpb24pIHBhc3NlZCBpbmNvcnJlY3QgcGFyYW1l dGVyIGluIFdlYkdMUmVuZGVyaW5nQ29udGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNDUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQnVmc2l6ZSBhcmd1bWVudCBjb3JyZWN0ZWQgdG8gc2l6ZSBp biBieXRlcyBpbnN0ZWFkIG9mIG51bWJlciBvZiBpbnRlZ2VycyBvciBmbG9hdHMuCisKKyAgICAg ICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2Vi Q29yZSk6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZv cm0pOgorCiAyMDEzLTAyLTI4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmVydCBhbiBlcnJvbmVvdXMgY2hhbmdlIGluIHIxNDQzMzYuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRl eCBkZWI2NGIxMDI0MWExNGU4N2Y3ZWUyYjQzYTEzMGE2ZjYwYTExZDU1Li44YWY0MGFmMjdlODI4 N2RlMDY4NGNmNGM1ZDgzOWZiZWIzYjVhYTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKQEAgLTMxMTYsNyArMzExNiw3 IEBAIFdlYkdMR2V0SW5mbyBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFVuaWZvcm0oV2ViR0xQ cm9ncmFtKiBwcm9ncmFtLCBjb25zdCBXZWJHCiAgICAgICAgICAgICAgICAgY2FzZSBHcmFwaGlj c0NvbnRleHQzRDo6RkxPQVQ6IHsKICAgICAgICAgICAgICAgICAgICAgR0MzRGZsb2F0IHZhbHVl WzE2XSA9IHswfTsKICAgICAgICAgICAgICAgICAgICAgaWYgKG1faXNSb2J1c3RuZXNzRVhUU3Vw cG9ydGVkKQotICAgICAgICAgICAgICAgICAgICAgICAgbV9jb250ZXh0LT5nZXRFeHRlbnNpb25z KCktPmdldG5Vbmlmb3JtZnZFWFQob2JqZWN0T3JaZXJvKHByb2dyYW0pLCBsb2NhdGlvbiwgMTYs IHZhbHVlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9u cygpLT5nZXRuVW5pZm9ybWZ2RVhUKG9iamVjdE9yWmVybyhwcm9ncmFtKSwgbG9jYXRpb24sIDE2 ICogc2l6ZW9mKEdDM0RmbG9hdCksIHZhbHVlKTsKICAgICAgICAgICAgICAgICAgICAgZWxzZQog ICAgICAgICAgICAgICAgICAgICAgICAgbV9jb250ZXh0LT5nZXRVbmlmb3JtZnYob2JqZWN0T3Ja ZXJvKHByb2dyYW0pLCBsb2NhdGlvbiwgdmFsdWUpOwogICAgICAgICAgICAgICAgICAgICBpZiAo bGVuZ3RoID09IDEpCkBAIC0zMTI2LDcgKzMxMjYsNyBAQCBXZWJHTEdldEluZm8gV2ViR0xSZW5k ZXJpbmdDb250ZXh0OjpnZXRVbmlmb3JtKFdlYkdMUHJvZ3JhbSogcHJvZ3JhbSwgY29uc3QgV2Vi RwogICAgICAgICAgICAgICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OklOVDogewogICAgICAg ICAgICAgICAgICAgICBHQzNEaW50IHZhbHVlWzRdID0gezB9OwogICAgICAgICAgICAgICAgICAg ICBpZiAobV9pc1JvYnVzdG5lc3NFWFRTdXBwb3J0ZWQpCi0gICAgICAgICAgICAgICAgICAgICAg ICBtX2NvbnRleHQtPmdldEV4dGVuc2lvbnMoKS0+Z2V0blVuaWZvcm1pdkVYVChvYmplY3RPclpl cm8ocHJvZ3JhbSksIGxvY2F0aW9uLCA0LCB2YWx1ZSk7CisgICAgICAgICAgICAgICAgICAgICAg ICBtX2NvbnRleHQtPmdldEV4dGVuc2lvbnMoKS0+Z2V0blVuaWZvcm1pdkVYVChvYmplY3RPclpl cm8ocHJvZ3JhbSksIGxvY2F0aW9uLCA0ICogc2l6ZW9mKEdDM0RpbnQpLCB2YWx1ZSk7CiAgICAg ICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgICAgIG1fY29udGV4dC0+ Z2V0VW5pZm9ybWl2KG9iamVjdE9yWmVybyhwcm9ncmFtKSwgbG9jYXRpb24sIHZhbHVlKTsKICAg ICAgICAgICAgICAgICAgICAgaWYgKGxlbmd0aCA9PSAxKQpAQCAtMzEzNiw3ICszMTM2LDcgQEAg V2ViR0xHZXRJbmZvIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0VW5pZm9ybShXZWJHTFByb2dy YW0qIHByb2dyYW0sIGNvbnN0IFdlYkcKICAgICAgICAgICAgICAgICBjYXNlIEdyYXBoaWNzQ29u dGV4dDNEOjpCT09MOiB7CiAgICAgICAgICAgICAgICAgICAgIEdDM0RpbnQgdmFsdWVbNF0gPSB7 MH07CiAgICAgICAgICAgICAgICAgICAgIGlmIChtX2lzUm9idXN0bmVzc0VYVFN1cHBvcnRlZCkK LSAgICAgICAgICAgICAgICAgICAgICAgIG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9ucygpLT5nZXRu VW5pZm9ybWl2RVhUKG9iamVjdE9yWmVybyhwcm9ncmFtKSwgbG9jYXRpb24sIDQsIHZhbHVlKTsK KyAgICAgICAgICAgICAgICAgICAgICAgIG1fY29udGV4dC0+Z2V0RXh0ZW5zaW9ucygpLT5nZXRu VW5pZm9ybWl2RVhUKG9iamVjdE9yWmVybyhwcm9ncmFtKSwgbG9jYXRpb24sIDQgKiBzaXplb2Yo R0MzRGludCksIHZhbHVlKTsKICAgICAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAg ICAgICAgICAgICAgbV9jb250ZXh0LT5nZXRVbmlmb3JtaXYob2JqZWN0T3JaZXJvKHByb2dyYW0p LCBsb2NhdGlvbiwgdmFsdWUpOwogICAgICAgICAgICAgICAgICAgICBpZiAobGVuZ3RoID4gMSkg ewo=