111448 2013-03-05 09:07:25 -0800 [GTK][WK2] Implement WebInspector::localizedStringsURL() to return the file URL of localizedStrings.js 2013-03-06 14:28:59 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis andersca cgarcia gustavo mrobinson sam webkit.review.bot oldest_to_newest 847731 0 naginenis 2013-03-05 09:07:25 -0800 Implement WebInspector::localizedStringsURL() method, so that it will prevent printing warnings about "Localized string not found" in the console when the Web Inspector opened. 848759 1 191729 naginenis 2013-03-06 05:41:37 -0800 Created attachment 191729 Patch 848849 2 mrobinson 2013-03-06 07:35:48 -0800 I wonder if this should be included in the GResources bundle. What do you think Carlos? 848864 3 cgarcia 2013-03-06 07:54:58 -0800 We don't have GResource bundle yet, no? my plan was to include all the inspector resources as a GResource in the library itself, to avoid the problems of resources not found when not installed and to avoid a lot of disk io. 848872 4 mrobinson 2013-03-06 08:05:25 -0800 (In reply to comment #3) > We don't have GResource bundle yet, no? my plan was to include all the inspector resources as a GResource in the library itself, to avoid the problems of resources not found when not installed and to avoid a lot of disk io. Sorry. I thought inspector resources were already stored as GResource data in the library itself. If not, this patch seems fine to me. 848873 5 cgarcia 2013-03-06 08:11:42 -0800 (In reply to comment #4) > (In reply to comment #3) > > We don't have GResource bundle yet, no? my plan was to include all the inspector resources as a GResource in the library itself, to avoid the problems of resources not found when not installed and to avoid a lot of disk io. > > Sorry. I thought inspector resources were already stored as GResource data in the library itself. If not, this patch seems fine to me. For now it's only a plan, the main problem is that we would need to bump glib (and probably libsoup) requirements, or do both, install the resources and compile them as a gresource, falling back to the installed files if the resources are not present in the library. 848878 6 mrobinson 2013-03-06 08:17:33 -0800 Maybe a WebKit2 owner could put the final stamp on this one? 849282 7 191729 naginenis 2013-03-06 14:12:34 -0800 Comment on attachment 191729 Patch Thanks for reviewing. 849299 8 191729 webkit.review.bot 2013-03-06 14:28:56 -0800 Comment on attachment 191729 Patch Clearing flags on attachment: 191729 Committed r144982: <http://trac.webkit.org/changeset/144982> 849300 9 webkit.review.bot 2013-03-06 14:28:59 -0800 All reviewed patches have been landed. Closing bug. 191729 2013-03-06 05:41:37 -0800 2013-03-06 14:28:55 -0800 Patch 111448.patch text/plain 2078 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2ZjM1ZGJmLi45YTdhYWE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDMtMDYgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW0dUS11bV0syXSBJbXBsZW1lbnQgV2ViSW5zcGVjdG9yOjps b2NhbGl6ZWRTdHJpbmdzVVJMKCkgdG8gcmV0dXJuIHRoZSBmaWxlIFVSTCBvZiBsb2NhbGl6ZWRT dHJpbmdzLmpzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTE0NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbXBsZW1lbnQgV2ViSW5zcGVjdG9yOjpsb2NhbGl6ZWRTdHJpbmdzVVJMKCkgbWV0aG9kIHRv IHJldHVybiB0aGUKKyAgICAgICAgZmlsZSBVUkwgb2YgdGhlIGxvY2FsaXplZFN0cmluZ3MuanMu CisKKyAgICAgICAgVGhpcyBwcmV2ZW50cyBwcmludGluZyB3YXJuaW5ncyBhYm91dCAiTG9jYWxp emVkIHN0cmluZyBub3QgZm91bmQiIGluCisgICAgICAgIHRoZSBjb25zb2xlLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9XZWJJbnNwZWN0b3JHdGsuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJJbnNwZWN0b3I6OmxvY2FsaXplZFN0cmluZ3NVUkwpOgorCiAyMDEzLTAzLTA2 ICBMdWl6IEFnb3N0aW5pICA8bHVpei5hZ29zdGluaUBub2tpYS5jb20+CiAKICAgICAgICAgQWNj ZWxlcmF0ZWQgb3ZlcmZsb3cgc2Nyb2xsaW5nIGZvciBDb29yZGluYXRlZCBHcmFwaGljcy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2ViSW5zcGVj dG9yR3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2ViSW5z cGVjdG9yR3RrLmNwcAppbmRleCBlMDBlNDM3Li5lYjc5ZjU5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYkluc3BlY3Rvckd0ay5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9XZWJJbnNwZWN0b3JHdGsuY3Bw CkBAIC0yOSwxNSArMjksMjQgQEAKIAogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAKLSNpbmNsdWRl IDxXZWJDb3JlL05vdEltcGxlbWVudGVkLmg+CisjaW5jbHVkZSA8V2ViQ29yZS9GaWxlU3lzdGVt Lmg+CisjaW5jbHVkZSA8Z2xpYi5oPgorI2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dPd25QdHIuaD4K ICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAogbmFtZXNwYWNlIFdlYktpdCB7CiAK IFN0cmluZyBXZWJJbnNwZWN0b3I6OmxvY2FsaXplZFN0cmluZ3NVUkwoKSBjb25zdAogewotICAg IG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIFN0cmluZygpOworICAgIEdPd25QdHI8Z2No YXI+IGZpbGVQYXRoOworICAgIGNvbnN0IGdjaGFyKiBlbnZpcm9ubWVudFBhdGggPSBnX2dldGVu digiV0VCS0lUX0lOU1BFQ1RPUl9QQVRIIik7CisgICAgaWYgKGVudmlyb25tZW50UGF0aCAmJiBn X2ZpbGVfdGVzdChlbnZpcm9ubWVudFBhdGgsIEdfRklMRV9URVNUX0lTX0RJUikpCisgICAgICAg IGZpbGVQYXRoLnNldChnX2J1aWxkX2ZpbGVuYW1lKGVudmlyb25tZW50UGF0aCwgImxvY2FsaXpl ZFN0cmluZ3MuanMiLCBOVUxMKSk7CisgICAgZWxzZQorICAgICAgICBmaWxlUGF0aC5zZXQoZ19i dWlsZF9maWxlbmFtZShXZWJDb3JlOjpzaGFyZWRSZXNvdXJjZXNQYXRoKCkuZGF0YSgpLCAid2Vi aW5zcGVjdG9yIiwgImxvY2FsaXplZFN0cmluZ3MuanMiLCBOVUxMKSk7CisKKyAgICBHT3duUHRy PGdjaGFyPiBmaWxlVVJJKGdfZmlsZW5hbWVfdG9fdXJpKGZpbGVQYXRoLmdldCgpLCAwLCAwKSk7 CisgICAgcmV0dXJuIFdlYkNvcmU6OmZpbGVuYW1lVG9TdHJpbmcoZmlsZVVSSS5nZXQoKSk7CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=