111445 2013-03-05 08:56:10 -0800 [BlackBerry] Authentication credentials lost when opening a new tab 2013-03-05 10:07:31 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 otcheung webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 847719 0 otcheung 2013-03-05 08:56:10 -0800 CredentialStorage is cleared when the chrome switches tabs 847732 1 191507 otcheung 2013-03-05 09:08:21 -0800 Created attachment 191507 Patch 847739 2 191507 rwlbuis 2013-03-05 09:16:36 -0800 Comment on attachment 191507 Patch LGTM. 847775 3 191507 webkit.review.bot 2013-03-05 10:07:27 -0800 Comment on attachment 191507 Patch Clearing flags on attachment: 191507 Committed r144772: <http://trac.webkit.org/changeset/144772> 847776 4 webkit.review.bot 2013-03-05 10:07:31 -0800 All reviewed patches have been landed. Closing bug. 191507 2013-03-05 09:08:21 -0800 2013-03-05 10:07:26 -0800 Patch bug-111445-20130305120428.patch text/plain 3724 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA3NzI3NGM1NjkwY2QwZDlkYzFjMmJjNDM2MzI1NzI4NWMwYjQ0NjhkLi5mZDBhMDNjYThk ODZhYzFhZmEzNjM5ZThlNDc2MjZjM2QzM2M2ZDJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMy0wMy0wNSAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBBdXRoZW50aWNhdGlvbiBj cmVkZW50aWFscyBsb3N0IHdoZW4gb3BlbmluZyBhIG5ldyB0YWIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTQ0NQorCisgICAgICAgIFBSIDI4NjYy NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBJbnRlcm5h bGx5IFJldmlld2VkIGJ5IExpYW5naHVpIENoZW4uCisKKyAgICAgICAgUHJldmVudCBjaGFuZ2lu ZyB0aGUgcHJpdmF0ZSBtb2RlIGJvb2xlYW4gdmFsdWUgaW4gZGlkQ2hhbmdlU2V0dGluZ3MgaWYg dGhlIHZhbHVlCisgICAgICAgIGhhc24ndCBjaGFuZ2VkLgorCisgICAgICAgIFNldHRpbmcgdGhl IHByaXZhdGUgbW9kZSB2YWx1ZSBvZiBjcmVkZW50aWFsc3RvcmFnZSBldmVyeSB0aW1lIGRpZENo YW5nZVNldHRpbmdzIGdldHMKKyAgICAgICAgY2FsbGVkIGNhdXNlcyB0aGUgc2Vzc2lvbiBjcmVk ZW50aWFsIG1hcHBpbmcgdG8gYmUgY2xlYXJlZCBvbiBldmVyeSB0YWIgY2hhbmdlIGluCisgICAg ICAgIG5vbi1wcml2YXRlIG1vZGUuCisKKyAgICAgICAgVGVzdGVkIGNoYW5naW5nIHRhYnMgYWZ0 ZXIgbG9nZ2luZyBpbnRvIGEgc2l0ZSB1c2luZyB0aGUgSFRUUCBCYXNpYyBBdXRoIHByb3RvY29s IHRvIHNlZQorICAgICAgICBpZiB0aGUgY3JlZGVudGlhbHMgYXJlIGNsZWFyZWQuIEFsc28gZW5z dXJlZCB0aGUgZnVuY3Rpb25hbGl0eSBvZiBwcml2YXRlIG1vZGUgaXMgbm90IGNoYW5nZWQuCisK KyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6 OldlYlBhZ2VQcml2YXRlOjpkaWRDaGFuZ2VTZXR0aW5ncyk6CisKIDIwMTMtMDMtMDUgIEFuZHJl dyBMbyAgPGFubG9AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQ2xlYW4gdXAgYW5p bWF0ZWQgc2Nyb2xsL3pvb20gY29kZSBpbiBXZWJQYWdlUHJpdmF0ZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggZTkyMjYwZmY3MjEzNDkyOTdiMzI5ZTQxNGI2 NjA0NWUwMjcyODVjYS4uNDg3MzZhNDFmY2NjYmExNjdhNzdmN2Y2ZDU4NTkwMDQxNTBjZjI5MCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC01OTI5LDcgKzU5 MjksNiBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjpkaWRDaGFuZ2VTZXR0aW5ncyhXZWJTZXR0aW5n cyogd2ViU2V0dGluZ3MpCiAgICAgY29yZVNldHRpbmdzLT5zZXRMb2Fkc0ltYWdlc0F1dG9tYXRp Y2FsbHkod2ViU2V0dGluZ3MtPmxvYWRzSW1hZ2VzQXV0b21hdGljYWxseSgpKTsKICAgICBjb3Jl U2V0dGluZ3MtPnNldFNob3VsZERyYXdCb3JkZXJXaGlsZUxvYWRpbmdJbWFnZXMod2ViU2V0dGlu Z3MtPnNob3VsZERyYXdCb3JkZXJXaGlsZUxvYWRpbmdJbWFnZXMoKSk7CiAgICAgY29yZVNldHRp bmdzLT5zZXRTY3JpcHRFbmFibGVkKHdlYlNldHRpbmdzLT5pc0phdmFTY3JpcHRFbmFibGVkKCkp OwotICAgIGNvcmVTZXR0aW5ncy0+c2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCh3ZWJTZXR0aW5n cy0+aXNQcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpOwogICAgIGNvcmVTZXR0aW5ncy0+c2V0RGV2 aWNlU3VwcG9ydHNNb3VzZSh3ZWJTZXR0aW5ncy0+ZGV2aWNlU3VwcG9ydHNNb3VzZSgpKTsKICAg ICBjb3JlU2V0dGluZ3MtPnNldERlZmF1bHRGaXhlZEZvbnRTaXplKHdlYlNldHRpbmdzLT5kZWZh dWx0Rml4ZWRGb250U2l6ZSgpKTsKICAgICBjb3JlU2V0dGluZ3MtPnNldERlZmF1bHRGb250U2l6 ZSh3ZWJTZXR0aW5ncy0+ZGVmYXVsdEZvbnRTaXplKCkpOwpAQCAtNTk1OCw2ICs1OTU3LDEyIEBA IHZvaWQgV2ViUGFnZVByaXZhdGU6OmRpZENoYW5nZVNldHRpbmdzKFdlYlNldHRpbmdzKiB3ZWJT ZXR0aW5ncykKICAgICBjb3JlU2V0dGluZ3MtPnNldFVzZUNhY2hlKHdlYlNldHRpbmdzLT51c2VX ZWJLaXRDYWNoZSgpKTsKICAgICBjb3JlU2V0dGluZ3MtPnNldENvb2tpZUVuYWJsZWQod2ViU2V0 dGluZ3MtPmFyZUNvb2tpZXNFbmFibGVkKCkpOwogCisgICAgaWYgKGNvcmVTZXR0aW5ncy0+cHJp dmF0ZUJyb3dzaW5nRW5hYmxlZCgpICE9IHdlYlNldHRpbmdzLT5pc1ByaXZhdGVCcm93c2luZ0Vu YWJsZWQoKSkgeworICAgICAgICBjb3JlU2V0dGluZ3MtPnNldFByaXZhdGVCcm93c2luZ0VuYWJs ZWQod2ViU2V0dGluZ3MtPmlzUHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpKTsKKyAgICAgICAgY29v a2llTWFuYWdlcigpLnNldFByaXZhdGVNb2RlKHdlYlNldHRpbmdzLT5pc1ByaXZhdGVCcm93c2lu Z0VuYWJsZWQoKSk7CisgICAgICAgIENyZWRlbnRpYWxTdG9yYWdlOjpzZXRQcml2YXRlTW9kZSh3 ZWJTZXR0aW5ncy0+aXNQcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpOworICAgIH0KKwogI2lmIEVO QUJMRShTUUxfREFUQUJBU0UpCiAgICAgLy8gRGF0YWJhc2VNYW5hZ2VyIGNhbiBvbmx5IGJlIGlu aXRpYWxpemVkIGZvciBvbmNlLCBzbyBpdCBkb2Vzbid0CiAgICAgLy8gbWFrZSBzZW5zZSB0byBj aGFuZ2UgZGF0YWJhc2UgcGF0aCBhZnRlciBEYXRhYmFzZU1hbmFnZXIgaGFzCkBAIC02MDE0LDEw ICs2MDE5LDYgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6ZGlkQ2hhbmdlU2V0dGluZ3MoV2ViU2V0 dGluZ3MqIHdlYlNldHRpbmdzKQogICAgIGNvcmVTZXR0aW5ncy0+c2V0V2ViU2VjdXJpdHlFbmFi bGVkKCF3ZWJTZXR0aW5ncy0+YWxsb3dDcm9zc1NpdGVSZXF1ZXN0cygpKTsKICAgICBjb3JlU2V0 dGluZ3MtPnNldEFwcGx5UGFnZVNjYWxlRmFjdG9ySW5Db21wb3NpdG9yKHdlYlNldHRpbmdzLT5h cHBseURldmljZVNjYWxlRmFjdG9ySW5Db21wb3NpdG9yKCkpOwogCi0gICAgY29va2llTWFuYWdl cigpLnNldFByaXZhdGVNb2RlKHdlYlNldHRpbmdzLT5pc1ByaXZhdGVCcm93c2luZ0VuYWJsZWQo KSk7Ci0KLSAgICBDcmVkZW50aWFsU3RvcmFnZTo6c2V0UHJpdmF0ZU1vZGUod2ViU2V0dGluZ3Mt PmlzUHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCgpKTsKLQogICAgIGlmIChtX21haW5GcmFtZSAmJiBt X21haW5GcmFtZS0+dmlldygpKSB7CiAgICAgICAgIENvbG9yIGJhY2tncm91bmRDb2xvcih3ZWJT ZXR0aW5ncy0+YmFja2dyb3VuZENvbG9yKCkpOwogICAgICAgICBtX21haW5GcmFtZS0+dmlldygp LT51cGRhdGVCYWNrZ3JvdW5kUmVjdXJzaXZlbHkoYmFja2dyb3VuZENvbG9yLCBiYWNrZ3JvdW5k Q29sb3IuaGFzQWxwaGEoKSk7Cg==