111444 2013-03-05 08:53:11 -0800 [BlackBerry] FatFinger pairs the wrong element with fatfinger rect part 2013-03-05 10:28:48 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tijiang webkit-unassigned allan.jensen mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 847717 0 tijiang 2013-03-05 08:53:11 -0800 When we do the fatfinger and try to findIntersectingRegions, we use fatfinger rect subtract element area, which end up we pair the wrong fatfinger rect part, which is outside the chosen element area, with the chosen element. This result adjustedposition is outside of the chosen element. 847721 1 191505 tijiang 2013-03-05 08:58:40 -0800 Created attachment 191505 Patch 847738 2 191505 rwlbuis 2013-03-05 09:13:58 -0800 Comment on attachment 191505 Patch Ok. 847762 3 191505 tonikitoo 2013-03-05 09:53:09 -0800 Comment on attachment 191505 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191505&action=review > Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:382 > - remainingFingerRegion = subtractRegions(remainingFingerRegion, layerRegion); > + remainingFingerRegion = intersectRegions(remainingFingerRegion, layerRegion); that is not right. what does it fix? 847766 4 191505 webkit.review.bot 2013-03-05 09:56:33 -0800 Comment on attachment 191505 Patch Clearing flags on attachment: 191505 Committed r144771: <http://trac.webkit.org/changeset/144771> 847767 5 webkit.review.bot 2013-03-05 09:56:36 -0800 All reviewed patches have been landed. Closing bug. 847805 6 tijiang 2013-03-05 10:28:48 -0800 If we use remainingFingerRegion subtract layerRegion, which will give us a region outside of layerRegion. But when we do checkFingerIntersection, we pair this region with the layer element. This end up a mismatch pair. We should pair the intersected part with the layerRegion element. (In reply to comment #3) > (From update of attachment 191505 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191505&action=review > > > Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:382 > > - remainingFingerRegion = subtractRegions(remainingFingerRegion, layerRegion); > > + remainingFingerRegion = intersectRegions(remainingFingerRegion, layerRegion); > > that is not right. what does it fix? 191505 2013-03-05 08:58:40 -0800 2013-03-05 09:56:33 -0800 Patch bug-111444-20130305115447.patch text/plain 2435 tijiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA3NzI3NGM1NjkwY2QwZDlkYzFjMmJjNDM2MzI1NzI4NWMwYjQ0NjhkLi5iMzgxNWExN2Rk MTE0ZDRjMThhZmFlMGEwNjgzMGU0MzRiMDNkODk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMy0wMy0wNSAgVGlhbmNoZW5nIEppYW5nICA8dGlq aWFuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBGYXRGaW5nZXIgcGFpcnMgdGhl IHdyb25nIGVsZW1lbnQgd2l0aCBmYXRmaW5nZXIgcmVjdCBwYXJ0LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNDQ0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW50ZXJuYWwgUFIgMjY2MjE0CisgICAg ICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgR2VuZXZpZXZlIE1hay4KKworICAgICAgICBJbnN0 ZWFkIG9mIHN1YnRyYWN0aW5nIHdpdGggdGhlIGVsZW1lbnQgcmVnaW9uLCB3ZSBzaG91bGQgZ2V0 IHRoZSByZW1haW5pbmcKKyAgICAgICAgcmVjdCBieSBmaW5kIHRoZSBpbnRlcnNlY3QgcmVnaW9u IG9mIGVsZW1lbnQgcmVnaW9uIGFuZCBmYXRmaW5nZXIgZGV0ZWN0aW9uCisgICAgICAgIHJlZ2lv bi4KKworCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9GYXRGaW5nZXJzLmNwcDoKKyAgICAgICAg KEJsYWNrQmVycnk6OldlYktpdDo6RmF0RmluZ2Vyczo6Y2hlY2tGb3JDbGlja2FibGVFbGVtZW50 KToKKwogMjAxMy0wMy0wNSAgQW5kcmV3IExvICA8YW5sb0ByaW0uY29tPgogCiAgICAgICAgIFtC bGFja0JlcnJ5XSBDbGVhbiB1cCBhbmltYXRlZCBzY3JvbGwvem9vbSBjb2RlIGluIFdlYlBhZ2VQ cml2YXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9y dC9GYXRGaW5nZXJzLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L0ZhdEZpbmdlcnMuY3BwCmluZGV4IDAzZDUxNWUyOTE3NGU0NmFhZDIxYzQ3Yzc4NDQ3MzA0Yzcx Y2UxZDQuLjlhYzk3OGU2ODgwMDkxYjdhN2JkNjAwMGMxMzIyZjJjNDA3ZDdiNDkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0ZhdEZpbmdlcnMuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0ZhdEZpbmdlcnMu Y3BwCkBAIC0zNzQsMTIgKzM3NCwxMiBAQCBib29sIEZhdEZpbmdlcnM6OmNoZWNrRm9yQ2xpY2th YmxlRWxlbWVudChFbGVtZW50KiBjdXJFbGVtZW50LAogICAgICAgICBpZiAoY3VyRWxlbWVudFJl bmRlckxheWVyICE9IGxvd2VzdFBvc2l0aW9uZWRFbmNsb3NpbmdMYXllclNvRmFyKSB7CiAKICAg ICAgICAgICAgIC8vIGVsZW1lbnRSZWdpb24gd2lsbCBhbHdheXMgYmUgaW4gY29udGVudHMgY29v cmRpbmF0ZXMgb2YgaXRzIGNvbnRhaW5lciBmcmFtZS4gSXQgbmVlZHMgdG8gYmUKLSAgICAgICAg ICAgIC8vIG1hcHBlZCB0byBtYWluIGZyYW1lIGNvbnRlbnRzIGNvb3JkaW5hdGVzIGluIG9yZGVy IHRvIHN1YnRyYWN0IHRoZSBmaW5nZXJSZWdpb24sIHRoZW4uCisgICAgICAgICAgICAvLyBtYXBw ZWQgdG8gbWFpbiBmcmFtZSBjb250ZW50cyBjb29yZGluYXRlcyBpbiBvcmRlciB0byBpbnRlcnNl Y3QgdGhlIGZpbmdlclJlZ2lvbiwgdGhlbi4KICAgICAgICAgICAgIFdlYkNvcmU6OkludFBvaW50 IGZyYW1lUG9zKG1fd2ViUGFnZS0+ZnJhbWVPZmZzZXQoY3VyRWxlbWVudC0+ZG9jdW1lbnQoKS0+ ZnJhbWUoKSkpOwogICAgICAgICAgICAgSW50UmVjdFJlZ2lvbiBsYXllclJlZ2lvbihQbGF0Zm9y bTo6SW50UmVjdChsb3dlc3RQb3NpdGlvbmVkRW5jbG9zaW5nTGF5ZXJTb0Zhci0+cmVuZGVyZXIo KS0+YWJzb2x1dGVCb3VuZGluZ0JveFJlY3QodHJ1ZS8qdXNlIHRyYW5zZm9ybXMqLykpKTsKICAg ICAgICAgICAgIGxheWVyUmVnaW9uLm1vdmUoZnJhbWVQb3MueCgpLCBmcmFtZVBvcy55KCkpOwog Ci0gICAgICAgICAgICByZW1haW5pbmdGaW5nZXJSZWdpb24gPSBzdWJ0cmFjdFJlZ2lvbnMocmVt YWluaW5nRmluZ2VyUmVnaW9uLCBsYXllclJlZ2lvbik7CisgICAgICAgICAgICByZW1haW5pbmdG aW5nZXJSZWdpb24gPSBpbnRlcnNlY3RSZWdpb25zKHJlbWFpbmluZ0ZpbmdlclJlZ2lvbiwgbGF5 ZXJSZWdpb24pOwogCiAgICAgICAgICAgICBsb3dlc3RQb3NpdGlvbmVkRW5jbG9zaW5nTGF5ZXJT b0ZhciA9IGN1ckVsZW1lbnRSZW5kZXJMYXllcjsKICAgICAgICAgfQo=