111442 2013-03-05 08:04:22 -0800 Web Inspector: Flame Chart. Provide node context info in a popover when mouse hovers over a flame chart item 2013-04-08 12:25:29 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 847689 0 loislo 2013-03-05 08:04:22 -0800 EOM 847693 1 191499 loislo 2013-03-05 08:07:03 -0800 Created attachment 191499 Patch 847702 2 191499 yurys 2013-03-05 08:24:32 -0800 Comment on attachment 191499 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191499&action=review Please attach a screenshot. > Source/WebCore/ChangeLog:8 > + FlameChart creates a fake anchor element and moves it to the right position. Can you rephrase this or add more context? > Source/WebCore/inspector/front-end/FlameChart.js:93 > + if (typeof node === 'undefined' && !this._highlightedNode) Please use " instead of ' > Source/WebCore/inspector/front-end/FlameChart.js:120 > + style.height = this._yScaleFactor + "px"; Consider renaming _yScaleFactor to _barHeight 191499 2013-03-05 08:07:03 -0800 2013-03-05 08:24:32 -0800 Patch bug-111442-20130305200309.patch text/plain 5513 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQ4YjM4OGQ4MjdiODZk MmMwYjhhMGU5YmYzYTJmNDAyZWI0YzhiZC4uZmVhNDY3NDllZjUxYmJlZmZjNWFiNWNiMTMxNzlj MzUxOTYwZmEwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAzLTA1ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBGbGFtZSBDaGFydC4gUHJvdmlkZSBub2RlIGNvbnRleHQgaW5mbyBpbiBhIHBvcG92ZXIg d2hlbiBtb3VzZSBob3ZlcnMgb3ZlciBhIGZsYW1lIGNoYXJ0IGl0ZW0uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE0NDIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGbGFtZUNoYXJ0IGNyZWF0ZXMgYSBm YWtlIGFuY2hvciBlbGVtZW50IGFuZCBtb3ZlcyBpdCB0byB0aGUgcmlnaHQgcG9zaXRpb24uCisK KyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0ZsYW1lQ2hhcnQuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuRmxhbWVDaGFydCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRmxhbWVDaGFy dC5wcm90b3R5cGUuX2dldFBvcG92ZXJBbmNob3IpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkZs YW1lQ2hhcnQucHJvdG90eXBlLl9zaG93UG9wb3Zlcik6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu RmxhbWVDaGFydC5wcm90b3R5cGUuX29uTW91c2VNb3ZlKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5GbGFtZUNoYXJ0LnByb3RvdHlwZS5maW5kTm9kZUNhbGxiYWNrKToKKyAgICAgICAgKFdlYklu c3BlY3Rvci5GbGFtZUNoYXJ0LnByb3RvdHlwZS5fY29vcmRpbmF0ZXNUb05vZGUpOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkZsYW1lQ2hhcnQucHJvdG90eXBlLm9uUmVzaXplKToKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL2ZsYW1lQ2hhcnQuY3NzOgorICAgICAgICAoLmZsYW1lLWNo YXJ0IC5pdGVtLWFuY2hvcik6CisKIDIwMTMtMDMtMDUgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBw bGUuY29tPgogCiAgICAgICAgIEltcHJvdmUgcm9idXN0bmVzcyBvZiBXZWJTUUwgcXVvdGEgbWFu YWdlbWVudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv RmxhbWVDaGFydC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRmxhbWVD aGFydC5qcwppbmRleCBjNGIzMTZlMzYxMDcxYzliMGFkYzI0ZGQ0ODExODRmY2NiZGQxY2ZlLi5h ZDJlMDNlYWViNTBjNDg3ZDc0NmI1MTFkNGYwMDVhZDNmZmE1Y2ExIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ZsYW1lQ2hhcnQuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9GbGFtZUNoYXJ0LmpzCkBAIC00Niw2ICs0Niwx MCBAQCBXZWJJbnNwZWN0b3IuRmxhbWVDaGFydCA9IGZ1bmN0aW9uKGNwdVByb2ZpbGVWaWV3KQog ICAgIHRoaXMuX21pbldpZHRoID0gMzsKICAgICB0aGlzLmVsZW1lbnQub25tb3VzZW1vdmUgPSB0 aGlzLl9vbk1vdXNlTW92ZS5iaW5kKHRoaXMpOwogICAgIHRoaXMuZWxlbWVudC5vbmNsaWNrID0g dGhpcy5fb25DbGljay5iaW5kKHRoaXMpOworICAgIHRoaXMuX3BvcG92ZXJIZWxwZXIgPSBuZXcg V2ViSW5zcGVjdG9yLlBvcG92ZXJIZWxwZXIodGhpcy5lbGVtZW50LCB0aGlzLl9nZXRQb3BvdmVy QW5jaG9yLmJpbmQodGhpcyksIHRoaXMuX3Nob3dQb3BvdmVyLmJpbmQodGhpcykpOworICAgIHRo aXMuX2FuY2hvckVsZW1lbnQgPSB0aGlzLmVsZW1lbnQuY3JlYXRlQ2hpbGQoInNwYW4iKTsKKyAg ICB0aGlzLl9hbmNob3JFbGVtZW50LmNsYXNzTmFtZSA9ICJpdGVtLWFuY2hvciI7CisgICAgdGhp cy5fbGlua2lmaWVyID0gbmV3IFdlYkluc3BlY3Rvci5MaW5raWZpZXIoKTsKIH0KIAogV2ViSW5z cGVjdG9yLkZsYW1lQ2hhcnQuRXZlbnRzID0gewpAQCAtNTMsNiArNTcsMjkgQEAgV2ViSW5zcGVj dG9yLkZsYW1lQ2hhcnQuRXZlbnRzID0gewogfQogCiBXZWJJbnNwZWN0b3IuRmxhbWVDaGFydC5w cm90b3R5cGUgPSB7CisgICAgX2dldFBvcG92ZXJBbmNob3I6IGZ1bmN0aW9uKCkKKyAgICB7Cisg ICAgICAgIGlmICghdGhpcy5faGlnaGxpZ2h0ZWROb2RlKQorICAgICAgICAgICAgcmV0dXJuIG51 bGw7CisgICAgICAgIHJldHVybiB0aGlzLl9hbmNob3JFbGVtZW50OworICAgIH0sCisKKyAgICBf c2hvd1BvcG92ZXI6IGZ1bmN0aW9uKGFuY2hvciwgcG9wb3ZlcikKKyAgICB7CisgICAgICAgIHZh ciBub2RlID0gdGhpcy5faGlnaGxpZ2h0ZWROb2RlOworICAgICAgICB2YXIgY29udGVudEhlbHBl ciA9IG5ldyBXZWJJbnNwZWN0b3IuUG9wb3ZlckNvbnRlbnRIZWxwZXIobm9kZS5mdW5jdGlvbk5h bWUpOworICAgICAgICBjb250ZW50SGVscGVyLmFwcGVuZFRleHRSb3coV2ViSW5zcGVjdG9yLlVJ U3RyaW5nKCJUb3RhbCB0aW1lIiksIE51bWJlci5zZWNvbmRzVG9TdHJpbmcobm9kZS50b3RhbFRp bWUgLyAxMDAwLCB0cnVlKSk7CisgICAgICAgIGNvbnRlbnRIZWxwZXIuYXBwZW5kVGV4dFJvdyhX ZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNlbGYgdGltZSIpLCBOdW1iZXIuc2Vjb25kc1RvU3RyaW5n KG5vZGUuc2VsZlRpbWUgLyAxMDAwLCB0cnVlKSk7CisgICAgICAgIGlmIChub2RlLm51bWJlck9m Q2FsbHMpCisgICAgICAgICAgICBjb250ZW50SGVscGVyLmFwcGVuZFRleHRSb3coV2ViSW5zcGVj dG9yLlVJU3RyaW5nKCJOdW1iZXIgb2YgY2FsbHMiKSwgbm9kZS5udW1iZXJPZkNhbGxzKTsKKyAg ICAgICAgaWYgKG5vZGUudXJsKSB7CisgICAgICAgICAgICB2YXIgbGluayA9IHRoaXMuX2xpbmtp Zmllci5saW5raWZ5TG9jYXRpb24obm9kZS51cmwsIG5vZGUubGluZU51bWJlcik7CisgICAgICAg ICAgICBjb250ZW50SGVscGVyLmFwcGVuZEVsZW1lbnRSb3coIkxvY2F0aW9uIiwgbGluayk7Cisg ICAgICAgIH0KKworICAgICAgICBwb3BvdmVyLnNob3coY29udGVudEhlbHBlci5fY29udGVudFRh YmxlLCBhbmNob3IpOworICAgIH0sCisKICAgICBfb25DbGljazogZnVuY3Rpb24oZSkKICAgICB7 CiAgICAgICAgIGlmICghdGhpcy5faGlnaGxpZ2h0ZWROb2RlKQpAQCAtNjMsMTAgKzkwLDE0IEBA IFdlYkluc3BlY3Rvci5GbGFtZUNoYXJ0LnByb3RvdHlwZSA9IHsKICAgICBfb25Nb3VzZU1vdmU6 IGZ1bmN0aW9uKGUpCiAgICAgewogICAgICAgICB2YXIgbm9kZSA9IHRoaXMuX2Nvb3JkaW5hdGVz VG9Ob2RlKGUub2Zmc2V0WCwgZS5vZmZzZXRZKTsKLSAgICAgICAgaWYgKG5vZGUgIT09IHRoaXMu X2hpZ2hsaWdodGVkTm9kZSkgewotICAgICAgICAgICAgdGhpcy5faGlnaGxpZ2h0ZWROb2RlID0g bm9kZTsKLSAgICAgICAgICAgIHRoaXMudXBkYXRlKCk7Ci0gICAgICAgIH0KKyAgICAgICAgaWYg KHR5cGVvZiBub2RlID09PSAndW5kZWZpbmVkJyAmJiAhdGhpcy5faGlnaGxpZ2h0ZWROb2RlKQor ICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBpZiAobm9kZSA9PT0gdGhpcy5faGlnaGxpZ2h0 ZWROb2RlKQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBpZiAodGhpcy5faGlnaGxpZ2h0 ZWROb2RlKQorICAgICAgICAgICAgdGhpcy5fcG9wb3ZlckhlbHBlci5oaWRlUG9wb3ZlcigpOwor ICAgICAgICB0aGlzLl9oaWdobGlnaHRlZE5vZGUgPSBub2RlOworICAgICAgICB0aGlzLnVwZGF0 ZSgpOwogICAgIH0sCiAKICAgICAvKioKQEAgLTgyLDggKzExMywxNCBAQCBXZWJJbnNwZWN0b3Iu RmxhbWVDaGFydC5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgZnVuY3Rpb24gZmluZE5vZGVDYWxs YmFjayhvZmZzZXQsIGxldmVsLCBub2RlKQogICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoY3Vy c29yTGV2ZWwgPiBsZXZlbCAmJiBjdXJzb3JMZXZlbCA8IGxldmVsICsgMSAmJiBjdXJzb3JPZmZz ZXQgPiBvZmZzZXQgJiYgY3Vyc29yT2Zmc2V0IDwgb2Zmc2V0ICsgbm9kZS50b3RhbFRpbWUpCisg ICAgICAgICAgICBpZiAoY3Vyc29yTGV2ZWwgPiBsZXZlbCAmJiBjdXJzb3JMZXZlbCA8IGxldmVs ICsgMSAmJiBjdXJzb3JPZmZzZXQgPiBvZmZzZXQgJiYgY3Vyc29yT2Zmc2V0IDwgb2Zmc2V0ICsg bm9kZS50b3RhbFRpbWUpIHsKICAgICAgICAgICAgICAgICBjdXJzb3JOb2RlID0gbm9kZTsKKyAg ICAgICAgICAgICAgICB2YXIgc3R5bGUgPSB0aGlzLl9hbmNob3JFbGVtZW50LnN0eWxlOworICAg ICAgICAgICAgICAgIHN0eWxlLndpZHRoID0gTWF0aC5mbG9vcihub2RlLnRvdGFsVGltZSAqIHRo aXMuX3hTY2FsZUZhY3RvcikgKyAicHgiOworICAgICAgICAgICAgICAgIHN0eWxlLmhlaWdodCA9 IHRoaXMuX3lTY2FsZUZhY3RvciArICJweCI7CisgICAgICAgICAgICAgICAgc3R5bGUubGVmdCA9 IE1hdGguZmxvb3Iob2Zmc2V0ICogdGhpcy5feFNjYWxlRmFjdG9yKSArICJweCI7CisgICAgICAg ICAgICAgICAgc3R5bGUudG9wID0gTWF0aC5mbG9vcih0aGlzLl9jYW52YXMuaGVpZ2h0IC0gKGxl dmVsICsgMSkgKiB0aGlzLl95U2NhbGVGYWN0b3IpICsgInB4IjsKKyAgICAgICAgICAgIH0KICAg ICAgICAgfQogICAgICAgICB0aGlzLl9mb3JFYWNoTm9kZShmaW5kTm9kZUNhbGxiYWNrLmJpbmQo dGhpcykpOwogICAgICAgICByZXR1cm4gY3Vyc29yTm9kZTsKQEAgLTkyLDYgKzEyOSw3IEBAIFdl Ykluc3BlY3Rvci5GbGFtZUNoYXJ0LnByb3RvdHlwZSA9IHsKICAgICBvblJlc2l6ZTogZnVuY3Rp b24oKQogICAgIHsKICAgICAgICAgdGhpcy5kcmF3KHRoaXMuZWxlbWVudC5jbGllbnRXaWR0aCwg dGhpcy5lbGVtZW50LmNsaWVudEhlaWdodCk7CisgICAgICAgIHRoaXMuX3BvcG92ZXJIZWxwZXIu aGlkZVBvcG92ZXIoKTsKICAgICB9LAogCiAgICAgLyoqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2ZsYW1lQ2hhcnQuY3NzIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9mbGFtZUNoYXJ0LmNzcwppbmRleCA2Nzc2YTY0OTRkMDcyZjQx NjU4NDk5ZDVmMjQ5ZDY3OTc4ZjA0MjQ3Li45ZjUyZWYwODdiODk5ZjAxNjRjMWZmNDFjYjlkMzdh MzFlNjBkNmIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L2ZsYW1lQ2hhcnQuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv ZmxhbWVDaGFydC5jc3MKQEAgLTIsMyArMiw4IEBACiAgICAgaGVpZ2h0OiAxMDAlOwogICAgIG92 ZXJmbG93OiBoaWRkZW47CiB9CisKKy5mbGFtZS1jaGFydCAuaXRlbS1hbmNob3IgeworICAgIHBv c2l0aW9uOiBhYnNvbHV0ZTsKKyAgICB6LWluZGV4OiAtMTAwOworfQo=