111429 2013-03-05 05:16:18 -0800 [Qt][MiniBrowser] Improve the update of touch indicators 2013-03-05 07:09:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 111430 1 abecsi abecsi jturcotte oldest_to_newest 847576 0 abecsi 2013-03-05 05:16:18 -0800 [Qt][MiniBrowser] Improve the update of touch indicators 847578 1 191473 abecsi 2013-03-05 05:18:04 -0800 Created attachment 191473 Patch 847588 2 191473 jturcotte 2013-03-05 05:40:51 -0800 Comment on attachment 191473 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191473&action=review > Tools/MiniBrowser/qt/BrowserWindow.cpp:122 > + if (touchPoints.isEmpty()) { Is it possible that we get a partial list of touchpoints where some IDs would be missing? 847609 3 abecsi 2013-03-05 06:15:57 -0800 (In reply to comment #2) > (From update of attachment 191473 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191473&action=review > > > Tools/MiniBrowser/qt/BrowserWindow.cpp:122 > > + if (touchPoints.isEmpty()) { > > Is it possible that we get a partial list of touchpoints where some IDs would be missing? The problem is not missing IDs, it's just that not all events have released state. We receive an empty list because of a released control key an this results in problems if you test gesture chains, since not all the states are released by the time the control key is released. Maybe this makes more sense in context with: https://bugs.webkit.org/show_bug.cgi?id=111430 847611 4 abecsi 2013-03-05 06:22:00 -0800 (In reply to comment #2) > (From update of attachment 191473 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191473&action=review > > > Tools/MiniBrowser/qt/BrowserWindow.cpp:122 > > + if (touchPoints.isEmpty()) { > > Is it possible that we get a partial list of touchpoints where some IDs would be missing? To also answer your actual question :) It looks like we always receive all the possible ID because touch points are updated for all combinations. But I can verify that if you have concerns. 847615 5 191473 jturcotte 2013-03-05 06:30:58 -0800 Comment on attachment 191473 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191473&action=review > Tools/MiniBrowser/qt/BrowserWindow.cpp:79 > + m_activeMockComponents.reserve(3); I think that at this level it won't have any noticeable benefit, if any. >>>> Tools/MiniBrowser/qt/BrowserWindow.cpp:122 >>>> + if (touchPoints.isEmpty()) { >>> >>> Is it possible that we get a partial list of touchpoints where some IDs would be missing? >> >> The problem is not missing IDs, it's just that not all events have released state. >> >> We receive an empty list because of a released control key an this results in problems if you test gesture chains, since not all the states are released by the time the control key is released. >> >> Maybe this makes more sense in context with: >> https://bugs.webkit.org/show_bug.cgi?id=111430 > > To also answer your actual question :) > It looks like we always receive all the possible ID because touch points are updated for all combinations. > But I can verify that if you have concerns. Ok I see what you mean, it's passed that way explicitely by MiniBrowserApplication::sendTouchEvent. I was wondering if it was worth checking for missing ids in the list as a general solution instead of checking the only subcase that interests us: "isEmpty()". An explicit way would be to have a clearVisualMockTouchPoints method that does this. Just an idea, both are fine to me so r=me. 847647 6 abecsi 2013-03-05 07:02:06 -0800 Committed r144758: <http://trac.webkit.org/changeset/144758> 191473 2013-03-05 05:18:04 -0800 2013-03-05 07:09:57 -0800 Patch bug-111429-20130305141145.patch text/plain 3813 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmU4NWZhYzZiNjY1ODAyMDA1OTFiMzc1YjUyN2JmZTJh M2QyNzViZi4uMTRjOTU1MTY0YWQ0OGZhMTBkZjI0MDI2OWVhOTY0NGMzOGRlYmMxMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDEzLTAzLTA1ICBBbmRyYXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAZGlnaWEuY29tPgor CisgICAgICAgIFtRdF1bTWluaUJyb3dzZXJdIEltcHJvdmUgdGhlIHVwZGF0ZSBvZiB0b3VjaCBp bmRpY2F0b3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTE0MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBNaW5pQnJvd3NlckFwcGxpY2F0aW9uOjpzZW5kVG91Y2hFdmVudCBzZW5kcyBhbiBlbXB0eSBs aXN0CisgICAgICAgIHRvIEJyb3dzZXJXaW5kb3c6OnVwZGF0ZVZpc3VhbE1vY2tUb3VjaFBvaW50 cyBpZiB0aGUgY29udHJvbAorICAgICAgICBidXR0b24gaXMgcmVsZWFzZWQsIGluIHdoaWNoIGNh c2UgdGhlIHRvdWNoIGluZGljYXRvcnMgc2hvdWxkCisgICAgICAgIGJlIGhpZGRlbiBzbyB0aGF0 IHdlIG5ldmVyIGVuZCB1cCB3aXRoIGEgbGVmdG92ZXIgaW5kaWNhdG9yCisgICAgICAgIHN0aWNr aW5nIG9uIHRoZSBzY3JlZW4uCisgICAgICAgIFRoaXMgcGF0Y2ggYWxzbyBzaW1wbGlmaWVzIHRo ZSBsb29rdXAgb2YgdGhlIGluZGljYXRvciBpdGVtcyBieQorICAgICAgICByZXBsYWNpbmcgdGhl IGZpbmRDaGlsZCBzZWFyY2ggaW4gdGhlIGl0ZW0gdHJlZSB3aXRoIGEgUUhhc2gKKyAgICAgICAg dGhhdCBzdG9yZXMgdGhlIHRvdWNoIElEJ3MgYW5kIHRoZSBwb2ludGVycyB0byB0aGUgY29ycmVz cG9uZGluZworICAgICAgICBpbmRpY2F0b3IgaXRlbXMuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nl ci9xdC9Ccm93c2VyV2luZG93LmNwcDoKKyAgICAgICAgKEJyb3dzZXJXaW5kb3c6OnVwZGF0ZVZp c3VhbE1vY2tUb3VjaFBvaW50cyk6CisgICAgICAgICogTWluaUJyb3dzZXIvcXQvQnJvd3Nlcldp bmRvdy5oOgorICAgICAgICAoQnJvd3NlcldpbmRvdyk6CisKIDIwMTMtMDMtMDUgIEpvY2hlbiBF aXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIGNvbnRlbnQgc2hl bGwgYm90cyB0byBnYXJkZW4tby1tYXRpYyBmb3IgZ2VuZXJhbCBmYWlsdXJzZQpkaWZmIC0tZ2l0 IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5jcHAgYi9Ub29scy9NaW5pQnJv d3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcAppbmRleCBlNTZiNzk5ZDU5NzQ4ZmFmM2E5YWZlYWQ0 MmUzOTRlNDdhYzg5NzMyLi5kNjI1MmZjODY3OGMxMTZjMDIzNDkzZWMwMjgzODZkNThlODdjYmU1 IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcAorKysg Yi9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcApAQCAtNzYsNiArNzYsNyBA QCBCcm93c2VyV2luZG93OjpCcm93c2VyV2luZG93KFdpbmRvd09wdGlvbnMqIG9wdGlvbnMpCiAg ICAgICAgICAgICAgICAgIDw8IDEuMTEgPDwgMS4yMiA8PCAxLjMzIDw8IDEuNSA8PCAxLjcgPDwg MiA8PCAyLjQgPDwgMzsKIAogICAgIG1fY3VycmVudFpvb21MZXZlbCA9IG1fem9vbUxldmVscy5p bmRleE9mKDEpOworICAgIG1fYWN0aXZlTW9ja0NvbXBvbmVudHMucmVzZXJ2ZSgzKTsKIH0KIAog UVF1aWNrV2ViVmlldyogQnJvd3NlcldpbmRvdzo6d2ViVmlldygpIGNvbnN0CkBAIC0xMTgsMTQg KzExOSwyMiBAQCBCcm93c2VyV2luZG93KiBCcm93c2VyV2luZG93OjpuZXdXaW5kb3coY29uc3Qg UVN0cmluZyYgdXJsKQogCiB2b2lkIEJyb3dzZXJXaW5kb3c6OnVwZGF0ZVZpc3VhbE1vY2tUb3Vj aFBvaW50cyhjb25zdCBRTGlzdDxRVG91Y2hFdmVudDo6VG91Y2hQb2ludD4mIHRvdWNoUG9pbnRz KQogeworICAgIGlmICh0b3VjaFBvaW50cy5pc0VtcHR5KCkpIHsKKyAgICAgICAgLy8gSGlkZSBh bGwgdG91Y2ggaW5kaWNhdG9yIGl0ZW1zLgorICAgICAgICBmb3JlYWNoIChRUXVpY2tJdGVtKiBp dGVtLCBtX2FjdGl2ZU1vY2tDb21wb25lbnRzLnZhbHVlcygpKQorICAgICAgICAgICAgaXRlbS0+ c2V0UHJvcGVydHkoInByZXNzZWQiLCBmYWxzZSk7CisKKyAgICAgICAgcmV0dXJuOworICAgIH0K KwogICAgIGZvcmVhY2ggKGNvbnN0IFFUb3VjaEV2ZW50OjpUb3VjaFBvaW50JiB0b3VjaFBvaW50 LCB0b3VjaFBvaW50cykgewotICAgICAgICBRU3RyaW5nIG1vY2tUb3VjaFBvaW50SWRlbnRpZmll ciA9IFFTdHJpbmcoIm1vY2tUb3VjaFBvaW50JTEiKS5hcmcodG91Y2hQb2ludC5pZCgpKTsKLSAg ICAgICAgUVF1aWNrSXRlbSogbW9ja1RvdWNoUG9pbnRJdGVtID0gcm9vdE9iamVjdCgpLT5maW5k Q2hpbGQ8UVF1aWNrSXRlbSo+KG1vY2tUb3VjaFBvaW50SWRlbnRpZmllciwgUXQ6OkZpbmREaXJl Y3RDaGlsZHJlbk9ubHkpOworICAgICAgICBRUXVpY2tJdGVtKiBtb2NrVG91Y2hQb2ludEl0ZW0g PSBtX2FjdGl2ZU1vY2tDb21wb25lbnRzLnZhbHVlKHRvdWNoUG9pbnQuaWQoKSk7CiAKICAgICAg ICAgaWYgKCFtb2NrVG91Y2hQb2ludEl0ZW0pIHsKICAgICAgICAgICAgIFFRbWxDb21wb25lbnQg dG91Y2hNb2NrUG9pbnRDb21wb25lbnQoZW5naW5lKCksIFFVcmwoInFyYzovLy9xbWwvTW9ja1Rv dWNoUG9pbnQucW1sIikpOwogICAgICAgICAgICAgbW9ja1RvdWNoUG9pbnRJdGVtID0gcW9iamVj dF9jYXN0PFFRdWlja0l0ZW0qPih0b3VjaE1vY2tQb2ludENvbXBvbmVudC5jcmVhdGUoKSk7Ci0g ICAgICAgICAgICBtb2NrVG91Y2hQb2ludEl0ZW0tPnNldE9iamVjdE5hbWUobW9ja1RvdWNoUG9p bnRJZGVudGlmaWVyKTsKKyAgICAgICAgICAgIFFfQVNTRVJUKG1vY2tUb3VjaFBvaW50SXRlbSk7 CisgICAgICAgICAgICBtX2FjdGl2ZU1vY2tDb21wb25lbnRzLmluc2VydCh0b3VjaFBvaW50Lmlk KCksIG1vY2tUb3VjaFBvaW50SXRlbSk7CiAgICAgICAgICAgICBtb2NrVG91Y2hQb2ludEl0ZW0t PnNldFByb3BlcnR5KCJwb2ludElkIiwgUVZhcmlhbnQodG91Y2hQb2ludC5pZCgpKSk7CiAgICAg ICAgICAgICBtb2NrVG91Y2hQb2ludEl0ZW0tPnNldFBhcmVudChyb290T2JqZWN0KCkpOwogICAg ICAgICAgICAgbW9ja1RvdWNoUG9pbnRJdGVtLT5zZXRQYXJlbnRJdGVtKHJvb3RPYmplY3QoKSk7 CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmggYi9Ub29s cy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmgKaW5kZXggZTc2MTc2NDNlNzg0MDJkOGNk ZmI0NGNmMTlkNmRiMzgyNTdhOTc3OC4uMmVjZmMxNDUzYTMyOGQxZjVmODFlYzE4NTRmMzlkMDY5 NGE1YjJkYiAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3NlcldpbmRvdy5o CisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuaApAQCAtNjgsNiArNjgs NyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCB3aGVlbEV2ZW50KFFXaGVlbEV2ZW50Kik7 CiAKICAgICBXaW5kb3dPcHRpb25zKiBtX3dpbmRvd09wdGlvbnM7CisgICAgUUhhc2g8aW50LCBR UXVpY2tJdGVtKj4gbV9hY3RpdmVNb2NrQ29tcG9uZW50czsKICAgICBRVmVjdG9yPHFyZWFsPiBt X3pvb21MZXZlbHM7CiAgICAgdW5zaWduZWQgbV9jdXJyZW50Wm9vbUxldmVsOwogfTsK