111427 2013-03-05 05:05:07 -0800 Web Inspector: Clarify some StylesSidebarPanel and CSSMetadata JSDocs. 2013-03-05 05:35:47 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 111301 1 eustas eustas apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 847570 0 eustas 2013-03-05 05:05:07 -0800 Goal: reflect in JSDoc that non-null array is passed to completionsReady callback. 847571 1 191470 eustas 2013-03-05 05:09:29 -0800 Created attachment 191470 Patch 847585 2 191470 webkit.review.bot 2013-03-05 05:35:44 -0800 Comment on attachment 191470 Patch Clearing flags on attachment: 191470 Committed r144753: <http://trac.webkit.org/changeset/144753> 847586 3 webkit.review.bot 2013-03-05 05:35:47 -0800 All reviewed patches have been landed. Closing bug. 191470 2013-03-05 05:09:29 -0800 2013-03-05 05:35:44 -0800 Patch bug-111427-20130305170536.patch text/plain 4318 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTM0YzdkYTZmNTJiOGQ3 NmMwMzZmNmY0OGM1ZjAzYTI0ZjhmYmI3OS4uMjcyMjIwZTcwMDBhNzY2ZTk1Y2U1OWNmYjNjMDdl NDc0NTBjZGUzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTA1ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IENsYXJpZnkgc29tZSBTdHlsZXNTaWRlYmFyUGFuZWwgYW5kIENTU01ldGFkYXRhIEpT RG9jcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MTQyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdv YWw6IHJlZmxlY3QgaW4gSlNEb2MgdGhhdCBub24tbnVsbCBhcnJheSBpcyBwYXNzZWQgdG8gY29t cGxldGlvbnNSZWFkeSBjYWxsYmFjay4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv Q1NTTWV0YWRhdGEuanM6CisgICAgICAgIEFkZGVkIEpTRG9jcywgYXZvaWRlZCBwb3NzaWJsZSBO UEVzLgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanM6 CisgICAgICAgIEZpeGVkIEpTRG9jcywgcmVtb3ZlZCB1bnVzZWQgYXNzaWdubWVudC4KKwogMjAx My0wMy0wNCAgRXVnZW5lIEtseXVjaG5pa292ICA8ZXVzdGFzQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBFeGNlcHRpb25zIHdoZW4gV2ViSW5zcGVjdG9yIHJ1biBpbiBo b3N0ZWQgbW9kZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvQ1NTTWV0YWRhdGEuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NT U01ldGFkYXRhLmpzCmluZGV4IDFmOGFjZGI5ZmFiYjBiYjhkMDIxN2QzYmE0OWYzMTU5MDBlNTgw OGEuLjExM2NmMzRlZTliNzY1NWZjZDU4M2UzYTRjY2UyYzQxZjg2ZTM3YWEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1NTTWV0YWRhdGEuanMKKysrIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DU1NNZXRhZGF0YS5qcwpAQCAtMzYs NyArMzYsNyBAQAogICovCiBXZWJJbnNwZWN0b3IuQ1NTTWV0YWRhdGEgPSBmdW5jdGlvbihwcm9w ZXJ0aWVzKQogewotICAgIHRoaXMuX3ZhbHVlcyA9IFtdOworICAgIHRoaXMuX3ZhbHVlcyA9IC8q KiAhQXJyYXkuPHN0cmluZz4gKi8gKFtdKTsKICAgICB0aGlzLl9sb25naGFuZHMgPSB7fTsKICAg ICB0aGlzLl9zaG9ydGhhbmRzID0ge307CiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBwcm9wZXJ0 aWVzLmxlbmd0aDsgKytpKSB7CkBAIC02Nyw5ICs2Nyw5IEBAIFdlYkluc3BlY3Rvci5DU1NNZXRh ZGF0YSA9IGZ1bmN0aW9uKHByb3BlcnRpZXMpCiB9CiAKIC8qKgotICogQHR5cGUge1dlYkluc3Bl Y3Rvci5DU1NNZXRhZGF0YX0KKyAqIEB0eXBlIHshV2ViSW5zcGVjdG9yLkNTU01ldGFkYXRhfQog ICovCi1XZWJJbnNwZWN0b3IuQ1NTTWV0YWRhdGEuY3NzUHJvcGVydGllc01ldGFpbmZvID0gbnVs bDsKK1dlYkluc3BlY3Rvci5DU1NNZXRhZGF0YS5jc3NQcm9wZXJ0aWVzTWV0YWluZm8gPSBuZXcg V2ViSW5zcGVjdG9yLkNTU01ldGFkYXRhKFtdKTsKIAogV2ViSW5zcGVjdG9yLkNTU01ldGFkYXRh LmlzQ29sb3JBd2FyZVByb3BlcnR5ID0gZnVuY3Rpb24ocHJvcGVydHlOYW1lKQogewpAQCAtNjcz LDcgKzY3Myw3IEBAIFdlYkluc3BlY3Rvci5DU1NNZXRhZGF0YS5fcHJvcGVydHlEYXRhTWFwID0g ewogCiAvKioKICAqIEBwYXJhbSB7c3RyaW5nfSBwcm9wZXJ0eU5hbWUKLSAqIEByZXR1cm4ge1dl Ykluc3BlY3Rvci5DU1NNZXRhZGF0YX0KKyAqIEByZXR1cm4geyFXZWJJbnNwZWN0b3IuQ1NTTWV0 YWRhdGF9CiAgKi8KIFdlYkluc3BlY3Rvci5DU1NNZXRhZGF0YS5rZXl3b3Jkc0ZvclByb3BlcnR5 ID0gZnVuY3Rpb24ocHJvcGVydHlOYW1lKQogewpAQCAtODQxLDYgKzg0MSwxMCBAQCBXZWJJbnNw ZWN0b3IuQ1NTTWV0YWRhdGEuV2VpZ2h0ID0gewogCiAKIFdlYkluc3BlY3Rvci5DU1NNZXRhZGF0 YS5wcm90b3R5cGUgPSB7CisgICAgLyoqCisgICAgICogQHBhcmFtIHtzdHJpbmd9IHByZWZpeAor ICAgICAqIEByZXR1cm4geyFBcnJheS48c3RyaW5nPn0KKyAgICAgKi8KICAgICBzdGFydHNXaXRo OiBmdW5jdGlvbihwcmVmaXgpCiAgICAgewogICAgICAgICB2YXIgZmlyc3RJbmRleCA9IHRoaXMu X2ZpcnN0SW5kZXhPZlByZWZpeChwcmVmaXgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMKaW5kZXggZmRiZmM5M2I3 ZWU4MTg4NWE5MmM0NmEzMDYyMTk5YTM1YTlkMWQ3OC4uOWVjYTc4ZmFkOTZhOWExNjQ2NWE3ZjFh YzBhNDc5ZjYyNmJlNWFmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCkBAIC0yMjIwLDcgKzIyMjAsNiBAQCBX ZWJJbnNwZWN0b3IuU3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKICAgICAg ICAgaWYgKCFpc0VkaXRpbmdOYW1lKSB7CiAgICAgICAgICAgICBpZiAoc2VsZWN0RWxlbWVudCAh PT0gdGhpcy52YWx1ZUVsZW1lbnQpIHsKICAgICAgICAgICAgICAgICAvLyBDbGljayBpbiB0aGUg TEkgLSBzdGFydCBlZGl0aW5nIHZhbHVlLgotICAgICAgICAgICAgICAgIGlzRWRpdGluZ05hbWUg PSBmYWxzZTsKICAgICAgICAgICAgICAgICBzZWxlY3RFbGVtZW50ID0gdGhpcy52YWx1ZUVsZW1l bnQ7CiAgICAgICAgICAgICB9CiAKQEAgLTI2NDcsOSArMjY0NiwxMSBAQCBXZWJJbnNwZWN0b3Iu U3R5bGVQcm9wZXJ0eVRyZWVFbGVtZW50LnByb3RvdHlwZSA9IHsKIC8qKgogICogQGNvbnN0cnVj dG9yCiAgKiBAZXh0ZW5kcyB7V2ViSW5zcGVjdG9yLlRleHRQcm9tcHR9Ci0gKiBAcGFyYW0ge2Z1 bmN0aW9uKCopPX0gYWNjZXB0Q2FsbGJhY2sKKyAqIEBwYXJhbSB7IVdlYkluc3BlY3Rvci5DU1NN ZXRhZGF0YX0gY3NzQ29tcGxldGlvbnMKKyAqIEBwYXJhbSB7IVdlYkluc3BlY3Rvci5TdHlsZVBy b3BlcnR5VHJlZUVsZW1lbnR9IHNpZGViYXJQYW5lCisgKiBAcGFyYW0ge2Jvb2xlYW59IGlzRWRp dGluZ05hbWUKICAqLwotV2ViSW5zcGVjdG9yLlN0eWxlc1NpZGViYXJQYW5lLkNTU1Byb3BlcnR5 UHJvbXB0ID0gZnVuY3Rpb24oY3NzQ29tcGxldGlvbnMsIHNpZGViYXJQYW5lLCBpc0VkaXRpbmdO YW1lLCBhY2NlcHRDYWxsYmFjaykKK1dlYkluc3BlY3Rvci5TdHlsZXNTaWRlYmFyUGFuZS5DU1NQ cm9wZXJ0eVByb21wdCA9IGZ1bmN0aW9uKGNzc0NvbXBsZXRpb25zLCBzaWRlYmFyUGFuZSwgaXNF ZGl0aW5nTmFtZSkKIHsKICAgICAvLyBVc2UgdGhlIHNhbWUgY2FsbGJhY2sgYm90aCBmb3IgYXBw bHlJdGVtQ2FsbGJhY2sgYW5kIGFjY2VwdEl0ZW1DYWxsYmFjay4KICAgICBXZWJJbnNwZWN0b3Iu VGV4dFByb21wdC5jYWxsKHRoaXMsIHRoaXMuX2J1aWxkUHJvcGVydHlDb21wbGV0aW9ucy5iaW5k KHRoaXMpLCBXZWJJbnNwZWN0b3IuU3R5bGVWYWx1ZURlbGltaXRlcnMpOwpAQCAtMjcyMSw3ICsy NzIyLDcgQEAgV2ViSW5zcGVjdG9yLlN0eWxlc1NpZGViYXJQYW5lLkNTU1Byb3BlcnR5UHJvbXB0 LnByb3RvdHlwZSA9IHsKICAgICAgKiBAcGFyYW0ge0VsZW1lbnR9IHByb3h5RWxlbWVudAogICAg ICAqIEBwYXJhbSB7UmFuZ2V9IHdvcmRSYW5nZQogICAgICAqIEBwYXJhbSB7Ym9vbGVhbn0gZm9y Y2UKLSAgICAgKiBAcGFyYW0ge2Z1bmN0aW9uKEFycmF5LjxzdHJpbmc+LCBudW1iZXI9KX0gY29t cGxldGlvbnNSZWFkeUNhbGxiYWNrCisgICAgICogQHBhcmFtIHtmdW5jdGlvbighQXJyYXkuPHN0 cmluZz4sIG51bWJlcj0pfSBjb21wbGV0aW9uc1JlYWR5Q2FsbGJhY2sKICAgICAgKi8KICAgICBf YnVpbGRQcm9wZXJ0eUNvbXBsZXRpb25zOiBmdW5jdGlvbihwcm94eUVsZW1lbnQsIHdvcmRSYW5n ZSwgZm9yY2UsIGNvbXBsZXRpb25zUmVhZHlDYWxsYmFjaykKICAgICB7Cg==