111414 2013-03-05 00:28:20 -0800 [GTK] Expose "ShouldRespectImageOrientation" setting into WebKitWebSettings 2013-03-07 06:24:59 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tpopela webkit-unassigned cgarcia gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 847375 0 tpopela 2013-03-05 00:28:20 -0800 We should expose ShouldRespectImageOrientation into WebKitWebSettings as discussed here: https://lists.webkit.org/pipermail/webkit-gtk/2013-March/001372.html . 847386 1 191422 tpopela 2013-03-05 00:36:25 -0800 Created attachment 191422 Proposed patch 847393 2 webkit.review.bot 2013-03-05 00:47:22 -0800 Attachment 191422 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebsettings.cpp', u'Source/WebKit/gtk/webkit/webkitwebsettingsprivate.h', u'Source/WebKit/gtk/webkit/webkitwebview.cpp']" exit_code: 1 Source/WebKit/gtk/webkit/webkitwebsettings.cpp:284: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 848874 3 191422 mrobinson 2013-03-06 08:12:08 -0800 Comment on attachment 191422 Proposed patch Looks good to me. Just need another review from a GTK+ port maintainer to land this one. 848889 4 tpopela 2013-03-06 08:33:04 -0800 Ok.. And can we also include it in webkitgtk2.0 release? 848922 5 mrobinson 2013-03-06 09:14:55 -0800 We don't like to add API late in the cycle, but this seems pretty low risk. Can you add this bug to: http://trac.webkit.org/wiki/WebKitGTK/2.0.x 848924 6 mrobinson 2013-03-06 09:15:20 -0800 Adding a couple more port maintainers who could flip the flag here. 850027 7 191422 cgarcia 2013-03-07 06:18:39 -0800 Comment on attachment 191422 Proposed patch This looks good to me, you need approval from another reviewer since this is new API. 850030 8 191422 cgarcia 2013-03-07 06:19:42 -0800 Comment on attachment 191422 Proposed patch Martin already reviewed it, sorry. 850034 9 191422 webkit.review.bot 2013-03-07 06:24:55 -0800 Comment on attachment 191422 Proposed patch Clearing flags on attachment: 191422 Committed r145070: <http://trac.webkit.org/changeset/145070> 850035 10 webkit.review.bot 2013-03-07 06:24:59 -0800 All reviewed patches have been landed. Closing bug. 191422 2013-03-05 00:36:25 -0800 2013-03-07 06:24:55 -0800 Proposed patch 111414.patch text/plain 6653 tpopela RnJvbSBiNjE0NTBiNjcyNzMwZjU0NTE0MTQ3NDk1NTU5OTYzNjNmOWQyNWI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hcyBQb3BlbGEgPHRwb3BlbGFAcmVkaGF0LmNvbT4KRGF0 ZTogVHVlLCA1IE1hciAyMDEzIDA5OjI5OjU4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMy0w My0wNSAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgoKICAgICAgICBbR1RLXSBF eHBvc2UgIlNob3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uIiBzZXR0aW5nIGludG8gV2ViS2l0 V2ViU2V0dGluZ3MKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTExNDE0CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBX ZSBzaG91bGQgZXhwb3NlIFNob3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uIHNldHRpbmcgaW50 bwogICAgICAgIFdlYktpdFdlYlNldHRpbmdzLiBXaGVuIGl0IGlzIGVuYWJsZWQsIHRoZSBpbWFn ZXMgYXJlIHNob3duIHdpdGggcmlnaHQKICAgICAgICBvcmllbnRhdGlvbiByZWdhcmRpbmcgdG8g aW1hZ2VzIEVYSUYgZGF0YS4KCiAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3Bw OgogICAgICAgICh3ZWJraXRfd2ViX3NldHRpbmdzX2NsYXNzX2luaXQpOgogICAgICAgICh3ZWJr aXRfd2ViX3NldHRpbmdzX3NldF9wcm9wZXJ0eSk6CiAgICAgICAgKHdlYmtpdF93ZWJfc2V0dGlu Z3NfZ2V0X3Byb3BlcnR5KToKICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJzZXR0aW5nc3ByaXZh dGUuaDoKICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKICAgICAgICAod2Via2l0 X3dlYl92aWV3X3VwZGF0ZV9zZXR0aW5ncyk6CiAgICAgICAgKHdlYmtpdF93ZWJfdmlld19zZXR0 aW5nc19ub3RpZnkpOgotLS0KIFNvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICB8IDIwICsrKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViS2l0L2d0 ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwICAgICAgfCAxNiArKysrKysrKysrKysrKysr CiBTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3Nwcml2YXRlLmggfCAg MSArCiBTb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgICAgICAgICAg fCAgMyArKysKIDQgZmlsZXMgY2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxv ZwppbmRleCAwYzI5NzJkLi42NWU4ZTZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTMtMDMtMDUgIFRvbWFzIFBvcGVsYSAgPHRwb3BlbGFAcmVkaGF0LmNvbT4KKworICAg ICAgICBbR1RLXSBFeHBvc2UgIlNob3VsZFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uIiBzZXR0aW5n IGludG8gV2ViS2l0V2ViU2V0dGluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMTQxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlIHNob3VsZCBleHBvc2UgU2hvdWxkUmVzcGVjdEltYWdlT3JpZW50 YXRpb24gc2V0dGluZyBpbnRvCisgICAgICAgIFdlYktpdFdlYlNldHRpbmdzLiBXaGVuIGl0IGlz IGVuYWJsZWQsIHRoZSBpbWFnZXMgYXJlIHNob3duIHdpdGggcmlnaHQKKyAgICAgICAgb3JpZW50 YXRpb24gcmVnYXJkaW5nIHRvIGltYWdlcyBFWElGIGRhdGEuCisKKyAgICAgICAgKiB3ZWJraXQv d2Via2l0d2Vic2V0dGluZ3MuY3BwOgorICAgICAgICAod2Via2l0X3dlYl9zZXR0aW5nc19jbGFz c19pbml0KToKKyAgICAgICAgKHdlYmtpdF93ZWJfc2V0dGluZ3Nfc2V0X3Byb3BlcnR5KToKKyAg ICAgICAgKHdlYmtpdF93ZWJfc2V0dGluZ3NfZ2V0X3Byb3BlcnR5KToKKyAgICAgICAgKiB3ZWJr aXQvd2Via2l0d2Vic2V0dGluZ3Nwcml2YXRlLmg6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdl YnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X3VwZGF0ZV9zZXR0aW5ncyk6Cisg ICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfc2V0dGluZ3Nfbm90aWZ5KToKKwogMjAxMy0wMy0wMyAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgcm9s bG91dCBvZiBodHRwOi8vdHJhYy53ZWJraXQub3JnL3IxNDQ1MzAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwCmluZGV4IGZmNTFlYmMuLjMwYTdiZTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcApA QCAtNzksNiArNzksNyBAQCBlbnVtIHsKICAgICBQUk9QX0VORk9SQ0VfOTZfRFBJLAogICAgIFBS T1BfQVVUT19MT0FEX0lNQUdFUywKICAgICBQUk9QX0FVVE9fU0hSSU5LX0lNQUdFUywKKyAgICBQ Uk9QX1JFU1BFQ1RfSU1BR0VfT1JJRU5UQVRJT04sCiAgICAgUFJPUF9QUklOVF9CQUNLR1JPVU5E UywKICAgICBQUk9QX0VOQUJMRV9TQ1JJUFRTLAogICAgIFBST1BfRU5BQkxFX1BMVUdJTlMsCkBA IC0yODAsNiArMjgxLDE1IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfc2V0dGluZ3NfY2xhc3Nf aW5pdChXZWJLaXRXZWJTZXR0aW5nc0NsYXNzKiBrbGFzcykKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGZsYWdzKSk7CiAKICAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3By b3BlcnR5KGdvYmplY3RfY2xhc3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBQUk9QX1JFU1BFQ1RfSU1BR0VfT1JJRU5UQVRJT04sCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVhbigKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICJyZXNwZWN0LWltYWdlLW9yaWVudGF0aW9uIiwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIF8oIlJlc3BlY3QgSW1hZ2UgT3JpZW50YXRpb24iKSwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIldoZXRoZXIgV2ViS2l0IHNo b3VsZCByZXNwZWN0IGltYWdlIG9yaWVudGF0aW9uLiIpLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgRkFMU0UsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBmbGFncykpOworCisgICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShnb2JqZWN0 X2NsYXNzLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUFJPUF9QUklOVF9C QUNLR1JPVU5EUywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdfcGFyYW1f c3BlY19ib29sZWFuKAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInByaW50 LWJhY2tncm91bmRzIiwKQEAgLTEwNzUsNiArMTA4NSw5IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93 ZWJfc2V0dGluZ3Nfc2V0X3Byb3BlcnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJvcF9pZCwg Y29uCiAgICAgY2FzZSBQUk9QX0FVVE9fU0hSSU5LX0lNQUdFUzoKICAgICAgICAgcHJpdi0+YXV0 b1Nocmlua0ltYWdlcyA9IGdfdmFsdWVfZ2V0X2Jvb2xlYW4odmFsdWUpOwogICAgICAgICBicmVh azsKKyAgICBjYXNlIFBST1BfUkVTUEVDVF9JTUFHRV9PUklFTlRBVElPTjoKKyAgICAgICAgcHJp di0+cmVzcGVjdEltYWdlT3JpZW50YXRpb24gPSBnX3ZhbHVlX2dldF9ib29sZWFuKHZhbHVlKTsK KyAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBQUk9QX1BSSU5UX0JBQ0tHUk9VTkRTOgogICAgICAg ICBwcml2LT5wcmludEJhY2tncm91bmRzID0gZ192YWx1ZV9nZXRfYm9vbGVhbih2YWx1ZSk7CiAg ICAgICAgIGJyZWFrOwpAQCAtMTI2NCw2ICsxMjc3LDkgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dl Yl9zZXR0aW5nc19nZXRfcHJvcGVydHkoR09iamVjdCogb2JqZWN0LCBndWludCBwcm9wX2lkLCBH VmEKICAgICBjYXNlIFBST1BfQVVUT19TSFJJTktfSU1BR0VTOgogICAgICAgICBnX3ZhbHVlX3Nl dF9ib29sZWFuKHZhbHVlLCBwcml2LT5hdXRvU2hyaW5rSW1hZ2VzKTsKICAgICAgICAgYnJlYWs7 CisgICAgY2FzZSBQUk9QX1JFU1BFQ1RfSU1BR0VfT1JJRU5UQVRJT046CisgICAgICAgIGdfdmFs dWVfc2V0X2Jvb2xlYW4odmFsdWUsIHByaXYtPnJlc3BlY3RJbWFnZU9yaWVudGF0aW9uKTsKKyAg ICAgICAgYnJlYWs7CiAgICAgY2FzZSBQUk9QX1BSSU5UX0JBQ0tHUk9VTkRTOgogICAgICAgICBn X3ZhbHVlX3NldF9ib29sZWFuKHZhbHVlLCBwcml2LT5wcmludEJhY2tncm91bmRzKTsKICAgICAg ICAgYnJlYWs7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi c2V0dGluZ3Nwcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0 dGluZ3Nwcml2YXRlLmgKaW5kZXggMzg3Y2IwNS4uNzBiODg2NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzcHJpdmF0ZS5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0aW5nc3ByaXZhdGUuaApAQCAtNDMsNiAr NDMsNyBAQCBzdHJ1Y3QgX1dlYktpdFdlYlNldHRpbmdzUHJpdmF0ZSB7CiAgICAgZ2Jvb2xlYW4g ZW5mb3JjZTk2RFBJOwogICAgIGdib29sZWFuIGF1dG9Mb2FkSW1hZ2VzOwogICAgIGdib29sZWFu IGF1dG9TaHJpbmtJbWFnZXM7CisgICAgZ2Jvb2xlYW4gcmVzcGVjdEltYWdlT3JpZW50YXRpb247 CiAgICAgZ2Jvb2xlYW4gcHJpbnRCYWNrZ3JvdW5kczsKICAgICBnYm9vbGVhbiBlbmFibGVTY3Jp cHRzOwogICAgIGdib29sZWFuIGVuYWJsZVBsdWdpbnM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggODU3OWUxOC4uMTJhNjFhMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMzM4NSw2ICszMzg1LDcgQEAg c3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3VwZGF0ZV9zZXR0aW5ncyhXZWJLaXRXZWJWaWV3 KiB3ZWJWaWV3KQogICAgIGNvcmVTZXR0aW5ncy0+c2V0U2VyaWZGb250RmFtaWx5KHNldHRpbmdz UHJpdmF0ZS0+c2VyaWZGb250RmFtaWx5LmRhdGEoKSk7CiAgICAgY29yZVNldHRpbmdzLT5zZXRM b2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkoc2V0dGluZ3NQcml2YXRlLT5hdXRvTG9hZEltYWdlcyk7 CiAgICAgY29yZVNldHRpbmdzLT5zZXRTaHJpbmtzU3RhbmRhbG9uZUltYWdlc1RvRml0KHNldHRp bmdzUHJpdmF0ZS0+YXV0b1Nocmlua0ltYWdlcyk7CisgICAgY29yZVNldHRpbmdzLT5zZXRTaG91 bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbihzZXR0aW5nc1ByaXZhdGUtPnJlc3BlY3RJbWFnZU9y aWVudGF0aW9uKTsKICAgICBjb3JlU2V0dGluZ3MtPnNldFNob3VsZFByaW50QmFja2dyb3VuZHMo c2V0dGluZ3NQcml2YXRlLT5wcmludEJhY2tncm91bmRzKTsKICAgICBjb3JlU2V0dGluZ3MtPnNl dFNjcmlwdEVuYWJsZWQoc2V0dGluZ3NQcml2YXRlLT5lbmFibGVTY3JpcHRzKTsKICAgICBjb3Jl U2V0dGluZ3MtPnNldFBsdWdpbnNFbmFibGVkKHNldHRpbmdzUHJpdmF0ZS0+ZW5hYmxlUGx1Z2lu cyk7CkBAIC0zNTA0LDYgKzM1MDUsOCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfc2V0 dGluZ3Nfbm90aWZ5KFdlYktpdFdlYlNldHRpbmdzKiB3ZWJTZXR0aW5ncywgR1BhcgogICAgICAg ICBzZXR0aW5ncy0+c2V0TG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5KGdfdmFsdWVfZ2V0X2Jvb2xl YW4oJnZhbHVlKSk7CiAgICAgZWxzZSBpZiAobmFtZSA9PSBnX2ludGVybl9zdHJpbmcoImF1dG8t c2hyaW5rLWltYWdlcyIpKQogICAgICAgICBzZXR0aW5ncy0+c2V0U2hyaW5rc1N0YW5kYWxvbmVJ bWFnZXNUb0ZpdChnX3ZhbHVlX2dldF9ib29sZWFuKCZ2YWx1ZSkpOworICAgIGVsc2UgaWYgKG5h bWUgPT0gZ19pbnRlcm5fc3RyaW5nKCJyZXNwZWN0LWltYWdlLW9yaWVudGF0aW9uIikpCisgICAg ICAgIHNldHRpbmdzLT5zZXRTaG91bGRSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbihnX3ZhbHVlX2dl dF9ib29sZWFuKCZ2YWx1ZSkpOwogICAgIGVsc2UgaWYgKG5hbWUgPT0gZ19pbnRlcm5fc3RyaW5n KCJwcmludC1iYWNrZ3JvdW5kcyIpKQogICAgICAgICBzZXR0aW5ncy0+c2V0U2hvdWxkUHJpbnRC YWNrZ3JvdW5kcyhnX3ZhbHVlX2dldF9ib29sZWFuKCZ2YWx1ZSkpOwogICAgIGVsc2UgaWYgKG5h bWUgPT0gZ19pbnRlcm5fc3RyaW5nKCJlbmFibGUtc2NyaXB0cyIpKQo=