111408 2013-03-04 22:43:53 -0800 [WK2] Use canHaveScrollbars() or useFixedLayout() instead of delegatesScrolling(). 2022-02-27 23:32:32 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 111532 110066 1 dongseong.hwang dongseong.hwang cmarcelo darin dglazkov eric esprehn+autocc jturcotte kenneth mikhail.pozdnyakov noam ojan.autocc simon.fraser webkit.review.bot zeno oldest_to_newest 847290 0 dongseong.hwang 2013-03-04 22:43:53 -0800 There are many code that should use canHaveScrollbars() or useFixedLayout() instead of delegatesScrolling(). 847293 1 191404 dongseong.hwang 2013-03-04 22:45:35 -0800 Created attachment 191404 Patch 847295 2 dongseong.hwang 2013-03-04 22:49:56 -0800 Currently, only Qt and EFL set delegatesScrolling to true. And Qt and EFL set canHaveScrollbars to false. So Qt and EFL are fine with this patch. But I'm afraid that the outer ports which set canHaveScrollbars to false would have problem. Could you let me know what port set canHaveScrollbars to false? 847324 3 191404 allan.jensen 2013-03-04 23:30:41 -0800 Comment on attachment 191404 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191404&action=review > Source/WebCore/page/FrameView.cpp:1198 > - if (useFixedLayout() && !fixedLayoutSize().isEmpty() && delegatesScrolling()) > - m_lastViewportSize = fixedLayoutSize(); > - else > + if (canHaveScrollbars()) > m_lastViewportSize = visibleContentRect(IncludeScrollbars).size(); > + else > + m_lastViewportSize = visibleContentRect(ExcludeScrollbars).size(); visibleContentRetc(ExcludeScrollbars) is the same as fixedVisibleRect, not the same as fixedLayoutSize. 847330 4 191404 allan.jensen 2013-03-04 23:36:14 -0800 Comment on attachment 191404 Patch This patch completely changes how resize events are emitted. 847345 5 191415 dongseong.hwang 2013-03-04 23:54:59 -0800 Created attachment 191415 Patch 847346 6 dongseong.hwang 2013-03-04 23:56:07 -0800 (In reply to comment #3) > (From update of attachment 191404 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191404&action=review > visibleContentRetc(ExcludeScrollbars) is the same as fixedVisibleRect, not the same as fixedLayoutSize. Thank you for review. you are right. I made a mistake. How about the second patch? 847416 7 191415 allan.jensen 2013-03-05 01:23:32 -0800 Comment on attachment 191415 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191415&action=review > Source/WebCore/page/FrameView.cpp:2648 > + if (useFixedLayout() && !fixedLayoutSize().isEmpty() && useFixedLayout()) useFixedLayout() && useFixedLayout()? I can remember the reason delegatesScrolling() was used was to ensure it only affected the right platforms. You may want to try to run blame on the lines and dig up the bug where we discussed it. > Source/WebCore/rendering/RenderLayerCompositor.cpp:2227 > - if (m_renderView->frameView()->delegatesScrolling()) > + if (!m_renderView->frameView()->canHaveScrollbars()) This is wrong. CanHaveScrollbars can be set by simply forcing scrollbars to be disabled (ScrollbarAlwaysOff). It does not imply delegated scrolling or paintsEntireContents. For instance without a scrollbar, you could still scroll using scroll gestures, mouse wheel or JavaScript events. 847445 8 191415 webkit.review.bot 2013-03-05 01:43:59 -0800 Comment on attachment 191415 Patch Attachment 191415 did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17029021 New failing tests: compositing/iframes/nested-composited-iframe.html compositing/iframes/overlapped-nested-iframes.html platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed.html platform/chromium/virtual/softwarecompositing/framesets/composited-frame-alignment.html compositing/framesets/composited-frame-alignment.html compositing/iframes/invisible-nested-iframe-show.html platform/chromium/virtual/softwarecompositing/iframes/invisible-nested-iframe-show.html platform/chromium/virtual/softwarecompositing/iframes/overlapped-nested-iframes.html platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute.html platform/chromium/virtual/softwarecompositing/iframes/become-composited-nested-iframes.html platform/chromium/virtual/softwarecompositing/iframes/nested-composited-iframe.html compositing/iframes/become-composited-nested-iframes.html platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative.html 847506 9 dongseong.hwang 2013-03-05 03:05:03 -0800 (In reply to comment #7) > (From update of attachment 191415 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191415&action=review Thanks for explanation. I spit it to get this valuable explanation. thanks again. I'll survey more and ask questions :) 847580 10 191415 jturcotte 2013-03-05 05:23:37 -0800 Comment on attachment 191415 Patch (In reply to comment #9) > (In reply to comment #7) > > (From update of attachment 191415 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=191415&action=review > Thanks for explanation. I spit it to get this valuable explanation. thanks again. I'll survey more and ask questions :) Please ask for explanations on IRC, proposing faulty patches to learn is like skipping classes and taking exams until you get it right enough to get a pass grade. 847798 11 191415 simon.fraser 2013-03-05 10:25:16 -0800 Comment on attachment 191415 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191415&action=review > Source/WebCore/ChangeLog:9 > + There are many code that should use canHaveScrollbars() or useFixedLayout() > + instead of delegatesScrolling(). "There are many parts of the code" or "There is much code". This should explain why using delegatesScrolling() is wrong. 848420 12 dongseong.hwang 2013-03-05 20:30:41 -0800 (In reply to comment #10) > (From update of attachment 191415 [details]) > (In reply to comment #9) > Please ask for explanations on IRC, proposing faulty patches to learn is like skipping classes and taking exams until you get it right enough to get a pass grade. Ok, I'll do it. Sorry for skipping classes. see yon in IRC. (In reply to comment #11) > (From update of attachment 191415 [details]) > This should explain why using delegatesScrolling() is wrong. I agree. I'll support. 848569 13 191673 dongseong.hwang 2013-03-06 00:43:10 -0800 Created attachment 191673 Patch 848573 14 191673 kenneth 2013-03-06 00:44:21 -0800 Comment on attachment 191673 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191673&action=review > Source/WebKit2/ChangeLog:17 > + 1. WebChromeClient::contentsSizeChanged() uses canHaveScrollbars(). > + In theory, it is possible for FrameView to have scrollbars although > + FrameView delegates scrolling to UI. So it is more natural to check > + canHaveScrollbars() before scrollbar code. > + > + 2. WebPage::didCompletePageTransition() uses useFixedLayout(). > + EFL and Qt uses PageViewportController that receives > + PageTransitionViewportReady massages when using fixed layout, so it is > + more natural to check useFixedLayout(). > + can't this be tested? 848582 15 dongseong.hwang 2013-03-06 00:48:59 -0800 (In reply to comment #13) > Created an attachment (id=191673) [details] > Patch I remain only WK2 part. (In reply to comment #7) > (From update of attachment 191415 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191415&action=review > I can remember the reason delegatesScrolling() was used was to ensure it only affected the right platforms. You may want to try to run blame on the lines and dig up the bug where we discussed it. I studied the history, and now I understand what is layout viewport and visual viewport. (I added the links that helped you 1 years ago in Reference of https://trac.webkit.org/wiki/ScalesAndZooms) And I posted Bug 11532 to clean up a little on your great work. could you take a look? 848584 16 dongseong.hwang 2013-03-06 00:50:08 -0800 (In reply to comment #14) > (From update of attachment 191673 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191673&action=review > can't this be tested? only in EFL and Qt. I does not have mac book. I'm sorry for Mac. 855710 17 191673 dongseong.hwang 2013-03-14 22:49:22 -0700 Comment on attachment 191673 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191673&action=review >> Source/WebKit2/ChangeLog:17 >> + > > can't this be tested? I think it is hard to test, because this patch does not change behavior actually. 1. WebChromeClient::contentsSizeChanged() uses canHaveScrollbars(). It does not change any WK2 internal behavior. This change only affect whether WKPageHasHorizontalScrollbar can return true or not. 2. WebPage::didCompletePageTransition() uses useFixedLayout(). This routine is used by only EFL and Qt because there is USE(TILED_BACKING_STORE) guard. And when we enable/disable useFixedLayout, delegatesScrolling always is enabled/disabled. 1172573 18 darin 2016-03-09 09:37:01 -0800 Anders, Simon, do you think this is a good change? 1172580 19 simon.fraser 2016-03-09 09:45:16 -0800 iOS uses delegatesScrolling(). We need to be very careful to not break it. 1196130 20 191673 beidson 2016-05-24 21:37:34 -0700 Comment on attachment 191673 Patch r- to clear stale patches from the review queue 191404 2013-03-04 22:45:35 -0800 2013-03-04 23:54:54 -0800 Patch bug-111408-20130305154110.patch text/plain 6211 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThlMDM0YjA2YzEzM2Rh NjY5MzBiNTRkNzdlMzhjYzQ3ZDhjZjliNS4uZjRmNGQ5ODZhODk5ODdhMzRiYzFkMmFlYzMwNzBk ZmFmMzk5ZWQ2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTA0ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIERvbid0IG92 ZXJ1c2UgU2Nyb2xsVmlldzo6ZGVsZWdhdGVzU2Nyb2xsaW5nKCkuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE0MDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBhcmUgbWFueSBjb2RlIHRoYXQg c2hvdWxkIHVzZSBjYW5IYXZlU2Nyb2xsYmFycygpIG9yIHVzZUZpeGVkTGF5b3V0KCkKKyAgICAg ICAgaW5zdGVhZCBvZiBkZWxlZ2F0ZXNTY3JvbGxpbmcoKS4KKworICAgICAgICBObyBuZXcgdGVz dHMuIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmll dy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmxheW91dCk6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZVZpZXc6OnBlcmZvcm1Qb3N0TGF5b3V0VGFza3MpOgorICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc1Njcm9sbExheWVyKToKKwogMjAxMy0wMi0yNiAg SHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBbRUZM XVtRdF0gQ29vcmRpbmF0ZWQgR3JhcGhpY3M6IHNjcm9sbCBhbmltYXRpb24gbWFrZXMgZml4ZWQg ZWxlbWVudCBzaGFrZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA5Nzg0YWNjMzdlYjc4M2M0NGRhNmIyNjNkNDky NmRhNGEyNTM2ZTM4Li5iODRkNjE5M2VjNzE1M2Q0MDZlNzhmYTJiOTI4MGFiYzQyNjUwYTI3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTMtMDMtMDQgIEh1YW5nIERvbmdzdW5nICA8 bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CiAKKyAgICAgICAgRG9uJ3Qgb3ZlcnVzZSBTY3JvbGxW aWV3OjpkZWxlZ2F0ZXNTY3JvbGxpbmcoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMTQwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBtYW55IGNvZGUgdGhhdCBzaG91bGQgdXNlIGNh bkhhdmVTY3JvbGxiYXJzKCkgb3IgdXNlRml4ZWRMYXlvdXQoKQorICAgICAgICBpbnN0ZWFkIG9m IGRlbGVnYXRlc1Njcm9sbGluZygpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDaHJvbWVDbGll bnQ6OmNvbnRlbnRzU2l6ZUNoYW5nZWQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9X ZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6ZGlkQ29tcGxldGVQYWdlVHJh bnNpdGlvbik6CisKKzIwMTMtMDMtMDQgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFu eTEwMC5uZXQ+CisKICAgICAgICAgQ29vcmRpbmF0ZWQgR3JhcGhpY3M6IEFkZCBjb250ZW50c1Np emVEaWRDaGFuZ2UoKSB0byBpbmNyZWFzZSByZWFkYWJpbGl0eS4KICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTQwNwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAKaW5kZXggYTg0ZTU2ZTgxNDk3ZjQ4ZmY2MWIwNzhiNTFjMzk4NWQwNDUxMDUzZi4u Y2ZmOTQ3YTU1ZmQyMThhMjVhMWU4OGU4YThkMjgwZWEwYWEyMTEyZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcApAQCAtMTE5MiwxMCArMTE5MiwxMCBAQCB2b2lkIEZyYW1lVmlldzo6bGF5 b3V0KGJvb2wgYWxsb3dTdWJ0cmVlKQogCiAgICAgICAgICAgICAgICAgICAgIG1fZmlyc3RMYXlv dXQgPSBmYWxzZTsKICAgICAgICAgICAgICAgICAgICAgbV9maXJzdExheW91dENhbGxiYWNrUGVu ZGluZyA9IHRydWU7Ci0gICAgICAgICAgICAgICAgICAgIGlmICh1c2VGaXhlZExheW91dCgpICYm ICFmaXhlZExheW91dFNpemUoKS5pc0VtcHR5KCkgJiYgZGVsZWdhdGVzU2Nyb2xsaW5nKCkpCi0g ICAgICAgICAgICAgICAgICAgICAgICBtX2xhc3RWaWV3cG9ydFNpemUgPSBmaXhlZExheW91dFNp emUoKTsKLSAgICAgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICBpZiAo Y2FuSGF2ZVNjcm9sbGJhcnMoKSkKICAgICAgICAgICAgICAgICAgICAgICAgIG1fbGFzdFZpZXdw b3J0U2l6ZSA9IHZpc2libGVDb250ZW50UmVjdChJbmNsdWRlU2Nyb2xsYmFycykuc2l6ZSgpOwor ICAgICAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgICAgICBtX2xhc3RW aWV3cG9ydFNpemUgPSB2aXNpYmxlQ29udGVudFJlY3QoRXhjbHVkZVNjcm9sbGJhcnMpLnNpemUo KTsKICAgICAgICAgICAgICAgICAgICAgbV9sYXN0Wm9vbUZhY3RvciA9IHJvb3QtPnN0eWxlKCkt Pnpvb20oKTsKIAogICAgICAgICAgICAgICAgICAgICAvLyBTZXQgdGhlIGluaXRpYWwgdk1vZGUg dG8gQWx3YXlzT24gaWYgd2UncmUgYXV0by4KQEAgLTI2NDUsMTAgKzI2NDUsMTAgQEAgdm9pZCBG cmFtZVZpZXc6OnBlcmZvcm1Qb3N0TGF5b3V0VGFza3MoKQogCiAgICAgaWYgKHJlbmRlclZpZXcg JiYgIXJlbmRlclZpZXctPnByaW50aW5nKCkpIHsKICAgICAgICAgSW50U2l6ZSBjdXJyZW50U2l6 ZTsKLSAgICAgICAgaWYgKHVzZUZpeGVkTGF5b3V0KCkgJiYgIWZpeGVkTGF5b3V0U2l6ZSgpLmlz RW1wdHkoKSAmJiBkZWxlZ2F0ZXNTY3JvbGxpbmcoKSkKLSAgICAgICAgICAgIGN1cnJlbnRTaXpl ID0gZml4ZWRMYXlvdXRTaXplKCk7CisgICAgICAgIGlmIChjYW5IYXZlU2Nyb2xsYmFycygpKQor ICAgICAgICAgICAgbV9sYXN0Vmlld3BvcnRTaXplID0gdmlzaWJsZUNvbnRlbnRSZWN0KEluY2x1 ZGVTY3JvbGxiYXJzKS5zaXplKCk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIGN1cnJlbnRT aXplID0gdmlzaWJsZUNvbnRlbnRSZWN0KEluY2x1ZGVTY3JvbGxiYXJzKS5zaXplKCk7CisgICAg ICAgICAgICBtX2xhc3RWaWV3cG9ydFNpemUgPSB2aXNpYmxlQ29udGVudFJlY3QoRXhjbHVkZVNj cm9sbGJhcnMpLnNpemUoKTsKICAgICAgICAgZmxvYXQgY3VycmVudFpvb21GYWN0b3IgPSByZW5k ZXJWaWV3LT5zdHlsZSgpLT56b29tKCk7CiAgICAgICAgIGJvb2wgcmVzaXplZCA9ICFtX2ZpcnN0 TGF5b3V0ICYmIChjdXJyZW50U2l6ZSAhPSBtX2xhc3RWaWV3cG9ydFNpemUgfHwgY3VycmVudFpv b21GYWN0b3IgIT0gbV9sYXN0Wm9vbUZhY3Rvcik7CiAgICAgICAgIG1fbGFzdFZpZXdwb3J0U2l6 ZSA9IGN1cnJlbnRTaXplOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCAxMjYxNDllNjc0MzBjYmFhMjkzODA5MWY3YjdjYTUw MDk1NTVkM2QyLi5hZjAxZjk5ZmI5ZDY4YzczZTU5MjA0ZTZjNzdhMTI0ODBkMDk2MjkwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNw cApAQCAtMjIyNCw3ICsyMjI0LDcgQEAgYm9vbCBSZW5kZXJMYXllckNvbXBvc2l0b3I6Om5lZWRz Q29udGVudHNDb21wb3NpdGluZ0xheWVyKGNvbnN0IFJlbmRlckxheWVyKiBsYXkKIGJvb2wgUmVu ZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc1Njcm9sbExheWVyKFJvb3RMYXllckF0dGFjaG1l bnQgYXR0YWNobWVudCkgY29uc3QKIHsKICAgICAvLyBUaGlzIGFwcGxpZXMgd2hlbiB0aGUgYXBw bGljYXRpb24gVUkgaGFuZGxlcyBzY3JvbGxpbmcsIGluIHdoaWNoIGNhc2UgUmVuZGVyTGF5ZXJD b21wb3NpdG9yIGRvZXNuJ3QgbmVlZCB0byBtYW5hZ2UgaXQuCi0gICAgaWYgKG1fcmVuZGVyVmll dy0+ZnJhbWVWaWV3KCktPmRlbGVnYXRlc1Njcm9sbGluZygpKQorICAgIGlmICghbV9yZW5kZXJW aWV3LT5mcmFtZVZpZXcoKS0+Y2FuSGF2ZVNjcm9sbGJhcnMoKSkKICAgICAgICAgcmV0dXJuIGZh bHNlOwogCiAgICAgLy8gV2UgbmVlZCB0byBoYW5kbGUgb3VyIG93biBzY3JvbGxpbmcgaWYgd2Un cmU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L1dlYkNocm9tZUNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAKaW5kZXggYjc2YTJkMDExMTQ0YWVjZmYyODMwZWQ1 MmRhMzg2YWZhYmJmYWE4My4uNjRjYTUwZDdmZWNhZmYwODgzZjgwNTExY2U1Mzk3MzZjYTQ1MjA3 MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9X ZWJDaHJvbWVDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29y ZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcApAQCAtNDU2LDcgKzQ1Niw3IEBAIHZvaWQgV2Vi Q2hyb21lQ2xpZW50Ojpjb250ZW50c1NpemVDaGFuZ2VkKEZyYW1lKiBmcmFtZSwgY29uc3QgSW50 U2l6ZSYgc2l6ZSkgY29uCiAgICAgbV9wYWdlLT5kcmF3aW5nQXJlYSgpLT5tYWluRnJhbWVDb250 ZW50U2l6ZUNoYW5nZWQoc2l6ZSk7CiAKICAgICBGcmFtZVZpZXcqIGZyYW1lVmlldyA9IGZyYW1l LT52aWV3KCk7Ci0gICAgaWYgKGZyYW1lVmlldyAmJiAhZnJhbWVWaWV3LT5kZWxlZ2F0ZXNTY3Jv bGxpbmcoKSkgIHsKKyAgICBpZiAoZnJhbWVWaWV3ICYmIGZyYW1lVmlldy0+Y2FuSGF2ZVNjcm9s bGJhcnMoKSkgewogICAgICAgICBib29sIGhhc0hvcml6b250YWxTY3JvbGxiYXIgPSBmcmFtZVZp ZXctPmhvcml6b250YWxTY3JvbGxiYXIoKTsKICAgICAgICAgYm9vbCBoYXNWZXJ0aWNhbFNjcm9s bGJhciA9IGZyYW1lVmlldy0+dmVydGljYWxTY3JvbGxiYXIoKTsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IGJlZjY0MzBjODQ5NzNkYjVj NGQ0ZmYyYzc4OTI4YzA2YTBmNjJmODkuLjZiYjFmNDg3NmU5MDQ0MjQ0M2MyYTljMzRlNTQyMmMx YWI4NWMyZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9X ZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5jcHAKQEAgLTE5ODksNyArMTk4OSw3IEBAIHZvaWQgV2ViUGFnZTo6ZGlkU3RhcnRQYWdlVHJh bnNpdGlvbigpCiB2b2lkIFdlYlBhZ2U6OmRpZENvbXBsZXRlUGFnZVRyYW5zaXRpb24oKQogewog I2lmIFVTRShUSUxFRF9CQUNLSU5HX1NUT1JFKQotICAgIGlmIChtX21haW5GcmFtZS0+Y29yZUZy YW1lKCktPnZpZXcoKS0+ZGVsZWdhdGVzU2Nyb2xsaW5nKCkpCisgICAgaWYgKHVzZUZpeGVkTGF5 b3V0KCkpCiAgICAgICAgIC8vIFdhaXQgdW50aWwgdGhlIFVJIHByb2Nlc3Mgc2VudCB1cyB0aGUg dmlzaWJsZSByZWN0IGl0IHdhbnRzIHJlbmRlcmVkLgogICAgICAgICBzZW5kKE1lc3NhZ2VzOjpX ZWJQYWdlUHJveHk6OlBhZ2VUcmFuc2l0aW9uVmlld3BvcnRSZWFkeSgpKTsKICAgICBlbHNlCg== 191415 2013-03-04 23:54:59 -0800 2013-03-06 00:43:06 -0800 Patch bug-111408-20130305165032.patch text/plain 5662 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThlMDM0YjA2YzEzM2Rh NjY5MzBiNTRkNzdlMzhjYzQ3ZDhjZjliNS4uZjRmNGQ5ODZhODk5ODdhMzRiYzFkMmFlYzMwNzBk ZmFmMzk5ZWQ2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTA0ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIERvbid0IG92 ZXJ1c2UgU2Nyb2xsVmlldzo6ZGVsZWdhdGVzU2Nyb2xsaW5nKCkuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE0MDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBhcmUgbWFueSBjb2RlIHRoYXQg c2hvdWxkIHVzZSBjYW5IYXZlU2Nyb2xsYmFycygpIG9yIHVzZUZpeGVkTGF5b3V0KCkKKyAgICAg ICAgaW5zdGVhZCBvZiBkZWxlZ2F0ZXNTY3JvbGxpbmcoKS4KKworICAgICAgICBObyBuZXcgdGVz dHMuIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmll dy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmxheW91dCk6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZVZpZXc6OnBlcmZvcm1Qb3N0TGF5b3V0VGFza3MpOgorICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc1Njcm9sbExheWVyKToKKwogMjAxMy0wMi0yNiAg SHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBbRUZM XVtRdF0gQ29vcmRpbmF0ZWQgR3JhcGhpY3M6IHNjcm9sbCBhbmltYXRpb24gbWFrZXMgZml4ZWQg ZWxlbWVudCBzaGFrZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA5Nzg0YWNjMzdlYjc4M2M0NGRhNmIyNjNkNDky NmRhNGEyNTM2ZTM4Li5iODRkNjE5M2VjNzE1M2Q0MDZlNzhmYTJiOTI4MGFiYzQyNjUwYTI3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTMtMDMtMDQgIEh1YW5nIERvbmdzdW5nICA8 bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CiAKKyAgICAgICAgRG9uJ3Qgb3ZlcnVzZSBTY3JvbGxW aWV3OjpkZWxlZ2F0ZXNTY3JvbGxpbmcoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTExMTQwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBtYW55IGNvZGUgdGhhdCBzaG91bGQgdXNlIGNh bkhhdmVTY3JvbGxiYXJzKCkgb3IgdXNlRml4ZWRMYXlvdXQoKQorICAgICAgICBpbnN0ZWFkIG9m IGRlbGVnYXRlc1Njcm9sbGluZygpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDaHJvbWVDbGll bnQ6OmNvbnRlbnRzU2l6ZUNoYW5nZWQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9X ZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6ZGlkQ29tcGxldGVQYWdlVHJh bnNpdGlvbik6CisKKzIwMTMtMDMtMDQgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFu eTEwMC5uZXQ+CisKICAgICAgICAgQ29vcmRpbmF0ZWQgR3JhcGhpY3M6IEFkZCBjb250ZW50c1Np emVEaWRDaGFuZ2UoKSB0byBpbmNyZWFzZSByZWFkYWJpbGl0eS4KICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTQwNwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAKaW5kZXggYTg0ZTU2ZTgxNDk3ZjQ4ZmY2MWIwNzhiNTFjMzk4NWQwNDUxMDUzZi4u MzU4NWRkY2I3OWYyYmQzOWU4NGYwOWQ2OTYxZTA2OTkxNjk2ZmY0MCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcApAQCAtMTE5Miw3ICsxMTkyLDcgQEAgdm9pZCBGcmFtZVZpZXc6OmxheW91 dChib29sIGFsbG93U3VidHJlZSkKIAogICAgICAgICAgICAgICAgICAgICBtX2ZpcnN0TGF5b3V0 ID0gZmFsc2U7CiAgICAgICAgICAgICAgICAgICAgIG1fZmlyc3RMYXlvdXRDYWxsYmFja1BlbmRp bmcgPSB0cnVlOwotICAgICAgICAgICAgICAgICAgICBpZiAodXNlRml4ZWRMYXlvdXQoKSAmJiAh Zml4ZWRMYXlvdXRTaXplKCkuaXNFbXB0eSgpICYmIGRlbGVnYXRlc1Njcm9sbGluZygpKQorICAg ICAgICAgICAgICAgICAgICBpZiAodXNlRml4ZWRMYXlvdXQoKSAmJiAhZml4ZWRMYXlvdXRTaXpl KCkuaXNFbXB0eSgpICYmIHVzZUZpeGVkTGF5b3V0KCkpCiAgICAgICAgICAgICAgICAgICAgICAg ICBtX2xhc3RWaWV3cG9ydFNpemUgPSBmaXhlZExheW91dFNpemUoKTsKICAgICAgICAgICAgICAg ICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICAgICAgbV9sYXN0Vmlld3BvcnRTaXplID0g dmlzaWJsZUNvbnRlbnRSZWN0KEluY2x1ZGVTY3JvbGxiYXJzKS5zaXplKCk7CkBAIC0yNjQ1LDcg KzI2NDUsNyBAQCB2b2lkIEZyYW1lVmlldzo6cGVyZm9ybVBvc3RMYXlvdXRUYXNrcygpCiAKICAg ICBpZiAocmVuZGVyVmlldyAmJiAhcmVuZGVyVmlldy0+cHJpbnRpbmcoKSkgewogICAgICAgICBJ bnRTaXplIGN1cnJlbnRTaXplOwotICAgICAgICBpZiAodXNlRml4ZWRMYXlvdXQoKSAmJiAhZml4 ZWRMYXlvdXRTaXplKCkuaXNFbXB0eSgpICYmIGRlbGVnYXRlc1Njcm9sbGluZygpKQorICAgICAg ICBpZiAodXNlRml4ZWRMYXlvdXQoKSAmJiAhZml4ZWRMYXlvdXRTaXplKCkuaXNFbXB0eSgpICYm IHVzZUZpeGVkTGF5b3V0KCkpCiAgICAgICAgICAgICBjdXJyZW50U2l6ZSA9IGZpeGVkTGF5b3V0 U2l6ZSgpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBjdXJyZW50U2l6ZSA9IHZpc2libGVD b250ZW50UmVjdChJbmNsdWRlU2Nyb2xsYmFycykuc2l6ZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCAxMjYxNDllNjc0 MzBjYmFhMjkzODA5MWY3YjdjYTUwMDk1NTVkM2QyLi5hZjAxZjk5ZmI5ZDY4YzczZTU5MjA0ZTZj NzdhMTI0ODBkMDk2MjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtMjIyNCw3ICsyMjI0LDcgQEAgYm9vbCBSZW5kZXJM YXllckNvbXBvc2l0b3I6Om5lZWRzQ29udGVudHNDb21wb3NpdGluZ0xheWVyKGNvbnN0IFJlbmRl ckxheWVyKiBsYXkKIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc1Njcm9sbExh eWVyKFJvb3RMYXllckF0dGFjaG1lbnQgYXR0YWNobWVudCkgY29uc3QKIHsKICAgICAvLyBUaGlz IGFwcGxpZXMgd2hlbiB0aGUgYXBwbGljYXRpb24gVUkgaGFuZGxlcyBzY3JvbGxpbmcsIGluIHdo aWNoIGNhc2UgUmVuZGVyTGF5ZXJDb21wb3NpdG9yIGRvZXNuJ3QgbmVlZCB0byBtYW5hZ2UgaXQu Ci0gICAgaWYgKG1fcmVuZGVyVmlldy0+ZnJhbWVWaWV3KCktPmRlbGVnYXRlc1Njcm9sbGluZygp KQorICAgIGlmICghbV9yZW5kZXJWaWV3LT5mcmFtZVZpZXcoKS0+Y2FuSGF2ZVNjcm9sbGJhcnMo KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgLy8gV2UgbmVlZCB0byBoYW5kbGUgb3Vy IG93biBzY3JvbGxpbmcgaWYgd2UncmU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAKaW5kZXggYjc2 YTJkMDExMTQ0YWVjZmYyODMwZWQ1MmRhMzg2YWZhYmJmYWE4My4uNjRjYTUwZDdmZWNhZmYwODgz ZjgwNTExY2U1Mzk3MzZjYTQ1MjA3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcApAQCAtNDU2 LDcgKzQ1Niw3IEBAIHZvaWQgV2ViQ2hyb21lQ2xpZW50Ojpjb250ZW50c1NpemVDaGFuZ2VkKEZy YW1lKiBmcmFtZSwgY29uc3QgSW50U2l6ZSYgc2l6ZSkgY29uCiAgICAgbV9wYWdlLT5kcmF3aW5n QXJlYSgpLT5tYWluRnJhbWVDb250ZW50U2l6ZUNoYW5nZWQoc2l6ZSk7CiAKICAgICBGcmFtZVZp ZXcqIGZyYW1lVmlldyA9IGZyYW1lLT52aWV3KCk7Ci0gICAgaWYgKGZyYW1lVmlldyAmJiAhZnJh bWVWaWV3LT5kZWxlZ2F0ZXNTY3JvbGxpbmcoKSkgIHsKKyAgICBpZiAoZnJhbWVWaWV3ICYmIGZy YW1lVmlldy0+Y2FuSGF2ZVNjcm9sbGJhcnMoKSkgewogICAgICAgICBib29sIGhhc0hvcml6b250 YWxTY3JvbGxiYXIgPSBmcmFtZVZpZXctPmhvcml6b250YWxTY3JvbGxiYXIoKTsKICAgICAgICAg Ym9vbCBoYXNWZXJ0aWNhbFNjcm9sbGJhciA9IGZyYW1lVmlldy0+dmVydGljYWxTY3JvbGxiYXIo KTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmlu ZGV4IGJlZjY0MzBjODQ5NzNkYjVjNGQ0ZmYyYzc4OTI4YzA2YTBmNjJmODkuLjZiYjFmNDg3NmU5 MDQ0MjQ0M2MyYTljMzRlNTQyMmMxYWI4NWMyZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTE5ODksNyArMTk4OSw3IEBAIHZvaWQgV2Vi UGFnZTo6ZGlkU3RhcnRQYWdlVHJhbnNpdGlvbigpCiB2b2lkIFdlYlBhZ2U6OmRpZENvbXBsZXRl UGFnZVRyYW5zaXRpb24oKQogewogI2lmIFVTRShUSUxFRF9CQUNLSU5HX1NUT1JFKQotICAgIGlm IChtX21haW5GcmFtZS0+Y29yZUZyYW1lKCktPnZpZXcoKS0+ZGVsZWdhdGVzU2Nyb2xsaW5nKCkp CisgICAgaWYgKHVzZUZpeGVkTGF5b3V0KCkpCiAgICAgICAgIC8vIFdhaXQgdW50aWwgdGhlIFVJ IHByb2Nlc3Mgc2VudCB1cyB0aGUgdmlzaWJsZSByZWN0IGl0IHdhbnRzIHJlbmRlcmVkLgogICAg ICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OlBhZ2VUcmFuc2l0aW9uVmlld3BvcnRS ZWFkeSgpKTsKICAgICBlbHNlCg== 191673 2013-03-06 00:43:10 -0800 2022-02-27 23:32:32 -0800 Patch bug-111408-20130306173840.patch text/plain 2994 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDk4Yjg4YzE4ZmJjNzdh MmYyY2ZlNGEwOWVkZTUzNjk5NzQ2YzkwYS4uYzc2NWVlMjYyYjYxMDU3NjExMDBjMjFlNWJlZDhm ZWMzMzk5MTc4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEzLTAzLTA0ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIFtXSzJdIFVz ZSBjYW5IYXZlU2Nyb2xsYmFycygpIG9yIHVzZUZpeGVkTGF5b3V0KCkgaW5zdGVhZCBvZiBkZWxl Z2F0ZXNTY3JvbGxpbmcoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMTQwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIDEuIFdlYkNocm9tZUNsaWVudDo6Y29udGVudHNTaXplQ2hhbmdlZCgpIHVzZXMg Y2FuSGF2ZVNjcm9sbGJhcnMoKS4KKyAgICAgICAgSW4gdGhlb3J5LCBpdCBpcyBwb3NzaWJsZSBm b3IgRnJhbWVWaWV3IHRvIGhhdmUgc2Nyb2xsYmFycyBhbHRob3VnaAorICAgICAgICBGcmFtZVZp ZXcgZGVsZWdhdGVzIHNjcm9sbGluZyB0byBVSS4gU28gaXQgaXMgbW9yZSBuYXR1cmFsIHRvIGNo ZWNrCisgICAgICAgIGNhbkhhdmVTY3JvbGxiYXJzKCkgYmVmb3JlIHNjcm9sbGJhciBjb2RlLgor CisgICAgICAgIDIuIFdlYlBhZ2U6OmRpZENvbXBsZXRlUGFnZVRyYW5zaXRpb24oKSB1c2VzIHVz ZUZpeGVkTGF5b3V0KCkuCisgICAgICAgIEVGTCBhbmQgUXQgdXNlcyBQYWdlVmlld3BvcnRDb250 cm9sbGVyIHRoYXQgcmVjZWl2ZXMKKyAgICAgICAgUGFnZVRyYW5zaXRpb25WaWV3cG9ydFJlYWR5 IG1hc3NhZ2VzIHdoZW4gdXNpbmcgZml4ZWQgbGF5b3V0LCBzbyBpdCBpcworICAgICAgICBtb3Jl IG5hdHVyYWwgdG8gY2hlY2sgdXNlRml4ZWRMYXlvdXQoKS4KKworICAgICAgICAqIFdlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViQ2hyb21lQ2xpZW50Ojpjb250ZW50c1NpemVDaGFuZ2VkKToKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmRpZENv bXBsZXRlUGFnZVRyYW5zaXRpb24pOgorCisyMDEzLTAzLTA0ICBIdWFuZyBEb25nc3VuZyAgPGx1 eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCiAgICAgICAgIFtFRkxdW1F0XVtXSzJdIE1ha2UgUGFn ZVZpZXdwb3J0Q29udHJvbGxlciBtb3JlIHJlYWRhYmxlLgogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExNDA1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNw cAppbmRleCBiNzZhMmQwMTExNDRhZWNmZjI4MzBlZDUyZGEzODZhZmFiYmZhYTgzLi42NGNhNTBk N2ZlY2FmZjA4ODNmODA1MTFjZTUzOTczNmNhNDUyMDcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQu Y3BwCkBAIC00NTYsNyArNDU2LDcgQEAgdm9pZCBXZWJDaHJvbWVDbGllbnQ6OmNvbnRlbnRzU2l6 ZUNoYW5nZWQoRnJhbWUqIGZyYW1lLCBjb25zdCBJbnRTaXplJiBzaXplKSBjb24KICAgICBtX3Bh Z2UtPmRyYXdpbmdBcmVhKCktPm1haW5GcmFtZUNvbnRlbnRTaXplQ2hhbmdlZChzaXplKTsKIAog ICAgIEZyYW1lVmlldyogZnJhbWVWaWV3ID0gZnJhbWUtPnZpZXcoKTsKLSAgICBpZiAoZnJhbWVW aWV3ICYmICFmcmFtZVZpZXctPmRlbGVnYXRlc1Njcm9sbGluZygpKSAgeworICAgIGlmIChmcmFt ZVZpZXcgJiYgZnJhbWVWaWV3LT5jYW5IYXZlU2Nyb2xsYmFycygpKSB7CiAgICAgICAgIGJvb2wg aGFzSG9yaXpvbnRhbFNjcm9sbGJhciA9IGZyYW1lVmlldy0+aG9yaXpvbnRhbFNjcm9sbGJhcigp OwogICAgICAgICBib29sIGhhc1ZlcnRpY2FsU2Nyb2xsYmFyID0gZnJhbWVWaWV3LT52ZXJ0aWNh bFNjcm9sbGJhcigpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKaW5kZXggZDBkZGIwNGMwZWFkNjY4YzBmY2Y4MTllY2IxYTBlNmYwOGM5ZTU4Ni4u Y2E2YzA4NTY2NGU2NGU0ZTg3MjU1YTA2ZWM0Mjg1YTY4ODUwYzkzMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtMTk4OSw3ICsxOTg5LDcg QEAgdm9pZCBXZWJQYWdlOjpkaWRTdGFydFBhZ2VUcmFuc2l0aW9uKCkKIHZvaWQgV2ViUGFnZTo6 ZGlkQ29tcGxldGVQYWdlVHJhbnNpdGlvbigpCiB7CiAjaWYgVVNFKFRJTEVEX0JBQ0tJTkdfU1RP UkUpCi0gICAgaWYgKG1fbWFpbkZyYW1lLT5jb3JlRnJhbWUoKS0+dmlldygpLT5kZWxlZ2F0ZXNT Y3JvbGxpbmcoKSkKKyAgICBpZiAodXNlRml4ZWRMYXlvdXQoKSkKICAgICAgICAgLy8gV2FpdCB1 bnRpbCB0aGUgVUkgcHJvY2VzcyBzZW50IHVzIHRoZSB2aXNpYmxlIHJlY3QgaXQgd2FudHMgcmVu ZGVyZWQuCiAgICAgICAgIHNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6UGFnZVRyYW5zaXRp b25WaWV3cG9ydFJlYWR5KCkpOwogICAgIGVsc2UK