111407 2013-03-04 22:21:17 -0800 Coordinated Graphics: Add contentsSizeDidChange() to increase readability. 2013-10-11 08:05:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 110066 1 dongseong.hwang dongseong.hwang andersca cmarcelo kenneth luiz noam simon.fraser webkit.review.bot zeno oldest_to_newest 847276 0 dongseong.hwang 2013-03-04 22:21:17 -0800 Add contentsSizeDidChange() to prevent from overusing sizeDidChange() callback when contents size is changed. 847279 1 191402 dongseong.hwang 2013-03-04 22:23:54 -0800 Created attachment 191402 Patch 851030 2 191402 noam 2013-03-08 02:39:17 -0800 Comment on attachment 191402 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191402&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:240 > + if (!m_webPage->useFixedLayout()) > + nonCompositedContentsSizeDidChange(newSize); > +} > + > +void CoordinatedLayerTreeHost::contentsSizeDidChange(const IntSize& newSize) > +{ > + if (m_webPage->useFixedLayout()) > + nonCompositedContentsSizeDidChange(newSize); This looks funny... I don't understand how CLTHost deals with fixed layout vs. non-fixed layout. Does any port even use CoordinatedGraphics without fixed layout? Is that tested anywhere? 851038 3 dongseong.hwang 2013-03-08 02:49:28 -0800 (In reply to comment #2) > (From update of attachment 191402 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191402&action=review > This looks funny... I don't understand how CLTHost deals with fixed layout vs. non-fixed layout. > Does any port even use CoordinatedGraphics without fixed layout? Is that tested anywhere? I agree that it's funny. I hope Coordinated Graphics does not deal with non-fixed layout in the future. I think WebKitTestRunner does not use fixedLayout in both EFL and Qt. 851039 4 dongseong.hwang 2013-03-08 02:53:52 -0800 I filed this bug to prepare Bug 110066. When turning off delegatesScrolling and fixedVisibleContentsRect, CoordinatedLayerTreeHost need to update visible contents rect when WebPage::m_viewSize is changed. However, currently CoordinatedLayerTreeHost does not know when WebPage::m_viewSize is changed. So I filed this bug. and, I think this patch increases readability a little bit. 855721 5 dongseong.hwang 2013-03-14 23:05:45 -0700 The sub goal of this patch clarifies as follows: o. if coordinated graphics uses fixed layout, the size of non composited contents is contents size. o. if coordinated graphics does not use fixed layout, the size of non composited contents is view size. WDYT? 938794 6 191402 noam 2013-10-11 08:05:14 -0700 Comment on attachment 191402 Patch Clearing review flags for now. 191402 2013-03-04 22:23:54 -0800 2013-10-11 08:05:13 -0700 Patch bug-111407-20130305151928.patch text/plain 6585 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWQ3MmIzOTcwMjk1MGY3 MjM4MmUxYjg4Y2EzNWM5Yjc4NmYxYzUxNC4uOTc4NGFjYzM3ZWI3ODNjNDRkYTZiMjYzZDQ5MjZk YTRhMjUzNmUzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDEzLTAzLTA0ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIENvb3JkaW5h dGVkIEdyYXBoaWNzOiBBZGQgY29udGVudHNTaXplRGlkQ2hhbmdlKCkgdG8gaW5jcmVhc2UgcmVh ZGFiaWxpdHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMTE0MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgY29udGVudHNTaXplRGlkQ2hhbmdlKCkgdG8gcHJldmVudCBmcm9tIG92ZXJ1c2luZyBz aXplRGlkQ2hhbmdlKCkgY2FsbGJhY2sKKyAgICAgICAgd2hlbiBjb250ZW50cyBzaXplIGlzIGNo YW5nZWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNs aWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkNocm9tZUNsaWVudDo6Y29udGVudHNTaXpl Q2hhbmdlZCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29vcmRp bmF0ZWRMYXllclRyZWVIb3N0OjpzaXplRGlkQ2hhbmdlKToKKyAgICAgICAgKFdlYktpdCk6Cisg ICAgICAgIChXZWJLaXQ6OkNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6Y29udGVudHNTaXplRGlk Q2hhbmdlKToKKyAgICAgICAgKFdlYktpdDo6Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0Ojpub25D b21wb3NpdGVkQ29udGVudHNTaXplRGlkQ2hhbmdlKToKKyAgICAgICAgICAgIFNldCBtX3Nob3Vs ZFN5bmNGcmFtZSB0byB0cnVlIHRvIG5vdGlmeSB0byBVSSBQcm9jZXNzLgorICAgICAgICAqIFdl YlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVl SG9zdC5oOgorICAgICAgICAoQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0KToKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 RHJhd2luZ0FyZWFJbXBsOjp1cGRhdGVCYWNraW5nU3RvcmVTdGF0ZSk6CisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQYWdlL0xheWVyVHJlZUhvc3QuaDoKKyAgICAgICAgKFdlYktpdDo6TGF5ZXJU cmVlSG9zdDo6Y29udGVudHNTaXplRGlkQ2hhbmdlKToKKworMjAxMy0wMy0wNCAgSHVhbmcgRG9u Z3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KKwogICAgICAgICBDb29yZGluYXRlZCBH cmFwaGljczogSGFuZGxlIHNjcm9sbGluZyBjb3JyZWN0bHkuCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE0MDYKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQu Y3BwCmluZGV4IDZiM2FkZjI3NWI5MGUzNjMzNDVlNDVhYzA5NmJmZDdlN2VkYTVlNzUuLmI3NmEy ZDAxMTE0NGFlY2ZmMjgzMGVkNTJkYTM4NmFmYWJiZmFhODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVu dC5jcHAKQEAgLTQ0OSw5ICs0NDksNyBAQCB2b2lkIFdlYkNocm9tZUNsaWVudDo6Y29udGVudHNT aXplQ2hhbmdlZChGcmFtZSogZnJhbWUsIGNvbnN0IEludFNpemUmIHNpemUpIGNvbgogICAgICAg ICByZXR1cm47CiAKICNpZiBVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1MpCi0gICAgaWYgKG1fcGFn ZS0+dXNlRml4ZWRMYXlvdXQoKSkKLSAgICAgICAgbV9wYWdlLT5kcmF3aW5nQXJlYSgpLT5sYXll clRyZWVIb3N0KCktPnNpemVEaWRDaGFuZ2Uoc2l6ZSk7Ci0KKyAgICBtX3BhZ2UtPmRyYXdpbmdB cmVhKCktPmxheWVyVHJlZUhvc3QoKS0+Y29udGVudHNTaXplRGlkQ2hhbmdlKHNpemUpOwogICAg IG1fcGFnZS0+c2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpEaWRDaGFuZ2VDb250ZW50c1Np emUoc2l6ZSkpOwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGlj cy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwCmluZGV4IGJjMmY4MmQ0ZjgyYjhhNzIyMTEz NGZjMGZjYmJjOGE5ZGFiMGUwZTcuLjIwMDViNWZhMGE0ZGM1YmZmMTc3NWYzZDlmMzZiMjI2ZGEx YWQ2N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29y ZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0 ZWRMYXllclRyZWVIb3N0LmNwcApAQCAtMjI4LDExICsyMjgsMjQgQEAgYm9vbCBDb29yZGluYXRl ZExheWVyVHJlZUhvc3Q6OmZvcmNlUmVwYWludEFzeW5jKHVpbnQ2NF90IGNhbGxiYWNrSUQpCiAg ICAgcmV0dXJuIHRydWU7CiB9CiAKLXZvaWQgQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0OjpzaXpl RGlkQ2hhbmdlKGNvbnN0IFdlYkNvcmU6OkludFNpemUmIG5ld1NpemUpCit2b2lkIENvb3JkaW5h dGVkTGF5ZXJUcmVlSG9zdDo6c2l6ZURpZENoYW5nZShjb25zdCBJbnRTaXplJiBuZXdTaXplKQor eworICAgIGlmICghbV93ZWJQYWdlLT51c2VGaXhlZExheW91dCgpKQorICAgICAgICBub25Db21w b3NpdGVkQ29udGVudHNTaXplRGlkQ2hhbmdlKG5ld1NpemUpOworfQorCit2b2lkIENvb3JkaW5h dGVkTGF5ZXJUcmVlSG9zdDo6Y29udGVudHNTaXplRGlkQ2hhbmdlKGNvbnN0IEludFNpemUmIG5l d1NpemUpCit7CisgICAgaWYgKG1fd2ViUGFnZS0+dXNlRml4ZWRMYXlvdXQoKSkKKyAgICAgICAg bm9uQ29tcG9zaXRlZENvbnRlbnRzU2l6ZURpZENoYW5nZShuZXdTaXplKTsKK30KKwordm9pZCBD b29yZGluYXRlZExheWVyVHJlZUhvc3Q6Om5vbkNvbXBvc2l0ZWRDb250ZW50c1NpemVEaWRDaGFu Z2UoY29uc3QgSW50U2l6ZSYgbmV3U2l6ZSkKIHsKICAgICBpZiAobV9yb290TGF5ZXItPnNpemUo KSA9PSBuZXdTaXplKQogICAgICAgICByZXR1cm47CiAKKyAgICBtX3Nob3VsZFN5bmNGcmFtZSA9 IHRydWU7CiAgICAgbV9yb290TGF5ZXItPnNldFNpemUobmV3U2l6ZSk7CiAKICAgICAvLyBJZiB0 aGUgbmV3U2l6ZSBleHBvc2VzIG5ldyBhcmVhcyBvZiB0aGUgbm9uLWNvbXBvc2l0ZWQgY29udGVu dCBhIHNldE5lZWRzRGlzcGxheSBpcyBuZWVkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJU cmVlSG9zdC5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVk R3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmgKaW5kZXggYjYwNTI4OTA5ZjdlYjli NjcxM2MxZTk5NmE4Y2U4NzAxOTY1MzI0ZS4uYzBiYmU4NjhiOGZkZGYyZmY2MTQ3NTEwZmRhMjhm YzZkOWMxYjA0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmgKKysrIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRp bmF0ZWRMYXllclRyZWVIb3N0LmgKQEAgLTcwLDYgKzcwLDcgQEAgcHVibGljOgogICAgIHZpcnR1 YWwgdm9pZCBmb3JjZVJlcGFpbnQoKTsKICAgICB2aXJ0dWFsIGJvb2wgZm9yY2VSZXBhaW50QXN5 bmModWludDY0X3QgY2FsbGJhY2tJRCk7CiAgICAgdmlydHVhbCB2b2lkIHNpemVEaWRDaGFuZ2Uo Y29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgbmV3U2l6ZSk7CisgICAgdmlydHVhbCB2b2lkIGNvbnRl bnRzU2l6ZURpZENoYW5nZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJiBuZXdTaXplKSBPVkVSUklE RTsKIAogICAgIHZpcnR1YWwgdm9pZCBkaWRJbnN0YWxsUGFnZU92ZXJsYXkoKTsKICAgICB2aXJ0 dWFsIHZvaWQgZGlkVW5pbnN0YWxsUGFnZU92ZXJsYXkoKTsKQEAgLTE1NSw2ICsxNTYsNyBAQCBw cml2YXRlOgogICAgIHZvaWQgc3luY0Rpc3BsYXlTdGF0ZSgpOwogICAgIHZvaWQgbG9ja0FuaW1h dGlvbnMoKTsKICAgICB2b2lkIHVubG9ja0FuaW1hdGlvbnMoKTsKKyAgICB2b2lkIG5vbkNvbXBv c2l0ZWRDb250ZW50c1NpemVEaWRDaGFuZ2UoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYpOwogCiAg ICAgdm9pZCBsYXllckZsdXNoVGltZXJGaXJlZChXZWJDb3JlOjpUaW1lcjxDb29yZGluYXRlZExh eWVyVHJlZUhvc3Q+Kik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL0RyYXdpbmdBcmVhSW1wbC5jcHAKaW5kZXggZTliNmRlYTZiMzY3YzlkZjAwNGNiNmVj NTdmZTRlNDgwZjZlYThkOS4uZTJiYzkwZjIxNDAzZjE1ZGFhNThjNzcxN2EwYTU2M2ExYTYyYjVi MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdB cmVhSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdp bmdBcmVhSW1wbC5jcHAKQEAgLTM5MiwxMyArMzkyLDkgQEAgdm9pZCBEcmF3aW5nQXJlYUltcGw6 OnVwZGF0ZUJhY2tpbmdTdG9yZVN0YXRlKHVpbnQ2NF90IHN0YXRlSUQsIGJvb2wgcmVzcG9uZElt bWUKICAgICAgICAgbV93ZWJQYWdlLT5sYXlvdXRJZk5lZWRlZCgpOwogICAgICAgICBtX3dlYlBh Z2UtPnNjcm9sbE1haW5GcmFtZUlmTm90QXRNYXhTY3JvbGxQb3NpdGlvbihzY3JvbGxPZmZzZXQp OwogCi0gICAgICAgIGlmIChtX2xheWVyVHJlZUhvc3QpIHsKLSNpZiBVU0UoQ09PUkRJTkFURURf R1JBUEhJQ1MpCi0gICAgICAgICAgICAvLyBDb29yZGluYXRlZCBHcmFwaGljcyBzZXRzIHRoZSBz aXplIG9mIHRoZSByb290IGxheWVyIHRvIGNvbnRlbnRzIHNpemUuCi0gICAgICAgICAgICBpZiAo IW1fd2ViUGFnZS0+dXNlRml4ZWRMYXlvdXQoKSkKLSNlbmRpZgotICAgICAgICAgICAgICAgIG1f bGF5ZXJUcmVlSG9zdC0+c2l6ZURpZENoYW5nZShtX3dlYlBhZ2UtPnNpemUoKSk7Ci0gICAgICAg IH0gZWxzZQorICAgICAgICBpZiAobV9sYXllclRyZWVIb3N0KQorICAgICAgICAgICAgbV9sYXll clRyZWVIb3N0LT5zaXplRGlkQ2hhbmdlKG1fd2ViUGFnZS0+c2l6ZSgpKTsKKyAgICAgICAgZWxz ZQogICAgICAgICAgICAgbV9kaXJ0eVJlZ2lvbiA9IG1fd2ViUGFnZS0+Ym91bmRzKCk7CiAgICAg fSBlbHNlIHsKICAgICAgICAgQVNTRVJUKHNpemUgPT0gbV93ZWJQYWdlLT5zaXplKCkpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0xheWVyVHJlZUhvc3Qu aCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9MYXllclRyZWVIb3N0LmgKaW5k ZXggMzlmZWY4MjRmYTI5NGE1YjVmZTZhMTNhMTU2NzU5MzVmZTczNWFjOS4uYTJmZDRiMGYzMTY5 MmYxYWUyOWZjZGI0YmZjOTBhZDJkNjcyZDE5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQYWdlL0xheWVyVHJlZUhvc3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvTGF5ZXJUcmVlSG9zdC5oCkBAIC04NSw2ICs4NSw3IEBAIHB1Ymxp YzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0QmFja2dyb3VuZENvbG9yKGNvbnN0IFdlYkNvcmU6OkNv bG9yJikgeyB9CiAKICNpZiBVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1MpCisgICAgdmlydHVhbCB2 b2lkIGNvbnRlbnRzU2l6ZURpZENoYW5nZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJikgeyB9Owog ICAgIHZpcnR1YWwgdm9pZCBzZXRWaXNpYmxlQ29udGVudHNSZWN0KGNvbnN0IFdlYkNvcmU6OkZs b2F0UmVjdCYsIGZsb2F0IC8qIHNjYWxlICovLCBjb25zdCBXZWJDb3JlOjpGbG9hdFBvaW50Jikg eyB9CiAgICAgdmlydHVhbCB2b2lkIHJlbmRlck5leHRGcmFtZSgpIHsgfQogICAgIHZpcnR1YWwg dm9pZCBwdXJnZUJhY2tpbmdTdG9yZXMoKSB7IH0K