111398 2013-03-04 19:59:32 -0800 [GTK] Enable translations for WebKit2 2013-03-07 08:31:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gustavo gustavo cgarcia mrobinson oldest_to_newest 847207 0 gustavo 2013-03-04 19:59:32 -0800 [GTK] Enable translations for WebKit2 847216 1 191386 gustavo 2013-03-04 20:15:25 -0800 Created attachment 191386 Enable translation for WebKit2GTK+ Something that we might want to consider: custom rule that installs .mo files a second time but with a different name for WebKit2GTK+, which would need adjusting our usage of GETTEXT_PACKAGE as well, but would allow having different versions of wk1gtk and wk2gtk installed. I am not sure if it's really useful to have this flexibility - the Debian package sure would build both from the same source, so there would always be the same version of both in the archive, in addition, sharing is a good thing. But... something that needs considering. 847619 2 191484 gustavo 2013-03-05 06:34:38 -0800 Created attachment 191484 Patch for EWS 847674 3 mrobinson 2013-03-05 07:38:25 -0800 Do you also need to update the paths listed in POTFILES.in? I think you can tell if it's working properly by running intltool-update -m from the directory containing POTFILES.in. 847677 4 gustavo 2013-03-05 07:48:15 -0800 Unsure why the patch is not getting applied. 847684 5 gustavo 2013-03-05 07:58:42 -0800 (In reply to comment #3) > Do you also need to update the paths listed in POTFILES.in? I think you can tell if it's working properly by running intltool-update -m from the directory containing POTFILES.in. Good catch! I haven't been able to properly test this locally because everything complains libc doesn't know the locale and it falls back to C, my system apps all work, though, I asked in #gnome-hackers but got no reply, let me know if any of you has a clue what may be causing this in my jhbuild env? 847690 6 mrobinson 2013-03-05 08:05:39 -0800 (In reply to comment #5) > Good catch! I haven't been able to properly test this locally because everything complains libc doesn't know the locale and it falls back to C, my system apps all work, though, I asked in #gnome-hackers but got no reply, let me know if any of you has a clue what may be causing this in my jhbuild env? Sorry. I'm pretty clueless about translations except for the basics about getting intltool working. 847703 7 191501 gustavo 2013-03-05 08:25:37 -0800 Created attachment 191501 Patch for EWS 847704 8 gustavo 2013-03-05 08:27:00 -0800 (In reply to comment #6) > Sorry. I'm pretty clueless about translations except for the basics about getting intltool working. Guess I'll make dist and try it out on a debian package ;) 847716 9 gustavo 2013-03-05 08:47:43 -0800 I tested applying the patch locally with svn-apply and the error seems to be sr@latin.po and sr.po cause failed hunks, I'll see if I can figure out what that is. 849592 10 191886 gustavo 2013-03-06 18:39:01 -0800 Created attachment 191886 Patch This has been properly tested, it turns out what was causing my "locale not supported" issues was setting LC_ALL explicitly in the wk2 process launcher. I believe that should not be needed, let me know if there's some use case that was supposed to support that I should test. I don't think the EWS will be able to apply this one as well, I haven't figured out why the sr*.po files cause trouble, I think we'll have to land this one without the help of the EWS and CQ... let me know if it looks OK to you 849620 11 191886 mrobinson 2013-03-06 19:13:43 -0800 Comment on attachment 191886 Patch Looks good, apart from the fact that the paths in the po files are incorrect. Maybe there's a way to automatically fix those. :( 850116 12 191886 gustavo 2013-03-07 08:31:02 -0800 Comment on attachment 191886 Patch http://trac.webkit.org/changeset/145081 191386 2013-03-04 20:15:25 -0800 2013-03-05 06:34:38 -0800 Enable translation for WebKit2GTK+ 0001-Patch.patch text/plain 0 gustavo 191484 2013-03-05 06:34:38 -0800 2013-03-05 08:25:37 -0800 Patch for EWS 0001-Patch.patch text/plain 0 gustavo 191501 2013-03-05 08:25:37 -0800 2013-03-06 18:39:01 -0800 Patch for EWS 0001-Patch.patch text/plain 0 gustavo 191886 2013-03-06 18:39:01 -0800 2013-03-07 08:31:02 -0800 Patch 0001-Patch.patch text/plain 0 gustavo