111389 2013-03-04 17:47:34 -0800 Add PerformanceTest for document startup via iframe append/remove 2013-03-07 03:27:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110876 1 eric eric abarth dcarney haraken jochen mkwst nduca peter rniwa tonyg oldest_to_newest 847109 0 eric 2013-03-04 17:47:34 -0800 Add PerformanceTest for document startup via iframe append/remove 847113 1 191367 eric 2013-03-04 17:50:02 -0800 Created attachment 191367 Patch 847115 2 eric 2013-03-04 17:51:04 -0800 The poor performance of our iframe startup is the root cause behind the timeouts in bug 110876. 847116 3 191367 haraken 2013-03-04 17:51:43 -0800 Comment on attachment 191367 Patch Looks good! 847117 4 haraken 2013-03-04 17:51:58 -0800 Is someone working on improving the performance? 847123 5 eric 2013-03-04 17:56:14 -0800 %run-perf-tests DOM/iframe-append-remove.html --chromium --release [/src/WebKit/PerformanceTests] Running 1 tests Running DOM/iframe-append-remove.html (1 of 1) DESCRIPTION: This benchmark tests adding/removing an iframe from the DOM RESULT DOM: iframe-append-remove: Runs= 69.4810809919 runs/s median= 69.4740711458 runs/s, stdev= 1.9264792407 runs/s, min= 65.68248037 runs/s, max= 74.5266625482 runs/s RESULT DOM: iframe-append-remove: JSHeap= 55972944.8 bytes median= 56490824.0 bytes, stdev= 3181796.3693 bytes, min= 46464360.0 bytes, max= 58860160.0 bytes RESULT DOM: iframe-append-remove: Malloc= 0.0 bytes median= 0.0 bytes, stdev= 0.0 bytes, min= 0.0 bytes, max= 0.0 bytes Finished: 23.599536 s %run-perf-tests DOM/iframe-append-remove.html --chromium --debug [/src/WebKit/PerformanceTests] Running 1 tests Running DOM/iframe-append-remove.html (1 of 1) DESCRIPTION: This benchmark tests adding/removing an iframe from the DOM RESULT DOM: iframe-append-remove: Runs= 4.77791539633 runs/s median= 4.75796009956 runs/s, stdev= 0.0924369707694 runs/s, min= 4.58572029651 runs/s, max= 4.91179038154 runs/s RESULT DOM: iframe-append-remove: JSHeap= 9151589.2 bytes median= 9546816.0 bytes, stdev= 892193.548796 bytes, min= 7730712.0 bytes, max= 10387696.0 bytes RESULT DOM: iframe-append-remove: Malloc= 0.0 bytes median= 0.0 bytes, stdev= 0.0 bytes, min= 0.0 bytes, max= 0.0 bytes Finished: 33.710775 s Note the values of interest: Release: RESULT DOM: iframe-append-remove: Runs= 69.4810809919 runs/s Debug: RESULT DOM: iframe-append-remove: Runs= 4.77791539633 runs/s run-perf-tests is found at WebKit/Tools/Scripts/run-perf-tests 847126 6 191367 rniwa 2013-03-04 17:57:22 -0800 Comment on attachment 191367 Patch Please don't add new tests to DOM. This directory should only contain tests imported from chromium's dom_perf test. We should probably rename it to something else and add DOM directory instead. 847128 7 eric 2013-03-04 17:58:38 -0800 (In reply to comment #4) > Is someone working on improving the performance? Not to my knowledge. This came to my attention due to bug 110876, which I investigated (thinking the parser was doing something wrong) and found that v8 startup was completely dominating the -data variants of the test. Each -data test uses iframe.src="data:..." loads for the subtests. There are hundreds of subtests in some tests. Thus in debug, it's not surprising that we're timing out if each frame takes 1/5th of a second to load v8. :) 847134 8 eric 2013-03-04 18:01:00 -0800 (In reply to comment #6) > (From update of attachment 191367 [details]) > Please don't add new tests to DOM. This directory should only contain tests imported from chromium's dom_perf test. We should probably rename it to something else and add DOM directory instead. That's absolutely ridiculous. I added a README to warn future committers. Please edit it to explain the situation. 847136 9 eric 2013-03-04 18:01:21 -0800 Committed r144704: <http://trac.webkit.org/changeset/144704> 847278 10 dcarney 2013-03-04 22:22:28 -0800 (In reply to comment #4) > Is someone working on improving the performance? There's an effort to get more or less instant context startup in v8. It will take some time to get there. 847297 11 eric 2013-03-04 22:53:16 -0800 (In reply to comment #10) > (In reply to comment #4) > > Is someone working on improving the performance? > > There's an effort to get more or less instant context startup in v8. It will take some time to get there. Currently it looks like it takes about 1000/70 = 14.2ms (nearly a full frame) on my ridiculous Linux desktop. Glad to hear its on the plan. :) 847321 12 abarth 2013-03-04 23:27:43 -0800 We should run this test on Android to see how long it takes there. 847366 13 eric 2013-03-05 00:18:00 -0800 Agreed. I'll be away from my linux desktop (and thus Android build) tomorrow, but perhaps one of the folks with CrAndroid WebKit checkouts might try: run-perf-tests DOM/iframe-append-remove.html --chromium-android --release and report back. :) 847367 14 eric 2013-03-05 00:18:28 -0800 (In reply to comment #13) > Agreed. I'll be away from my linux desktop (and thus Android build) tomorrow, but perhaps one of the folks with CrAndroid WebKit checkouts might try: > > run-perf-tests DOM/iframe-append-remove.html --chromium-android --release > > and report back. :) Sorry, that changed to Parser/iframe-append-remove.html. 191367 2013-03-04 17:50:02 -0800 2013-03-04 17:57:22 -0800 Patch bug-111389-20130304174610.patch text/plain 1655 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NjYxCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGE0Y2U2YzEzMmQ5 YmUzZmQwMjhlNjMyNDM4MTdlMmNlNGY2NTlkZmMuLjkyY2Y4YTgyZWEzZWRjYjVjZWFhZGU4YzMy MDlkMWNhN2E4MDJlNzQgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTMtMDMt MDQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBQZXJmb3Jt YW5jZVRlc3QgZm9yIGRvY3VtZW50IHN0YXJ0dXAgdmlhIGlmcmFtZSBhcHBlbmQvcmVtb3ZlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTEzODkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSdkIGxpa2Ug cGFnZXMgd2l0aCBsb3RzIG9mIGlmcmFtZXMgdG8gYmUgZmFzdC4KKyAgICAgICAgVGhpcyB0ZXN0 IHNob3dzIHRoYXQgYXQgbGVhc3QgZm9yIFY4L0Nocm9taXVtIHdlIHNwZW5kCisgICAgICAgIGFs bCBvdXIgdGltZSBib290aW5nIHY4LgorCisgICAgICAgIE9uIG15IDMyLWNvcmUgbGludXggbWFj aGluZSBJIHNlZSBhYm91dCA3MCBydW5zL3NlYyBpbgorICAgICAgICBSZWxlYXNlIGFuZCA1IHJ1 bnMvc2VjIGluIERlYnVnLgorCisgICAgICAgICogRE9NL2lmcmFtZS1hcHBlbmQtcmVtb3ZlLmh0 bWw6IEFkZGVkLgorCiAyMDEzLTAzLTAzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFNvbWUgcGVyZi4gdGVzdHMgaGF2ZSB2YXJpYW5jZXMgdGhhdCBkaWZmZXIg Z3JlYXRseSBiZXR3ZWVuIHJ1bnMKZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvRE9NL2lm cmFtZS1hcHBlbmQtcmVtb3ZlLmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL0RPTS9pZnJhbWUtYXBw ZW5kLXJlbW92ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQxMmFiNjZkNzBmNjI5NDdlMTI5YTlhN2U0MjE4 MTUxZWU0NTY3M2EKLS0tIC9kZXYvbnVsbAorKysgYi9QZXJmb3JtYW5jZVRlc3RzL0RPTS9pZnJh bWUtYXBwZW5kLXJlbW92ZS5odG1sCkBAIC0wLDAgKzEsMTYgQEAKKzwhRE9DVFlQRSBodG1sPgor PGh0bWw+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvcnVubmVyLmpzIj48L3Nj cmlwdD4KKzxzY3JpcHQ+CisKK1BlcmZUZXN0UnVubmVyLm1lYXN1cmVSdW5zUGVyU2Vjb25kKHsK KyAgICBkZXNjcmlwdGlvbjogIlRoaXMgYmVuY2htYXJrIHRlc3RzIGFkZGluZy9yZW1vdmluZyBh biBpZnJhbWUgZnJvbSB0aGUgRE9NIiwKKyAgICBydW46IGZ1bmN0aW9uKCkgeworICAgICAgICB2 YXIgaWZyYW1lID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaWZyYW1lIik7CisgICAgICAgIGRv Y3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoaWZyYW1lKTsKKyAgICAgICAgZG9jdW1lbnQuYm9keS5y ZW1vdmVDaGlsZChpZnJhbWUpOworICAgIH19KTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s Pgo=