111357 2013-03-04 12:44:14 -0800 Web Inspector: Cmd+L (Go-to-Line) masks Go to location bar action 2013-03-07 00:11:07 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman eustas apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 846745 0 pfeldman 2013-03-04 12:44:14 -0800 We should only consume Cmd+L on the source files. 847400 1 eustas 2013-03-05 01:00:39 -0800 Go-to-Line dialog is installed in 3 panels. But in most cases it can't be activated because no line-based views are shown. I propose to turn shortcut "handlers" to be handlers. This means that they should return true IFF they actually performed some action. 847404 2 191427 eustas 2013-03-05 01:07:08 -0800 Created attachment 191427 Patch 849814 3 191427 webkit.review.bot 2013-03-07 00:11:03 -0800 Comment on attachment 191427 Patch Clearing flags on attachment: 191427 Committed r145045: <http://trac.webkit.org/changeset/145045> 849815 4 webkit.review.bot 2013-03-07 00:11:07 -0800 All reviewed patches have been landed. Closing bug. 191427 2013-03-05 01:07:08 -0800 2013-03-07 00:11:03 -0800 Patch bug-111357-20130305130314.patch text/plain 7043 eustas U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTM0YzdkYTZmNTJiOGQ3 NmMwMzZmNmY0OGM1ZjAzYTI0ZjhmYmI3OS4uMDRmMGUzNjJjYzgxODNiYTQzMzkyMTJiZGFmN2Fi MmI0MDdmNzI3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTA1ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IENtZCtMIChHby10by1MaW5lKSBtYXNrcyBHbyB0byBsb2NhdGlvbiBiYXIgYWN0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTEzNTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGxvdyBw YW5lbCBzaG9ydGN1dCBoYW5kbGVycyB0byBidWJibGUgZXZlbnQuCisKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL0dvVG9MaW5lRGlhbG9nLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkdvVG9MaW5lRGlhbG9nLmluc3RhbGwpOiBNaW5vciByZWZhY3RvcmluZywgYWRkZWQgSlNEb2Nz LgorICAgICAgICAoV2ViSW5zcGVjdG9yLkdvVG9MaW5lRGlhbG9nLl9zaG93KTogQWRkZWQgSlNE b2NzIGFuZCByZXR1cm4gdmFsdWUuCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9QYW5l bC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5QYW5lbC5wcm90b3R5cGUuaGFuZGxlU2hvcnRj dXQpOgorICAgICAgICBNYXJrIGV2ZW50IGFzIGhhbmRsZWQgaWZmIGhhbmRsZXIgcmV0dXJuZWQg dHJ1ZS4KKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qczogQWRk ZWQgcmV0dXJuIHZhbHVlcyB0byBoYW5kbGVycy4KKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL1RpbWVsaW5lUGFuZWwuanM6IERpdHRvLgorCiAyMDEzLTAzLTA0ICBFdWdlbmUgS2x5dWNo bmlrb3YgIDxldXN0YXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEV4 Y2VwdGlvbnMgd2hlbiBXZWJJbnNwZWN0b3IgcnVuIGluIGhvc3RlZCBtb2RlLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Hb1RvTGluZURpYWxvZy5qcyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvR29Ub0xpbmVEaWFsb2cuanMKaW5k ZXggNTc2Mzk0ZWIwZDE5YWEyYThlODdhYzEyMTY0YzNmNzcwNGUwYjFiYy4uZGUxYjlhNmNjYWE3 YzVlNjE3YzlhMGY2MzdkNTU5NjMxMTlkOTYxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9Hb1RvTGluZURpYWxvZy5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0dvVG9MaW5lRGlhbG9nLmpzCkBAIC01NCwyNSArNTQsMjUg QEAgV2ViSW5zcGVjdG9yLkdvVG9MaW5lRGlhbG9nID0gZnVuY3Rpb24odmlldykKIAogLyoqCiAg KiBAcGFyYW0ge1dlYkluc3BlY3Rvci5QYW5lbH0gcGFuZWwKKyAqIEBwYXJhbSB7ZnVuY3Rpb24o KTo/V2ViSW5zcGVjdG9yLlZpZXd9IHZpZXdHZXR0ZXIKICAqLwogV2ViSW5zcGVjdG9yLkdvVG9M aW5lRGlhbG9nLmluc3RhbGwgPSBmdW5jdGlvbihwYW5lbCwgdmlld0dldHRlcikKIHsKLSAgICBm dW5jdGlvbiBzaG93R29Ub0xpbmVEaWFsb2coKQotICAgIHsKLSAgICAgICAgIHZhciB2aWV3ID0g dmlld0dldHRlcigpOwotICAgICAgICAgaWYgKHZpZXcpCi0gICAgICAgICAgICAgV2ViSW5zcGVj dG9yLkdvVG9MaW5lRGlhbG9nLl9zaG93KHZpZXcpOwotICAgIH0KLQogICAgIHZhciBnb1RvTGlu ZVNob3J0Y3V0ID0gV2ViSW5zcGVjdG9yLkdvVG9MaW5lRGlhbG9nLmNyZWF0ZVNob3J0Y3V0KCk7 Ci0gICAgcGFuZWwucmVnaXN0ZXJTaG9ydGN1dHMoW2dvVG9MaW5lU2hvcnRjdXRdLCBzaG93R29U b0xpbmVEaWFsb2cpOworICAgIHBhbmVsLnJlZ2lzdGVyU2hvcnRjdXRzKFtnb1RvTGluZVNob3J0 Y3V0XSwgV2ViSW5zcGVjdG9yLkdvVG9MaW5lRGlhbG9nLl9zaG93LmJpbmQobnVsbCwgdmlld0dl dHRlcikpOwogfQogCi1XZWJJbnNwZWN0b3IuR29Ub0xpbmVEaWFsb2cuX3Nob3cgPSBmdW5jdGlv bihzb3VyY2VWaWV3KQorLyoqCisgKiBAcGFyYW0ge2Z1bmN0aW9uKCk6P1dlYkluc3BlY3Rvci5W aWV3fSB2aWV3R2V0dGVyCisgKiBAcmV0dXJuIHtib29sZWFufQorICovCitXZWJJbnNwZWN0b3Iu R29Ub0xpbmVEaWFsb2cuX3Nob3cgPSBmdW5jdGlvbih2aWV3R2V0dGVyKQogeworICAgIHZhciBz b3VyY2VWaWV3ID0gdmlld0dldHRlcigpOwogICAgIGlmICghc291cmNlVmlldyB8fCAhc291cmNl Vmlldy5jYW5IaWdobGlnaHRMaW5lKCkpCi0gICAgICAgIHJldHVybjsKKyAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIFdlYkluc3BlY3Rvci5EaWFsb2cuc2hvdyhzb3VyY2VWaWV3LmVsZW1lbnQs IG5ldyBXZWJJbnNwZWN0b3IuR29Ub0xpbmVEaWFsb2coc291cmNlVmlldykpOworICAgIHJldHVy biB0cnVlOwogfQogCiAvKioKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Bh bmVsLmpzCmluZGV4IDMxNGExMmI3NzI3ZmFlMTNiNjJkMzQ0MjdiNjFjNGIxZjQ4ZTNhYWYuLjk2 MjQyNTI0YTY3ZDdmN2JmOWZlNDZiMzQ0ZjlmM2VjOWJkNzJjMjQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9QYW5lbC5qcwpAQCAtMjUxLDE1ICsyNTEsMTMgQEAgV2Vi SW5zcGVjdG9yLlBhbmVsLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAgIHZhciBzaG9ydGN1 dEtleSA9IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lm1ha2VLZXlGcm9tRXZlbnQoZXZl bnQpOwogICAgICAgICB2YXIgaGFuZGxlciA9IHRoaXMuX3Nob3J0Y3V0c1tzaG9ydGN1dEtleV07 Ci0gICAgICAgIGlmIChoYW5kbGVyKSB7Ci0gICAgICAgICAgICBoYW5kbGVyKGV2ZW50KTsKKyAg ICAgICAgaWYgKGhhbmRsZXIgJiYgaGFuZGxlcihldmVudCkpCiAgICAgICAgICAgICBldmVudC5o YW5kbGVkID0gdHJ1ZTsKLSAgICAgICAgfQogICAgIH0sCiAKICAgICAvKioKICAgICAgKiBAcGFy YW0geyFBcnJheS48IVdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LkRlc2NyaXB0b3I+fSBr ZXlzCi0gICAgICogQHBhcmFtIHtmdW5jdGlvbihLZXlib2FyZEV2ZW50KX0gaGFuZGxlcgorICAg ICAqIEBwYXJhbSB7ZnVuY3Rpb24oS2V5Ym9hcmRFdmVudCk6Ym9vbGVhbn0gaGFuZGxlcgogICAg ICAqLwogICAgIHJlZ2lzdGVyU2hvcnRjdXRzOiBmdW5jdGlvbihrZXlzLCBoYW5kbGVyKQogICAg IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0 c1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFu ZWwuanMKaW5kZXggYWQ0ZTZmNjMwYThjNmIxNzU4NmIwNGU3ODc3NmY3ZDA1MzczYzVlNS4uYjY1 NWYwZmVmMjBhMzlkODNjNGE1N2ZiMjljY2Q5NjE4ZjNmYWI1NiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKQEAgLTc1MSw4ICs3 NTEsMTAgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgX2V2 YWx1YXRlU2VsZWN0aW9uSW5Db25zb2xlOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICB2YXIg c2VsZWN0aW9uID0gd2luZG93LmdldFNlbGVjdGlvbigpOwotICAgICAgICBpZiAoc2VsZWN0aW9u LnR5cGUgPT09ICJSYW5nZSIgJiYgIXNlbGVjdGlvbi5pc0NvbGxhcHNlZCkKLSAgICAgICAgICAg IFdlYkluc3BlY3Rvci5ldmFsdWF0ZUluQ29uc29sZShzZWxlY3Rpb24udG9TdHJpbmcoKSk7Cisg ICAgICAgIGlmIChzZWxlY3Rpb24udHlwZSAhPT0gIlJhbmdlIiB8fCBzZWxlY3Rpb24uaXNDb2xs YXBzZWQpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIFdlYkluc3BlY3Rvci5l dmFsdWF0ZUluQ29uc29sZShzZWxlY3Rpb24udG9TdHJpbmcoKSk7CisgICAgICAgIHJldHVybiB0 cnVlOwogICAgIH0sCiAKICAgICBfY3JlYXRlRGVidWdUb29sYmFyOiBmdW5jdGlvbigpCkBAIC05 NTcsMjkgKzk1OSwzMiBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZSA9IHsK ICAgICB7CiAgICAgICAgIHZhciBzb3VyY2VGcmFtZSA9IHRoaXMudmlzaWJsZVZpZXc7CiAgICAg ICAgIGlmICghc291cmNlRnJhbWUpCi0gICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKICAgICAgICAgaWYgKHNvdXJjZUZyYW1lIGluc3RhbmNlb2YgV2ViSW5z cGVjdG9yLkphdmFTY3JpcHRTb3VyY2VGcmFtZSkgewogICAgICAgICAgICAgdmFyIGphdmFTY3Jp cHRTb3VyY2VGcmFtZSA9IC8qKiBAdHlwZSB7V2ViSW5zcGVjdG9yLkphdmFTY3JpcHRTb3VyY2VG cmFtZX0gKi8gKHNvdXJjZUZyYW1lKTsKICAgICAgICAgICAgIGphdmFTY3JpcHRTb3VyY2VGcmFt ZS50b2dnbGVCcmVha3BvaW50T25DdXJyZW50TGluZSgpOwotICAgICAgICB9ICAgICAgICAgICAg CisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQorICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgfSwKIAogICAgIF9zaG93T3V0bGluZURpYWxvZzogZnVuY3Rpb24oKQogICAgIHsK ICAgICAgICAgdmFyIHVpU291cmNlQ29kZSA9IHRoaXMuX2VkaXRvckNvbnRhaW5lci5jdXJyZW50 RmlsZSgpOwogICAgICAgICBpZiAoIXVpU291cmNlQ29kZSkKLSAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgICAgICBzd2l0Y2ggKHVpU291cmNlQ29k ZS5jb250ZW50VHlwZSgpKSB7CiAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLnJlc291cmNlVHlw ZXMuRG9jdW1lbnQ6CiAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLnJlc291cmNlVHlwZXMuU2Ny aXB0OgogICAgICAgICAgICAgV2ViSW5zcGVjdG9yLkphdmFTY3JpcHRPdXRsaW5lRGlhbG9nLnNo b3codGhpcy52aXNpYmxlVmlldywgdWlTb3VyY2VDb2RlKTsKLSAgICAgICAgICAgIGJyZWFrOwor ICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLnJlc291 cmNlVHlwZXMuU3R5bGVzaGVldDoKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5TdHlsZVNoZWV0 T3V0bGluZURpYWxvZy5zaG93KHRoaXMudmlzaWJsZVZpZXcsIHVpU291cmNlQ29kZSk7Ci0gICAg ICAgICAgICBicmVhazsKKyAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICB9CisgICAg ICAgIHJldHVybiBmYWxzZTsKICAgICB9LAogCiAgICAgX2luc3RhbGxEZWJ1Z2dlclNpZGViYXJD b250cm9sbGVyOiBmdW5jdGlvbigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggNDIyZjE5ZmQzMWVhNjBmNGI0NmIwYTEw MWNiNjU0YjI2ZDY4YmE2Yi4uN2RmNjViZDBmZDNlMzIyMzUxMTIwZjEwNjM0MTg3NGNjZTI4YmJk MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGlu ZVBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxp bmVQYW5lbC5qcwpAQCAtMzczLDggKzM3Myw5IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVs LnByb3RvdHlwZSA9IHsKICAgICBfc2F2ZVRvRmlsZTogZnVuY3Rpb24oKQogICAgIHsKICAgICAg ICAgaWYgKHRoaXMuX29wZXJhdGlvbkluUHJvZ3Jlc3MpCi0gICAgICAgICAgICByZXR1cm47Cisg ICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIHRoaXMuX21vZGVsLnNhdmVUb0ZpbGUo KTsKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAogICAgIF9sb2FkRnJvbUZpbGU6IGZ1 bmN0aW9uKCkKQEAgLTU2NCwxNyArNTY1LDE3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVs LnByb3RvdHlwZSA9IHsKICAgICBfdG9nZ2xlVGltZWxpbmVCdXR0b25DbGlja2VkOiBmdW5jdGlv bigpCiAgICAgewogICAgICAgICBpZiAodGhpcy5fb3BlcmF0aW9uSW5Qcm9ncmVzcykKLSAgICAg ICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgaWYgKHRo aXMudG9nZ2xlVGltZWxpbmVCdXR0b24udG9nZ2xlZCkgewogICAgICAgICAgICAgdGhpcy5fbW9k ZWwuc3RvcFJlY29yZCgpOwogICAgICAgICAgICAgdGhpcy50b2dnbGVUaW1lbGluZUJ1dHRvbi50 aXRsZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiUmVjb3JkIik7Ci0gICAgICAgIH0KLSAgICAg ICAgZWxzZSB7CisgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICB0aGlzLl9tb2RlbC5zdGFy dFJlY29yZCgpOwogICAgICAgICAgICAgdGhpcy50b2dnbGVUaW1lbGluZUJ1dHRvbi50aXRsZSA9 IFdlYkluc3BlY3Rvci5VSVN0cmluZygiU3RvcCIpOwogICAgICAgICAgICAgV2ViSW5zcGVjdG9y LnVzZXJNZXRyaWNzLlRpbWVsaW5lU3RhcnRlZC5yZWNvcmQoKTsKICAgICAgICAgfQogICAgICAg ICB0aGlzLnRvZ2dsZVRpbWVsaW5lQnV0dG9uLnRvZ2dsZWQgPSAhdGhpcy50b2dnbGVUaW1lbGlu ZUJ1dHRvbi50b2dnbGVkOworICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCiAgICAgX2R1 cmF0aW9uRmlsdGVyQ2hhbmdlZDogZnVuY3Rpb24oKQo=