111353 2013-03-04 12:05:27 -0800 Make fastmalloc use guardpages 2013-03-06 18:43:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver benjamin cmarcelo ojan.autocc webkit.review.bot oldest_to_newest 846701 0 oliver 2013-03-04 12:05:27 -0800 Make fastmalloc use guardpages 846703 1 191285 oliver 2013-03-04 12:07:06 -0800 Created attachment 191285 Patch 846707 2 webkit.review.bot 2013-03-04 12:08:57 -0800 Attachment 191285 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/TCSystemAlloc.cpp']" exit_code: 1 Source/WTF/wtf/TCSystemAlloc.cpp:169: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/TCSystemAlloc.cpp:169: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/TCSystemAlloc.cpp:177: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/TCSystemAlloc.cpp:178: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/TCSystemAlloc.cpp:179: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 849212 3 191813 oliver 2013-03-06 12:54:57 -0800 Created attachment 191813 Patch 849214 4 webkit.review.bot 2013-03-06 12:57:41 -0800 Attachment 191813 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/TCSystemAlloc.cpp']" exit_code: 1 Source/WTF/wtf/TCSystemAlloc.cpp:170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/TCSystemAlloc.cpp:171: Use 0 instead of NULL. [readability/null] [5] Source/WTF/wtf/TCSystemAlloc.cpp:171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/TCSystemAlloc.cpp:179: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/TCSystemAlloc.cpp:180: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/TCSystemAlloc.cpp:181: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 849237 5 191813 msaboff 2013-03-06 13:17:30 -0800 Comment on attachment 191813 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191813&action=review >> Source/WTF/wtf/TCSystemAlloc.cpp:179 >> + mmap(result, pagesize, PROT_NONE, MAP_FIXED | MAP_PRIVATE | MAP_ANON, VM_TAG_FOR_TCMALLOC_MEMORY, 0); > > Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Shouldn't this be an mprotect() call. >> Source/WTF/wtf/TCSystemAlloc.cpp:180 >> + mmap(static_cast<char*>(result) + (mapSize - pagesize).unsafeGet(), pagesize, PROT_NONE, MAP_FIXED | MAP_PRIVATE | MAP_ANON, VM_TAG_FOR_TCMALLOC_MEMORY, 0); > > Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Ditto. 849593 6 oliver 2013-03-06 18:43:32 -0800 Committed r144971: <http://trac.webkit.org/changeset/144971> 191285 2013-03-04 12:07:06 -0800 2013-03-06 12:54:55 -0800 Patch bug-111353-20130304120332.patch text/plain 1821 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDgyNmY2YTFiY2Q1ZDcyZGZjNGIxZDNj NWVhZDI4YTA5NWQ3NTJhYjUuLjdjMWY1MDk0NWNlZWViYzFhMTIyYjEwMDYxNDdlZWVmMTkyNGQw MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDMtMDQgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIGZhc3RtYWxsb2MgdXNlIGd1YXJkcGFnZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTM1MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBQUk9UX05P TkUgcGFnZXMgYXQgdGhlIGJlZ2lubmluZyBhbmQgZW5kIG9mIGV2ZXJ5CisgICAgICAgIG1tYXAg Y2FsbCBtYWRlIGJ5IGZhc3RtYWxsb2MuCisKKyAgICAgICAgKiB3dGYvVENTeXN0ZW1BbGxvYy5j cHA6CisgICAgICAgIChUcnlNbWFwKToKKwogMjAxMy0wMy0wNCAgQW5kcmVhcyBLbGluZyAgPGFr bGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgRGVxdWU6IEZyZWUgaW50ZXJuYWwgYnVmZmVyIGlu IGNsZWFyKCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9UQ1N5c3RlbUFsbG9jLmNwcCBi L1NvdXJjZS9XVEYvd3RmL1RDU3lzdGVtQWxsb2MuY3BwCmluZGV4IGY1NDcwODVlNmNmNDQ3YjYx M2Y0MDA3YmRiOWYwOWMzNmViNjc2OTIuLjJhNDhlMDE2YjliZmYyMzExZjFlNDlmNTIyMDkyMGVk YWM2OTMzNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1RDU3lzdGVtQWxsb2MuY3BwCisr KyBiL1NvdXJjZS9XVEYvd3RmL1RDU3lzdGVtQWxsb2MuY3BwCkBAIC0xNjYsNyArMTY2LDcgQEAg c3RhdGljIHZvaWQqIFRyeU1tYXAoc2l6ZV90IHNpemUsIHNpemVfdCAqYWN0dWFsX3NpemUsIHNp emVfdCBhbGlnbm1lbnQpIHsKICAgaWYgKGFsaWdubWVudCA+IHBhZ2VzaXplKSB7CiAgICAgZXh0 cmEgPSBhbGlnbm1lbnQgLSBwYWdlc2l6ZTsKICAgfQotICB2b2lkKiByZXN1bHQgPSBtbWFwKE5V TEwsIHNpemUgKyBleHRyYSwKKyAgdm9pZCogcmVzdWx0ID0gbW1hcChOVUxMLCBzaXplICsgZXh0 cmEgKyAyICogcGFnZXNpemUsCiAgICAgICAgICAgICAgICAgICAgICAgUFJPVF9SRUFEIHwgUFJP VF9XUklURSwKICAgICAgICAgICAgICAgICAgICAgICBNQVBfUFJJVkFURXxNQVBfQU5PTllNT1VT LAogICAgICAgICAgICAgICAgICAgICAgIFZNX1RBR19GT1JfVENNQUxMT0NfTUVNT1JZLCAwKTsK QEAgLTE3NCw3ICsxNzQsOSBAQCBzdGF0aWMgdm9pZCogVHJ5TW1hcChzaXplX3Qgc2l6ZSwgc2l6 ZV90ICphY3R1YWxfc2l6ZSwgc2l6ZV90IGFsaWdubWVudCkgewogICAgIG1tYXBfZmFpbHVyZSA9 IHRydWU7CiAgICAgcmV0dXJuIE5VTEw7CiAgIH0KLQorICBtcHJvdGVjdChyZXN1bHQsIHBhZ2Vz aXplLCBQUk9UX05PTkUpOworICBtcHJvdGVjdChzdGF0aWNfY2FzdDxjaGFyKj4ocmVzdWx0KSAr IHNpemUgKyBleHRyYSArIHBhZ2VzaXplLCBwYWdlc2l6ZSwgUFJPVF9OT05FKTsKKyAgcmVzdWx0 ID0gc3RhdGljX2Nhc3Q8Y2hhcio+KHJlc3VsdCkgKyBwYWdlc2l6ZTsKICAgLy8gQWRqdXN0IHRo ZSByZXR1cm4gbWVtb3J5IHNvIGl0IGlzIGFsaWduZWQKICAgdWludHB0cl90IHB0ciA9IHJlaW50 ZXJwcmV0X2Nhc3Q8dWludHB0cl90PihyZXN1bHQpOwogICBzaXplX3QgYWRqdXN0ID0gMDsK 191813 2013-03-06 12:54:57 -0800 2013-03-06 13:17:30 -0800 Patch bug-111353-20130306125102.patch text/plain 2198 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0OTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJmMjMzYWIwYTc3MTk0NTBiMzg5Njg5 Y2IyZDEzOTllNTYyNTBlOTkuLjU4NmIzZGNhMjQ5N2Y3ZTIzNTYwZjU1YWQ4NTE1YTI2OGQ2MmE1 ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMDMtMDQgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIGZhc3RtYWxsb2MgdXNlIGd1YXJkcGFnZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTM1MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBQUk9UX05P TkUgcGFnZXMgYXQgdGhlIGJlZ2lubmluZyBhbmQgZW5kIG9mIGV2ZXJ5CisgICAgICAgIG1tYXAg Y2FsbCBtYWRlIGJ5IGZhc3RtYWxsb2MuCisKKyAgICAgICAgKiB3dGYvVENTeXN0ZW1BbGxvYy5j cHA6CisgICAgICAgIChUcnlNbWFwKToKKwogMjAxMy0wMy0wNiAgUGF3ZcWCIEZvcnlzaXVrICA8 dHV4YXRvckBvMi5wbD4KIAogICAgICAgICBUeXBvIGluIGlubGluZSBmdW5jdGlvbiBpbiBCeXRl T3JkZXIuaApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvVENTeXN0ZW1BbGxvYy5jcHAgYi9T b3VyY2UvV1RGL3d0Zi9UQ1N5c3RlbUFsbG9jLmNwcAppbmRleCBmNTQ3MDg1ZTZjZjQ0N2I2MTNm NDAwN2JkYjlmMDljMzZlYjY3NjkyLi40YTUxM2VlNTIxYzQ0MjVjZWRmZDE0ZTAyZmNjNWQxNmEx ZDBhYjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9UQ1N5c3RlbUFsbG9jLmNwcAorKysg Yi9Tb3VyY2UvV1RGL3d0Zi9UQ1N5c3RlbUFsbG9jLmNwcApAQCAtMzUsNiArMzUsNyBAQAogI2lu Y2x1ZGUgIlRDU3lzdGVtQWxsb2MuaCIKIAogI2luY2x1ZGUgIkFzc2VydGlvbnMuaCIKKyNpbmNs dWRlICJDaGVja2VkQXJpdGhtZXRpYy5oIgogI2luY2x1ZGUgIlRDU3BpbkxvY2suaCIKICNpbmNs dWRlICJVbnVzZWRQYXJhbS5oIgogI2luY2x1ZGUgIlZNVGFncy5oIgpAQCAtMTY2LDcgKzE2Nyw4 IEBAIHN0YXRpYyB2b2lkKiBUcnlNbWFwKHNpemVfdCBzaXplLCBzaXplX3QgKmFjdHVhbF9zaXpl LCBzaXplX3QgYWxpZ25tZW50KSB7CiAgIGlmIChhbGlnbm1lbnQgPiBwYWdlc2l6ZSkgewogICAg IGV4dHJhID0gYWxpZ25tZW50IC0gcGFnZXNpemU7CiAgIH0KLSAgdm9pZCogcmVzdWx0ID0gbW1h cChOVUxMLCBzaXplICsgZXh0cmEsCisgIENoZWNrZWQ8c2l6ZV90PiBtYXBTaXplID0gQ2hlY2tl ZDxzaXplX3Q+KHNpemUpICsgZXh0cmEgKyAyICogcGFnZXNpemU7CisgIHZvaWQqIHJlc3VsdCA9 IG1tYXAoTlVMTCwgbWFwU2l6ZS51bnNhZmVHZXQoKSwKICAgICAgICAgICAgICAgICAgICAgICBQ Uk9UX1JFQUQgfCBQUk9UX1dSSVRFLAogICAgICAgICAgICAgICAgICAgICAgIE1BUF9QUklWQVRF fE1BUF9BTk9OWU1PVVMsCiAgICAgICAgICAgICAgICAgICAgICAgVk1fVEFHX0ZPUl9UQ01BTExP Q19NRU1PUlksIDApOwpAQCAtMTc0LDcgKzE3Niw5IEBAIHN0YXRpYyB2b2lkKiBUcnlNbWFwKHNp emVfdCBzaXplLCBzaXplX3QgKmFjdHVhbF9zaXplLCBzaXplX3QgYWxpZ25tZW50KSB7CiAgICAg bW1hcF9mYWlsdXJlID0gdHJ1ZTsKICAgICByZXR1cm4gTlVMTDsKICAgfQotCisgIG1tYXAocmVz dWx0LCBwYWdlc2l6ZSwgUFJPVF9OT05FLCBNQVBfRklYRUQgfCBNQVBfUFJJVkFURSB8IE1BUF9B Tk9OLCBWTV9UQUdfRk9SX1RDTUFMTE9DX01FTU9SWSwgMCk7CisgIG1tYXAoc3RhdGljX2Nhc3Q8 Y2hhcio+KHJlc3VsdCkgKyAobWFwU2l6ZSAtIHBhZ2VzaXplKS51bnNhZmVHZXQoKSwgcGFnZXNp emUsIFBST1RfTk9ORSwgTUFQX0ZJWEVEIHwgTUFQX1BSSVZBVEUgfCBNQVBfQU5PTiwgVk1fVEFH X0ZPUl9UQ01BTExPQ19NRU1PUlksIDApOworICByZXN1bHQgPSBzdGF0aWNfY2FzdDxjaGFyKj4o cmVzdWx0KSArIHBhZ2VzaXplOwogICAvLyBBZGp1c3QgdGhlIHJldHVybiBtZW1vcnkgc28gaXQg aXMgYWxpZ25lZAogICB1aW50cHRyX3QgcHRyID0gcmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+ KHJlc3VsdCk7CiAgIHNpemVfdCBhZGp1c3QgPSAwOwo=