111339 2013-03-04 09:16:02 -0800 AX: user agent shadow roots for plugins should be 'accessible' 2013-03-04 15:48:09 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach dino esprehn+autocc jonlee ojan.autocc webkit.review.bot oldest_to_newest 846554 0 cfleizach 2013-03-04 09:16:02 -0800 Right now the user agent shadow root adds a title and subtitle to some divs. To make it accessible, we should turn the overall div into a button and concatenate the title/subtitle and use that as the aria-label 846555 1 cfleizach 2013-03-04 09:16:17 -0800 rdar://12998748 846560 2 191258 cfleizach 2013-03-04 09:19:29 -0800 Created attachment 191258 patch 846563 3 cfleizach 2013-03-04 09:20:55 -0800 Adding Jon and Dean for review. Please let me know if there's a good way to do a layout test for this, I couldn't find any examples 846909 4 191258 thorton 2013-03-04 15:22:01 -0800 Comment on attachment 191258 patch Seems reasonable. 846949 5 191258 webkit.review.bot 2013-03-04 15:48:05 -0800 Comment on attachment 191258 patch Clearing flags on attachment: 191258 Committed r144690: <http://trac.webkit.org/changeset/144690> 846950 6 webkit.review.bot 2013-03-04 15:48:09 -0800 All reviewed patches have been landed. Closing bug. 191258 2013-03-04 09:19:29 -0800 2013-03-04 15:48:05 -0800 patch patch text/plain 1758 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDYzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTA0ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IHVzZXIgYWdlbnQg c2hhZG93IHJvb3RzIGZvciBwbHVnaW5zIHNob3VsZCBiZSAnYWNjZXNzaWJsZScKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTMzOQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIGEgcGx1Z2luIGVsZW1l bnQgdXNlcyBhIHVzZXIgYWdlbnQgc2hhZG93IGVsZW1lbnQsIHdlIHNob3VsZCBtYWtlIHRoYXQg c2hhZG93IGVsZW1lbnQKKyAgICAgICAgaW50byBhIGJ1dHRvbiB3aXRoIHRoZSB0aXRsZSBhbmQg c3VidGl0bGUgcHV0IHRvZ2V0aGVyLCBhbmQgdXNlIHRoYXQgYXMgdGhlIGxhYmVsLiBUaGlzIAor ICAgICAgICB3aWxsIHByb2JhYmx5IGJlIHRoZSBiZXN0IGFjY2Vzc2liaWxpdHkgZXhwZXJpZW5j ZS4KKworICAgICAgICAqIGh0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpIVE1MUGx1Z0luSW1hZ2VFbGVtZW50OjpkaWRBZGRVc2VyQWdlbnRTaGFkb3dS b290KToKKwogMjAxMy0wMy0wNCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNh bXN1bmcuY29tPgogCiAgICAgICAgIFtHVEtdIFdlYkNvcmU6OnJldHVyblN0cmluZyBpcyB1bnNh ZmUgYW5kIHNob3VsZCBiZSByZW1vdmVkIQpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M UGx1Z0luSW1hZ2VFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNDQ1NzUpCisrKyBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zNjcsNiArMzY3LDE0IEBACiAKICAgICBjb250YWluZXItPmFwcGVuZENoaWxkKGxhYmVsLCBB U1NFUlRfTk9fRVhDRVBUSU9OKTsKIAorICAgIC8vIE1ha2UgdGhpcyBpbnRvIGEgYnV0dG9uIGZv ciBhY2Nlc3NpYmlsaXR5IGNsaWVudHMuCisgICAgU3RyaW5nIGNvbWJpbmVkVGV4dCA9IHRpdGxl VGV4dDsKKyAgICBpZiAoIWNvbWJpbmVkVGV4dC5pc0VtcHR5KCkgJiYgIXN1YnRpdGxlVGV4dC5p c0VtcHR5KCkpCisgICAgICAgIGNvbWJpbmVkVGV4dC5hcHBlbmQoIiAiKTsKKyAgICBjb21iaW5l ZFRleHQuYXBwZW5kKHN1YnRpdGxlVGV4dCk7CisgICAgY29udGFpbmVyLT5zZXRBdHRyaWJ1dGUo YXJpYV9sYWJlbEF0dHIsIGNvbWJpbmVkVGV4dCk7CisgICAgY29udGFpbmVyLT5zZXRBdHRyaWJ1 dGUocm9sZUF0dHIsICJidXR0b24iKTsKKyAgICAKICAgICBzaGFkb3dDb250YWluZXItPmFwcGVu ZENoaWxkKGNvbnRhaW5lciwgQVNTRVJUX05PX0VYQ0VQVElPTik7CiAgICAgcm9vdC0+YXBwZW5k Q2hpbGQoc2hhZG93Q29udGFpbmVyLCBBU1NFUlRfTk9fRVhDRVBUSU9OKTsKIH0K