111337 2013-03-04 09:02:10 -0800 Web Inspector: Add a renderer process memory size test. 2013-03-05 06:08:35 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 alph alph apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 846545 0 alph 2013-03-04 09:02:10 -0800 Add a renderer process memory size test. 846546 1 191256 alph 2013-03-04 09:05:15 -0800 Created attachment 191256 Patch 847537 2 191256 yurys 2013-03-05 04:06:29 -0800 Comment on attachment 191256 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191256&action=review > Source/WebKit/chromium/src/js/Tests.js:333 > + checkFuzzyValue(memoryBlock.size, 8000 * KB, 0.5); We should allow for a broader range otherwise it is bound to be flaky. I think it would be enough to check that it is >1Mb and < 1.5Gb or something. 847551 3 191256 alph 2013-03-05 04:23:21 -0800 Comment on attachment 191256 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191256&action=review >> Source/WebKit/chromium/src/js/Tests.js:333 >> + checkFuzzyValue(memoryBlock.size, 8000 * KB, 0.5); > > We should allow for a broader range otherwise it is bound to be flaky. I think it would be enough to check that it is >1Mb and < 1.5Gb or something. 1.5GB??? For a fresh renderer process??? Ok! 847552 4 191464 alph 2013-03-05 04:23:43 -0800 Created attachment 191464 Patch 847605 5 191464 webkit.review.bot 2013-03-05 06:08:31 -0800 Comment on attachment 191464 Patch Clearing flags on attachment: 191464 Committed r144755: <http://trac.webkit.org/changeset/144755> 847606 6 webkit.review.bot 2013-03-05 06:08:35 -0800 All reviewed patches have been landed. Closing bug. 191256 2013-03-04 09:05:15 -0800 2013-03-05 04:23:39 -0800 Patch bug-111337-20130304210122.patch text/plain 3281 alph U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDdiYjg3MWI5YzNkZGYwMzUzYzA2MjAxYTA0NDhhODJkOTA1MDliMGEuLmRmMDgyMGRlMjBhZDhi NGRhMTJhMTIxODI5NzFhZjFmMGEwNDkyYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTMtMDMtMDQgIEFsZXhlaSBGaWxpcHBvdiAgPGFscGhAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBhIHJlbmRlcmVyIHByb2Nlc3Mg bWVtb3J5IHNpemUgdGVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMTMzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSB0ZXN0IGNoZWNrcyB0aGF0IHRoZSByZW5kZXJlciBwcm9jZXNzIG1lbW9y eSBzaXplCisgICAgICAgIGlzIG9idGFpbmVkIGZyb20gdGhlIGJyb3dzZXIgYW5kIHJlcG9ydGVk IHRvIHRoZSBpbnNwZWN0b3IKKyAgICAgICAgZnJvbnRlbmQgY29ycmVjdGx5LgorCisgICAgICAg ICogc3JjL2pzL1Rlc3RzLmpzOgorICAgICAgICAoLlRlc3RTdWl0ZS5wcm90b3R5cGUudGVzdFJl bmRlcmVyUHJvY2Vzc05hdGl2ZU1lbW9yeVNpemUuY2hlY2tGdXp6eVZhbHVlKToKKyAgICAgICAg KC5UZXN0U3VpdGUucHJvdG90eXBlLnRlc3RSZW5kZXJlclByb2Nlc3NOYXRpdmVNZW1vcnlTaXpl LnN0ZXAyKToKKwogMjAxMy0wMy0wNCAgQW5kcmV5IEx1c2huaWtvdiAgPGx1c2huaWtvdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIHJ1bnRpbWUgZmxhZyB0byBk ZXRlcm1pbmUgaWYgaW5zcGVjdG9yJ3Mgc291cmNlIGZpbGVzIHdlcmUgZmxhdHRlbmVkLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvVGVzdHMuanMgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9qcy9UZXN0cy5qcwppbmRleCAxM2RkMDkyZWY0ZTViMTMxODYy ZGNjYTFkZTFiMDlmZTQyZjMwY2ZjLi4zNDdmOWNlZjBlZTQ0YmU3N2MyNGM2MDY2YmI1MTZjNjdh Nzc5OWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9UZXN0cy5q cworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9UZXN0cy5qcwpAQCAtMzA2LDYg KzMwNiw1NyBAQCBUZXN0U3VpdGUucHJvdG90eXBlLnRlc3RDb250ZW50U2NyaXB0SXNQcmVzZW50 ID0gZnVuY3Rpb24oKQogCiAKIC8qKgorICogVGVzdHMgcmVuZGVyZXIgcHJvY2VzcyBtZW1vcnkg c2l6ZSBvYnRhaW5lZCBhbmQgcGFzc2VkIHRvIGluc3BlY3RvcgorICogc3VjY2Vzc2Z1bGx5Lgor ICovCitUZXN0U3VpdGUucHJvdG90eXBlLnRlc3RSZW5kZXJlclByb2Nlc3NOYXRpdmVNZW1vcnlT aXplID0gZnVuY3Rpb24oKQoreworICAgIHZhciB0ZXN0ID0gdGhpczsKKyAgICB2YXIgS0IgPSAx MDI0OworICAgIHZhciBhcnJheVNpemUgPSAyMDAwMDAwMDsKKyAgICB2YXIgaW5pdGlhbFNpemU7 CisKKyAgICBmdW5jdGlvbiBjaGVja0Z1enp5VmFsdWUodmFsdWUsIGV4cGVjdGVkLCBhbGxvd2Vk RGVsdGEpCisgICAgeworICAgICAgICB2YXIgcmVsYXRpdmVEaWZmID0gTWF0aC5hYnModmFsdWUg LSBleHBlY3RlZCkgLyBleHBlY3RlZDsKKyAgICAgICAgaWYgKHJlbGF0aXZlRGlmZiA+IGFsbG93 ZWREZWx0YSkKKyAgICAgICAgICAgIHRlc3QuZmFpbCgiVmFsdWUgKCIgKyB2YWx1ZSArICIpIGRp ZmZlcnMgZnJvbSBleHBlY3RlZCAoIiArIGV4cGVjdGVkICsgIikgYnkgbW9yZSB0aGFuICIgKyAo YWxsb3dlZERlbHRhICogMTAwKSArICIlLiIpOworICAgIH0KKworICAgIGZ1bmN0aW9uIHN0ZXAx KGVycm9yLCBtZW1vcnlCbG9jaykKKyAgICB7CisgICAgICAgIHRlc3QuYXNzZXJ0VHJ1ZSghZXJy b3IsICJBbiBlcnJvciBoYXMgb2NjdXJyZWQ6ICIgKyBlcnJvcik7CisgICAgICAgIHRlc3QuYXNz ZXJ0VHJ1ZShtZW1vcnlCbG9jay5zaXplICE9PSAwLCAiWmVybyBwcm9jZXNzIHNpemUuIik7Cisg ICAgICAgIC8vIENoZWNrcyB0aGF0IGluaXRpYWwgcmVuZGVyZXIgcHJvY2VzcyBzaXplIGlzIGFi b3V0IDgwMDAgS0IKKyAgICAgICAgLy8gd2l0aGluIDUwJSBjb25maWRlbmNlIGludGVydmFsLgor ICAgICAgICAvLyBJZiBpdCBiZWNvbWVzIGZsYWt5IGFkanVzdCB0aGUgc2l6ZSBhbmQvb3IgdGhl IGludGVydmFsLgorICAgICAgICBjaGVja0Z1enp5VmFsdWUobWVtb3J5QmxvY2suc2l6ZSwgODAw MCAqIEtCLCAwLjUpOworCisgICAgICAgIGluaXRpYWxTaXplID0gbWVtb3J5QmxvY2suc2l6ZTsK KworICAgICAgICB0ZXN0LmV2YWx1YXRlSW5Db25zb2xlXygidmFyIGEgPSBuZXcgVWludDhBcnJh eSgiICsgYXJyYXlTaXplICsgIik7IiwgZnVuY3Rpb24oKSB7fSk7CisKKyAgICAgICAgTWVtb3J5 QWdlbnQuZ2V0UHJvY2Vzc01lbW9yeURpc3RyaWJ1dGlvbihmYWxzZSwgc3RlcDIpOworICAgIH0K KworICAgIGZ1bmN0aW9uIHN0ZXAyKGVycm9yLCBtZW1vcnlCbG9jaykKKyAgICB7CisgICAgICAg IHRlc3QuYXNzZXJ0VHJ1ZSghZXJyb3IsICJBbiBlcnJvciBoYXMgb2NjdXJyZWQ6ICIgKyBlcnJv cik7CisgICAgICAgIHZhciBkZWx0YUJ5dGVzID0gbWVtb3J5QmxvY2suc2l6ZSAtIGluaXRpYWxT aXplOworICAgICAgICAvLyBDaGVja3MgdGhhdCB0aGUgcHJvY2VzcyBzaXplIGhhcyBncm93biBh cHByb3hpbWF0ZWx5IGJ5CisgICAgICAgIC8vIHRoZSBzaXplIG9mIHRoZSBhbGxvY2F0ZWQgYXJy YXkgKHdpdGhpbiAxMCUgY29uZmlkZW5jZSBpbnRlcnZhbCkuCisgICAgICAgIGNoZWNrRnV6enlW YWx1ZShkZWx0YUJ5dGVzLCBhcnJheVNpemUsIDAuMSk7CisKKyAgICAgICAgdGVzdC5yZWxlYXNl Q29udHJvbCgpOworICAgIH0KKworICAgIE1lbW9yeUFnZW50LmdldFByb2Nlc3NNZW1vcnlEaXN0 cmlidXRpb24oZmFsc2UsIHN0ZXAxKTsKKworICAgIHRoaXMudGFrZUNvbnRyb2woKTsKK307CisK KworLyoqCiAgKiBUZXN0cyB0aGF0IHNjcmlwdHMgYXJlIG5vdCBkdXBsaWNhZWQgb24gU2NyaXB0 cyB0YWIgc3dpdGNoLgogICovCiBUZXN0U3VpdGUucHJvdG90eXBlLnRlc3ROb1NjcmlwdER1cGxp Y2F0ZXNPblBhbmVsU3dpdGNoID0gZnVuY3Rpb24oKQo= 191464 2013-03-05 04:23:43 -0800 2013-03-05 06:08:31 -0800 Patch bug-111337-20130305161950.patch text/plain 3072 alph U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBlNWE2ZDZmNzY3YzE3OWJlNWY1OGZlYWFkMjUxZTY0MGFlMTljZjcuLjI0MWM0MjMxNzJmNTM3 MTYxMTZlMjgxNDZhYjJlZTZhN2UxN2FlN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTMtMDMtMDQgIEFsZXhlaSBGaWxpcHBvdiAgPGFscGhAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCBhIHJlbmRlcmVyIHByb2Nlc3Mg bWVtb3J5IHNpemUgdGVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMTMzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSB0ZXN0IGNoZWNrcyB0aGF0IHRoZSByZW5kZXJlciBwcm9jZXNzIG1lbW9y eSBzaXplCisgICAgICAgIGlzIG9idGFpbmVkIGZyb20gdGhlIGJyb3dzZXIgYW5kIHJlcG9ydGVk IHRvIHRoZSBpbnNwZWN0b3IKKyAgICAgICAgZnJvbnRlbmQgY29ycmVjdGx5LgorCisgICAgICAg ICogc3JjL2pzL1Rlc3RzLmpzOgorICAgICAgICAoLlRlc3RTdWl0ZS5wcm90b3R5cGUudGVzdFJl bmRlcmVyUHJvY2Vzc05hdGl2ZU1lbW9yeVNpemUuY2hlY2tGdXp6eVZhbHVlKToKKyAgICAgICAg KC5UZXN0U3VpdGUucHJvdG90eXBlLnRlc3RSZW5kZXJlclByb2Nlc3NOYXRpdmVNZW1vcnlTaXpl LnN0ZXAyKToKKwogMjAxMy0wMy0wNCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUu Y29tPgogCiAgICAgICAgIEFYOiBjZWxsRm9yQ29sdW1uQW5kUm93IGZhaWxzIGZvciB0YWJsZXMg d2l0aCBoaWRkZW4gdGFibGUgY2VsbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL2pzL1Rlc3RzLmpzIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvVGVzdHMu anMKaW5kZXggMTNkZDA5MmVmNGU1YjEzMTg2MmRjY2ExZGUxYjA5ZmU0MmYzMGNmYy4uYzc4OTZh YWE1Y2FlM2FjODFjMTIxYzUzMWQwZDIxNGFhM2RkNTJiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvanMvVGVzdHMuanMKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvanMvVGVzdHMuanMKQEAgLTMwNiw2ICszMDYsNTQgQEAgVGVzdFN1aXRlLnByb3RvdHlw ZS50ZXN0Q29udGVudFNjcmlwdElzUHJlc2VudCA9IGZ1bmN0aW9uKCkKIAogCiAvKioKKyAqIFRl c3RzIHJlbmRlcmVyIHByb2Nlc3MgbWVtb3J5IHNpemUgb2J0YWluZWQgYW5kIHBhc3NlZCB0byBp bnNwZWN0b3IKKyAqIHN1Y2Nlc3NmdWxseS4KKyAqLworVGVzdFN1aXRlLnByb3RvdHlwZS50ZXN0 UmVuZGVyZXJQcm9jZXNzTmF0aXZlTWVtb3J5U2l6ZSA9IGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIg dGVzdCA9IHRoaXM7CisgICAgdmFyIEtCID0gMTAyNDsKKyAgICB2YXIgTUIgPSBLQiAqIEtCOwor ICAgIHZhciBhcnJheVNpemUgPSAyMDAwMDAwMDsKKyAgICB2YXIgaW5pdGlhbFNpemU7CisKKyAg ICBmdW5jdGlvbiBjaGVja0Z1enp5VmFsdWUodmFsdWUsIGV4cGVjdGVkLCBhbGxvd2VkRGVsdGEp CisgICAgeworICAgICAgICB2YXIgcmVsYXRpdmVEaWZmID0gTWF0aC5hYnModmFsdWUgLSBleHBl Y3RlZCkgLyBleHBlY3RlZDsKKyAgICAgICAgaWYgKHJlbGF0aXZlRGlmZiA+IGFsbG93ZWREZWx0 YSkKKyAgICAgICAgICAgIHRlc3QuZmFpbCgiVmFsdWUgKCIgKyB2YWx1ZSArICIpIGRpZmZlcnMg ZnJvbSBleHBlY3RlZCAoIiArIGV4cGVjdGVkICsgIikgYnkgbW9yZSB0aGFuICIgKyAoYWxsb3dl ZERlbHRhICogMTAwKSArICIlLiIpOworICAgIH0KKworICAgIGZ1bmN0aW9uIHN0ZXAxKGVycm9y LCBtZW1vcnlCbG9jaykKKyAgICB7CisgICAgICAgIHRlc3QuYXNzZXJ0VHJ1ZSghZXJyb3IsICJB biBlcnJvciBoYXMgb2NjdXJyZWQ6ICIgKyBlcnJvcik7CisgICAgICAgIHRlc3QuYXNzZXJ0VHJ1 ZShtZW1vcnlCbG9jay5zaXplID4gMSAqIE1CICYmIG1lbW9yeUJsb2NrLnNpemUgPCAxNTAwICog TUIsICJVbmZlYXNpYmxlIHByb2Nlc3Mgc2l6ZS4iKTsKKworICAgICAgICBpbml0aWFsU2l6ZSA9 IG1lbW9yeUJsb2NrLnNpemU7CisKKyAgICAgICAgdGVzdC5ldmFsdWF0ZUluQ29uc29sZV8oInZh ciBhID0gbmV3IFVpbnQ4QXJyYXkoIiArIGFycmF5U2l6ZSArICIpOyIsIGZ1bmN0aW9uKCkge30p OworCisgICAgICAgIE1lbW9yeUFnZW50LmdldFByb2Nlc3NNZW1vcnlEaXN0cmlidXRpb24oZmFs c2UsIHN0ZXAyKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBzdGVwMihlcnJvciwgbWVtb3J5Qmxv Y2spCisgICAgeworICAgICAgICB0ZXN0LmFzc2VydFRydWUoIWVycm9yLCAiQW4gZXJyb3IgaGFz IG9jY3VycmVkOiAiICsgZXJyb3IpOworICAgICAgICB2YXIgZGVsdGFCeXRlcyA9IG1lbW9yeUJs b2NrLnNpemUgLSBpbml0aWFsU2l6ZTsKKyAgICAgICAgLy8gQ2hlY2tzIHRoYXQgdGhlIHByb2Nl c3Mgc2l6ZSBoYXMgZ3Jvd24gYXBwcm94aW1hdGVseSBieQorICAgICAgICAvLyB0aGUgc2l6ZSBv ZiB0aGUgYWxsb2NhdGVkIGFycmF5ICh3aXRoaW4gMTAlIGNvbmZpZGVuY2UgaW50ZXJ2YWwpLgor ICAgICAgICBjaGVja0Z1enp5VmFsdWUoZGVsdGFCeXRlcywgYXJyYXlTaXplLCAwLjEpOworCisg ICAgICAgIHRlc3QucmVsZWFzZUNvbnRyb2woKTsKKyAgICB9CisKKyAgICBNZW1vcnlBZ2VudC5n ZXRQcm9jZXNzTWVtb3J5RGlzdHJpYnV0aW9uKGZhbHNlLCBzdGVwMSk7CisKKyAgICB0aGlzLnRh a2VDb250cm9sKCk7Cit9OworCisKKy8qKgogICogVGVzdHMgdGhhdCBzY3JpcHRzIGFyZSBub3Qg ZHVwbGljYWVkIG9uIFNjcmlwdHMgdGFiIHN3aXRjaC4KICAqLwogVGVzdFN1aXRlLnByb3RvdHlw ZS50ZXN0Tm9TY3JpcHREdXBsaWNhdGVzT25QYW5lbFN3aXRjaCA9IGZ1bmN0aW9uKCkK