111306 2013-03-04 05:52:58 -0800 [WinCairo] Compile fix after r144024. 2013-03-05 14:49:12 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned andersca cmarcelo jamesr luiz tonikitoo tuxator webkit.review.bot zan oldest_to_newest 846374 0 peavo 2013-03-04 05:52:58 -0800 Need to add guard for USE(ACCELERATED_COMPOSITING). 846382 1 191216 peavo 2013-03-04 05:57:14 -0800 Created attachment 191216 Patch 846536 2 191216 jamesr 2013-03-04 08:52:43 -0800 Comment on attachment 191216 Patch I swear I've seen this exact same patch before. I'll give the same feedback - I'd prefer to have trivial null-returning versions of these ScrollableArea functions defined when USE(ACCELERATED_COMPOSITING) is not set so the macro ugliness is in one place instead of being in every caller. 846543 3 zan 2013-03-04 09:00:35 -0800 (In reply to comment #2) > (From update of attachment 191216 [details]) > I swear I've seen this exact same patch before. Bug #111271. 847382 4 191421 peavo 2013-03-05 00:33:05 -0800 Created attachment 191421 Patch 847385 5 peavo 2013-03-05 00:34:17 -0800 Updated patch after review feedback. Seems we don't need these methods for the !USE(ACCELERATED_COMPOSITING) case. 847957 6 191421 webkit.review.bot 2013-03-05 12:56:54 -0800 Comment on attachment 191421 Patch Rejecting attachment 191421 from commit-queue. peavo@outlook.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 848091 7 jamesr 2013-03-05 14:41:39 -0800 *** Bug 111271 has been marked as a duplicate of this bug. *** 848105 8 191421 webkit.review.bot 2013-03-05 14:49:08 -0800 Comment on attachment 191421 Patch Clearing flags on attachment: 191421 Committed r144823: <http://trac.webkit.org/changeset/144823> 848106 9 webkit.review.bot 2013-03-05 14:49:12 -0800 All reviewed patches have been landed. Closing bug. 191216 2013-03-04 05:57:14 -0800 2013-03-05 00:32:58 -0800 Patch bug-111306-20130304145257.patch text/plain 2223 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDYyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTA0ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBmaXggYWZ0ZXIgcjE0NDAyNC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMTMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNjcm9sbExheWVyRm9y U2Nyb2xsYWJsZUFyZWEpOiBBZGQgZ3VhcmQgZm9yIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElO RykuCisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvcjo6aG9yaXpvbnRhbFNj cm9sbGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEpOiBBZGQgZ3VhcmQgZm9yIFVTRShBQ0NFTEVS QVRFRF9DT01QT1NJVElORykuCisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRv cjo6dmVydGljYWxTY3JvbGxiYXJMYXllckZvclNjcm9sbGFibGVBcmVhKTogQWRkIGd1YXJkIGZv ciBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpLgorCiAyMDEzLTAzLTA0ICBBbGV4YW5kZXIg UGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog QWRkaW5nIG5ldyBydWxlcyBicm9rZW4gaWYgYSA8c3R5bGU+IHRhZyBpcyBhZGRlZCB0byBkb2N1 bWVudCBkeW5hbWljYWxseQpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Ny b2xsaW5nQ29vcmRpbmF0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv c2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAkocmV2aXNpb24gMTQ0NjAzKQorKysg U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yNzQsMTcgKzI3NCwzMiBAQCB2b2lkIFNjcm9sbGluZ0Nvb3JkaW5h dG9yOjpmcmFtZVZpZXdGaXhlCiAKIEdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9y OjpzY3JvbGxMYXllckZvclNjcm9sbGFibGVBcmVhKFNjcm9sbGFibGVBcmVhKiBzY3JvbGxhYmxl QXJlYSkKIHsKKyNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgcmV0dXJuIHNj cm9sbGFibGVBcmVhLT5sYXllckZvclNjcm9sbGluZygpOworI2Vsc2UKKyAgICBVTlVTRURfUEFS QU0oc2Nyb2xsYWJsZUFyZWEpOworICAgIHJldHVybiAwOworI2VuZGlmCiB9CiAKIEdyYXBoaWNz TGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpob3Jpem9udGFsU2Nyb2xsYmFyTGF5ZXJGb3JT Y3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSogc2Nyb2xsYWJsZUFyZWEpCiB7CisjaWYgVVNF KEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIHJldHVybiBzY3JvbGxhYmxlQXJlYS0+bGF5 ZXJGb3JIb3Jpem9udGFsU2Nyb2xsYmFyKCk7CisjZWxzZQorICAgIFVOVVNFRF9QQVJBTShzY3Jv bGxhYmxlQXJlYSk7CisgICAgcmV0dXJuIDA7CisjZW5kaWYKIH0KIAogR3JhcGhpY3NMYXllciog U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnZlcnRpY2FsU2Nyb2xsYmFyTGF5ZXJGb3JTY3JvbGxhYmxl QXJlYShTY3JvbGxhYmxlQXJlYSogc2Nyb2xsYWJsZUFyZWEpCiB7CisjaWYgVVNFKEFDQ0VMRVJB VEVEX0NPTVBPU0lUSU5HKQogICAgIHJldHVybiBzY3JvbGxhYmxlQXJlYS0+bGF5ZXJGb3JWZXJ0 aWNhbFNjcm9sbGJhcigpOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oc2Nyb2xsYWJsZUFyZWEp OworICAgIHJldHVybiAwOworI2VuZGlmCiB9CiAKIEdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nv b3JkaW5hdG9yOjpzY3JvbGxMYXllckZvckZyYW1lVmlldyhGcmFtZVZpZXcqIGZyYW1lVmlldykK 191421 2013-03-05 00:33:05 -0800 2013-03-05 14:49:08 -0800 Patch bug-111306-20130305092844.patch text/plain 2281 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDczNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTAzLTA1ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBmaXggYWZ0ZXIgcjE0NDAyNC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTExMTMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3Bw OiBBZGRlZCBndWFyZCBmb3IgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKS4KKyAgICAgICAg KiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5oOiBBZGRlZCBndWFyZCBmb3Ig VVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKS4KKwogMjAxMy0wMy0wNSAgSGFqaW1lIE1vcnJp dGEgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgU2hhZG93Um9vdCBuZWVkcyBndWFy ZFJlZigpIGFuZCBndWFyZERlcmVmKCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xs aW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAJKHJldmlzaW9uIDE0NDYw MykKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9y LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjcyLDYgKzI3Miw3IEBAIHZvaWQgU2Nyb2xsaW5nQ29v cmRpbmF0b3I6OmZyYW1lVmlld0ZpeGUKICAgICB1cGRhdGVTaG91bGRVcGRhdGVTY3JvbGxMYXll clBvc2l0aW9uT25NYWluVGhyZWFkKCk7CiB9CiAKKyNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9T SVRJTkcpCiBHcmFwaGljc0xheWVyKiBTY3JvbGxpbmdDb29yZGluYXRvcjo6c2Nyb2xsTGF5ZXJG b3JTY3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSogc2Nyb2xsYWJsZUFyZWEpCiB7CiAgICAg cmV0dXJuIHNjcm9sbGFibGVBcmVhLT5sYXllckZvclNjcm9sbGluZygpOwpAQCAtMjg2LDYgKzI4 Nyw3IEBAIEdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjp2ZXIKIHsKICAgICBy ZXR1cm4gc2Nyb2xsYWJsZUFyZWEtPmxheWVyRm9yVmVydGljYWxTY3JvbGxiYXIoKTsKIH0KKyNl bmRpZgogCiBHcmFwaGljc0xheWVyKiBTY3JvbGxpbmdDb29yZGluYXRvcjo6c2Nyb2xsTGF5ZXJG b3JGcmFtZVZpZXcoRnJhbWVWaWV3KiBmcmFtZVZpZXcpCiB7CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgJKHJldmlz aW9uIDE0NDYwMykKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nv b3JkaW5hdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTE2OCw5ICsxNjgsMTEgQEAgcHVibGljOgog cHJvdGVjdGVkOgogICAgIGV4cGxpY2l0IFNjcm9sbGluZ0Nvb3JkaW5hdG9yKFBhZ2UqKTsKIAor I2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBzdGF0aWMgR3JhcGhpY3NMYXll ciogc2Nyb2xsTGF5ZXJGb3JTY3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSopOwogICAgIHN0 YXRpYyBHcmFwaGljc0xheWVyKiBob3Jpem9udGFsU2Nyb2xsYmFyTGF5ZXJGb3JTY3JvbGxhYmxl QXJlYShTY3JvbGxhYmxlQXJlYSopOwogICAgIHN0YXRpYyBHcmFwaGljc0xheWVyKiB2ZXJ0aWNh bFNjcm9sbGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEoU2Nyb2xsYWJsZUFyZWEqKTsKKyNlbmRp ZgogCiAgICAgdW5zaWduZWQgY29tcHV0ZUN1cnJlbnRXaGVlbEV2ZW50SGFuZGxlckNvdW50KCk7 CiAgICAgR3JhcGhpY3NMYXllciogc2Nyb2xsTGF5ZXJGb3JGcmFtZVZpZXcoRnJhbWVWaWV3Kik7 Cg==