111303 2013-03-04 05:11:26 -0800 Remove redundant code in Document::updateHoverActiveState. 2013-03-05 01:18:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mkwst mkwst esprehn+autocc ojan.autocc webkit.review.bot oldest_to_newest 846346 0 mkwst 2013-03-04 05:11:26 -0800 Remove redundant code in Document::updateHoverActiveState. 846348 1 191206 mkwst 2013-03-04 05:15:33 -0800 Created attachment 191206 Patch 846351 2 mkwst 2013-03-04 05:17:43 -0800 I've extracted this bit from carewolf's patch in bug 98168. It seems like a good idea to land this bit separately, as it's tangential to that larger patch's focus. 846391 3 191206 mkwst 2013-03-04 06:08:38 -0800 Comment on attachment 191206 Patch FIXME: Credit carewolf in the ChangeLog before landing this. 846887 4 191206 darin 2013-03-04 15:02:35 -0800 Comment on attachment 191206 Patch Looks OK. The old code is simpler and faster for the special case it covers, but there’s no need for it if it’s not a significant performance optimization. 847372 5 mkwst 2013-03-05 00:27:16 -0800 (In reply to comment #4) > (From update of attachment 191206 [details]) > Looks OK. The old code is simpler and faster for the special case it covers, but there’s no need for it if it’s not a significant performance optimization. I believe the effect will be miniscule, but I'll keep an eye on perf.webkit.org just in case. Thanks! 847374 6 191419 mkwst 2013-03-05 00:27:53 -0800 Created attachment 191419 Patch for landing 847410 7 191419 webkit.review.bot 2013-03-05 01:18:03 -0800 Comment on attachment 191419 Patch for landing Clearing flags on attachment: 191419 Committed r144741: <http://trac.webkit.org/changeset/144741> 847411 8 webkit.review.bot 2013-03-05 01:18:06 -0800 All reviewed patches have been landed. Closing bug. 191206 2013-03-04 05:15:33 -0800 2013-03-05 00:27:48 -0800 Patch bug-111303-20130304141140.patch text/plain 2797 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDRkZTUwODYwNGFkOGYw OGY0ODM5MjczNmIwNzUyZWNjYjZlNDU1Mi4uMjY3ZmYxNWUyMmJlZTkwYjU2NTQxMTkzOTcxYzJi MDJjM2MzMGNkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAzLTA0ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHJlZHVuZGFudCBj b2RlIGluIERvY3VtZW50Ojp1cGRhdGVIb3ZlckFjdGl2ZVN0YXRlLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMzAzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9jdW1lbnQ6OnVwZGF0ZUhvdmVyQWN0 aXZlU3RhdGUgY3VycmVudGx5IGxvb2tzIGZvciB0b3VjaHJlbGVhc2UgZXZlbnRzCisgICAgICAg IGFuZCBleHBsaWN0bHkgY2xlYXJzIG91dCB0aGUgaG92ZXIgc3RhdGUgZm9yIGFsbCBub2RlcyBi ZXR3ZWVuIHRoZQorICAgICAgICBjdXJyZW50bHkgaG92ZXJlZCBub2RlIGFuZCB0aGUgdG9wIG9m IHRoZSBob3ZlciBjaGFpbi4gVGhpcyBpcyBhY3R1YWxseQorICAgICAgICByZWR1bmRhbnQgd2l0 aCB0aGUgbG9naWMgaW4gdGhlIHJlc3Qgb2YgdGhlIGZ1bmN0aW9uOyB3ZSBjYW4gc2ltcGxpZnkg YnkKKyAgICAgICAgc2V0dGluZyB0aGUgRWxlbWVudCogd2UncmUgd29ya2luZyB3aXRoIHRvIDAs IHdoaWNoIGNhdXNlcyB0aGUgbGF0ZXIKKyAgICAgICAgbG9vcHMgdG8gZG8gdGhlIG5lY2Vzc2Fy eSB3b3JrLgorCisgICAgICAgIFRoZXJlIHNob3VsZCBiZSBubyB3ZWItdmlzaWJsZSBlZmZlY3Qg ZnJvbSB0aGlzIGNoYW5nZTsgaXQgc2hvdWxkIHNpbXBseQorICAgICAgICBtYWtlIHRoaXMgZnVu Y3Rpb24gbGVzcyBjb21wbGV4LgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp1cGRhdGVIb3ZlckFjdGl2ZVN0YXRlKToKKyAgICAgICAg ICAgIFNldCBpbm5lckVsZW1lbnRJbkRvY3VtZW50IHRvIDAgcmF0aGVyIHRoYW4gd2Fsa2luZyB0 aGUgaG92ZXIgY2hhaW4KKyAgICAgICAgICAgIGFuZCBjbGVhcmluZyBpdCB3aGVuIHdlIHNlZSBh IHRvdWNocmVsZWFzZSBldmVudC4gVGhlIHJlc3Qgb2YgdGhlCisgICAgICAgICAgICBjb2RlIGlu IHRoaXMgZnVuY3Rpb24gd2lsbCBoYXZlIHRoZSBzYW1lIGVmZmVjdC4KKwogMjAxMy0wMy0wNCAg QWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IHRvdWNobW92ZSBub3QgZW11bGF0ZWQgaW5zaWRlIGlmcmFtZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAKaW5kZXggYzM2ZTY1Y2Q3MmEzNThiZGZhOGI2YTU1ZDJiOWM3MTY2YzgzZGFl Mi4uOWRlZDc2ZTg0ZjBkZjk5MTQzMjY5ZWY1MjA4NTA1YmQxODQ3OWFiYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCkBAIC01ODg2LDE4ICs1ODg2LDExIEBAIHZvaWQgRG9jdW1lbnQ6OnVwZGF0 ZUhvdmVyQWN0aXZlU3RhdGUoY29uc3QgSGl0VGVzdFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RS ZXN1CiAgICAgYm9vbCBtdXN0QmVJbkFjdGl2ZUNoYWluID0gcmVxdWVzdC5hY3RpdmUoKSAmJiBy ZXF1ZXN0Lm1vdmUoKTsKIAogICAgIFJlZlB0cjxOb2RlPiBvbGRIb3Zlck5vZGUgPSBob3Zlck5v ZGUoKTsKLSAgICAvLyBDbGVhciB0aGUgOmhvdmVyIGNoYWluIHdoZW4gdGhlIHRvdWNoIGdlc3R1 cmUgaXMgb3Zlci4KLSAgICBpZiAocmVxdWVzdC50b3VjaFJlbGVhc2UoKSkgewotICAgICAgICBp ZiAob2xkSG92ZXJOb2RlKSB7Ci0gICAgICAgICAgICBmb3IgKFJlbmRlck9iamVjdCogY3VyciA9 IG9sZEhvdmVyTm9kZS0+cmVuZGVyZXIoKTsgY3VycjsgY3VyciA9IGN1cnItPmhvdmVyQW5jZXN0 b3IoKSkgewotICAgICAgICAgICAgICAgIGlmIChjdXJyLT5ub2RlKCkgJiYgIWN1cnItPmlzVGV4 dCgpKQotICAgICAgICAgICAgICAgICAgICBjdXJyLT5ub2RlKCktPnNldEhvdmVyZWQoZmFsc2Up OwotICAgICAgICAgICAgfQotICAgICAgICAgICAgc2V0SG92ZXJOb2RlKDApOwotICAgICAgICB9 Ci0gICAgICAgIC8vIEEgdG91Y2ggcmVsZWFzZSBjYW4gbm90IHNldCBuZXcgaG92ZXIgb3IgYWN0 aXZlIHRhcmdldC4KLSAgICAgICAgcmV0dXJuOwotICAgIH0KKworICAgIC8vIEEgdG91Y2ggcmVs ZWFzZSBkb2VzIG5vdCBzZXQgYSBuZXcgaG92ZXIgdGFyZ2V0OyBzZXR0aW5nIHRoZSBlbGVtZW50 IHdlJ3JlIHdvcmtpbmcgd2l0aCB0byAwCisgICAgLy8gd2lsbCBjbGVhciB0aGUgY2hhaW4gb2Yg aG92ZXJlZCBlbGVtZW50cyBhbGwgdGhlIHdheSB0byB0aGUgdG9wIG9mIHRoZSB0cmVlLgorICAg IGlmIChyZXF1ZXN0LnRvdWNoUmVsZWFzZSgpKQorICAgICAgICBpbm5lckVsZW1lbnRJbkRvY3Vt ZW50ID0gMDsKIAogICAgIC8vIENoZWNrIHRvIHNlZSBpZiB0aGUgaG92ZXJlZCBub2RlIGhhcyBj aGFuZ2VkLgogICAgIC8vIElmIGl0IGhhc24ndCwgd2UgZG8gbm90IG5lZWQgdG8gZG8gYW55dGhp bmcuCg== 191419 2013-03-05 00:27:53 -0800 2013-03-05 01:18:03 -0800 Patch for landing bug-111303-20130305092359.patch text/plain 2878 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDRkZTUwODYwNGFkOGYw OGY0ODM5MjczNmIwNzUyZWNjYjZlNDU1Mi4uZGUzZWQyYWQ5MDdhYTY1NjU5YTAwOWNhMmJmYmE0 YTIwMTRhM2VhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEzLTAzLTA1ICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHJlZHVuZGFudCBj b2RlIGluIERvY3VtZW50Ojp1cGRhdGVIb3ZlckFjdGl2ZVN0YXRlLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMzAzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgRG9jdW1lbnQ6OnVwZGF0ZUhvdmVyQWN0aXZl U3RhdGUgY3VycmVudGx5IGxvb2tzIGZvciB0b3VjaHJlbGVhc2UgZXZlbnRzCisgICAgICAgIGFu ZCBleHBsaWN0bHkgY2xlYXJzIG91dCB0aGUgaG92ZXIgc3RhdGUgZm9yIGFsbCBub2RlcyBiZXR3 ZWVuIHRoZQorICAgICAgICBjdXJyZW50bHkgaG92ZXJlZCBub2RlIGFuZCB0aGUgdG9wIG9mIHRo ZSBob3ZlciBjaGFpbi4gVGhpcyBpcyBhY3R1YWxseQorICAgICAgICByZWR1bmRhbnQgd2l0aCB0 aGUgbG9naWMgaW4gdGhlIHJlc3Qgb2YgdGhlIGZ1bmN0aW9uOyB3ZSBjYW4gc2ltcGxpZnkgYnkK KyAgICAgICAgc2V0dGluZyB0aGUgRWxlbWVudCogd2UncmUgd29ya2luZyB3aXRoIHRvIDAsIHdo aWNoIGNhdXNlcyB0aGUgbGF0ZXIKKyAgICAgICAgbG9vcHMgdG8gZG8gdGhlIG5lY2Vzc2FyeSB3 b3JrLgorCisgICAgICAgIFRoZXJlIHNob3VsZCBiZSBubyB3ZWItdmlzaWJsZSBlZmZlY3QgZnJv bSB0aGlzIGNoYW5nZTsgaXQgc2hvdWxkIHNpbXBseQorICAgICAgICBtYWtlIHRoaXMgZnVuY3Rp b24gbGVzcyBjb21wbGV4LgorCisgICAgICAgIEV4dHJhY3RlZCBmcm9tIEFsbGFuIFNhbmRmZWxk IEplbnNlbidzIG9yaWdpbmFsIHBhdGNoIHRvIHdrYnVnLmNvbS85ODE2OAorCisgICAgICAgICog ZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp1cGRhdGVIb3Zl ckFjdGl2ZVN0YXRlKToKKyAgICAgICAgICAgIFNldCBpbm5lckVsZW1lbnRJbkRvY3VtZW50IHRv IDAgcmF0aGVyIHRoYW4gd2Fsa2luZyB0aGUgaG92ZXIgY2hhaW4KKyAgICAgICAgICAgIGFuZCBj bGVhcmluZyBpdCB3aGVuIHdlIHNlZSBhIHRvdWNocmVsZWFzZSBldmVudC4gVGhlIHJlc3Qgb2Yg dGhlCisgICAgICAgICAgICBjb2RlIGluIHRoaXMgZnVuY3Rpb24gd2lsbCBoYXZlIHRoZSBzYW1l IGVmZmVjdC4KKwogMjAxMy0wMy0wNCAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHRvdWNobW92ZSBub3QgZW11bGF0ZWQg aW5zaWRlIGlmcmFtZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggYzM2ZTY1Y2Q3MmEzNThi ZGZhOGI2YTU1ZDJiOWM3MTY2YzgzZGFlMi4uOWRlZDc2ZTg0ZjBkZjk5MTQzMjY5ZWY1MjA4NTA1 YmQxODQ3OWFiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC01ODg2LDE4ICs1ODg2LDEx IEBAIHZvaWQgRG9jdW1lbnQ6OnVwZGF0ZUhvdmVyQWN0aXZlU3RhdGUoY29uc3QgSGl0VGVzdFJl cXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1CiAgICAgYm9vbCBtdXN0QmVJbkFjdGl2ZUNoYWlu ID0gcmVxdWVzdC5hY3RpdmUoKSAmJiByZXF1ZXN0Lm1vdmUoKTsKIAogICAgIFJlZlB0cjxOb2Rl PiBvbGRIb3Zlck5vZGUgPSBob3Zlck5vZGUoKTsKLSAgICAvLyBDbGVhciB0aGUgOmhvdmVyIGNo YWluIHdoZW4gdGhlIHRvdWNoIGdlc3R1cmUgaXMgb3Zlci4KLSAgICBpZiAocmVxdWVzdC50b3Vj aFJlbGVhc2UoKSkgewotICAgICAgICBpZiAob2xkSG92ZXJOb2RlKSB7Ci0gICAgICAgICAgICBm b3IgKFJlbmRlck9iamVjdCogY3VyciA9IG9sZEhvdmVyTm9kZS0+cmVuZGVyZXIoKTsgY3Vycjsg Y3VyciA9IGN1cnItPmhvdmVyQW5jZXN0b3IoKSkgewotICAgICAgICAgICAgICAgIGlmIChjdXJy LT5ub2RlKCkgJiYgIWN1cnItPmlzVGV4dCgpKQotICAgICAgICAgICAgICAgICAgICBjdXJyLT5u b2RlKCktPnNldEhvdmVyZWQoZmFsc2UpOwotICAgICAgICAgICAgfQotICAgICAgICAgICAgc2V0 SG92ZXJOb2RlKDApOwotICAgICAgICB9Ci0gICAgICAgIC8vIEEgdG91Y2ggcmVsZWFzZSBjYW4g bm90IHNldCBuZXcgaG92ZXIgb3IgYWN0aXZlIHRhcmdldC4KLSAgICAgICAgcmV0dXJuOwotICAg IH0KKworICAgIC8vIEEgdG91Y2ggcmVsZWFzZSBkb2VzIG5vdCBzZXQgYSBuZXcgaG92ZXIgdGFy Z2V0OyBzZXR0aW5nIHRoZSBlbGVtZW50IHdlJ3JlIHdvcmtpbmcgd2l0aCB0byAwCisgICAgLy8g d2lsbCBjbGVhciB0aGUgY2hhaW4gb2YgaG92ZXJlZCBlbGVtZW50cyBhbGwgdGhlIHdheSB0byB0 aGUgdG9wIG9mIHRoZSB0cmVlLgorICAgIGlmIChyZXF1ZXN0LnRvdWNoUmVsZWFzZSgpKQorICAg ICAgICBpbm5lckVsZW1lbnRJbkRvY3VtZW50ID0gMDsKIAogICAgIC8vIENoZWNrIHRvIHNlZSBp ZiB0aGUgaG92ZXJlZCBub2RlIGhhcyBjaGFuZ2VkLgogICAgIC8vIElmIGl0IGhhc24ndCwgd2Ug ZG8gbm90IG5lZWQgdG8gZG8gYW55dGhpbmcuCg==