111295 2013-03-04 02:01:38 -0800 [WK2][EFL] Enable asynchronous spell checking by default 2013-03-06 00:07:36 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 81042 108172 1 g.czajkowski g.czajkowski gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 846239 0 g.czajkowski 2013-03-04 02:01:38 -0800 Asynchronous spell checking is disabled by default (bug 81042). It means all requests of checking the string are sent synchronously. WebKit-EFL implements requestCheckingOfString method (bug 108172) which allows to call spelling checking asynchronously. We should enable it be default for EFL to use non blocking API. 846310 1 191195 g.czajkowski 2013-03-04 03:37:37 -0800 Created attachment 191195 proposed patch 846313 2 191195 eflews.bot 2013-03-04 03:44:07 -0800 Comment on attachment 191195 proposed patch Attachment 191195 did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16916235 848538 3 g.czajkowski 2013-03-06 00:07:36 -0800 Committed r144892: <http://trac.webkit.org/changeset/144892> 191195 2013-03-04 03:37:37 -0800 2013-03-04 12:07:38 -0800 proposed patch spelling-asynchronous-enable-for-EFL.patch text/plain 1663 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5Mjc0MDlhLi4yZTMxMTk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDMtMDQgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW1dLMl1bRUZMXSBFbmFibGUgYXN5bmNocm9ub3VzIHNwZWxsIGNo ZWNraW5nIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExMTI5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFzeW5jaHJvbm91cyBzcGVsbCBjaGVja2luZyBmZWF0dXJlIGlzIGRpc2FibGVk IGJ5IGRlZmF1bHQgZm9yIHdrMiBwbGF0Zm9ybXMuCisgICAgICAgIEl0IG1lYW5zIGFsbCByZXF1 ZXN0cyBvZiBjaGVja2luZyB0aGUgc3RyaW5nIGFyZSBzZW50IHN5bmNocm9ub3VzbHkuCisKKyAg ICAgICAgV2ViS2l0LUVGTCBpbXBsZW1lbnRzIHJlcXVlc3RDaGVja2luZ09mU3RyaW5nIG1ldGhv ZCB3aGljaCBhbGxvd3MKKyAgICAgICAgdG8gY2hlY2sgc3BlbGxpbmcgYXN5bmNocm9ub3VzbHku CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcDoKKyAgICAgICAgKEV3 a1ZpZXc6OkV3a1ZpZXcpOgorCiAyMDEzLTAzLTAzICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0 b25AYXBwbGUuY29tPiwgR3J6ZWdvcnogQ3phamtvd3NraSAgPGcuY3phamtvd3NraUBzYW1zdW5n LmNvbT4KIAogICAgICAgICBbV0syXSBXVFIgbmVlZHMgYW4gaW1wbGVtZW50YXRpb24gb2Ygc2V0 QXN5bmNocm9ub3VzU3BlbGxDaGVja2luZ0VuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKaW5kZXggMTQ2MGI3MC4uN2EzY2FkYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKQEAgLTI4MCw2ICsyODAs OSBAQCBFd2tWaWV3OjpFd2tWaWV3KEV2YXNfT2JqZWN0KiBldmFzT2JqZWN0LCBQYXNzUmVmUHRy PEV3a0NvbnRleHQ+IGNvbnRleHQsIFdLUGFnZQogICAgIFdLUHJlZmVyZW5jZXNTZXRGdWxsU2Ny ZWVuRW5hYmxlZCh3a1ByZWZlcmVuY2VzLCB0cnVlKTsKICAgICBXS1ByZWZlcmVuY2VzU2V0V2Vi QXVkaW9FbmFibGVkKHdrUHJlZmVyZW5jZXMsIHRydWUpOwogICAgIFdLUHJlZmVyZW5jZXNTZXRP ZmZsaW5lV2ViQXBwbGljYXRpb25DYWNoZUVuYWJsZWQod2tQcmVmZXJlbmNlcywgdHJ1ZSk7Cisj aWYgRU5BQkxFKFNQRUxMQ0hFQ0spCisgICAgV0tQcmVmZXJlbmNlc1NldEFzeW5jaHJvbm91c1Nw ZWxsQ2hlY2tpbmdFbmFibGVkKHdrUHJlZmVyZW5jZXMsIHRydWUpOworI2VuZGlmCiAKICAgICAv LyBFbmFibGUgbW91c2UgZXZlbnRzIGJ5IGRlZmF1bHQKICAgICBzZXRNb3VzZUV2ZW50c0VuYWJs ZWQodHJ1ZSk7Cg==