111285 2013-03-03 22:35:51 -0800 [chromium] Switch to new webkit_support::CreateLayerTreeView interface 2013-03-05 10:21:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth dglazkov enne peter+ews tasak webkit.review.bot oldest_to_newest 846156 0 jamesr 2013-03-03 22:35:51 -0800 [chromium] Switch to new webkit_support::CreateLayerTreeView interface 846157 1 191162 jamesr 2013-03-03 22:36:46 -0800 Created attachment 191162 Patch 846158 2 jamesr 2013-03-03 22:37:13 -0800 Depends on https://codereview.chromium.org/12385074/ landing + rolling in. 846159 3 191162 webkit.review.bot 2013-03-03 22:48:02 -0800 Comment on attachment 191162 Patch Attachment 191162 did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16913258 846162 4 191162 webkit.review.bot 2013-03-03 22:56:25 -0800 Comment on attachment 191162 Patch Attachment 191162 did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16892980 846681 5 191162 enne 2013-03-04 11:47:23 -0800 Comment on attachment 191162 Patch R=me. 846755 6 191162 peter+ews 2013-03-04 12:57:08 -0800 Comment on attachment 191162 Patch Attachment 191162 did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/16897018 846850 7 191162 jamesr 2013-03-04 14:24:47 -0800 Comment on attachment 191162 Patch API has rolled in now 847161 8 191162 webkit.review.bot 2013-03-04 18:36:29 -0800 Comment on attachment 191162 Patch Clearing flags on attachment: 191162 Committed r144705: <http://trac.webkit.org/changeset/144705> 847162 9 webkit.review.bot 2013-03-04 18:36:33 -0800 All reviewed patches have been landed. Closing bug. 847398 10 tasak 2013-03-05 00:59:30 -0800 Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails. 75 void WebCompositorSupportImpl::shutdown() { 76 DCHECK(initialized_); 77 initialized_ = false; 78 compositor_thread_message_loop_proxy_ = NULL; 79 } So, core dumped. [18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. [0x000002735eb4] base::debug::StackTrace::StackTrace() [0x0000027511fd] logging::LogMessage::~LogMessage() [0x000002600963] webkit::WebCompositorSupportImpl::shutdown() [0x000000420244] main [0x7ffff394376d] __libc_start_main [0x00000041dc29] <unknown> 847784 11 jamesr 2013-03-05 10:15:03 -0800 (In reply to comment #10) > Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails. > > 75 void WebCompositorSupportImpl::shutdown() { > 76 DCHECK(initialized_); > 77 initialized_ = false; > 78 compositor_thread_message_loop_proxy_ = NULL; > 79 } > > So, core dumped. > > [18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. > [0x000002735eb4] base::debug::StackTrace::StackTrace() > [0x0000027511fd] logging::LogMessage::~LogMessage() > [0x000002600963] webkit::WebCompositorSupportImpl::shutdown() > [0x000000420244] main > [0x7ffff394376d] __libc_start_main > [0x00000041dc29] <unknown> D'oh. It's a silly assert, but lives on the chromium side. Will remove there. 847794 12 jamesr 2013-03-05 10:21:08 -0800 (In reply to comment #11) > (In reply to comment #10) > > Since WebKit::Platform::current()->compositorSupport()->initialize(m_webCompositorThread.get()); was removed, I think, the following DCHECK always fails. > > > > 75 void WebCompositorSupportImpl::shutdown() { > > 76 DCHECK(initialized_); > > 77 initialized_ = false; > > 78 compositor_thread_message_loop_proxy_ = NULL; > > 79 } > > > > So, core dumped. > > > > [18794:18794:2166180256545:FATAL:web_compositor_support_impl.cc(76)] Check failed: initialized_. > > [0x000002735eb4] base::debug::StackTrace::StackTrace() > > [0x0000027511fd] logging::LogMessage::~LogMessage() > > [0x000002600963] webkit::WebCompositorSupportImpl::shutdown() > > [0x000000420244] main > > [0x7ffff394376d] __libc_start_main > > [0x00000041dc29] <unknown> > > D'oh. It's a silly assert, but lives on the chromium side. Will remove there. https://bugs.webkit.org/show_bug.cgi?id=111440 191162 2013-03-03 22:36:46 -0800 2013-03-04 18:36:29 -0800 Patch bug-111285-20130303223305.patch text/plain 3741 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NTk0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjM4NjIwMmU4MjFmMjUxZjQ5NmZmYzI4ZjkwZTUxNjEz NTgwN2VlNC4uMmI5YzE1MjljZTk4YzA1YzU2ZGQ1ZTU4MDZiNzdmMTczZmIwNmQxYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEzLTAzLTAzICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgW2Nocm9taXVtXSBTd2l0Y2ggdG8gbmV3IHdlYmtpdF9zdXBwb3J0OjpDcmVhdGVM YXllclRyZWVWaWV3IGludGVyZmFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTExMjg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyByZW1vdmVzIHRoZSBuZWVkIGZvciBXZWJDb21wb3NpdG9yU3Vw cG9ydDo6aW5pdGlhbGl6ZSBhbmQgZXhwb3NlcworICAgICAgICBzbGlnaHRseSBmZXdlciBlbnRy eSBwb2ludHMgYWNyb3NzIHRoZSByZXBvc2l0b3J5IGJvdW5kYXJ5LgorCisgICAgICAgICogRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcDoKKyAgICAgICAgKFRlc3RTaGVsbDo6 aW5pdGlhbGl6ZSk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxs Lmg6CisgICAgICAgIChUZXN0U2hlbGw6OndlYkNvbXBvc2l0b3JUaHJlYWQpOgorICAgICAgICAo VGVzdFNoZWxsKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9z dC5jcHA6CisgICAgICAgIChXZWJWaWV3SG9zdDo6aW5pdGlhbGl6ZUxheWVyVHJlZVZpZXcpOgor CiAyMDEzLTAzLTAzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAg IFNvbWUgcGVyZi4gdGVzdHMgaGF2ZSB2YXJpYW5jZXMgdGhhdCBkaWZmZXIgZ3JlYXRseSBiZXR3 ZWVuIHJ1bnMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RT aGVsbC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwCmlu ZGV4IDgyZGM1ODQ2N2ZlOWRkM2U0MmIwNWRhZjJkZWFjNDIwMGI1ZTFlNTMuLjMxMzdkZjU5NDc5 YjY3M2ZkZTc3YWVkZTA4Y2RhYTMzNDdkNWMwZTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vVGVzdFNoZWxsLmNwcApAQCAtMTQ1LDcgKzE0NSw2IEBAIHZvaWQgVGVzdFNoZWxs Ojppbml0aWFsaXplKE1vY2tQbGF0Zm9ybSogcGxhdGZvcm1TdXBwb3J0KQogCiAgICAgaWYgKG1f dGhyZWFkZWRDb21wb3NpdGluZ0VuYWJsZWQpCiAgICAgICAgIG1fd2ViQ29tcG9zaXRvclRocmVh ZCA9IGFkb3B0UHRyKFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+Y3JlYXRlVGhyZWFkKCJD b21wb3NpdG9yIikpOwotICAgIFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQoKS0+Y29tcG9zaXRv clN1cHBvcnQoKS0+aW5pdGlhbGl6ZShtX3dlYkNvbXBvc2l0b3JUaHJlYWQuZ2V0KCkpOwogCiAg ICAgY3JlYXRlTWFpbldpbmRvdygpOwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vVGVzdFNoZWxsLmggYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9U ZXN0U2hlbGwuaAppbmRleCA2NzUwNmFkOWZmZTQ0ODcxMjM3NjZhMmZjMzk2MGI5OWFjMTRjMDIw Li4wMmRhMWZjMmU5NWVhNjg2NTE5NTUyZWY3MDhkY2M5NTMxODQyZjQ4IDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuaAorKysgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuaApAQCAtMTc1LDYgKzE3NSw4IEBAIHB1Ymxp YzoKICAgICB0eXBlZGVmIFZlY3RvcjxXZWJWaWV3SG9zdCo+IFdpbmRvd0xpc3Q7CiAgICAgV2lu ZG93TGlzdCB3aW5kb3dMaXN0KCkgY29uc3QgeyByZXR1cm4gbV93aW5kb3dMaXN0OyB9CiAKKyAg ICBXZWJLaXQ6OldlYlRocmVhZCogd2ViQ29tcG9zaXRvclRocmVhZCgpIGNvbnN0IHsgcmV0dXJu IG1fd2ViQ29tcG9zaXRvclRocmVhZC5nZXQoKTsgfQorCiBwcml2YXRlOgogICAgIFdlYlZpZXdI b3N0KiBjcmVhdGVOZXdXaW5kb3coY29uc3QgV2ViS2l0OjpXZWJVUkwmLCBEUlREZXZUb29sc0Fn ZW50KiwgV2ViVGVzdFJ1bm5lcjo6V2ViVGVzdEludGVyZmFjZXMqKTsKICAgICB2b2lkIGNyZWF0 ZU1haW5XaW5kb3coKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVt L1dlYlZpZXdIb3N0LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdI b3N0LmNwcAppbmRleCBlMDZkNGU0MGQxYzQ4OTllMmNjZDhhMWQ4ODYwMGU5OGE5Njg3M2RlLi4y NTYxOWQ2YTQ4MGYxYjNiOTIxYTZmYjlmNTJiMGQxMGQwNWUxNDkyIDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKKysrIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCkBAIC0yNzgsMTAgKzI3OCwxNyBA QCBwcml2YXRlOgogdm9pZCBXZWJWaWV3SG9zdDo6aW5pdGlhbGl6ZUxheWVyVHJlZVZpZXcoV2Vi TGF5ZXJUcmVlVmlld0NsaWVudCogY2xpZW50LCBjb25zdCBXZWJMYXllciYgcm9vdExheWVyLCBj b25zdCBXZWJMYXllclRyZWVWaWV3OjpTZXR0aW5ncyYgc2V0dGluZ3MpCiB7CiAgICAgbV9sYXll clRyZWVWaWV3Q2xpZW50ID0gYWRvcHRQdHIobmV3IFdlYlZpZXdIb3N0RFJUTGF5ZXJUcmVlVmll d0NsaWVudCh0aGlzKSk7Ci0gICAgaWYgKG1fc2hlbGwtPnNvZnR3YXJlQ29tcG9zaXRpbmdFbmFi bGVkKCkpCi0gICAgICAgIG1fbGF5ZXJUcmVlVmlldyA9IGFkb3B0UHRyKHdlYmtpdF9zdXBwb3J0 OjpDcmVhdGVMYXllclRyZWVWaWV3U29mdHdhcmUobV9sYXllclRyZWVWaWV3Q2xpZW50LmdldCgp KSk7Ci0gICAgZWxzZQotICAgICAgICBtX2xheWVyVHJlZVZpZXcgPSBhZG9wdFB0cih3ZWJraXRf c3VwcG9ydDo6Q3JlYXRlTGF5ZXJUcmVlVmlldzNkKG1fbGF5ZXJUcmVlVmlld0NsaWVudC5nZXQo KSkpOworICAgIGlmIChtX3NoZWxsLT5zb2Z0d2FyZUNvbXBvc2l0aW5nRW5hYmxlZCgpKSB7Cisg ICAgICAgIG1fbGF5ZXJUcmVlVmlldyA9IGFkb3B0UHRyKHdlYmtpdF9zdXBwb3J0OjpDcmVhdGVM YXllclRyZWVWaWV3KAorICAgICAgICAgICAgd2Via2l0X3N1cHBvcnQ6OlNPRlRXQVJFX0NPTlRF WFQsCisgICAgICAgICAgICBtX2xheWVyVHJlZVZpZXdDbGllbnQuZ2V0KCksCisgICAgICAgICAg ICBtX3NoZWxsLT53ZWJDb21wb3NpdG9yVGhyZWFkKCkpKTsKKyAgICB9IGVsc2UgeworICAgICAg ICBtX2xheWVyVHJlZVZpZXcgPSBhZG9wdFB0cih3ZWJraXRfc3VwcG9ydDo6Q3JlYXRlTGF5ZXJU cmVlVmlldygKKyAgICAgICAgICAgIHdlYmtpdF9zdXBwb3J0OjpNRVNBX0NPTlRFWFQsCisgICAg ICAgICAgICBtX2xheWVyVHJlZVZpZXdDbGllbnQuZ2V0KCksCisgICAgICAgICAgICBtX3NoZWxs LT53ZWJDb21wb3NpdG9yVGhyZWFkKCkpKTsKKyAgICB9CiAKICAgICBBU1NFUlQobV9sYXllclRy ZWVWaWV3KTsKICAgICB1cGRhdGVWaWV3cG9ydFNpemUoKTsK