111272 2013-03-03 10:18:09 -0800 Attempt to fix the Qt build after r144498 2013-03-03 12:20:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106127 1 abarth abarth eric jbriance webkit.review.bot oldest_to_newest 846035 0 abarth 2013-03-03 10:18:09 -0800 Attempt to fix the Qt build after r144498 846036 1 191137 abarth 2013-03-03 10:20:36 -0800 Created attachment 191137 Patch 846039 2 191137 eric 2013-03-03 10:27:27 -0800 Comment on attachment 191137 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191137&action=review > Source/WebCore/xml/parser/XMLDocumentParserQt.cpp:276 > + append(String("<qxmlstreamdummyelement>").impl()); This could be StringImpl::create(), but this is also fine. 846040 3 abarth 2013-03-03 10:30:42 -0800 I'm going to leave it that way for simplicity. 846049 4 191137 webkit.review.bot 2013-03-03 11:59:39 -0800 Comment on attachment 191137 Patch Clearing flags on attachment: 191137 Committed r144578: <http://trac.webkit.org/changeset/144578> 846050 5 webkit.review.bot 2013-03-03 11:59:42 -0800 All reviewed patches have been landed. Closing bug. 846051 6 jbriance 2013-03-03 12:20:26 -0800 (In reply to comment #0) > Attempt to fix the Qt build after r144498 Build is ok now: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/21413 Thanks a lot for your reactivity (even on a sunday) ! 191137 2013-03-03 10:20:36 -0800 2013-03-03 11:59:38 -0800 Patch bug-111272-20130303101645.patch text/plain 1852 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDU3NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTAzICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQXR0ZW1wdCB0byBmaXggdGhlIFF0 IGJ1aWxkIGFmdGVyIHIxNDQ0OTgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTExMTI3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVwZGF0ZSB0aGUgUXQgdmVyc2lvbiBvZiB0aGUgWE1MIHBhcnNlciB0byBj YWxsIHRoZSBuZXcgQVBJLgorCisgICAgICAgICogeG1sL3BhcnNlci9YTUxEb2N1bWVudFBhcnNl clF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlhNTERvY3VtZW50UGFyc2VyOjpyZXN1bWVQYXJz aW5nKToKKyAgICAgICAgKFdlYkNvcmU6OlhNTERvY3VtZW50UGFyc2VyOjphcHBlbmRGcmFnbWVu dFNvdXJjZSk6CisKIDIwMTMtMDMtMDMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgW1dpbl0gSURMUGFyc2VyLnBtIGZhaWxzIHRvIHBhcnNlIE9FU1RleHR1cmVI YWxmRmxvYXQgYW5kIGNhdXNlcyBhIGJ1aWxkIGZhaWx1cmUKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXJRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUveG1sL3BhcnNlci9YTUxEb2N1bWVudFBhcnNlclF0LmNwcAkocmV2aXNpb24gMTQ0 NTY3KQorKysgU291cmNlL1dlYkNvcmUveG1sL3BhcnNlci9YTUxEb2N1bWVudFBhcnNlclF0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjYyLDcgKzI2Miw3IEBAIHZvaWQgWE1MRG9jdW1lbnRQYXJz ZXI6OnJlc3VtZVBhcnNpbmcoKQogICAgIC8vIFRoZW4sIHdyaXRlIGFueSBwZW5kaW5nIGRhdGEK ICAgICBTZWdtZW50ZWRTdHJpbmcgcmVzdCA9IG1fcGVuZGluZ1NyYzsKICAgICBtX3BlbmRpbmdT cmMuY2xlYXIoKTsKLSAgICBhcHBlbmQocmVzdCk7CisgICAgYXBwZW5kKHJlc3QudG9TdHJpbmco KS5pbXBsKCkpOwogCiAgICAgLy8gRmluYWxseSwgaWYgZmluaXNoKCkgaGFzIGJlZW4gY2FsbGVk IGFuZCBhcHBlbmQoKSBkaWRuJ3QgcmVzdWx0CiAgICAgLy8gaW4gYW55IGZ1cnRoZXIgY2FsbGJh Y2tzIGJlaW5nIHF1ZXVlZCwgY2FsbCBlbmQoKQpAQCAtMjczLDkgKzI3Myw5IEBAIHZvaWQgWE1M RG9jdW1lbnRQYXJzZXI6OnJlc3VtZVBhcnNpbmcoKQogYm9vbCBYTUxEb2N1bWVudFBhcnNlcjo6 YXBwZW5kRnJhZ21lbnRTb3VyY2UoY29uc3QgU3RyaW5nJiBzb3VyY2UpCiB7CiAgICAgQVNTRVJU KCFtX3Nhd0ZpcnN0RWxlbWVudCk7Ci0gICAgYXBwZW5kKFN0cmluZygiPHF4bWxzdHJlYW1kdW1t eWVsZW1lbnQ+IikpOwotICAgIGFwcGVuZChzb3VyY2UpOwotICAgIGFwcGVuZChTdHJpbmcoIjwv cXhtbHN0cmVhbWR1bW15ZWxlbWVudD4iKSk7CisgICAgYXBwZW5kKFN0cmluZygiPHF4bWxzdHJl YW1kdW1teWVsZW1lbnQ+IikuaW1wbCgpKTsKKyAgICBhcHBlbmQoc291cmNlLmltcGwoKSk7Cisg ICAgYXBwZW5kKFN0cmluZygiPC9xeG1sc3RyZWFtZHVtbXllbGVtZW50PiIpLmltcGwoKSk7CiAg ICAgcmV0dXJuICFoYXNFcnJvcigpOwogfQogCg==