111271 2013-03-03 09:44:25 -0800 WebKit fails to build with MinGW compiler after changeset 144024 2013-03-05 14:41:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 111306 P2 Normal --- 0 tuxator webkit-unassigned andersca cmarcelo gustavo jamesr luiz mrobinson tonikitoo trchen webkit.review.bot zan oldest_to_newest 846028 0 tuxator 2013-03-03 09:44:25 -0800 WebKit fails to build with MinGW compiler after changeset 144024 846029 1 tuxator 2013-03-03 09:50:12 -0800 Build fails with the following error from Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:31: /usr/i686-w64-mingw32/sys-root/mingw/include/winsock2.h:15:2: warning: #warning Please include winsock2.h before windows.h [-Wcpp] Source/WebCore/page/scrolling/ScrollingCoordinator.cpp: In static member function 'static WebCore::GraphicsLayer* WebCore::ScrollingCoordinator::scrollLayerForScrollableArea(WebCore::ScrollableArea*)': Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:277:28: error: 'class WebCore::ScrollableArea' has no member named 'layerForScrolling' Source/WebCore/page/scrolling/ScrollingCoordinator.cpp: In static member function 'static WebCore::GraphicsLayer* WebCore::ScrollingCoordinator::horizontalScrollbarLayerForScrollableArea(WebCore::ScrollableArea*)': Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:282:28: error: 'class WebCore::ScrollableArea' has no member named 'layerForHorizontalScrollbar' Source/WebCore/page/scrolling/ScrollingCoordinator.cpp: In static member function 'static WebCore::GraphicsLayer* WebCore::ScrollingCoordinator::verticalScrollbarLayerForScrollableArea(WebCore::ScrollableArea*)': Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:287:28: error: 'class WebCore::ScrollableArea' has no member named 'layerForVerticalScrollbar' Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:288:1: warning: control reaches end of non-void function [-Wreturn-type] Source/WebCore/page/scrolling/ScrollingCoordinator.cpp: In static member function 'static WebCore::GraphicsLayer* WebCore::ScrollingCoordinator::horizontalScrollbarLayerForScrollableArea(WebCore::ScrollableArea*)': Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:283:1: warning: control reaches end of non-void function [-Wreturn-type] Source/WebCore/page/scrolling/ScrollingCoordinator.cpp: In static member function 'static WebCore::GraphicsLayer* WebCore::ScrollingCoordinator::scrollLayerForScrollableArea(WebCore::ScrollableArea*)': Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:278:1: warning: control reaches end of non-void function [-Wreturn-type] make[1]: *** [Source/WebCore/page/scrolling/libWebCore_la-ScrollingCoordinator.lo] Błąd 1 make[1]: Opuszczenie katalogu `/home/pawel/src/webkit' make: *** [all] Błąd 2 846032 2 191136 tuxator 2013-03-03 10:10:19 -0800 Created attachment 191136 Patch 846143 3 191136 jamesr 2013-03-03 21:24:29 -0800 Comment on attachment 191136 Patch Seems like this is fixing the problem in the wrong place. Can you just give ScrollableArea empty (inline return null) definitions in the !USE(ACCELERATED_COMPOSITING) case? Then the callers wouldn't have to look so ugly. 846459 4 gustavo 2013-03-04 07:15:47 -0800 Chromium seems to be the only user of these methods, I think not defining them at all if AC is off makes sense (as opposed to defining an empty version for the non-AC case). 847973 5 191545 tuxator 2013-03-05 13:04:58 -0800 Created attachment 191545 Patch 848050 6 191545 darin 2013-03-05 14:06:09 -0800 Comment on attachment 191545 Patch Not sure this has anything to do with the MinGW compiler. 848053 7 191545 darin 2013-03-05 14:07:39 -0800 Comment on attachment 191545 Patch I didn’t see James Robinson’s earlier comment; James, feel free to change to review- if you disagree with me. It seems to me that GraphicsLayer should only exist when USE(ACCELERATED_COMPOSITING) is true. I’m surprised that is not the case! 848067 8 jamesr 2013-03-05 14:18:31 -0800 (In reply to comment #7) > (From update of attachment 191545 [details]) > I didn’t see James Robinson’s earlier comment; James, feel free to change to review- if you disagree with me. > > It seems to me that GraphicsLayer should only exist when USE(ACCELERATED_COMPOSITING) is true. I’m surprised that is not the case! There's another patch that fixes this - lemme find it. 848079 9 jamesr 2013-03-05 14:32:05 -0800 I believe the patch in https://bugs.webkit.org/show_bug.cgi?id=111306 takes care of this. The GraphicsLayer type's definition is guarded by USE(ACCELERATED_COMPOSITING) but there are declarations of the type outside the guard in various places. I guess it's to keep the #ifdeffage down in interface definitions, but perhaps Simon knows the history more concretely here. 848081 10 jamesr 2013-03-05 14:32:56 -0800 I think the more general issue is very few ports compile without USE(ACCELERATED_COMPOSITING) these days (for instance, none of the EWS bots do) so it's harder to keep this configuration compiling. 848090 11 jamesr 2013-03-05 14:41:39 -0800 Nothing necessarily wrong with this patch, but it'll be handled by patch in bug 111306 just as well. *** This bug has been marked as a duplicate of bug 111306 *** 191136 2013-03-03 10:10:19 -0800 2013-03-05 13:04:48 -0800 Patch bug-111271-20130303190627.patch text/plain 2484 tuxator U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTIyYjgyYWMzZjY3NDEy N2IwZmVhNGJiMjY2NWFiMDI5NGI2YmI5OC4uNzZjMWVjYzI3NWVlYTlhMjQ0ODkxODYwNjRlMTc0 OWQ5NDFkMTM5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTAzLTAzICBQYXdl xYIgRm9yeXNpdWsgIDx0dXhhdG9yQG8yLnBsPgorCisgICAgICAgIFdlYktpdCBmYWlscyB0byBi dWlsZCB3aXRoIE1pbkdXIGNvbXBpbGVyIGFmdGVyIGNoYW5nZXNldCAxNDQwMjQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTI3MQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoT09Q UyEpLgorCisgICAgICAgIE9ubHkgY2FsbCB0aGUgbGF5ZXJGb3JTY3JvbGxpbmcgYW5kCisgICAg ICAgIGxheWVyRm9yKEhvcml6b250YWx8VmVydGljYWwpU2Nyb2xsYmFyIG9uIHRoZSBTY3JvbGxh YmxlQXJlYSBvYmplY3RzCisgICAgICAgIHdoZW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgaXMg ZW5hYmxlZCBiZWNhdXNlIHRoZXNlIG1ldGhvZHMgYXJlIG5vdAorICAgICAgICBkZWZpbmVkIG90 aGVyd2lzZS4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9y LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpzY3JvbGxMYXll ckZvclNjcm9sbGFibGVBcmVhKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5h dG9yOjpob3Jpem9udGFsU2Nyb2xsYmFyTGF5ZXJGb3JTY3JvbGxhYmxlQXJlYSk6CisgICAgICAg IChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvcjo6dmVydGljYWxTY3JvbGxiYXJMYXllckZv clNjcm9sbGFibGVBcmVhKToKKwogMjAxMy0wMy0wMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2 aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE0 NDU2Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGlu Z0Nvb3JkaW5hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGlu Z0Nvb3JkaW5hdG9yLmNwcAppbmRleCBiZWRlNGZlMjgzNWZjM2RhNzg5ZjM3OTg4MGU2MDFiMWI3 MGE2MGY1Li5hYTQ5MjAwZWVkNGJiNzIzOGZmZmVjZWViOTdjZTk3NDlmOGVjMGVhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0 b3IuY3BwCkBAIC0yNzQsMTcgKzI3NCwzMiBAQCB2b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpm cmFtZVZpZXdGaXhlZE9iamVjdHNEaWRDaGFuZ2UoRnJhbWVWaWV3KiBmcmFtZVZpZXcpCiAKIEdy YXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpzY3JvbGxMYXllckZvclNjcm9sbGFi bGVBcmVhKFNjcm9sbGFibGVBcmVhKiBzY3JvbGxhYmxlQXJlYSkKIHsKKyNpZiBVU0UoQUNDRUxF UkFURURfQ09NUE9TSVRJTkcpCiAgICAgcmV0dXJuIHNjcm9sbGFibGVBcmVhLT5sYXllckZvclNj cm9sbGluZygpOworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oc2Nyb2xsYWJsZUFyZWEpOworICAg IHJldHVybiAwOworI2VuZGlmCiB9CiAKIEdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5h dG9yOjpob3Jpem9udGFsU2Nyb2xsYmFyTGF5ZXJGb3JTY3JvbGxhYmxlQXJlYShTY3JvbGxhYmxl QXJlYSogc2Nyb2xsYWJsZUFyZWEpCiB7CisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5H KQogICAgIHJldHVybiBzY3JvbGxhYmxlQXJlYS0+bGF5ZXJGb3JIb3Jpem9udGFsU2Nyb2xsYmFy KCk7CisjZWxzZQorICAgIFVOVVNFRF9QQVJBTShzY3JvbGxhYmxlQXJlYSk7CisgICAgcmV0dXJu IDA7CisjZW5kaWYKIH0KIAogR3JhcGhpY3NMYXllciogU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnZl cnRpY2FsU2Nyb2xsYmFyTGF5ZXJGb3JTY3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSogc2Ny b2xsYWJsZUFyZWEpCiB7CisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIHJl dHVybiBzY3JvbGxhYmxlQXJlYS0+bGF5ZXJGb3JWZXJ0aWNhbFNjcm9sbGJhcigpOworI2Vsc2UK KyAgICBVTlVTRURfUEFSQU0oc2Nyb2xsYWJsZUFyZWEpOworICAgIHJldHVybiAwOworI2VuZGlm CiB9CiAKIEdyYXBoaWNzTGF5ZXIqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpzY3JvbGxMYXllckZv ckZyYW1lVmlldyhGcmFtZVZpZXcqIGZyYW1lVmlldykK 191545 2013-03-05 13:04:58 -0800 2013-03-05 14:07:38 -0800 Patch bug-111271-20130305220103.patch text/plain 2698 tuxator U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NzY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQwZWU2ZDUzMTA3NTk0 NzJlYmQwNGYyNjZmMzNlODgzYjg0OWQ3MC4uMGUxZDlmYWYyZmEwMDdlZGJkYzNiMDMwZDY4YzEy MDYxYTAzMGYyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTA1ICBQYXdl xYIgRm9yeXNpdWsgIDx0dXhhdG9yQG8yLnBsPgorCisgICAgICAgIFdlYktpdCBmYWlscyB0byBi dWlsZCB3aXRoIE1pbkdXIGNvbXBpbGVyIGFmdGVyIGNoYW5nZXNldCAxNDQwMjQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTI3MQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgZGVmaW5lIHNjcm9s bExheWVyRm9yU2Nyb2xsYWJsZUFyZWEgYW5kCisgICAgICAgIChob3Jpem9udGFsfHZlcnRpY2Fs KVNjcm9sbGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEKKyAgICAgICAgaWYgQUNDRUxFUkFURURf Q09NUE9TSVRJTkcgaXMgdXNlZC4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGlu Z0Nvb3JkaW5hdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIHBhZ2Uvc2Ny b2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmg6CisgICAgICAgIChTY3JvbGxpbmdDb29yZGlu YXRvcik6CisKIDIwMTMtMDMtMDUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4K IAogICAgICAgICBCVUlMRCBGSVggKHIxNDQ2OTgpOiBPbmx5IGVuYWJsZSBTUEVFQ0hfU1lOVEhF U0lTIGZvciBNYWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Nj cm9sbGluZ0Nvb3JkaW5hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Nj cm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAppbmRleCBiZWRlNGZlMjgzNWZjM2RhNzg5ZjM3OTg4MGU2 MDFiMWI3MGE2MGY1Li5lMTk2NTcyNTFkNDg3MDc4NzdiZjNjM2JiYjE5NzQyNmYxNjYxNTgzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGlu YXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29v cmRpbmF0b3IuY3BwCkBAIC0yNzIsNiArMjcyLDcgQEAgdm9pZCBTY3JvbGxpbmdDb29yZGluYXRv cjo6ZnJhbWVWaWV3Rml4ZWRPYmplY3RzRGlkQ2hhbmdlKEZyYW1lVmlldyogZnJhbWVWaWV3KQog ICAgIHVwZGF0ZVNob3VsZFVwZGF0ZVNjcm9sbExheWVyUG9zaXRpb25Pbk1haW5UaHJlYWQoKTsK IH0KIAorI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKIEdyYXBoaWNzTGF5ZXIqIFNj cm9sbGluZ0Nvb3JkaW5hdG9yOjpzY3JvbGxMYXllckZvclNjcm9sbGFibGVBcmVhKFNjcm9sbGFi bGVBcmVhKiBzY3JvbGxhYmxlQXJlYSkKIHsKICAgICByZXR1cm4gc2Nyb2xsYWJsZUFyZWEtPmxh eWVyRm9yU2Nyb2xsaW5nKCk7CkBAIC0yODYsNiArMjg3LDcgQEAgR3JhcGhpY3NMYXllciogU2Ny b2xsaW5nQ29vcmRpbmF0b3I6OnZlcnRpY2FsU2Nyb2xsYmFyTGF5ZXJGb3JTY3JvbGxhYmxlQXJl YShTY3IKIHsKICAgICByZXR1cm4gc2Nyb2xsYWJsZUFyZWEtPmxheWVyRm9yVmVydGljYWxTY3Jv bGxiYXIoKTsKIH0KKyNlbmRpZgogCiBHcmFwaGljc0xheWVyKiBTY3JvbGxpbmdDb29yZGluYXRv cjo6c2Nyb2xsTGF5ZXJGb3JGcmFtZVZpZXcoRnJhbWVWaWV3KiBmcmFtZVZpZXcpCiB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRv ci5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3Iu aAppbmRleCBkNmMzMzVkMjUxZTBhYzdiNTdlYWVjZjMzNzJlMTE3OTc2Y2I3YmE0Li4xNGQ5MGU1 ZDc4MDUwOTJhNjNjZTk4NmEzMGExNGIwOGMzMGUxNzk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgKQEAgLTE2OCw5ICsx NjgsMTEgQEAgcHVibGljOgogcHJvdGVjdGVkOgogICAgIGV4cGxpY2l0IFNjcm9sbGluZ0Nvb3Jk aW5hdG9yKFBhZ2UqKTsKIAorI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBz dGF0aWMgR3JhcGhpY3NMYXllciogc2Nyb2xsTGF5ZXJGb3JTY3JvbGxhYmxlQXJlYShTY3JvbGxh YmxlQXJlYSopOwogICAgIHN0YXRpYyBHcmFwaGljc0xheWVyKiBob3Jpem9udGFsU2Nyb2xsYmFy TGF5ZXJGb3JTY3JvbGxhYmxlQXJlYShTY3JvbGxhYmxlQXJlYSopOwogICAgIHN0YXRpYyBHcmFw aGljc0xheWVyKiB2ZXJ0aWNhbFNjcm9sbGJhckxheWVyRm9yU2Nyb2xsYWJsZUFyZWEoU2Nyb2xs YWJsZUFyZWEqKTsKKyNlbmRpZgogCiAgICAgdW5zaWduZWQgY29tcHV0ZUN1cnJlbnRXaGVlbEV2 ZW50SGFuZGxlckNvdW50KCk7CiAgICAgR3JhcGhpY3NMYXllciogc2Nyb2xsTGF5ZXJGb3JGcmFt ZVZpZXcoRnJhbWVWaWV3Kik7Cg==