111269 2013-03-03 09:10:09 -0800 JSC_OBJC_API_ENABLED should be removed from FeatureDefines.h 2013-03-04 13:13:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg benjamin buildbot cmarcelo ddkilzer laszlo.gombos ojan.autocc rniwa webkit.review.bot oldest_to_newest 846022 0 mhahnenberg 2013-03-03 09:10:09 -0800 From bug 110291: "This flag was originally added to FeatureDefines.h so that it could be used in WebCore.exp.in to determine whether or not we should be exporting certain symbols based on whether the WebKit-related portion of the JSC ObjC API was enabled, but it turned out conditionally including certain symbols didn't work when building fat binaries, so it's not even necessary any more. tl;dr: removing JSC_OBJC_API_ENABLED from FeatureDefines.h is a good idea." 846072 1 191143 laszlo.gombos 2013-03-03 14:01:05 -0800 Created attachment 191143 1st take 846098 2 191143 buildbot 2013-03-03 14:59:53 -0800 Comment on attachment 191143 1st take Attachment 191143 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16862955 846101 3 191143 buildbot 2013-03-03 15:26:33 -0800 Comment on attachment 191143 1st take Attachment 191143 did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16911184 846118 4 191143 buildbot 2013-03-03 16:25:23 -0800 Comment on attachment 191143 1st take Attachment 191143 did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16910317 846130 5 191157 laszlo.gombos 2013-03-03 17:50:33 -0800 Created attachment 191157 fix max builds 846443 6 laszlo.gombos 2013-03-04 06:51:31 -0800 (In reply to comment #5) > Created an attachment (id=191157) [details] > fix max builds I mean mac builds. 846742 7 191157 mhahnenberg 2013-03-04 12:42:23 -0800 Comment on attachment 191157 fix max builds r=me. Thanks for tackling this patch! 846768 8 191157 webkit.review.bot 2013-03-04 13:13:34 -0800 Comment on attachment 191157 fix max builds Clearing flags on attachment: 191157 Committed r144662: <http://trac.webkit.org/changeset/144662> 846769 9 webkit.review.bot 2013-03-04 13:13:39 -0800 All reviewed patches have been landed. Closing bug. 191143 2013-03-03 14:01:05 -0800 2013-03-03 17:50:33 -0800 1st take 111269.patch text/plain 1677 laszlo.gombos SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDQ1NzkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTAzICBMYXN6bG8gR29tYm9zICA8bC5n b21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgSlNDX09CSkNfQVBJX0VOQUJMRUQgc2hvdWxk IGJlIHJlbW92ZWQgZnJvbSBGZWF0dXJlRGVmaW5lcy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTEyNjkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKU0NfT0JKQ19BUElfRU5BQkxFRCBmbGFnIHdhcyBh ZGRlZCB0byBGZWF0dXJlRGVmaW5lcy5oIChyMTQzNjM3KSAKKyAgICAgICAgc28gdGhhdCBpdCBj b3VsZCBiZSB1c2VkIGluIFdlYkNvcmUuZXhwLmluIHRvIGRldGVybWluZSB3aGV0aGVyIAorICAg ICAgICBvciBub3Qgd2Ugc2hvdWxkIGJlIGV4cG9ydGluZyBjZXJ0YWluIHN5bWJvbHMgYmFzZWQg b24gd2hldGhlciAKKyAgICAgICAgdGhlIFdlYktpdC1yZWxhdGVkIHBvcnRpb24gb2YgdGhlIEpT QyBPYmpDIEFQSSB3YXMgZW5hYmxlZC4KKyAgICAgICAgCisgICAgICAgIEl0IHR1cm5lZCBvdXQg Y29uZGl0aW9uYWxseSBpbmNsdWRpbmcgY2VydGFpbiBzeW1ib2xzIGRpZG4ndAorICAgICAgICB3 b3JrIHdoZW4gYnVpbGRpbmcgZmF0IGJpbmFyaWVzLCBzbyBpdCdzIG5vdCBldmVuIG5lY2Vzc2Fy eSBhbnkgbW9yZS4KKworICAgICAgICAqIHd0Zi9GZWF0dXJlRGVmaW5lcy5oOiBSZW1vdmUgSlND X09CSkNfQVBJX0VOQUJMRUQuCisKIDIwMTMtMDItMjcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw bGUuY29tPgogCiAgICAgICAgIFN0cmluZ0hhc2hlciBmdW5jdGlvbnMgcmVxdWlyZSBhbGlnbm1l bnQgdGhhdCBjYWxsIHNpdGVzIGRvIG5vdCBhbGwgZ3VhcmFudGVlCkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9GZWF0dXJlRGVmaW5lcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0ZlYXR1 cmVEZWZpbmVzLmgJKHJldmlzaW9uIDE0NDU1MykKKysrIFNvdXJjZS9XVEYvd3RmL0ZlYXR1cmVE ZWZpbmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTU2OSwxMCArNTY5LDYgQEAKICNkZWZpbmUgRU5B QkxFX0pBVkFTQ1JJUFRfSTE4Tl9BUEkgMAogI2VuZGlmCiAKLSNpZiAhZGVmaW5lZChKU0NfT0JK Q19BUElfRU5BQkxFRCkKLSNkZWZpbmUgSlNDX09CSkNfQVBJX0VOQUJMRUQgKGRlZmluZWQoX19j bGFuZ19fKSAmJiBkZWZpbmVkKF9fQVBQTEVfXykgJiYgZGVmaW5lZChfX01BQ19PU19YX1ZFUlNJ T05fTUlOX1JFUVVJUkVEKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEw OTAgJiYgIWRlZmluZWQoX19pMzg2X18pKQotI2VuZGlmCi0KICNpZiAhZGVmaW5lZChFTkFCTEVf TEVHQUNZX0NTU19WRU5ET1JfUFJFRklYRVMpCiAjZGVmaW5lIEVOQUJMRV9MRUdBQ1lfQ1NTX1ZF TkRPUl9QUkVGSVhFUyAwCiAjZW5kaWYK 191157 2013-03-03 17:50:33 -0800 2013-03-04 13:13:34 -0800 fix max builds 111269.patch text/plain 2898 laszlo.gombos SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNDQ1OTIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTAzICBMYXN6bG8gR29tYm9zICA8bC5n b21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgSlNDX09CSkNfQVBJX0VOQUJMRUQgc2hvdWxk IGJlIHJlbW92ZWQgZnJvbSBGZWF0dXJlRGVmaW5lcy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTEyNjkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKU0NfT0JKQ19BUElfRU5BQkxFRCBmbGFnIHdhcyBh ZGRlZCB0byBGZWF0dXJlRGVmaW5lcy5oIChyMTQzNjM3KSAKKyAgICAgICAgc28gdGhhdCBpdCBj b3VsZCBiZSB1c2VkIGluIFdlYkNvcmUuZXhwLmluIHRvIGRldGVybWluZSB3aGV0aGVyIAorICAg ICAgICBvciBub3Qgd2Ugc2hvdWxkIGJlIGV4cG9ydGluZyBjZXJ0YWluIHN5bWJvbHMgYmFzZWQg b24gd2hldGhlciAKKyAgICAgICAgdGhlIFdlYktpdC1yZWxhdGVkIHBvcnRpb24gb2YgdGhlIEpT QyBPYmpDIEFQSSB3YXMgZW5hYmxlZC4KKyAgICAgICAgCisgICAgICAgIEl0IHR1cm5lZCBvdXQg Y29uZGl0aW9uYWxseSBpbmNsdWRpbmcgY2VydGFpbiBzeW1ib2xzIGRpZG4ndAorICAgICAgICB3 b3JrIHdoZW4gYnVpbGRpbmcgZmF0IGJpbmFyaWVzLCBzbyBpdCdzIG5vdCBldmVuIG5lY2Vzc2Fy eSBhbnkgbW9yZS4KKworICAgICAgICAqIHd0Zi9GZWF0dXJlRGVmaW5lcy5oOiBSZW1vdmUgSlND X09CSkNfQVBJX0VOQUJMRUQuCisKIDIwMTMtMDItMjcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw bGUuY29tPgogCiAgICAgICAgIFN0cmluZ0hhc2hlciBmdW5jdGlvbnMgcmVxdWlyZSBhbGlnbm1l bnQgdGhhdCBjYWxsIHNpdGVzIGRvIG5vdCBhbGwgZ3VhcmFudGVlCkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9GZWF0dXJlRGVmaW5lcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0ZlYXR1 cmVEZWZpbmVzLmgJKHJldmlzaW9uIDE0NDU1MykKKysrIFNvdXJjZS9XVEYvd3RmL0ZlYXR1cmVE ZWZpbmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTU2OSwxMCArNTY5LDYgQEAKICNkZWZpbmUgRU5B QkxFX0pBVkFTQ1JJUFRfSTE4Tl9BUEkgMAogI2VuZGlmCiAKLSNpZiAhZGVmaW5lZChKU0NfT0JK Q19BUElfRU5BQkxFRCkKLSNkZWZpbmUgSlNDX09CSkNfQVBJX0VOQUJMRUQgKGRlZmluZWQoX19j bGFuZ19fKSAmJiBkZWZpbmVkKF9fQVBQTEVfXykgJiYgZGVmaW5lZChfX01BQ19PU19YX1ZFUlNJ T05fTUlOX1JFUVVJUkVEKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEw OTAgJiYgIWRlZmluZWQoX19pMzg2X18pKQotI2VuZGlmCi0KICNpZiAhZGVmaW5lZChFTkFCTEVf TEVHQUNZX0NTU19WRU5ET1JfUFJFRklYRVMpCiAjZGVmaW5lIEVOQUJMRV9MRUdBQ1lfQ1NTX1ZF TkRPUl9QUkVGSVhFUyAwCiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0 NDU5MikKKysrIFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE0IEBACisyMDEzLTAzLTAzICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgSlNDX09CSkNfQVBJX0VOQUJMRUQgc2hvdWxkIGJlIHJlbW92ZWQg ZnJvbSBGZWF0dXJlRGVmaW5lcy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMTEyNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbmNsdWRlIEphdmFTY3JpcHRDb3JlL0pTQmFzZS5oIGZvciB0aGUgZGVm aW5pdGlvbiBvZiBKU0NfT0JKQ19BUElfRU5BQkxFRC4KKworICAgICAgICAqIFdlYlZpZXcvV2Vi RGVsZWdhdGVJbXBsZW1lbnRhdGlvbkNhY2hpbmcuaDoKKwogMjAxMy0wMy0wMyAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYXR0ZW1wdGVkIGJ1 aWxkIGZpeC4gQWRkcyBiYWNrIHNvbWUgaW5jbHVkZXMgcmVtb3ZlZCBpbgpJbmRleDogU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJEZWxlZ2F0ZUltcGxlbWVudGF0aW9uQ2FjaGluZy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRGVsZWdhdGVJbXBsZW1l bnRhdGlvbkNhY2hpbmcuaAkocmV2aXNpb24gMTQ0NTUzKQorKysgU291cmNlL1dlYktpdC9tYWMv V2ViVmlldy9XZWJEZWxlZ2F0ZUltcGxlbWVudGF0aW9uQ2FjaGluZy5oCSh3b3JraW5nIGNvcHkp CkBAIC0yOSw2ICsyOSw3IEBACiAvLyBUaGlzIGhlYWRlciBjb250YWlucyBXZWJWaWV3IGRlY2xh cmF0aW9ucyB0aGF0IGNhbiBiZSB1c2VkIGFueXdoZXJlIGluIFdlYktpdCwgYnV0IGFyZSBuZWl0 aGVyIFNQSSBub3IgQVBJLgogCiAjaW1wb3J0ICJXZWJUeXBlc0ludGVybmFsLmgiCisjaW1wb3J0 IDxKYXZhU2NyaXB0Q29yZS9KU0Jhc2UuaD4KIAogQGNsYXNzIFdlYlZpZXc7CiAK