111267 2013-03-03 03:46:36 -0800 [Win] IDLParser.pm fails to parse OESTextureHalfFloat and causes a build failure 2013-03-04 17:33:35 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110818 1 rniwa webkit-unassigned abarth haraken japhet kbr roger_fong sam webkit.review.bot oldest_to_newest 845998 0 rniwa 2013-03-03 03:46:36 -0800 8>/home/buildbot/slave/WIN-DE~1/build/Source/WebCore/DerivedSources.make:1016: recipe for target `JSOESTextureHalfFloat.h' failed 8>make: *** [JSOESTextureHalfFloat.h] Error 2 8>make: *** Waiting for unfinished jobs…. It’s failing at: http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts/IDLParser.pm#L196 196 die "No definitions founds" unless @definitions; 197 because this IDL is empty: http://trac.webkit.org/browser/trunk/Source/WebCore/html/canvas/OESTextureHalfFloat.idl 846001 1 191133 rniwa 2013-03-03 03:54:04 -0800 Created attachment 191133 Allow empty IDL definitions to fix clean builds There are so many things I don’t understand about this patch. First off, what does OESTextureHalfFloat even mean? And second off, why is this IDL file empty? And finally, why is this even compiled on Apple Win? But whatever. Here’s a trivial fix. 846013 2 191133 haraken 2013-03-03 07:45:06 -0800 Comment on attachment 191133 Allow empty IDL definitions to fix clean builds According to the Web IDL spec, an empty IDL definition is acceptable: http://www.w3.org/TR/WebIDL/#prod-Definitions . So this patch looks OK. However, an empty IDL definition does make zero sense in practice. Would you investigate about OESTextureHalfFloat ? 846017 3 191133 webkit.review.bot 2013-03-03 08:18:20 -0800 Comment on attachment 191133 Allow empty IDL definitions to fix clean builds Clearing flags on attachment: 191133 Committed r144575: <http://trac.webkit.org/changeset/144575> 846018 4 webkit.review.bot 2013-03-03 08:18:24 -0800 All reviewed patches have been landed. Closing bug. 846060 5 rniwa 2013-03-03 13:23:53 -0800 (In reply to comment #2) > (From update of attachment 191133 [details]) > > However, an empty IDL definition does make zero sense in practice. Would you investigate about OESTextureHalfFloat ? Yeah. I don’t understan why we need this IDL. For starters, OESTextureHalfFloat is such a terrible :( 846063 6 rniwa 2013-03-03 13:26:30 -0800 It was added in https://bugs.webkit.org/show_bug.cgi?id=110818. I don’t understand why this was not announced on webkit-dev given that it’s an extension… 191133 2013-03-03 03:54:04 -0800 2013-03-03 08:18:20 -0800 Allow empty IDL definitions to fix clean builds fix111267 text/plain 1137 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NDU3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAzLTAzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFtXaW5dIElETFBhcnNlci5wbSBm YWlscyB0byBwYXJzZSBPRVNUZXh0dXJlSGFsZkZsb2F0IGFuZCBjYXVzZXMgYSBidWlsZCBmYWls dXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTEy NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGxv dyBlbXB0eSBkZWZpbml0aW9ucy4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvSURMUGFy c2VyLnBtOgorICAgICAgICAoUGFyc2UpOgorCiAyMDEzLTAzLTAzICBTaGVyaWZmIEJvdCAgPHdl YmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMTQ0NTY3LgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9JRExQ YXJzZXIucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9J RExQYXJzZXIucG0JKHJldmlzaW9uIDE0NDU2OSkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvSURMUGFyc2VyLnBtCSh3b3JraW5nIGNvcHkpCkBAIC0xOTMsOCArMTkzLDYgQEAK ICAgICB9OwogICAgIGRpZSAkQCAuICIgaW4gJGZpbGVOYW1lIiBpZiAkQDsKIAotICAgIGRpZSAi Tm8gZGVmaW5pdGlvbnMgZm91bmRzIiB1bmxlc3MgQGRlZmluaXRpb25zOwotCiAgICAgbXkgJGRv Y3VtZW50ID0gaWRsRG9jdW1lbnQtPm5ldygpOwogICAgICRkb2N1bWVudC0+ZmlsZU5hbWUoJGZp bGVOYW1lKTsKICAgICBmb3JlYWNoIG15ICRkZWZpbml0aW9uIChAZGVmaW5pdGlvbnMpIHsK