111262 2013-03-03 00:37:26 -0800 Cue line-height property shouldn't be inherited from the video element 2013-03-05 14:04:34 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 vcarbune vcarbune dglazkov eric.carlson esprehn+autocc feature-media-reviews jer.noble macpherson menard ojan.autocc silviapf webkit-bug-importer webkit.review.bot oldest_to_newest 845959 0 vcarbune 2013-03-03 00:37:26 -0800 This can be reproduced with any captioned video. 846488 1 webkit-bug-importer 2013-03-04 07:47:58 -0800 <rdar://problem/13336907> 846790 2 vcarbune 2013-03-04 13:28:47 -0800 It looks like the problem appear each time the video is scaled (not neccessarily fullscreen, e.g. through height and width properties) Before I start digging even more into this, it looks now that WebKit supports viewport values (such as the 5vh which is the default for cues) and also using this when scaling the video seems to fix a part of the problem (no overlapping lines) Firstly, I'm thinking of dropping the manual CSS font-size adjustment of cues that happens in TextTrackContainer::updateSizes(). Is there anything that might block this? 846815 3 eric.carlson 2013-03-04 13:48:08 -0800 (In reply to comment #2) > It looks like the problem appear each time the video is scaled (not neccessarily > fullscreen, e.g. through height and width properties) > > Before I start digging even more into this, it looks now that WebKit supports > viewport values (such as the 5vh which is the default for cues) and also using > this when scaling the video seems to fix a part of the problem (no overlapping > lines) > > Firstly, I'm thinking of dropping the manual CSS font-size adjustment of cues > that happens in TextTrackContainer::updateSizes(). Is there anything that might > block this? It is also possible for user preferences to override font size, eg. CaptionUserPreferencesMac::captionFontSizeScale, but there is no reason that we couldn't change the size by adding a font size override to the style sheet generated by CaptionUserPreferencesMac::captionsStyleSheetOverride. This would actually be simpler because it could be done only when the user preferences change (as we do with the other overrides) instead of every time the size changes. Note, I originally tried to use vh but it did not work 847998 4 vcarbune 2013-03-05 13:20:48 -0800 (In reply to comment #3) > Note, I originally tried to use vh but it did not work You are right, it still doesn't work correctly. Further debugging shows that this doesn't happen all the time, but particularly when the line-height on the video element is inherited from containing blocks. I think this is a problem with the shadow tree, and such properties shouldn't be inherited (I'm not sure if there's a bug already for this). 848004 5 191549 vcarbune 2013-03-05 13:27:56 -0800 Created attachment 191549 Fix 848007 6 eric.carlson 2013-03-05 13:30:38 -0800 (In reply to comment #4) > (In reply to comment #3) > > Note, I originally tried to use vh but it did not work > You are right, it still doesn't work correctly. > Darn :-( > Further debugging shows that this doesn't happen all the time, but particularly > when the line-height on the video element is inherited from containing blocks. > > I think this is a problem with the shadow tree, and such properties shouldn't > be inherited (I'm not sure if there's a bug already for this). > I agree that this looks like a shadow tree problem, the existing code that sets inline style sometimes works and sometimes does not. 848046 7 191549 webkit.review.bot 2013-03-05 14:04:29 -0800 Comment on attachment 191549 Fix Clearing flags on attachment: 191549 Committed r144814: <http://trac.webkit.org/changeset/144814> 848048 8 webkit.review.bot 2013-03-05 14:04:34 -0800 All reviewed patches have been landed. Closing bug. 191549 2013-03-05 13:27:56 -0800 2013-03-05 14:04:29 -0800 Fix bug-111262-20130305232401.patch text/plain 5526 vcarbune U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzA5Y2RlNDkzNjIwYTNl ZGUwZjA4YjkxZWM4NmRjMTc4OWJiYWI2Ny4uNzJiYjUzMThkZGMxNmNhNDNjZDI1ZTdmYTg0Zjhi NzNjYTYxYTIwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTAzLTA1ICBWaWN0 b3IgQ2FyYnVuZSAgPHZjYXJidW5lQGNocm9taXVtLm9yZz4KKworICAgICAgICBDdWUgbGluZS1o ZWlnaHQgcHJvcGVydHkgc2hvdWxkbid0IGJlIGluaGVyaXRlZCBmcm9tIHRoZSB2aWRlbyBlbGVt ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTEy NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0 OiBtZWRpYS90cmFjay90cmFjay1jdWUtcmVuZGVyaW5nLW9uLXJlc2l6ZS5odG1sCisKKyAgICAg ICAgKiBjc3MvbWVkaWFDb250cm9scy5jc3M6CisgICAgICAgICh2aWRlbzo6LXdlYmtpdC1tZWRp YS10ZXh0LXRyYWNrLWNvbnRhaW5lcik6IFNldCB0aGUgZGVmYXVsdCBmb250IHNpemUKKyAgICAg ICAgYW5kIGZhbWlseSB1c2luZyB0aGUgImZvbnQiIHByb3BlcnR5IHRvIGFsc28gcmVzZXQgdGhl IGxpbmUtaGVpZ2h0IHByb3BlcnR5LgorCiAyMDEzLTAzLTA0ICBKb3NodWEgQmVsbCAgPGpzYmVs bEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBVbnJldmlld2VkLiBSZWJhc2VsaW5lZCBy dW4tYmluZGluZ3MtdGVzdHMgZm9sbG93aW5nIHIxNDQ2MTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzLmNzcyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tZWRpYUNv bnRyb2xzLmNzcwppbmRleCBiOTRkNDQ3ZTI2MDc0NWUwYTI4MTFlNzlmOTVkMDA3MmZjZTY0YmU0 Li4zNjJjN2E0MDJlMDRhNmNmMGZiNTZjM2UwMzk1NTljZjRkMjUxMWVmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9scy5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUv Y3NzL21lZGlhQ29udHJvbHMuY3NzCkBAIC0yMjEsOCArMjIxLDcgQEAgdmlkZW86Oi13ZWJraXQt bWVkaWEtdGV4dC10cmFjay1jb250YWluZXIgewogICAgIG92ZXJmbG93OiBoaWRkZW47CiAgICAg cGFkZGluZy1ib3R0b206IDVweDsKIAotICAgIGZvbnQtc2l6ZTogMjJweDsKLSAgICBmb250LWZh bWlseTogc2Fucy1zZXJpZjsKKyAgICBmb250OiAyMnB4IHNhbnMtc2VyaWY7CiAgICAgdGV4dC1h bGlnbjogY2VudGVyOwogICAgIGNvbG9yOiByZ2JhKDI1NSwgMjU1LCAyNTUsIDEpOwogCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggYTI2NzZlYmM2MDgyODNmMjU0M2RmNWUxODNmNTNkYmVkN2E4Nzg3NC4uMGRmZmM2Zjk5ZDBl MzQ3YzVkNGM2MjVjY2ExNmVlOGM0YmU4MmZmMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEz LTAzLTA1ICBWaWN0b3IgQ2FyYnVuZSAgPHZjYXJidW5lQGNocm9taXVtLm9yZz4KKworICAgICAg ICBDdWUgbGluZS1oZWlnaHQgcHJvcGVydHkgc2hvdWxkbid0IGJlIGluaGVyaXRlZCBmcm9tIHRo ZSB2aWRlbyBlbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMTEyNjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIG1lZGlhL3RyYWNrL2NhcHRpb25zLXdlYnZ0dC9jYXB0aW9ucy1zbmFwLXRvLWxp bmVzLXNldC52dHQ6IFVwZGF0ZWQuCisgICAgICAgICogbWVkaWEvdHJhY2svdHJhY2stY3VlLXJl bmRlcmluZy1vbi1yZXNpemUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRpYS90 cmFjay90cmFjay1jdWUtcmVuZGVyaW5nLW9uLXJlc2l6ZS5odG1sOiBBZGRlZC4KKwogMjAxMy0w My0wNCAgQ2hyaXN0aWFuIEJpZXNpbmdlciAgPGNiaWVzaW5nZXJAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgICh0ZXN0cykgZmxleGJveC9yZXNvdXJjZXMuY3NzIHNob3VsZCB1c2UgdW5wcmVmaXhl ZCBwcm9wZXJ0aWVzLCBmb3IgZmlyZWZveApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEv dHJhY2svY2FwdGlvbnMtd2VidnR0L2NhcHRpb25zLXNuYXAtdG8tbGluZXMtc2V0LnZ0dCBiL0xh eW91dFRlc3RzL21lZGlhL3RyYWNrL2NhcHRpb25zLXdlYnZ0dC9jYXB0aW9ucy1zbmFwLXRvLWxp bmVzLXNldC52dHQKaW5kZXggNjNkZWUyNzczODNhODI5YmRiMTdiNjJiMzU2NTZhZjdjNTA4NjNk My4uM2MzZDBiNjMxZWYyMmViY2Y2NjkzOWI0OTdmODQyZTZkN2EyM2VhMCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svY2FwdGlvbnMtd2VidnR0L2NhcHRpb25zLXNuYXAtdG8t bGluZXMtc2V0LnZ0dAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay9jYXB0aW9ucy13ZWJ2 dHQvY2FwdGlvbnMtc25hcC10by1saW5lcy1zZXQudnR0CkBAIC00NywzICs0Nyw4IEBAIEN1ZSA1 OiDnp4Hjga/nq4vmtL7jgarkuroKIDYKIDAwOjAwOjAwLjUwMCAtLT4gMDA6MDA6MDEuMDAwIHZl cnRpY2FsOmxyCiBDdWUgNjog56eB44Gv56uL5rS+44Gq5Lq6CisKKzcKKzAwOjAwOjAxLjAwMCAt LT4gMDA6MDA6MDEuMjUwCitNdWx0aS1saW5lIGN1ZSB0byB0ZXN0IHRoYXQgc2hvdWxkIGFwcGVh cgorY29ycmVjdCB3aGVuIGluIHRoZSBmdWxsLXNjcmVlbiBtb2RlCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jdWUtcmVuZGVyaW5nLW9uLXJlc2l6ZS1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jdWUtcmVuZGVyaW5nLW9uLXJl c2l6ZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzhiOTc3MTUzYjZlZTIwM2RhMDcwYzA3ZTk5 ODVlMTdkMjNiZDU0ZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNr L3RyYWNrLWN1ZS1yZW5kZXJpbmctb24tcmVzaXplLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDgg QEAKK0xpbmUgaGVpZ2h0IGlzbid0IG92ZXJyaWRlbiBieSBvdGhlciBDU1MgdmFsdWVzIGluIHRo ZSBmaWxlLgorRVZFTlQoY2FucGxheXRocm91Z2gpCitFVkVOVChzZWVrZWQpCisKKyoqIExpbmUg aGVpZ2h0IG9mIHRoZSBjdWUgZWxlbWVudCBzaG91bGQgYmUgJ25vcm1hbCcgKioKK0VYUEVDVEVE IChnZXRDb21wdXRlZFN0eWxlKG11bHRpTGluZUN1ZURpc3BsYXlFbGVtZW50KS5saW5lSGVpZ2h0 ID09ICdub3JtYWwnKSBPSworRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv bWVkaWEvdHJhY2svdHJhY2stY3VlLXJlbmRlcmluZy1vbi1yZXNpemUuaHRtbCBiL0xheW91dFRl c3RzL21lZGlhL3RyYWNrL3RyYWNrLWN1ZS1yZW5kZXJpbmctb24tcmVzaXplLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uYWE5MTgwZGY1ZWZjNjFkNjgyYzdjNzY1N2E5Y2ZiZDJlOTM0OWM2OAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWN1ZS1yZW5kZXJpbmctb24t cmVzaXplLmh0bWwKQEAgLTAsMCArMSw1NiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAg ICA8aGVhZD4KKyAgICAgICAgPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50 PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgiIC8+CisKKyAgICAgICAgPHN0eWxlIHR5cGU9InRl eHQvY3NzIj4KKyAgICAgICAgYm9keSB7CisgICAgICAgICAgICBsaW5lLWhlaWdodDogMTA4cHg7 CisgICAgICAgIH0KKyAgICAgICAgPC9zdHlsZT4KKyAgICAgICAgPHNjcmlwdCBzcmM9Li4vbWVk aWEtZmlsZS5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdCBzcmM9Li4vbWVkaWEtY29udHJv bHMuanM+PC9zY3JpcHQ+CisKKyAgICAgICAgPHNjcmlwdD4KKyAgICAgICAgdmFyIG11bHRpTGlu ZUN1ZURpc3BsYXlFbGVtZW50OworCisgICAgICAgIGZ1bmN0aW9uIHRlc3RDdWVIZWlnaHQoKQor ICAgICAgICB7CisgICAgICAgICAgICBpZiAoIXdpbmRvdy5pbnRlcm5hbHMpIHsKKyAgICAgICAg ICAgICAgZmFpbFRlc3QoKTsKKyAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgfQor CisgICAgICAgICAgICB2YXIgY3VlQ29udGFpbmVyRWxlbWVudCA9IHRleHRUcmFja0Rpc3BsYXlF bGVtZW50KHZpZGVvKTsKKyAgICAgICAgICAgIG11bHRpTGluZUN1ZURpc3BsYXlFbGVtZW50ID0g dGV4dFRyYWNrRGlzcGxheUVsZW1lbnQodmlkZW8sICdkaXNwbGF5JywgMCk7CisKKyAgICAgICAg ICAgIGNvbnNvbGVXcml0ZSgiPGJyPioqIExpbmUgaGVpZ2h0IG9mIHRoZSBjdWUgZWxlbWVudCBz aG91bGQgYmUgJ25vcm1hbCcgKioiKTsKKyAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiZ2V0Q29t cHV0ZWRTdHlsZShtdWx0aUxpbmVDdWVEaXNwbGF5RWxlbWVudCkubGluZUhlaWdodCIsICJub3Jt YWwiKTsKKworICAgICAgICAgICAgZW5kVGVzdCgpOworICAgICAgICB9CisKKyAgICAgICAgZnVu Y3Rpb24gbG9hZGVkKCkKKyAgICAgICAgeworICAgICAgICAgICAgY29uc29sZVdyaXRlKCJMaW5l IGhlaWdodCBpc24ndCBvdmVycmlkZW4gYnkgb3RoZXIgQ1NTIHZhbHVlcyBpbiB0aGUgZmlsZS4i KTsKKyAgICAgICAgICAgIGZpbmRNZWRpYUVsZW1lbnQoKTsKKworICAgICAgICAgICAgdGVzdFRy YWNrID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigndHJhY2snKTsKKyAgICAgICAgICAgIHZpZGVv LnNyYyA9IGZpbmRNZWRpYUZpbGUoJ3ZpZGVvJywgJy4uL2NvbnRlbnQvdGVzdCcpOworCisgICAg ICAgICAgICB3YWl0Rm9yRXZlbnQoJ3NlZWtlZCcsIHRlc3RDdWVIZWlnaHQpOworICAgICAgICAg ICAgd2FpdEZvckV2ZW50KCdjYW5wbGF5dGhyb3VnaCcsIGZ1bmN0aW9uKCkgeworICAgICAgICAg ICAgICAgIHZpZGVvLmN1cnJlbnRUaW1lID0gMS4yNTsKKyAgICAgICAgICAgIH0pOworICAgICAg ICB9CisKKyAgICAgICAgPC9zY3JpcHQ+CisKKyAgICAgICAgPHNjcmlwdCBzcmM9Li4vdmlkZW8t dGVzdC5qcz48L3NjcmlwdD4KKyAgICA8L2hlYWQ+CisgICAgPGJvZHkgb25sb2FkPSJsb2FkZWQo KSI+CisgICAgICAgIDx2aWRlbyBjb250cm9scz4KKyAgICAgICAgICAgIDx0cmFjayBzcmM9ImNh cHRpb25zLXdlYnZ0dC9jYXB0aW9ucy1zbmFwLXRvLWxpbmVzLXNldC52dHQiIGtpbmQ9ImNhcHRp b25zIiBkZWZhdWx0PgorICAgICAgICA8L3ZpZGVvPgorICAgIDwvYm9keT4KKzwvaHRtbD4K