111258 2013-03-02 17:03:47 -0800 PDFPlugin: Rename delegate method from openWithPreview to openWithNativeApplication 2013-03-03 23:11:26 -0800 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton webkit-unassigned ap oldest_to_newest 845884 0 thorton 2013-03-02 17:03:47 -0800 Because that's more accurate! 845885 1 191121 thorton 2013-03-02 17:05:28 -0800 Created attachment 191121 patch 845893 2 191121 ap 2013-03-02 18:28:33 -0800 Comment on attachment 191121 patch View in context: https://bugs.webkit.org/attachment.cgi?id=191121&action=review r=me assuming there is a good answer to the question below. > Source/WebKit2/ChangeLog:11 > + Rename from openWithPreview to openWithNativeApplication for accuracy. I don't understand this explanation. The delegate name should match what PDFLayerController expects, even if we find that inaccurate. Did PDFLayerController change? If it did, do we need to support both names for the time being? 845894 3 thorton 2013-03-02 18:30:02 -0800 (In reply to comment #2) > (From update of attachment 191121 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191121&action=review > > r=me assuming there is a good answer to the question below. > > > Source/WebKit2/ChangeLog:11 > > + Rename from openWithPreview to openWithNativeApplication for accuracy. > > I don't understand this explanation. The delegate name should match what PDFLayerController expects, even if we find that inaccurate. > > Did PDFLayerController change? If it did, do we need to support both names for the time being? Yes, it changed, long ago. It sends whichever the delegate implements. 846165 4 thorton 2013-03-03 23:11:26 -0800 http://trac.webkit.org/changeset/144599 191121 2013-03-02 17:05:28 -0800 2013-03-02 18:28:33 -0800 patch owna.diff text/plain 2090 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhZWQzNTZjLi5hYmUyMzU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTMtMDMtMDIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgUERGUGx1Z2luOiBSZW5hbWUgZGVsZWdhdGUgbWV0aG9kIGZyb20gb3BlbldpdGhQ cmV2aWV3IHRvIG9wZW5XaXRoTmF0aXZlQXBwbGljYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTI1OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZM YXllckNvbnRyb2xsZXJEZXRhaWxzLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BE Ri9QREZQbHVnaW4ubW06CisgICAgICAgICgtW1dLUERGTGF5ZXJDb250cm9sbGVyRGVsZWdhdGUg b3BlbldpdGhOYXRpdmVBcHBsaWNhdGlvbl0pOgorICAgICAgICBSZW5hbWUgZnJvbSBvcGVuV2l0 aFByZXZpZXcgdG8gb3BlbldpdGhOYXRpdmVBcHBsaWNhdGlvbiBmb3IgYWNjdXJhY3kuCisKKzIw MTMtMDMtMDIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKICAgICAg ICAgUERGUGx1Z2luOiBIb29rIHVwIFNlcnZpY2VzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTEyNDYKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEz MDYyNjcyPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BE Ri9QREZMYXllckNvbnRyb2xsZXJEZXRhaWxzLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1BsdWdpbnMvUERGL1BERkxheWVyQ29udHJvbGxlckRldGFpbHMuaAppbmRleCAzZjZiM2YyLi44 NWU5MDllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERG L1BERkxheWVyQ29udHJvbGxlckRldGFpbHMuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1BsdWdpbnMvUERGL1BERkxheWVyQ29udHJvbGxlckRldGFpbHMuaApAQCAtMzEsNyArMzEs NyBAQAogLSAodm9pZCl3cml0ZUl0ZW1zVG9QYXN0ZWJvYXJkOihOU0FycmF5ICopaXRlbXMgd2l0 aFR5cGVzOihOU0FycmF5ICopdHlwZXM7CiAtICh2b2lkKXNob3dEZWZpbml0aW9uRm9yQXR0cmli dXRlZFN0cmluZzooTlNBdHRyaWJ1dGVkU3RyaW5nICopc3RyaW5nIGF0UG9pbnQ6KENHUG9pbnQp cG9pbnQ7CiAtICh2b2lkKXBlcmZvcm1XZWJTZWFyY2g6KE5TU3RyaW5nICopc3RyaW5nOwotLSAo dm9pZClvcGVuV2l0aFByZXZpZXc7CistICh2b2lkKW9wZW5XaXRoTmF0aXZlQXBwbGljYXRpb247 CiAtICh2b2lkKXNhdmVUb1BERjsKIAogLSAodm9pZClwZGZMYXllckNvbnRyb2xsZXI6KFBERkxh eWVyQ29udHJvbGxlciAqKXBkZkxheWVyQ29udHJvbGxlciBkaWRDaGFuZ2VBY3RpdmVBbm5vdGF0 aW9uOihQREZBbm5vdGF0aW9uICopYW5ub3RhdGlvbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0KaW5kZXggMzc2NWU2ZS4uZGNmODY4 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQ bHVnaW4ubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQ bHVnaW4ubW0KQEAgLTE2Miw3ICsxNjIsNyBAQCBzdGF0aWMgY29uc3QgY2hhciogYW5ub3RhdGlv blN0eWxlID0KICAgICAvLyBGSVhNRTogSW1wbGVtZW50LgogfQogCi0tICh2b2lkKW9wZW5XaXRo UHJldmlldworLSAodm9pZClvcGVuV2l0aE5hdGl2ZUFwcGxpY2F0aW9uCiB7CiAgICAgX3BkZlBs dWdpbi0+b3BlbldpdGhOYXRpdmVBcHBsaWNhdGlvbigpOwogfQo=