111248 2013-03-02 02:22:43 -0800 constructTreeFromCompactHTMLToken should call clearExternalCharacters 2013-03-02 10:11:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106127 1 eric eric abarth esprehn+autocc inferno ojan.autocc webkit.review.bot oldest_to_newest 845776 0 eric 2013-03-02 02:22:43 -0800 constructTreeFromCompactHTMLToken should call clearExternalCharacters 845777 1 191102 eric 2013-03-02 02:23:25 -0800 Created attachment 191102 Patch 845778 2 eric 2013-03-02 02:25:21 -0800 I don't believe this causes any behavior change, but it's possible this is why we were passing that inspector view-source test better with the threaded parser. In order to have this be a problem, we would have to push a token onto the TreeBuilder's item-stack, and then end the chuck, and then somehow cause item()->token()->characters() to be accessed while parsing the next chunk. 845779 3 eric 2013-03-02 02:27:18 -0800 This whole design is wrong for HTMLCompactToken. We shouldn't need a heap allocated AtomicHTMLToken anyway. We should replace it with a stack-allocated object which knows how to hang onto the necessary data when copied into an HTMLStackItem. 845812 4 191102 abarth 2013-03-02 10:00:57 -0800 Comment on attachment 191102 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191102&action=review > Source/WebCore/ChangeLog:10 > + I don't know how to write a test for this. It's possible characters() > + is never accessed from HTMLStackItem::token(), but it's better to be > + safe than sorry here. Yeah, there isn't any behavior change from this patch, but it's worth doing anyway. > Source/WebCore/html/parser/HTMLDocumentParser.cpp:573 > + token->clearExternalCharacters(); // The compact token could be destroyed any time after this method returns. Yeah, we do the same thing in HTMLDocumentParser::constructTreeFromHTMLToken 845815 5 191102 webkit.review.bot 2013-03-02 10:11:53 -0800 Comment on attachment 191102 Patch Clearing flags on attachment: 191102 Committed r144543: <http://trac.webkit.org/changeset/144543> 845816 6 webkit.review.bot 2013-03-02 10:11:56 -0800 All reviewed patches have been landed. Closing bug. 191102 2013-03-02 02:23:25 -0800 2013-03-02 10:11:53 -0800 Patch bug-111248-20130302021940.patch text/plain 1689 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjM3ZTBjZTJkYTZhOTgz M2UxMWYwNDEyNTUzY2IwYjY5ZWY4MzE5ZS4uMWEyMWFiNWZjYzJlOGIwMWJlZjUzZWFjN2U3NTY3 OWQxNDI5MjZhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAzLTAyICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAgICBjb25zdHJ1Y3RUcmVlRnJvbUNv bXBhY3RIVE1MVG9rZW4gc2hvdWxkIGNhbGwgY2xlYXJFeHRlcm5hbENoYXJhY3RlcnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTI0OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEkgZG9uJ3Qga25vdyBo b3cgdG8gd3JpdGUgYSB0ZXN0IGZvciB0aGlzLiAgSXQncyBwb3NzaWJsZSBjaGFyYWN0ZXJzKCkK KyAgICAgICAgaXMgbmV2ZXIgYWNjZXNzZWQgZnJvbSBIVE1MU3RhY2tJdGVtOjp0b2tlbigpLCBi dXQgaXQncyBiZXR0ZXIgdG8gYmUKKyAgICAgICAgc2FmZSB0aGFuIHNvcnJ5IGhlcmUuCisKKyAg ICAgICAgKiBodG1sL3BhcnNlci9IVE1MRG9jdW1lbnRQYXJzZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTERvY3VtZW50UGFyc2VyOjpjb25zdHJ1Y3RUcmVlRnJvbUNvbXBhY3RIVE1MVG9r ZW4pOgorCiAyMDEzLTAzLTAxICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAg ICAgICBSRUdSRVNTSU9OIChyMTI1ODA5KTogQ0ZTdHJpbmdzIGNyZWF0ZWQgdmlhIFN0cmluZ0lt cGw6OmNyZWF0ZUNGU3RyaW5nKCkgIG1pZ2h0IHJlZmVyZW5jZSBmcmVlZCBtZW1vcnkgd2hlbiBP YmplY3RpdmUtQyBnYXJiYWdlIGNvbGxlY3Rpb24gaXMgZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTERvY3VtZW50UGFyc2VyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxEb2N1bWVudFBhcnNlci5jcHAKaW5kZXggOGY2YTU5NDYx OGEzMGY1NmE0YzhlN2FhZmQ1ZTRkMGZmNGEyNjUzNC4uYjU1NzY0ZjVhMWFiNDZkMTZjNTkzZjU4 YjcxNDc2OGYwMjE2N2RhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIv SFRNTERvY3VtZW50UGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9I VE1MRG9jdW1lbnRQYXJzZXIuY3BwCkBAIC01NzAsNiArNTcwLDcgQEAgdm9pZCBIVE1MRG9jdW1l bnRQYXJzZXI6OmNvbnN0cnVjdFRyZWVGcm9tQ29tcGFjdEhUTUxUb2tlbihjb25zdCBDb21wYWN0 SFRNTFRva2UKIHsKICAgICBSZWZQdHI8QXRvbWljSFRNTFRva2VuPiB0b2tlbiA9IEF0b21pY0hU TUxUb2tlbjo6Y3JlYXRlKGNvbXBhY3RUb2tlbik7CiAgICAgbV90cmVlQnVpbGRlci0+Y29uc3Ry dWN0VHJlZSh0b2tlbi5nZXQoKSk7CisgICAgdG9rZW4tPmNsZWFyRXh0ZXJuYWxDaGFyYWN0ZXJz KCk7IC8vIFRoZSBjb21wYWN0IHRva2VuIGNvdWxkIGJlIGRlc3Ryb3llZCBhbnkgdGltZSBhZnRl ciB0aGlzIG1ldGhvZCByZXR1cm5zLgogfQogCiAjZW5kaWYK