111243 2013-03-01 22:26:14 -0800 REGRESSION (r144517): IndexedDB layout test failures on GTK 2013-03-02 23:15:24 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 zan zan abarth alecflett dgrogan jsbell michael mrobinson webkit.review.bot oldest_to_newest 845735 0 zan 2013-03-01 22:26:14 -0800 A set of layout tests began failing after r144517. http://trac.webkit.org/changeset/144517 storage/indexeddb/index-basics.html storage/indexeddb/mozilla/create-objectstore-basics.html storage/indexeddb/mozilla/global-data.html storage/indexeddb/mozilla/indexes.html storage/indexeddb/objectstore-autoincrement.html storage/indexeddb/objectstore-basics.html storage/indexeddb/readonly.html storage/indexeddb/mozilla/create-index-unique.html A sample diff for the failure in storage/indexeddb/index-basics.html: --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/storage/indexeddb/index-basics-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/storage/indexeddb/index-basics-actual.txt @@ -27,7 +27,7 @@ PASS 'objectStore' in indexObject is true PASS indexObject.objectStore.name is "storeName" PASS 'keyPath' in indexObject is true -PASS indexObject.keyPath is "x" +FAIL indexObject.keyPath should be x (of type string). Was undefined (of type undefined). PASS 'unique' in indexObject is true PASS 'multiEntry' in indexObject is true PASS indexObject.unique is false Given the changes in r144517 it seems JSC bindings require modification. 845857 1 191116 zan 2013-03-02 13:08:50 -0800 Created attachment 191116 Patch 845926 2 191116 zan 2013-03-02 23:15:19 -0800 Comment on attachment 191116 Patch Clearing flags on attachment: 191116 Committed r144559: <http://trac.webkit.org/changeset/144559> 845928 3 zan 2013-03-02 23:15:24 -0800 All reviewed patches have been landed. Closing bug. 191116 2013-03-02 13:08:50 -0800 2013-03-02 23:15:19 -0800 Patch bug-111243-20130302220501.patch text/plain 5668 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDE4NTA0MTE5ODI1ZjA3 YWQxYWQ2YmIxNDU1ZDQ1ZGJjMjAzYjE5ZS4uZWQyMDZjNTQyMWUxZTliNGNhMWI1OTljZmMyYzA0 MDA0NTFjY2JmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEzLTAzLTAyICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy MTQ0NTE3KTogSW5kZXhlZERCIGxheW91dCB0ZXN0IGZhaWx1cmVzIG9uIEdUSworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMjQzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlcyB0byB0aGUgY3Vz dG9tIEpTQyBiaW5kaW5ncyBmb3IgSURCQW55IGFyZSByZXF1aXJlZCBhZnRlciByMTQ0NTE3LAor ICAgICAgICBzcGVjaWZpY2FsbHkgdGhlIGNhc2Ugb2YgSURCQW55IG9iamVjdCBoYXZpbmcgdGhl IEtleVBhdGhUeXBlIHR5cGUgaGFzIHRvIGJlIGNvdmVyZWQuCisgICAgICAgIFRoZXNlIGNoYW5n ZXMgYXJlIGFuYWxvZ291cyB0byB0aG9zZSBtYWRlIHRvIHRoZSBWOCBiaW5kaW5ncyBpbiB0aGUg bWVudGlvbmVkIGNvbW1pdC4KKworICAgICAgICBObyBuZXcgdGVzdHMgLSBhbHJlYWR5IGNvdmVy ZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0lEQkFueUN1 c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b0pTKTogQSBoZWxwZXIgZnVuY3Rpb24gdGhh dCB3cmFwcyBhbiBJREJLZXlQYXRoIGludG8gYSBKU1ZhbHVlLgorICAgICAgICAoV2ViQ29yZSk6 IFNodWZmbGUgdGhlIG9yZGVyIGluc2lkZSB0aGUgc3dpdGNoIHN0YXRlbWVudCBhIGJpdCB0byBt YXRjaCB0aGUgVjggY3VzdG9tIGJpbmRpbmdzLgorICAgICAgICBDb3ZlciB0aGUgY2FzZSB3aGVy ZSB0aGUgSURCQW55IG9iamVjdCBoYXMgdGhlIEtleVBhdGhUeXBlLCBjYWxsaW5nIHRoZSBuZXcg aGVscGVyIG1ldGhvZC4KKwogMjAxMy0wMy0wMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBGaXggYSB0eXBvIGluIG15IHByZXZpb3VzIGNvbW1pdCAocjE0NDUz NCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0lEQkFueUN1c3Rv bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0lEQkFueUN1c3RvbS5jcHAKaW5k ZXggNDdkZjMzNDA2N2FlOTY5ZjRkNjA2YzBjOWMxNDZhYzNiYmNiM2E5Yi4uMGIwMTJlNTRlNmVh YzhhNjQ4MTMzNGU4NTZjZTNmZTIzNjhmOWUzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNJREJBbnlDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL0pTSURCQW55Q3VzdG9tLmNwcApAQCAtNTIsNiArNTIsMjQgQEAgdXNpbmcgbmFtZXNw YWNlIEpTQzsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitKU1ZhbHVlIHRvSlMoRXhlY1N0YXRl KiBleGVjLCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBjb25zdCBJREJLZXlQYXRo JiB2YWx1ZSkKK3sKKyAgICBzd2l0Y2ggKHZhbHVlLnR5cGUoKSkgeworICAgIGNhc2UgSURCS2V5 UGF0aDo6TnVsbFR5cGU6CisgICAgICAgIHJldHVybiBqc051bGwoKTsKKyAgICBjYXNlIElEQktl eVBhdGg6OlN0cmluZ1R5cGU6CisgICAgICAgIHJldHVybiBqc1N0cmluZ1dpdGhDYWNoZShleGVj LCB2YWx1ZS5zdHJpbmcoKSk7CisgICAgY2FzZSBJREJLZXlQYXRoOjpBcnJheVR5cGU6CisgICAg ICAgIFJlZlB0cjxET01TdHJpbmdMaXN0PiBrZXlQYXRocyA9IERPTVN0cmluZ0xpc3Q6OmNyZWF0 ZSgpOworICAgICAgICBmb3IgKFZlY3RvcjxTdHJpbmc+Ojpjb25zdF9pdGVyYXRvciBpdCA9IHZh bHVlLmFycmF5KCkuYmVnaW4oKTsgaXQgIT0gdmFsdWUuYXJyYXkoKS5lbmQoKTsgKytpdCkKKyAg ICAgICAgICAgIGtleVBhdGhzLT5hcHBlbmQoKml0KTsKKyAgICAgICAgcmV0dXJuIHRvSlMoZXhl YywgZ2xvYmFsT2JqZWN0LCBrZXlQYXRocy5yZWxlYXNlKCkpOworICAgIH0KKworICAgIEFTU0VS VF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOworfQorCiBKU1ZhbHVl IHRvSlMoRXhlY1N0YXRlKiBleGVjLCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBJ REJBbnkqIGlkYkFueSkKIHsKICAgICBpZiAoIWlkYkFueSkKQEAgLTgwLDEwICs5OCwxMiBAQCBK U1ZhbHVlIHRvSlMoRXhlY1N0YXRlKiBleGVjLCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2Jq ZWN0LCBJREJBbnkqIGlkYkFueSkKICAgICAgICAgcmV0dXJuIHRvSlMoZXhlYywgZ2xvYmFsT2Jq ZWN0LCBpZGJBbnktPmlkYlRyYW5zYWN0aW9uKCkpOwogICAgIGNhc2UgSURCQW55OjpTY3JpcHRW YWx1ZVR5cGU6CiAgICAgICAgIHJldHVybiBpZGJBbnktPnNjcmlwdFZhbHVlKCkuanNWYWx1ZSgp OwotICAgIGNhc2UgSURCQW55OjpJbnRlZ2VyVHlwZToKLSAgICAgICAgcmV0dXJuIGpzTnVtYmVy KGlkYkFueS0+aW50ZWdlcigpKTsKICAgICBjYXNlIElEQkFueTo6U3RyaW5nVHlwZToKICAgICAg ICAgcmV0dXJuIGpzU3RyaW5nV2l0aENhY2hlKGV4ZWMsIGlkYkFueS0+c3RyaW5nKCkpOworICAg IGNhc2UgSURCQW55OjpJbnRlZ2VyVHlwZToKKyAgICAgICAgcmV0dXJuIGpzTnVtYmVyKGlkYkFu eS0+aW50ZWdlcigpKTsKKyAgICBjYXNlIElEQkFueTo6S2V5UGF0aFR5cGU6CisgICAgICAgIHJl dHVybiB0b0pTKGV4ZWMsIGdsb2JhbE9iamVjdCwgaWRiQW55LT5rZXlQYXRoKCkpOwogICAgIH0K IAogICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDZjYzRkYzJiMjU4NTVlNWZjYzhj MGM1NjVjOWQ0MmY3ZjY1NGJiMWEuLmJhOWY5ZTEwOTljYmJmY2ZkOTA4NjI0MGI3ZGFiYjM5MmVk MmI5ZmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0wMy0wMiAgWmFuIERvYmVyc2VrICA8 emRvYmVyc2VrQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE0NDUxNyk6IElu ZGV4ZWREQiBsYXlvdXQgdGVzdCBmYWlsdXJlcyBvbiBHVEsKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTI0MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlv bnM6IFJlbW92aW5nIGZhaWx1cmUgZXhwZWN0YXRpb25zIGZvciBJREIgdGVzdHMgdGhhdCBhZ2Fp biBwYXNzLgorCiAyMDEzLTAzLTAyICBOYXlhbiBLdW1hciBLICA8bmF5YW5ra0Btb3Rvcm9sYS5j b20+CiAKICAgICAgICAgW1dlYkdMXSBTdXBwb3J0IGZvciB0ZXhJbWFnZTJEIG9mIHR5cGUgSEFM Rl9GTE9BVF9PRVMgd2l0aCBBcnJheUJ1ZmZlclZpZXcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0 ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGIzZDEyYTZmNTY4YjdmODVmNDA3Y2ZkYWZlNzI3YjY5 OWMxZTA2OTYuLjVmODE0NWEzOWUyYmMyNTQ5ZWEyNGVkMGJiNmM1ODkzNjIwYzhhNmIgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC00NzAsOCArNDcwLDgg QEAgd2Via2l0Lm9yZy9iLzEwNzM3NyBzdG9yYWdlL2luZGV4ZWRkYi9jdXJzb3ItYWR2YW5jZS13 b3JrZXJzLmh0bWwgWyBDcmFzaCBQYXNzIF0KIHdlYmtpdC5vcmcvYi8xMDczNzcgc3RvcmFnZS9p bmRleGVkZGIvaW5kZXgtZ2V0LWtleS1hcmd1bWVudC1yZXF1aXJlZC5odG1sIFsgQ3Jhc2ggUGFz cyBdCiB3ZWJraXQub3JnL2IvMTA3Mzc3IHN0b3JhZ2UvaW5kZXhlZGRiL2tleXBhdGgtYmFzaWNz Lmh0bWwgWyBDcmFzaCBQYXNzIF0KIHdlYmtpdC5vcmcvYi8xMDczNzcgc3RvcmFnZS9pbmRleGVk ZGIvbW96aWxsYS9yZW1vdmUtaW5kZXguaHRtbCBbIENyYXNoIFBhc3MgXQotd2Via2l0Lm9yZy9i LzEwNzM3NyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2NyZWF0ZS1pbmRleC11bmlxdWUuaHRt bCBbIENyYXNoIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzEwNzM3NyBzdG9yYWdlL2luZGV4ZWRk Yi9vYmplY3RzdG9yZS1iYXNpY3MuaHRtbCBbIENyYXNoIEZhaWx1cmUgXQord2Via2l0Lm9yZy9i LzEwNzM3NyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2NyZWF0ZS1pbmRleC11bmlxdWUuaHRt bCBbIENyYXNoIFBhc3MgXQord2Via2l0Lm9yZy9iLzEwNzM3NyBzdG9yYWdlL2luZGV4ZWRkYi9v YmplY3RzdG9yZS1iYXNpY3MuaHRtbCBbIENyYXNoIFBhc3MgXQogd2Via2l0Lm9yZy9iLzEwNzE5 NCBzdG9yYWdlL2luZGV4ZWRkYi9vYmplY3RzdG9yZS1iYXNpY3Mtd29ya2Vycy5odG1sIFsgQ3Jh c2ggRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xMDg2ODIgWyBEZWJ1ZyBdIG1lZGlhL3ZpZGVv LWNvbnRyb2xzLWZ1bGxzY3JlZW4tdm9sdW1lLmh0bWwgWyBDcmFzaCBdCkBAIC0xNDAxLDEzICsx NDAxLDYgQEAgd2Via2l0Lm9yZy9iLzExMTAxNiBodHRwL3Rlc3RzL2xvYWRpbmcvcHJvbW90ZS1p bWctcHJlbG9hZC1wcmlvcml0eS5odG1sIFsgRmFpbHUKIAogd2Via2l0Lm9yZy9iLzExMTA1OCBw bHVnaW5zL3BsdWdpbi1jbGlwLXN1YmZyYW1lLmh0bWwgWyBGYWlsdXJlIF0KIAotd2Via2l0Lm9y Zy9iLzExMTI0MyBzdG9yYWdlL2luZGV4ZWRkYi9pbmRleC1iYXNpY3MuaHRtbCBbIEZhaWx1cmUg XQotd2Via2l0Lm9yZy9iLzExMTI0MyBzdG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2NyZWF0ZS1v YmplY3RzdG9yZS1iYXNpY3MuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzExMTI0MyBz dG9yYWdlL2luZGV4ZWRkYi9tb3ppbGxhL2dsb2JhbC1kYXRhLmh0bWwgWyBGYWlsdXJlIF0KLXdl YmtpdC5vcmcvYi8xMTEyNDMgc3RvcmFnZS9pbmRleGVkZGIvbW96aWxsYS9pbmRleGVzLmh0bWwg WyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xMTEyNDMgc3RvcmFnZS9pbmRleGVkZGIvb2JqZWN0 c3RvcmUtYXV0b2luY3JlbWVudC5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTExMjQz IHN0b3JhZ2UvaW5kZXhlZGRiL3JlYWRvbmx5Lmh0bWwgWyBGYWlsdXJlIF0KLQogIy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICMgRW5kIG9mIFRlc3RzIGZhaWxpbmcKICMvLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCg==