111230 2013-03-01 15:57:26 -0800 [V8] HTMLDocument.all should have [Replaceable] 2013-03-03 16:21:30 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth esprehn+autocc japhet ojan.autocc webkit.review.bot oldest_to_newest 845576 0 haraken 2013-03-01 15:57:26 -0800 (Although HTMLDocument.all is already removed from the spec,) it is expected to behave as a [Replaceable] attribute. By adding a [Replaceable] IDL attribute, we can remove custom implementation of HTMLDocument.all. 845577 1 191057 haraken 2013-03-01 15:59:22 -0800 Created attachment 191057 Patch 845933 2 191057 abarth 2013-03-02 23:24:33 -0800 Comment on attachment 191057 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191057&action=review > Source/WebCore/ChangeLog:14 > + I confimed that exactly the same code is generated for .all getter > + and setter. Really! Wow, I had no idea. Do all Replaceable attributes call ForceSet? 845934 3 191057 abarth 2013-03-02 23:24:53 -0800 Comment on attachment 191057 Patch Sorry, misclick. 846116 4 haraken 2013-03-03 16:18:36 -0800 Committed r144591: <http://trac.webkit.org/changeset/144591> 846117 5 haraken 2013-03-03 16:21:30 -0800 (In reply to comment #2) > (From update of attachment 191057 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191057&action=review > > > Source/WebCore/ChangeLog:14 > > + I confimed that exactly the same code is generated for .all getter > > + and setter. > > Really! Wow, I had no idea. Do all Replaceable attributes call ForceSet? Yes. All non-custom replaceable setters call info.This()->ForceSet(). 'info.This()->' makes sense because replaceable attributes have to be set on DOM instances (not prototype objects). On the other hand, I have no idea why we need to call ForceSet() instead of Set(). 191057 2013-03-01 15:59:22 -0800 2013-03-03 16:18:45 -0800 Patch bug-111230-20130301155533.patch text/plain 2587 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ0NDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTBkYzczMDU4NjI2NGJk ODcwYWFkN2Y0MGIxY2IxOTIxMzAwM2Y4NC4uMGI1MDFkODA2NzQ1NThlZTBkZjRhMzJiNzdjMWYw MGVjNGQzNDIyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTAzLTAxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEhUTUxEb2N1 bWVudC5hbGwgc2hvdWxkIGhhdmUgW1JlcGxhY2VhYmxlXQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTExMjMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKEFsdGhvdWdoIEhUTUxEb2N1bWVudC5hbGwgaXMg YWxyZWFkeSByZW1vdmVkIGZyb20gdGhlIHNwZWMsKQorICAgICAgICBpdCBpcyBleHBlY3RlZCB0 byBiZWhhdmUgYXMgYSBbUmVwbGFjZWFibGVdIGF0dHJpYnV0ZS4gQnkgYWRkaW5nCisgICAgICAg IGEgW1JlcGxhY2VhYmxlXSBJREwgYXR0cmlidXRlLCB3ZSBjYW4gcmVtb3ZlIGN1c3RvbSBpbXBs ZW1lbnRhdGlvbgorICAgICAgICBvZiBIVE1MRG9jdW1lbnQuYWxsLgorCisgICAgICAgIEkgY29u ZmltZWQgdGhhdCBleGFjdGx5IHRoZSBzYW1lIGNvZGUgaXMgZ2VuZXJhdGVkIGZvciAuYWxsIGdl dHRlcgorICAgICAgICBhbmQgc2V0dGVyLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2Ug aW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1l bnRDdXN0b20uY3BwOgorICAgICAgICAqIGh0bWwvSFRNTERvY3VtZW50LmlkbDoKKwogMjAxMy0w My0wMSAgVWRheSBLaXJhbiAgPHVkYXlraXJhbkBtb3Rvcm9sYS5jb20+CiAKICAgICAgICAgZ2V0 Q29tcHV0ZWRTdHlsZSBub3QgaW1wbGVtZW50ZWQgZm9yIC13ZWJraXQtY29sdW1uLXJ1bGUgc2hv cnRoYW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhI VE1MRG9jdW1lbnRDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9t L1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcAppbmRleCA1YzFmNjVmZjUxOWRhMmVjNTc4N2U0NzIw MGU3MDY1OGZhY2E4MjE0Li4zMmUzNzI2NTg3MzgzNGQ4MzU3MTRkZTg4MTViYzQ4NDQzZWZkODll IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9j dW1lbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9W OEhUTUxEb2N1bWVudEN1c3RvbS5jcHAKQEAgLTE1OSwxMiArMTU5LDYgQEAgdjg6OkhhbmRsZTx2 ODo6VmFsdWU+IFY4SFRNTERvY3VtZW50OjpvcGVuTWV0aG9kQ3VzdG9tKGNvbnN0IHY4OjpBcmd1 bWVudHMmIGFyZ3MKICAgICByZXR1cm4gYXJncy5Ib2xkZXIoKTsKIH0KIAotdm9pZCBWOEhUTUxE b2N1bWVudDo6YWxsQXR0clNldHRlckN1c3RvbSh2ODo6TG9jYWw8djg6OlN0cmluZz4gbmFtZSwg djg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsdWUsIGNvbnN0IHY4OjpBY2Nlc3NvckluZm8mIGluZm8p Ci17Ci0gICAgLy8gSnVzdCBlbXVsYXRlIGEgbm9ybWFsIEpTIGJlaGF2aW91ci0tLWluc3RhbGwg YSBwcm9wZXJ0eSBvbiB0aGlzLgotICAgIGluZm8uVGhpcygpLT5Gb3JjZVNldChuYW1lLCB2YWx1 ZSk7Ci19Ci0KIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gd3JhcChIVE1MRG9jdW1lbnQqIGltcGws IHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gY3JlYXRpb25Db250ZXh0LCB2ODo6SXNvbGF0ZSogaXNv bGF0ZSkKIHsKICAgICBBU1NFUlQoaW1wbCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxEb2N1bWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVudC5p ZGwKaW5kZXggN2MyOWZjYjVkYzE4OTJhYWFjNzJmNTI0MDM2M2VlMmMyNGQyM2Q5ZS4uZTFmNTdk MmMwMTZiNjBjMDA3ODRmOTI2ZTMyYTkwZGI3YjRlOTc3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TERvY3VtZW50LmlkbApAQCAtMzYsNyArMzYsNyBAQAogCiAjaWYgZGVmaW5lZChMQU5HVUFHRV9K QVZBU0NSSVBUKSAmJiBMQU5HVUFHRV9KQVZBU0NSSVBUCiAgICAgLy8gRklYTUU6IFRoaXMgc2hv dWxkIGV2ZW50dWFsbHkgYmUgYXZhaWxhYmxlIChpZiB0aGV5IGFyZSB3YW50ZWQpIGZvciBhbGwg bGFuZ3VhZ2VzLgotICAgIFtKU0N1c3RvbUdldHRlciwgQ3VzdG9tU2V0dGVyLCBEZWxldGFibGVd IGF0dHJpYnV0ZSBIVE1MQWxsQ29sbGVjdGlvbiBhbGw7CisgICAgW0pTQ3VzdG9tLCBSZXBsYWNl YWJsZSwgRGVsZXRhYmxlXSBhdHRyaWJ1dGUgSFRNTEFsbENvbGxlY3Rpb24gYWxsOwogI2VuZGlm CiAKICAgICB2b2lkIGNsZWFyKCk7Cg==